From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC2F5C27C4F for ; Thu, 13 Jun 2024 14:52:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2378B6B009A; Thu, 13 Jun 2024 10:52:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C1256B009B; Thu, 13 Jun 2024 10:52:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 061F96B009D; Thu, 13 Jun 2024 10:52:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DB09A6B009A for ; Thu, 13 Jun 2024 10:52:08 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 82590C0153 for ; Thu, 13 Jun 2024 14:52:08 +0000 (UTC) X-FDA: 82226155536.05.1CF2A0E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 515FA40002 for ; Thu, 13 Jun 2024 14:52:05 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mcCJfSwG; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718290325; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hwllek7tgRIKIgWqTMuIjNBfcKI/4V/kdxc3CTkL5T8=; b=rMqCnTUHD6h+OCB2NKG7QCpaadSpJclkpcNpxegx+2M/SqpU8uI9MKnbbrR4IL+J5PhKAG qtxtscamEeFcULRyuzQVe0ZjUNQxvHgorpvppF8CKRMPuqUJV7kYEXihtAnWBH4O4J9Xr1 r5yk9V9d0BqCj6LQ59ZhM5mWzHdpgNE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718290325; a=rsa-sha256; cv=none; b=GHiciCQLh/IX4vpOwtJLaNJg3A+uszucExRVNS78Vo1mxJp8oMb6mrmjzF3u8dh9+PIcfT nUQ/lxduNegnaWu8wPkh6NMwCFrjzMoiLy88AlSMaIUJHJPp7ZcQKqCWi+Qs567/lkp7FZ rZqL+J4g5xhIiedpQWxtyTQE4HSCsks= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mcCJfSwG; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hwllek7tgRIKIgWqTMuIjNBfcKI/4V/kdxc3CTkL5T8=; b=mcCJfSwGTlqspxYApXYn8jEvGN Ur5GCvff6OlByTHXzy7GheKWaDgwoJ/gJIHsDRHw0Vu1+Ar0iJYkEmIvXs4VIvcMxVcYZGgHGAQEJ M6ZyPggm4ViDcydB0l0BzO6fZ4O3iy+be5VZg6cJBwKlgTVfbal4JPn65up9T8FRByExjL/w/uCv0 IWCjwKo8aNwaOxd/+M8n3Z3pm28Ew7iktkFjGBD6IG1Qd/Q4tgGevvhBGkLh2uDrGAyogCrCCgC7u SQTZVZeT/EiDDNq1H9wyT+SNY9nI5FkwOVhJKXnKLF7C2JvtQ5wIc5EBa6Qwl/OgRZLyavaTNd9a+ UJR1iWGg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHlny-0000000FsBy-1cvc; Thu, 13 Jun 2024 14:51:58 +0000 Date: Thu, 13 Jun 2024 15:51:58 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , Muchun Song , David Hildenbrand , linux-mm@kvack.org Subject: Re: [PATCH 1/2] mm: convert clear_huge_page() to clear_large_folio() Message-ID: References: <20240613105344.2876119-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240613105344.2876119-1-wangkefeng.wang@huawei.com> X-Stat-Signature: jtzdzu3zfozgex5euxenukz6gjz5zma4 X-Rspamd-Queue-Id: 515FA40002 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1718290325-942506 X-HE-Meta: U2FsdGVkX1+15ObTFdGZI0FP4VU9liHiCVH5nH7WFaJq5VBUH4UDuv4miVt1Xd97IPkW1AuRuvahIcII0a94MNodDy9QFtKrVhEGYHzx5XiIr3oU4neEU9inrQEU3PJGWIQKY+PaXUM2avP+F0MB0Vh5z602hHSjkTuAO31JCNbv8jyQHqDPDQIGhmGx9lZEgA32CHgCJTnQpNT5zzn2PlMTF4YNpH3lxzBTyx965iAdaf5FKc5dhT5syyg/sAz+sEKtyjql2nMU08qTNpla9kGBVTHt6ehCG85XW8TfTbN/hCD1WW1j3CFoDqhq++uWJ5RMXiB9JO6VlnH3JhHem5kwX4aZcdzY6oMuD/XCdhNhqM+KCj9MGIly4ZkZ5xDHAQ+quzd4AKZ657VbahhJjMZqKHyghKrEy+Y/Uix8ik5qrFcvxzOJ+6KJV1chU2MfAmNTVvnnoAMYysz/EEBrd9CLOxxxWLT9d6+Exr87g9VPu1o/+VJOG9oP8u5Y1OBlfZzAYaAJgIHQCnl+Ol+n/TEn7BifxyTtNhb3JnOivjrOKy3o4EDDLQWdKfFpLicLNt5AspOO/H/GeJUYaqSTwx5tl8YNEkYhweNWTPPh9MqPAVygnT8Th0EDtiXSZKRMpLCZze7AT8g+d4dMzQT2UnHVoeo/KXcPpISjl2yNctEoylxiM+xNuRfLWTlUM+kobUgaS0nRbNHud1eYimvZWDRtDOjFuhib5drdtn44Pa7/24Dx4kODX73Ii1F/sboOKaNvjEJGj0ERDb5HjzpFn+0+XW507o958315uFzdD+NULDGGBNaAlBUV9aIfitcW8unb0A/WLMEtcbuFQHFP+kyfC3gTD0lARPNrx7SoCfT6PuhU7dJ8tJujAru89KAErn+TKnrhdiDXmhLcopZksgxn/xoM1my9RTUU7XzdqoXqX6J6AqR4KyKTauTuW/Eak2E9UDIcenBtF5JStvX htfV5jiy 6QqMZy/1Ay1oM1xY3ZTU6Ngkze7IHNjVTLNIYcsvWZd+VG4ZdFd54Z2IpAFw0tYkQtmOyGGrYGcbp5urj84BHJPKxbZrRvcNRlrnMFjSaviSCZaAtSdadZaHceBbVFqhxCSsPT50eYPdCk+EYxJyVHxOXx32NPU2HzdVeG80j7yxz0U1BymdQXqW4ko5y/IGDAAYfo1GfWsrpGQ82BKi0iV1dklNsquR58DJI39GbpuwOxqGiBs94PO6GN1Hiopri/ZCV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 13, 2024 at 06:53:43PM +0800, Kefeng Wang wrote: > +++ b/include/linux/mm.h > @@ -4071,9 +4071,7 @@ enum mf_action_page_type { > }; > > #if defined(CONFIG_TRANSPARENT_HUGEPAGE) || defined(CONFIG_HUGETLBFS) > -extern void clear_huge_page(struct page *page, > - unsigned long addr_hint, > - unsigned int pages_per_huge_page); > +void clear_large_folio(struct folio *folio, unsigned long addr_hint); I think this is properly called void folio_zero_user(struct folio *folio, unsigned long user_addr); > -void clear_huge_page(struct page *page, > - unsigned long addr_hint, unsigned int pages_per_huge_page) > +void clear_large_folio(struct folio *folio, unsigned long addr_hint) > { > + unsigned int pages_per_huge_page = folio_nr_pages(folio); I think it's worth renaming to nr_pages here. > unsigned long addr = addr_hint & > ~(((unsigned long)pages_per_huge_page << PAGE_SHIFT) - 1); This can just be: unsigned long addr = user_addr & ~(folio_size(folio) - 1); Umm. Except this assumes that the folio is always mapped to userspace at its natural alignment. And that's true for hugetlb, but not true for THP. So I think this needs to be moved into the callers for which it is true, and we need documentation that user_addr is expected to be the base address that the folio is mapped at.