From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F414C27C4F for ; Thu, 13 Jun 2024 11:20:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D29D6B008A; Thu, 13 Jun 2024 07:20:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 981DB6B0093; Thu, 13 Jun 2024 07:20:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 871086B0096; Thu, 13 Jun 2024 07:20:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6F7AD6B008A for ; Thu, 13 Jun 2024 07:20:30 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B2E84160985 for ; Thu, 13 Jun 2024 11:20:29 +0000 (UTC) X-FDA: 82225622178.20.0199FC5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP id 67C2120004 for ; Thu, 13 Jun 2024 11:20:26 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="AN/6ZfkC"; spf=none (imf13.hostedemail.com: domain of BATV+41157c8c401c8d2ebd10+7599+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+41157c8c401c8d2ebd10+7599+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718277626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2zcgRHuJsYat9muUyNpQ60Hc1jyeeQvzQsEJC6t++hQ=; b=SG8JrX5Kga4PxUXj9EAxrBT/A3LdjZGmFR/4EU9B5HhGF6+ZdIkKLfuse+SdiONSXlwvAm V9UJSSwwF03kvE0KjV7eXQa3ml3ctSNcO4624/0gi5Fmbe9gUfSZj0I0kqHLrQ8NEmHVTb ZiPcS1QBQ7Puw3WhqNI7VEOWmoNCQ4k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718277626; a=rsa-sha256; cv=none; b=is4QYaz/1crF2uVVX80nHabikMpXjDWuvtLX8Dmym2bh3I98+WOCNMjrJx0f0/M9lw/2bY NncAzpEhQ1Fb585JKwoIwykuXhl7KDlxihKKoH+DyKFFhicNd8XeILZUzVU5WtK110CCOM /v6Sgsafgm1YOqgY0YIPdF+zMQitw3w= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="AN/6ZfkC"; spf=none (imf13.hostedemail.com: domain of BATV+41157c8c401c8d2ebd10+7599+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+41157c8c401c8d2ebd10+7599+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2zcgRHuJsYat9muUyNpQ60Hc1jyeeQvzQsEJC6t++hQ=; b=AN/6ZfkCyyY/9mMdGB9ZFNhW3m ewYsckEUvP0jDxWTKpGPvQTD1lYUVnASLXrJVsSvJyt+Xn5LkqEtSdje492yzPuiMQsIWbZ3qn3qE 7/0XhgcF06wd8qcBlLuXXjJSR08jOLtN4rJfdotBDFDymuF1Dauocq9HeRkp12ty9SOYFyFy+jjjV La25/7p7gHC2Ktom2wdct3WSQAoH5stHnR9FGH8qa4Qh8p/W/9Lnkz4Q1pn/4mY9rIvvb0R3FPQXw 8ki53dyrg+cT8R75592KGLuRPj/0rhk3F8HrFSQV84Jtp+ClOKsBbQMSET88lstZEmCv/dVnbbWup OXc+HVGQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHiVC-0000000GI2B-1SjS; Thu, 13 Jun 2024 11:20:22 +0000 Date: Thu, 13 Jun 2024 04:20:22 -0700 From: Christoph Hellwig To: Jean-Michel Hautbois Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-mtd@lists.infradead.org, willy@infradead.org, Andrew Morton , linux-m68k@lists.linux-m68k.org Subject: Re: Issue with JFFS2 and a_ops->dirty_folio Message-ID: References: <0b657056-3a7f-46ba-8e99-a8fe2203901f@yoseli.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0b657056-3a7f-46ba-8e99-a8fe2203901f@yoseli.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 7px1k8d6bxtztqc5at74bh3s9anixf8w X-Rspamd-Queue-Id: 67C2120004 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1718277626-288867 X-HE-Meta: U2FsdGVkX1+Ec23GaoB4Va4NYzi9WJcx8gQvCgOw7tQcXXuVpbifSQXI+LTP2BduFCt4XlkzroQBon7NuL0WzIlffB8Tzk7EVjjKDioWU+eK4DAP+IvKlc5Ga2kPLOQey4v8mDiaPzhGfEIJS5b3VPFT3ZLVi3C/v/b/IbkTUIB1Zo5Bo8DGTNbXcs4PNzwBpOFZSXQAR5Zlsfyzvyug1QdSbL0KjOlSZwRysONIOTFElF/vbAAVuD7LOZWDQwTIlNKPsm32aZlU3s2gMNJHx3k2LyT94YUdYIkjS3+oCDTP5fa9YytdGmgHgyVbD0cseBN8jG0XxLXxuV5u3YjXMO9o+amtljzmAsys/UBS4+LVosmWzuKX6lW5g/8yacDfbCyAJakC/XX6U84OWwpp/5o6WMMgEPNMByhXzawKMznOuK0kpyBJVLlg3w+vv2Rl41il+LqMVXSQBMAT/Lp5h11IKzATwTGtRFeiyeGPkvcz5p2Fn38V0yG/t2ipAen456GXoxgypnWxcfdeBPR9FxkKnof0me9LZKJON18LPHKiGS3EEcYzKudLvz3VjKbtmN6Nhr8pDVJxToEmuSsKPUPbshmaQBKBzXeH3PF6Mfh5FLli3pgGjdzF9L9OXEp8geX1ix3KHoFi5+GbzIJ0tVhLAsRA/CJqqqNGNeX52+BIIFxc/eVqaAPZs4QSxg4erq3Oxi4pRdR5JUjthDJHR/57aQydoDrxXzZOiypNIpxYxNjuRzx917TDyyDG+71eyl37uzKHSP8UCUFHerbRjVxb40ZK7+TN/0mW+xMH2hDskGxt+hYPbjJmyYAYI1zm607J/cCP2HTuC+UMkMr1BJE5OAUFcJz8DV6PgvtvnrcUQ2KRos/0vDFRM65F8/x5MqLmwOLG6X8zI7P5nJ8r8t51BZ0XVpsitNUVHkKteUG7BUars9izwWS75UlYk7jry7HHRBORDOm6v6+GKtm lnNOm26u m4QQ3/WcQmqMAh7egXVKCYW5tfBWzAGvMcNLyuzxaABoroTnVHSSch0MKZNnb1LZAwxLjpOYXskRhbayyZ/RWpmCP3JkblBA3O29sF0w7jaMy8RHx1Haurh5qcq82bjrII7eBGQ+geO1KPL11JNPJzz1YNjRIKPx9uIIfNiBGHBbUlccSZQVUjQw3C8lKeJRKsjGQHyx0tkK7peG4Ma8hwAzRDcATq62nymAkQnEblAIj7Y6KT0a7yuvWICq9lON737yDX/4Hcyut2EuHli4cBJBNcYzp4KXN5Fb8m1ma5RFSOnj1nxcNtzizb0bXvucB6fZTc9a2S2WSwAOiyzYQUV+U0+k6MQaBu4k+uisz4DfYWtvFU0eeYiWoWA0Z19yXdM9pn0Kwqbjr9Hau6K21nBS12Dc3BQ5jKSJ6Q6CHnyfRga6BMlISowHWaLpOhMkos5LMIybr+PrCXTTZ1KUX6Ko+XHp1lfQEiZiTG9vO0FSNtKGQtgcpc/LJkmCoiEyrXBGB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 13, 2024 at 09:05:17AM +0200, Jean-Michel Hautbois wrote: > Hi everyone ! > > I am currently working on a Coldfire (MPC54418) and quite everything goes > well, except that I can only execute one command from user space before > getting a segmentation fault on the do_exit() syscall. Looks like jffs2 is simply missing a dirty_folio implementation. The simple filemap_dirty_folio should do the job, please try the patch below: diff --git a/fs/jffs2/file.c b/fs/jffs2/file.c index 62ea76da7fdf23..7124cbad6c35ae 100644 --- a/fs/jffs2/file.c +++ b/fs/jffs2/file.c @@ -19,6 +19,7 @@ #include #include #include +#include #include "nodelist.h" static int jffs2_write_end(struct file *filp, struct address_space *mapping, @@ -75,6 +76,7 @@ const struct address_space_operations jffs2_file_address_operations = .read_folio = jffs2_read_folio, .write_begin = jffs2_write_begin, .write_end = jffs2_write_end, + .dirty_folio = filemap_dirty_folio, }; static int jffs2_do_readpage_nolock (struct inode *inode, struct page *pg)