From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1EE7C27C4F for ; Thu, 13 Jun 2024 08:41:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6453D6B00A4; Thu, 13 Jun 2024 04:41:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F4A06B00AA; Thu, 13 Jun 2024 04:41:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BC946B00AB; Thu, 13 Jun 2024 04:41:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2C3AB6B00A4 for ; Thu, 13 Jun 2024 04:41:57 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D6BF0160808 for ; Thu, 13 Jun 2024 08:41:56 +0000 (UTC) X-FDA: 82225222632.25.1353487 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 1A73B16000F for ; Thu, 13 Jun 2024 08:41:54 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AP144Lrq; spf=pass (imf08.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718268113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vWc82pHy204AzEDhPBKEPpo04KnSaVs2ShuVlzL9t+0=; b=dsZgAic4X/FWdUgDlobegR/Ha0b+fOehUxVS079Bg0E2b/czA/aAZ0/uBqMiqYDwVxvNqx ksjGHhTnTHCu/m6fBOOUw9Lk9mNfIOrnH3JIrx2jq5op0hriA9GQBOqDo5qrc1CySpeVSD y9zIqV2Fb68Wm7/QPULIUAwTjAaUguE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AP144Lrq; spf=pass (imf08.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718268113; a=rsa-sha256; cv=none; b=6drtZSi8ShKlFBQggG7VFeUGRoXkr1H3CB+C/pWepu+kVy9JFZajQki8t87/+n3DoqPq4Z dmgiJwDeTxVeTS6gkWnykt84xgF/DcZOM++EsmhOBht3ybWXSiYCDB9f+jQDcsA/cJzDIc uKnrdo1567uofSW28Vz3T5uuhGV3oNg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718268114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vWc82pHy204AzEDhPBKEPpo04KnSaVs2ShuVlzL9t+0=; b=AP144Lrqf3lUCtzGTDPypfO2K6Kfm7xFSxx/M33dXNviLdXasVXTx+eiB0HpQHckuBhmVA MprbDOXqu7Rf2mcgeLilU0uyfgSFJ3opm/vlUAE+ZLROe4KGnnaVAmhA2JakcfLi1YsmEc 13oWc5P6ionNvoTohs1UUa22MZeCixs= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-481-bY8pvBWrOYGbtQ7EkwnCKA-1; Thu, 13 Jun 2024 04:41:44 -0400 X-MC-Unique: bY8pvBWrOYGbtQ7EkwnCKA-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A5B8C19560AF; Thu, 13 Jun 2024 08:41:41 +0000 (UTC) Received: from localhost (unknown [10.72.112.37]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C3E6E3000219; Thu, 13 Jun 2024 08:41:39 +0000 (UTC) Date: Thu, 13 Jun 2024 16:41:34 +0800 From: Baoquan He To: Uladzislau Rezki Cc: Zhaoyang Huang , "zhaoyang.huang" , Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Thomas Gleixner , hailong liu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, steve.kang@unisoc.com Subject: Re: [Resend PATCHv4 1/1] mm: fix incorrect vbq reference in purge_fragmented_block Message-ID: References: <20240607023116.1720640-1-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1A73B16000F X-Stat-Signature: hkiidfxd4zmwg4f6g1nadn3krh3c8k73 X-Rspam-User: X-HE-Tag: 1718268114-118768 X-HE-Meta: U2FsdGVkX18b6gDhLdPWDCtZQ8RSH1dZX/ykQv5Hw7ii2Kv/+mIk/YbwLHylEsbLOdVK04HavvmFjkkuE9+C/k5mwQ469rBsaieIraKVPEiRDEbkk5aLH19Z3GiBeYM+tEDyn2ZYOxM2q4cRa4/RaSmBHsVRMXYcduquAV57COm2Prz12o1OhzpvVxLnZC0UqU9EAuVXQSoaSr4dd86RmgogBTPGXj3JCpi2Xmzw6xz4GlQrneEWgX7v0zaOsje5aQMUDHYWGKCwpqfcQ2j/HbN9zP9ECul46kXfaEvCrdMBdSNtlq4W8EfdLXdKngckUYacdvKyzKYTKT5dtN1JJBc9u2Z9Md0Rq4kQPAYHWIuajLcdIwoXLdvwOAHybvyA7daW3460kSdOuZoodKbgP4sZxX+v9zpVnwZaRBHSmb31xN6WP+0MBuaxWNBQl7gUn+u+tVpGY3Yny+0QUGEGvloMefpX1MfuMnpNXtk70SwBtfeXt+HrIwl1QJUElSleXkVpRfXvyRoRuOBAIzb7/oEySE6hhO/2Ps4ugWtu2VPGoLibK/MkXwNcPhL+keR2t5H16v68x3XXf8Sod8zPjwHxdIiZinbT2rHNtxIK+ToPNkqocxDwu4tdWO7gD8mMThku72Ray+WvqsKhb0RfnfM1LJsPZXM2S4zxgCQPJJyO2Ap3gYxhEfJsr7Kc3XkLVYEL+9Y/Sg7MKS7PWrybTnMIPa+r2yh5rVXu7Yd2jGXfEfXWO7WgcF6oPIchH1f0E/DPeC/RtuBjGgTnx5b2NSFYQUUGrZzLaZZMtnyqVj8kSNMLhTXQXdn1VJKgtghJtnemckJUE6tJI9cztJ4cKAKy6LC26HCPQB6IoAmbR+8tSJqnTxvJPQpe1NtWMf7gutLLF/zN2KGs7oClvKBTgSArjW3p+STLNCN+pTb1MB6uP5MH44FDEp7pJhLeiwNOy5HhVt1FXe5qVRgma6E XOWtyRJJ aEHiQWAlWm2xhWRXIi1RlJgKiTktNhjhXZTB4x0TQYtD5akbz+d26oA5Cx90PnS3pdxy64sZsJhUcFmkO//nvarYjbDQN2oleoDr5/euAVJ5sg4ILHbaWF357dPq8Q2OW3k1UmJTFXh6OlW2NaIK11Cs8ouxdfy49Z39ytIAvt8Augn6jLJL8+w5+GE6YhFm+5MSoXwDwEwrF5oHMSnie3UEC1ifn5AQrLWNVnzF38ypJKeCNdPrf8YcNPzAWbfDPvpjsSDTv7PscOEmjnCq4htBb/jfOb/zBBPqoI1Hvt7f6kMbonqNJLP9wd03rrwvvGhfgCpub+mK6wTWcQBn4bAZxm3Sgz4HFo+3SRORglpzw/LWB29O629CaclCuq6VHCZJCnU1OaZFGP89NlItSQ8faUh4K+cJ09ILPWR3hWZc49h4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06/12/24 at 01:27pm, Uladzislau Rezki wrote: > On Wed, Jun 12, 2024 at 10:00:14AM +0800, Zhaoyang Huang wrote: > > On Wed, Jun 12, 2024 at 2:16 AM Uladzislau Rezki wrote: > > > > > > > > > > > Sorry to bother you again. Are there any other comments or new patch > > > > on this which block some test cases of ANDROID that only accept ACKed > > > > one on its tree. > > > > > > > I have just returned from vacation. Give me some time to review your > > > patch. Meanwhile, do you have a reproducer? So i would like to see how > > > i can trigger an issue that is in question. > > This bug arises from an system wide android test which has been > > reported by many vendors. Keep mount/unmount an erofs partition is > > supposed to be a simple reproducer. IMO, the logic defect is obvious > > enough to be found by code review. > > > Baoquan, any objection about this v4? > > Your proposal about inserting a new vmap-block based on it belongs > to, i.e. not per-this-cpu, should fix an issue. The problem is that > such way does __not__ pre-load a current CPU what is not good. With my understand, when we start handling to insert vb to vbq->xa and vbq->free, the vmap_area allocation has been done, it doesn't impact the CPU preloading when adding it into which CPU's vbq->free, does it? Not sure if I miss anything about the CPU preloading.