From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 806BCC27C4F for ; Thu, 13 Jun 2024 06:04:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 056116B0098; Thu, 13 Jun 2024 02:04:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 006516B0099; Thu, 13 Jun 2024 02:04:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0F4C6B009A; Thu, 13 Jun 2024 02:04:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C89006B0098 for ; Thu, 13 Jun 2024 02:04:53 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2A80240658 for ; Thu, 13 Jun 2024 06:04:53 +0000 (UTC) X-FDA: 82224826866.23.7BC414F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 7BC6D80012 for ; Thu, 13 Jun 2024 06:04:51 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DxcenJJR; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718258690; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kc+2k7k6saH29kFh2PBw2w5JNJv25ROll27IAGgv4Nk=; b=aYAI7HqJUkrfmA8hrz/UAVIOV/vV2E98Gvbb1oObt1JqsPOrXDNYU0om+6/f1F0GmsaIxD QFIhan5zxyW1txt9ROhDgXRQG4/wAUd1sj6uyYJgcnEm2QRRwnElTIZ+gmNkL3YeHbxV8R fCDzOpYtxixWUT3KOsnXCR9f39N0pGY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DxcenJJR; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718258690; a=rsa-sha256; cv=none; b=ENBGcwLhEGxlv6uGJd2mBwtAAzw+XmZRg4sNTDDaguC7Wg5YDOVjSJxyPuy1cPcdfusesZ naAutMTsoWqIDw9Jmy1CFZrIz4sbW8hBgdzXLn0JMTc4uJ8llX0W4yIe7/7jieLmh6vOzS ekQeCZo0IIIhaqhIs0CDK/29kFrmy84= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 78E81614ED; Thu, 13 Jun 2024 06:04:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B256AC2BBFC; Thu, 13 Jun 2024 06:04:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718258690; bh=7LdEa2cXZ92dCOV0tvIy2du3N9yfvC7ip0HcqkAwNEk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DxcenJJRa56E3C/mgOBon5mdRqu/s2dglNrbBslIgsKqZQPnSv42myJqNdUwbwS86 ZnTchHadTKKdC/FsOKWRlJY8omawHNlOKkPziXgC9DmDiAkupXVVOQsQ+ubwLizPI6 Xh6ETy2wifOBbI0rjnd/lDv9abcX7hG+qotJOSiv56gj30hJvBW5uBRCj67ST8B8rx ozL4oegTH5D4RyqBIJEV512FvBfIYw7aiekKt73/D6257eVpL9t5t3JtnpHRwzBb9n XPtR7VKWr7LKbamwS2COeMJPpI3dqc/YsGCBjNqvKoLT0eCi1L/lptXVP0PFwDqf1i WKxkzWrcXAJ+Q== Date: Thu, 13 Jun 2024 09:02:34 +0300 From: Mike Rapoport To: Steven Rostedt Cc: Kees Cook , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Tony Luck , "Guilherme G. Piccoli" , linux-hardening@vger.kernel.org, Guenter Roeck , Ross Zwisler , wklin@google.com, Vineeth Remanan Pillai , Joel Fernandes , Suleiman Souhlal , Linus Torvalds , Catalin Marinas , Will Deacon , Ard Biesheuvel Subject: Re: [PATCH v3 2/2] pstore/ramoops: Add ramoops.mem_name= command line option Message-ID: References: <20240611144911.327227285@goodmis.org> <20240611144949.703297941@goodmis.org> <202406121145.8860502D7@keescook> <20240612145228.5bf426e0@rorschach.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240612145228.5bf426e0@rorschach.local.home> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7BC6D80012 X-Stat-Signature: wk6bcuwh9jc4gap1qiqxxxyk7xjmnt59 X-Rspam-User: X-HE-Tag: 1718258691-816844 X-HE-Meta: U2FsdGVkX1+nxAVzsdicYtw6zAW8boh2AK1Hu/mkP6LH4UTD+dG/fo4b1UiMZNyc0ddg4Q10b50LO15RqQD81zXKztkOFKQqwdx6by7fyniVbXmTcwG6b0Xto5dpiNXZKdUish+EHyWRUnaSjjAq+qvqqVBlFGT9IWvJQ/ceUpI7Pz4Rr4ed7cvaT0PSRukVFzf1+H2YwSglOz3pWU0tyylHxOXzybsdbBDegrp0jrcZgyyIdit/SGOrXrnyOIJet+9aY2/vApxh2C36w9nhh2I4hogvm/nzBZ2cv9htHXJBKdhMxWIGwFWHrL6jR3DIttPnRsLwX6TOFw59cF3Pr5QHrn4dVC1G7TbplqoMSeeA7pl7ZlawB2rP1hbJ9LzO8+eRJfcTbq8SSdSZLL5oCfmIVx3pa0+/6vSfiAaUgfDLfZ2QFRzPzIcNxrXJMZvLKYJxPRJje34a0Ei85LY0BUJQ4N+/Gsv/nUJtqYxuspjk+WhCp7eAvn8X8/8VyB0m32968cQUlmsLxk9gdRzjWFQzVC4CGve6EH/JqVeugiQuZGAGEmAM1MQcUQpdtrIOWQHsS0/ytgu4t9rekXeUhvzsUMl3mkGWNQu/L5yHeKDqaEaZyrzGD+QdOIu1ldPm69Rkq+wLuDNeAmD1NuxN0KSTPUbbgFtKAHweQ45KTABkYOAyWEsyDiIme2lxjjM1mXA59TEHTe9FfN8N4QuThlu5GmyYcvlkImKbbtj9/hcWB0gTk5XQweyRxmCxGmxS3o4mLiZnT9gHGeaJeWqM6p4BYgIJhBasXegjCKNGYq2CXJEoO9UKC4At3luk0sPWQCc3JznODE+j7zquFWNfbDD/GmwV7Vh1DCoZOtC+iUbHh1N3N1yB9zmBqnoqjVRwXbve6zzIPd/lJmCKKjhuyHnDfmx5PB+1vBtrFMTZTxg+Yq9GFS77b7ZMRX4gPU1yj35YDOkMKwqAee5btac C45Q1zHK XVMTrvmbuBBz5c7P+kDnZzIVAEyy0lTK/vumG5KMynHfIscahJ8t5wBNxzDmlNW6kGO6MFS2Bl7ELuYpr2HtIdiXhYfqTJevxaz8CG68kw4boxuJ0kYj9flQJ1bxIg4v879UP+fNWKRtoVBFb1A9JJsa/11GL9iF2WAuQvd7c8Ctr8iLXeRYJKdf33h7Gi4J8zxomSwjGqbifN4hjQPmDW90NjSgkQNkM98AnzPE+KKYXIkFCR9hvT1QEOSqYAjJlyCNSQ+MZi8MYimhga/auHZuaXJvCCKYoqmk+c4y04xkdFggd/QgLxccXHeE+3cpnBzrpxX/VO32cv6YlAJ3iwqO3GoRBXOII7+rVips6WrZMWVV9kt579CtXZAgkJwjGQGM2uU6Is22DNeU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 12, 2024 at 02:52:28PM -0400, Steven Rostedt wrote: > On Wed, 12 Jun 2024 11:45:57 -0700 > Kees Cook wrote: > > > On Tue, Jun 11, 2024 at 10:49:13AM -0400, Steven Rostedt wrote: > > > From: "Steven Rostedt (Google)" > > > > > > Add a method to find a region specified by reserve_mem=nn:align:name for > > > ramoops. Adding a kernel command line parameter: > > > > > > reserve_mem=12M:4096:oops ramoops.mem_name=oops > > > > > > Will use the size and location defined by the memmap parameter where it > > > finds the memory and labels it "oops". The "oops" in the ramoops option > > > is used to search for it. > > > > > > This allows for arbitrary RAM to be used for ramoops if it is known that > > > the memory is not cleared on kernel crashes or soft reboots. > > > > > > Signed-off-by: Steven Rostedt (Google) > > > > Acked-by: Kees Cook > > > > Let me know if this should go via the pstore tree, if you'd rather carry > > it? > > > > I'm going to send out another version to cover some more comments that > were made, and perhaps it's best if Mike Rapoport takes it through his > tree. I've added one more comment to v5, with that fixed I can take this. > Thanks! > > -- Steve -- Sincerely yours, Mike.