From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D342C27C4F for ; Thu, 13 Jun 2024 05:44:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEA686B0095; Thu, 13 Jun 2024 01:44:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9AB86B0096; Thu, 13 Jun 2024 01:44:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D625B6B0098; Thu, 13 Jun 2024 01:44:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B6C8C6B0095 for ; Thu, 13 Jun 2024 01:44:29 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2B875C05F3 for ; Thu, 13 Jun 2024 05:44:29 +0000 (UTC) X-FDA: 82224775458.02.D91BDCF Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf16.hostedemail.com (Postfix) with ESMTP id C827F180002 for ; Thu, 13 Jun 2024 05:44:25 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XMBP4Gj4; spf=none (imf16.hostedemail.com: domain of BATV+41157c8c401c8d2ebd10+7599+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+41157c8c401c8d2ebd10+7599+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718257466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mZUyZbGRLoZ61VzFcElkmd0RzIflNIRedkXb41aYIms=; b=JB5zd3BZU+DTYVeLL0w7ko/ez7iolf4xGmccYv3KSTghN/6i7mog6dnbpdH6j6ox1kPry2 iKdZIHUa2RPHLmsk+O1R0GCD6bTK/dz0wZSMDu2abKWmLips8/9vh36gg+Xl8YjBV9w9PW Z5+Eg/13/MJU4B2h1uo8wmgkvJgQ8II= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718257466; a=rsa-sha256; cv=none; b=O5w2j/qFaLM8w6b7zoga6lCVkbPi/VHOSg8tvJpaEtTFyk0ECxTQfuFwvqW4QfOq0VLemR rmfPEW+7ME9II58cNVUwflkzW8GcU/lclM1w1solY5JDOmGsf7AXDn6q8OMWJ6s7qDfLsq pe6mPzkc/H5ro/ybkhychs6WAvAWWog= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XMBP4Gj4; spf=none (imf16.hostedemail.com: domain of BATV+41157c8c401c8d2ebd10+7599+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+41157c8c401c8d2ebd10+7599+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mZUyZbGRLoZ61VzFcElkmd0RzIflNIRedkXb41aYIms=; b=XMBP4Gj4alCsQXtnGvwGXhKGJq WcL/CT6vNh91rMWL54YOhyIVKEZ/leEAqL33Ichz8d1gGp+JsGDS2PbQPDoQGZr96bGQqisXqcIsJ OuEO+i9FYIEzwCXV36lgY4XnjcWtzPmXcjWWaOvp5deZ60g/G7q+sKCNsNgeM21GL+aAIXBewlA9h h7mCJ6SESIzFIIHYiPRtM2v1wtHhYFCW9tb+tr/QPY3z0FdPkqJxzfzXUyDeiXOKjmA45C2hTvlD6 Pu3Xx6w3CK5nY7Zfa/zkDicZU9YyKyX9LdVJ28OmMNCTD+BBduLlz0Ooq2RoJ35KLgLW4xgDRHnQ5 /vHY+Ewg==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHdG1-0000000FCio-48U9; Thu, 13 Jun 2024 05:44:21 +0000 Date: Wed, 12 Jun 2024 22:44:21 -0700 From: Christoph Hellwig To: Martin Oliveira Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jason Gunthorpe , Leon Romanovsky , Greg Kroah-Hartman , Tejun Heo , Andrew Morton , Logan Gunthorpe , Mike Marciniszyn , Shiraz Saleem , Michael Guralnik , Artemy Kovalyov Subject: Re: [PATCH v2 1/4] kernfs: remove page_mkwrite() from vm_operations_struct Message-ID: References: <20240611182732.360317-1-martin.oliveira@eideticom.com> <20240611182732.360317-2-martin.oliveira@eideticom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611182732.360317-2-martin.oliveira@eideticom.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: a85r3xujbwdz3rhx6xmy43nyzme74iko X-Rspamd-Queue-Id: C827F180002 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1718257465-51815 X-HE-Meta: U2FsdGVkX18Zp5SMP0ZAzxGmdu3Sb/pofKZwh5wUKYhsmIauanNduWRtSZyypqW4ADJFmcrxSSrU/woAs2qyGoiLGI6dReCHX/IJdrJNnRPFgIT0B+4/StQTIBlho5QRPQLfsrPqnK20uAp1MBRi7B8E5fTxsE10KyyPlBkEYa267g9Plak/jsblzoocWujLEABx9pno1kyvLQ+qdEI2NtG3dIdHqTtX1O79HlmW+9J8JQ5dltWxLr+KjRcApBt0rknT+8oebNILziQatsYYRgvw4CF+sn0/Bq2BLt2zucM+CVkjiuEtZxpfoLGRD0N3u1jF4AoQKrGkxrDGGh4jIHOp6RRQFMcUY5LvxhrrljE/tuydUqNUzXWpsgC9aEsLADzG1XmwbGcHSGLCbQwdKnLXKpJ9T+jqhau6sn4Kr9E5S7QmPNDvOXzoiFHt0+e7ScXtipTX6ogT3H/n/yPRPVS9uIZ52AFeuMLFUDpf/4NrJEdXOjKsoJprEG6p3FfxX/kfANuLMVWivdsJEA5tA+afbJV2n23fEYPlPUT3/WS823roZJya8rMKq7ci3SgJHdKN1dj627c9N3c/Bid1VvpFGEMGOlEmCn/dCvfNnOn2Q3VznEIFO4KRDsVejP0uMYdmB39P3vM1n9N5jv0xbje9B9LVmv5uJ79viRgHkG2LMNBMcZ6UpHA2goEs9Jsu/dq75UP3XQ5ncQg1wIV89nj+WMVDVpGYWvOlbL4l/C9QFF/vxirewVPrsFDvW+H9xRdnNQiiVfgC1LxO0URPJXG+RkNBkgNi0kfHvjx/97gwvMPZ8OQhbiD9l+Am2FqjGm9S672SP0doFk4Jt7dnHuJ4qR/G3bjZwDaFKoydVj8Q4aIfLgxvmn9HQfWwr/ngz+qTr4aUQg2XJHJJPSV4c57WmwuXqJf/4XqydR6vwXeyDfHWzHKP2DPJZpIJ1gl7Wlug8IgH45z/FFgubF3 z7rUdI7Q sk1ycpX5Bxplceqgx5eOPtsIQh1nqLgBGaQPR0OJMgasgPkzNDGVXlH8JoNsJTQgiOZNLpRrF1R9JWJyg7X6+iYBza2acktpo0g8UjXDTYF3NBfHMNTZ7xmnw4mPcTrd0LoerHBm+RKFRPlO2maZB8zy4n44wyqPORxLZ4zLNM40JOEkNGsj2BGL1Q7rd/5BYkiiNST5ibCz9yluzMwKJOD+POSqabFyALufhunWgojTO/z9lJBY2P7wYGaKG8eoSQd8LxI8eUUbUt97at07Qc0fQuSbK+mnrQNjQoAuOP+B9Y051A9UC6Q2uziBfX+RoetAAuLtCWnmnj7omos5wj9Ja8HJODxc8iIzC4o4MwtQmfwA4wj0E7RTaVQDR29L1WkTQPUpGG1uY5JxvdrAtEkvfRCdE8yfmETVPr6LkMdOZVN988igPi9r1mCuyLXvE9HLxV1Ugujlp7wWptmlSJWFFFPoP8msmmqgp1/VQ8iZO/99sc6U1oWyOxSNWnI5k4Be6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 11, 2024 at 12:27:29PM -0600, Martin Oliveira wrote: > + if (vma->vm_ops->page_mkwrite) > + goto out_put; > + I'd probably make this a WARN_ON so that driver authors trying to add a page_mkwrite in the vm_ops passed to kernfs get a big fat warning instead of spending a couple hours trying to track down what is going wrong :)