From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2109CC27C53 for ; Wed, 12 Jun 2024 20:27:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93C796B008A; Wed, 12 Jun 2024 16:27:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8ED026B008C; Wed, 12 Jun 2024 16:27:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B4436B0092; Wed, 12 Jun 2024 16:27:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 625226B008A for ; Wed, 12 Jun 2024 16:27:07 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E786CC025A for ; Wed, 12 Jun 2024 20:27:06 +0000 (UTC) X-FDA: 82223370852.15.CBD1C25 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf27.hostedemail.com (Postfix) with ESMTP id 7146B40016 for ; Wed, 12 Jun 2024 20:27:04 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=HwgdMkpr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=r+CigeT+; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=HwgdMkpr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=r+CigeT+; spf=pass (imf27.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718224024; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1VFuCUnuEepepF/nbFXGdMItjf3Q4jDShXXipYKEUy8=; b=0qYKQlFcwba9kCQvXb7TOaRNdq+71IpYOz8oY83CyA1XkAj00QYNfHdVR11+R3h68L7f1C WOczW7TjZ3WkgZpZvfT3M+/s/5yQWz6Ijl1gqUx8WuHBXFcgiJs2bYolOT5hv0WgxXDCcJ nD6cJaGA47GfXHj0N1YkVpg0DIqBB9I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718224024; a=rsa-sha256; cv=none; b=23Bsm1SFRIHtJQPPhPO8YJTXShb++RxrpYG5TBiAz3rIMF3dgqJoj3SDep/cPDx0+gFMkI +h4Gq+QtzscgN2uJDJP8gQOFkAEtiUeZuiU+Ff14Jwg3eKYhv6FSamPC+48FMfY0rN8pgo D8MXgw4x1uvb9mCp0BJrswynbugc7ts= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=HwgdMkpr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=r+CigeT+; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=HwgdMkpr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=r+CigeT+; spf=pass (imf27.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9FB255C700; Wed, 12 Jun 2024 20:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718224022; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1VFuCUnuEepepF/nbFXGdMItjf3Q4jDShXXipYKEUy8=; b=HwgdMkprsrWlowzdN0AurD8/qlL6BHBjM6iGkmzEsFQj49bK4dWsgjwEQhzNU8IjlliE2P q8Rj948CkYMq6aAJEv9T7SQdsJ7kZMcySRHaWDAyoY/4FG0eNN5Yy9CjqLmw8RV01AeIgi jCGk7koUgSzmqlnbp255TDiGsLoh2TY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718224022; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1VFuCUnuEepepF/nbFXGdMItjf3Q4jDShXXipYKEUy8=; b=r+CigeT+ebgc3nxPN7HvLvku6DTB0GTcJ722AIQzu2pPI/HhvI7fPocDaWO2+mvfHPDoDO RJ7SUIc0ePmkmVCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718224022; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1VFuCUnuEepepF/nbFXGdMItjf3Q4jDShXXipYKEUy8=; b=HwgdMkprsrWlowzdN0AurD8/qlL6BHBjM6iGkmzEsFQj49bK4dWsgjwEQhzNU8IjlliE2P q8Rj948CkYMq6aAJEv9T7SQdsJ7kZMcySRHaWDAyoY/4FG0eNN5Yy9CjqLmw8RV01AeIgi jCGk7koUgSzmqlnbp255TDiGsLoh2TY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718224022; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1VFuCUnuEepepF/nbFXGdMItjf3Q4jDShXXipYKEUy8=; b=r+CigeT+ebgc3nxPN7HvLvku6DTB0GTcJ722AIQzu2pPI/HhvI7fPocDaWO2+mvfHPDoDO RJ7SUIc0ePmkmVCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 47F9C1372E; Wed, 12 Jun 2024 20:27:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id IbqSDpYEambxKgAAD6G6ig (envelope-from ); Wed, 12 Jun 2024 20:27:02 +0000 Date: Wed, 12 Jun 2024 22:27:00 +0200 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Muchun Song , Vishal Moola Subject: Re: [PATCH] mm/hugetlb: Move vmf_anon_prepare upfront in hugetlb_wp Message-ID: References: <20240521073446.23185-1-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240521073446.23185-1-osalvador@suse.de> X-Rspamd-Action: no action X-Stat-Signature: gtyst175nhru8s9s8kqnqg5kz7whn7gb X-Rspam-User: X-Rspamd-Queue-Id: 7146B40016 X-Rspamd-Server: rspam01 X-HE-Tag: 1718224024-678497 X-HE-Meta: U2FsdGVkX1/k8wx0rhHHi8blq7Q3zZz2xy1AF85CIWBe4LLlsS7zG+EfVRx211mEjZdwiaFZwocYBUve6VAkKtNl0v3cx4sIAgPMv4p741JrAjmkO7qxLvimBYmmrp9M92wJXYc45wCwPUJtZxcJsz6RbSgX/UaaTuR+drEb1Q+NuDLm0e96LKb1shai+IE/K9McIU9MaIX0+4QNs5e33asOtL1Yac3H+5oqgTGBb8rN5XMQHdH0Wyf7siva/+AEKsg6r0638DIV0Ae+Up0Sx3bwKZd/YoQYGLNNDSm06rMeeYBJzFQU3IMOTWNhYeD7GGr9B6mcYzRsyM/DrjJXlAVN1/zTsLjGHC6fGWD5QIphW+ohMNGvUOm/d3M0TZ4Xdj63DH0JMKvzTnpyxreIXN9gc0LlogGrTimk9OMgelRMSjsoNbrHL7kvL8pA7iISpSBIX8OMAstoJWVSaHC+Y1TsMc4MpazgbzKi5kePRw6FM6asZDMOPM5ZeL71qKoCKS7xsCR2WgLAwpfkAq7qyqImJyA4BGemPIusCvBJo1k31kgfnCVUnQgnYmVFe00YTbDP6YwuObTp5qMTMykiHB7Evg63VnJpMkTi4OVe+H9Anrh2+WjoC/lXDHlyNg5X/UKwgmbLzcyT6cMi8c44dp6saOgidm8v6NmppkkGCNfZCGyiKG5wzRZ+XM0+Ej+5nsG0vvgus9tLTGcsJwR99O5MdhKVFW5Bpkw0KC0L5QEdroAt7XZDobsgBbM1hkQvsYwSnbuH5KN/iteHXGwZxXTbc49Fike4jt+yiEFsiq8pJvJiHkoNZkPBzMLv3ie0U0eatQJg47yNbDtMJWgF/nt8/vY7jeipHxR9ie+QAIpBaWbKYP3GQoJHZ/pDYMkluPkUZ6xfFhuD9hHp+kpTYU2oyaApNmRzF2V4Tz068zhrXw6Iz4HcN/XPIZeLlQLLdKnrG0a6DWJvmviAGhJ LuiVl4Ye 5BeEjIbGEEKX3DtG9bkPuDGe2UyiKJjkQFNlum/Tyzi0lPGzAXLo7XOAfdLIrfOEZiKOGlqOUT6B8miwXQpHWhM0Wkij87cbTbrP2Z/BWCA5ld9yx67hjJZh3oN5z8Hmsw2egzFJbyHueOh+h9myVRepv/pY0bdq4mZug0vTQhm3sCwqEQw/h7PTMkd2KohTh3mn/qlaCtcQMA8d+XXpraig1AILPyuaGCEDn63qq5CqN+1M8NblCKXbH7vvdhPirJLhzGuZUiCKQdgqwDYZ5pJf69jEI9pQSG3gpcUwE/ivTcQJQZHBI7cK1qO3Sdh0ql32Fu+Y1OYltXpMzeMasLD2lE+ngR3RmJw90 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000037, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 21, 2024 at 09:34:46AM +0200, Oscar Salvador wrote: > hugetlb_wp calls vmf_anon_prepare() after having allocated a page, which > means that we might need to call restore_reserve_on_error() upon error. > vmf_anon_prepare() releases the vma lock before returning, but > restore_reserve_on_error() expects the vma lock to be held by the caller. > > Fix it by calling vmf_anon_prepare() before allocating the page. > > Signed-off-by: Oscar Salvador > Fixes: 9acad7ba3e25 ("hugetlb: use vmf_anon_prepare() instead of anon_vma_prepare()") Let me just revamp this and run away -- Oscar Salvador SUSE Labs