From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5019AC27C53 for ; Wed, 12 Jun 2024 17:29:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD00B6B009D; Wed, 12 Jun 2024 13:29:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7F496B009E; Wed, 12 Jun 2024 13:29:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B20586B009F; Wed, 12 Jun 2024 13:29:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8B3296B009D for ; Wed, 12 Jun 2024 13:29:37 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 317271A0242 for ; Wed, 12 Jun 2024 17:29:37 +0000 (UTC) X-FDA: 82222923594.12.46FCAF1 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf04.hostedemail.com (Postfix) with ESMTP id 442B240002 for ; Wed, 12 Jun 2024 17:29:35 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nTHJN8f1; spf=pass (imf04.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718213375; a=rsa-sha256; cv=none; b=HB98lkFooKHxZGoug6IKSCSjfq/+dGmeYI4P375Qcxxo34mkdz8CjXi+eh5eNKjCF2pKZp gOJGyAPq/nle4SpdZua+8TCDCWmj9VlKqdxe4UkgK+QWDCv/5CbY8KHQtZWmhxs0MNtju9 PGKV3+S5tMnd0G0ya4qRzyEfyi+gjqM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nTHJN8f1; spf=pass (imf04.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718213375; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/7EZE8kZJ8YwXGxhpq3/arcNZCvvFBiX+mbM6jw0kdY=; b=wJl5y4paoQHFoqYM3XSNEoHef8/v+UB/C90L4CnVEjcqh6wW3WWADAgYzWNRr/D+O3cJc1 j/muHw26onWsyvF0pUxPo5LcHwjxsq0pTw8TbTt3bKfJVz4kPHLkKPoC5cK2GzDz1jbyqx SKvKbT2AlskwcPF6g/rZOmFug4boaBo= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1f44b45d6abso1331955ad.0 for ; Wed, 12 Jun 2024 10:29:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718213374; x=1718818174; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=/7EZE8kZJ8YwXGxhpq3/arcNZCvvFBiX+mbM6jw0kdY=; b=nTHJN8f13xYbzm6PeKdSbHdN6bRqKTPrfSBBIiB+bCnSxbynYwmNQzc1+LTMi+kVzn Be7dx1Glaoc9v+2owPvOyXJ9yAkrSJHliRgswFmtyr8VF3fdHERxVeEaUKjYnFou6kGc HgUmGz7MMqTpAZWdI08ReG3DHvX5Kmbz3gYqHyo32+KjLtRbVgoa3w81mgB3pDWo4TJo BcR7kHcsSeq5sjJPqALds/AfS5LN6tzaukTJjG4oMA1pVYxj23RVpe7gxugIyNFlgZac 4BxY5RYgfnIYITAsB5xeW+8XeqQHtQS4B1NhjRQjKvPwcW3bmg0cpgX66I91EY9fDyyW LNrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718213374; x=1718818174; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/7EZE8kZJ8YwXGxhpq3/arcNZCvvFBiX+mbM6jw0kdY=; b=cCKTTHntmo00Hm8NPT+OAy7QU0aFGHnjBXzPs6kW8NLMK9YKFHjWzhWdk0TsLLDKiQ XG0WoIQ4hgZlYNOOSGEqQ8E1gGrPbbXoJfO5uAqUj+OSq+DDT7xxez9ccN6eZiAejlcK cFfpCe8i6Sjj/32Tl44knstZRqSIJbSx+UGAHbLD/XsHCIl59F118bzws0N6dFR93KF2 mXZCG4wy2zXfhe2jmdzKARbTp3X8twEybOneGDjEVS7r7CBcfGmOZppvhCx+oFHtBEn9 KJQchwJBFZKKV3d2Hyo9jLIKEP63DVGWEbioukSl59kMcLAsYBiwtGQ8Z1aZLjLMtjzG +Q+Q== X-Forwarded-Encrypted: i=1; AJvYcCWIwCU/fgto3fsWDeqLt2tHSOy0FWX93EpovkPGmOlOaCef5uYjYqfIvSAOM5BNQU5umq+KUCT5orLRDxjWNdHx6q4= X-Gm-Message-State: AOJu0YwPIozvbGXI1BoTQogDgpybQwtCiwsp7twGtqkEnDIlkvtoNpY4 fe491bnnyiBqOy3FtyAmST7IJ/ACNVs4nxL3yQ3o/WbQyqk5sh2X X-Google-Smtp-Source: AGHT+IGd7Tv1NYL8MvHZP7GP4sML4J19g55sFnTvjguJaFG888Hs+XWIgGoJVs8gxFkgyVjNU8c+yw== X-Received: by 2002:a17:902:eccc:b0:1f7:3bb3:abb5 with SMTP id d9443c01a7336-1f83b64ac13mr27474335ad.8.1718213373929; Wed, 12 Jun 2024 10:29:33 -0700 (PDT) Received: from localhost (dhcp-141-239-159-203.hawaiiantel.net. [141.239.159.203]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f72a6c5a5fsm39546885ad.233.2024.06.12.10.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 10:29:33 -0700 (PDT) Date: Wed, 12 Jun 2024 07:29:32 -1000 From: Tejun Heo To: Martin Oliveira Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jason Gunthorpe , Leon Romanovsky , Greg Kroah-Hartman , Andrew Morton , Logan Gunthorpe , Mike Marciniszyn , Shiraz Saleem , Michael Guralnik , Artemy Kovalyov Subject: Re: [PATCH v2 1/4] kernfs: remove page_mkwrite() from vm_operations_struct Message-ID: References: <20240611182732.360317-1-martin.oliveira@eideticom.com> <20240611182732.360317-2-martin.oliveira@eideticom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611182732.360317-2-martin.oliveira@eideticom.com> X-Stat-Signature: tozhehoy4s55jx5upuk3neti3uk1ohxt X-Rspamd-Queue-Id: 442B240002 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1718213375-221323 X-HE-Meta: U2FsdGVkX1+U28ArTS3mU3HDlnopb5Wj4vwyRLwd5bhMUNPdQ/btIrp41Meg6IplRDc7hKOJtLM1dRtaLIXKsuP4siH6dRp4LOjXSxl58tOINlaKDQHixcEVyIGRbv6UxM67db8WDNUxylOgFk+IarGHzhL1mEQ28r1eI/CPWJ4ZhD69arApJDUTO1I5izKJEFzv+dJziYzF/ex87UtlXOGUJL9IPajIC6MfAif4JIHdW2Kj8trAeyIpHDTuyqFIaivO6QaKr60nE81SdWn/YOch2aK1smMhhyrdrzLuDKNSLhvdgPao43QNDdBVP0jgDwZSlb/N/xchgGtnn2wQ3JrkHeBVIZ28gqWBQ8p9555yLioqzoYAS5Saov41U0aH0CtFTLYkwpKKePMAZC+f6cxhmubdLY1tyDUylG9dJnpc10M5uMNcDP5TEVsFMUQf+gIk5Yh8XlIbSScx/nM+dk2+tORqE6gylwlLQ7U64CcIfc5Hk0XDTNXypz61vrXdsnpY7uotwbSTs9yrfkWQNq+by4z4K9Fsajed1eAOJNAepqDBTVQ0TEp4/4kkvFIQ9tWHjg1X3J4oAME3qGRJ8q0m3FbGfZrAEtOnHCCfOj3RF0BqSipg2mfuEtObNxUEXYMObBkdojwmjfgMTKFglDI43YpcGHa7mso2QsxA9jPbQYxEvZME3iK22awoQQgRCW69BH62+Ag1NJxk5l5UrqgGYg6gUukdymmcoiSkyECPN68WtQfgAtf6e1Zoi7e/Oflm9/hmUsWzP3CriJZytiMsz1HA2FgqT1F9GQcIG9W95hjQV3GtaPiQwUOOrFmJbjM0mmxrThNaadVgjX+FjtQ/sqOeurBclEzfkYTZ92K2MJPFbgktZi/NmdPuOlFXGk7rfoTkpjYf5a7I3NRXGR2OIdhGAUNxk3L8FfGjRrqaKNwrrY7oB20OiPoBCRizsZ6v6rvIU07DE0Oaw1T fU4gJ0YT lh3v9wDC8jBqXVUGWDPSl0i2akAbSPXXZXrMgrqUvV9/EySodZ5NoQLI7dNPKnEBpKMv8X+GhiBrZtVynEta2SK7/OFBCP7asALXKpadUOXCkbwF1sQDlIbhyr8WbxmKagHfyyc6sguTi0Ff7WNQHEyo0c4taiPovZDleq0obCwtCQmccukANtlDgtLRWnx2zBhzJwlwe8RMxRIJwCwDEqZcAGxYrqjCTptaWk8uutV5xLI7sIQt5hvJx7itPYbjpvnQaYI1LkeFxMpMgIpI9vtyyNaHGJhN/mU2/z2rLbfJ/MAtcnPs5Pdbvr4rPcRRvsLaQV6BGeZ6p7rBEHr+rYrY5lZ2dYhpKKyyosNdTrAY9YyEG2raBrGve1jNwfW21F8wwq4LKEiFmWeVBpoEvKYqah9y3/VOgi77i65X+Skv8PDhXO6HqR+8FK4x5YapEuNPkqqUY+jvqydjjQ+ru7Dth4DcGS2srrxoAQVFUuY6TY2HjqbZvKl7S/fed20ett2zYhspzvMzx1S6IiT2sGCdOpoe5RKq4nvVjRR4Zr4AG5YlTlKDcCOXqeoig1cNTFgXBYQkbj7RwFDll1Wbnugpowl01jx/ZqvOzdhvtKISbjYfj0Y7zaE7gMDWa8G0LLWA9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 11, 2024 at 12:27:29PM -0600, Martin Oliveira wrote: > The .page_mkwrite operator of kernfs just calls file_update_time(). > This is the same behaviour that the fault code does if .page_mkwrite is > not set. > > Furthermore, having the page_mkwrite() operator causes > writable_file_mapping_allowed() to fail due to > vma_needs_dirty_tracking() on the gup flow, which is a pre-requisite for > enabling P2PDMA over RDMA. > > There are no users of .page_mkwrite and no known valid use cases, so > just remove the .page_mkwrite from kernfs_ops and return -EINVAL if an > mmap() implementation sets .page_mkwrite. > > Co-developed-by: Logan Gunthorpe > Signed-off-by: Logan Gunthorpe > Signed-off-by: Martin Oliveira Acked-by: Tejun Heo Thanks. -- tejun