From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77287C27C53 for ; Wed, 12 Jun 2024 17:25:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0996F6B0098; Wed, 12 Jun 2024 13:25:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 021296B009B; Wed, 12 Jun 2024 13:25:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDD366B009D; Wed, 12 Jun 2024 13:25:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BD71F6B0098 for ; Wed, 12 Jun 2024 13:25:01 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6C7AA1C0567 for ; Wed, 12 Jun 2024 17:25:01 +0000 (UTC) X-FDA: 82222912002.09.394DD5A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 398E340011 for ; Wed, 12 Jun 2024 17:24:58 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="JSC2fm/3"; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718213099; a=rsa-sha256; cv=none; b=QZ+Iy4nKiOMmS5G55xbNDXaTtx89vLltxnM/+hrgF1i/DbiYzpBwTt6WJ3Laz9hV+1/C1T oFrYGRAThboOOvNOBdxFfZyJ0/34zM0fe0aBmKHmCf5u5uVtSRj4fnG5j5gJlRUAvQwWUR sMkd11rggYcBdqMNhlKhJCcdNI8GFsE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="JSC2fm/3"; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718213099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=amAeSiLiL/5PV3oMw3RYgelQ4VzuG/TJzfRKgkx8h+U=; b=ySFjyrOR9/p2OKgrY3QF9lu0m3xBNH62gOSCRamTcqVjh6+i9HPlH/zfnrtgeM6DXM8NLf iQq5dVnzYMK1tuFjd9KvJh7U0pnFvSucb+vO37XJXxNEbjf0czf1utuLMVqAyPx/2vpELV Y76J7X9wGMETVezVSehjAbm4oYD3x8w= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=amAeSiLiL/5PV3oMw3RYgelQ4VzuG/TJzfRKgkx8h+U=; b=JSC2fm/350AJHGVYIofS85JA6l LAB1PwbyUL7UlyrhGj6j0lN6XGLmXnNr9CehZfuT4tL4bUqAyS2HwvyrKZD/vS8o7ZGHgfP8ZVqhQ R0j+9U7YosceH9go477TzkPVw4QH3k9iRLsCKqBf554QA7Jv6FfFqVxuLytZzSNiGbSy73lYR8mZT +JHCegogZmo81skCsmDHCauhcSUov+i+itmhCvWzsbG+sPMbWn0b5ad3bdmxZ+3Wrmtts9zrfsdB+ /nr2xxTwpe/N8z5Pf4R0KLlkKXjAGQjwDt5ZJmBRwxgrPDq/mx+Lb6LIPIOynB9mgJn6n4PWkORlQ w7uQhO4A==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHRiN-0000000Ev4s-1apg; Wed, 12 Jun 2024 17:24:51 +0000 Date: Wed, 12 Jun 2024 18:24:51 +0100 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: david@fromorbit.com, djwong@kernel.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, mcgrof@kernel.org, linux-mm@kvack.org, hare@suse.de, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, Zi Yan , linux-xfs@vger.kernel.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, hch@lst.de, gost.dev@samsung.com, cl@os.amperecomputing.com, john.g.garry@oracle.com Subject: Re: [PATCH v7 03/11] filemap: allocate mapping_min_order folios in the page cache Message-ID: References: <20240607145902.1137853-1-kernel@pankajraghav.com> <20240607145902.1137853-4-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240607145902.1137853-4-kernel@pankajraghav.com> X-Rspamd-Queue-Id: 398E340011 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: mrmnuahcecd666owsa1xtof3qaorjsd7 X-HE-Tag: 1718213098-785673 X-HE-Meta: U2FsdGVkX18kFxVsQ0Co3hAlqVAhr9M5HTKhjuABrnF0H98gUK0xecliTWBCOXBvoe/t+dOVLTL7/nuWccOPOCe32XFWvGIKgreFq4DPf3C4RDS9IRHGg7MbWEAfYSiCx6/ITh3wXLoubE68SvOTbREo2xsurN7NnJ93tnLDcqH+MeuTIURPLiZUp67vyMu24j3I/m8M1U/t4zmPMZ41NSvPEXapVIwfwBdkMHzyrg9S1/q4xVnWJdxwktOwWqiCr3FMloLaoTSDr0PPBzdQX342aZfbq9f6JfSqOiTYHL5cPzTSeH8jXArVUGjCxIXmXzHNvEKlSLMXIT+dx2MjGI5h1Tm7A8vEikJS6l498sHrfeA5mgQYqAOkP3tNbR+J7rfAUzCDPPGT2BGWC+Wau1AlVM3UZ2Ervc/QC57rmGVWi27E5ff8GPsZItDwDTYvrJ8suG6PH9FQVnjGl3KNqRb6RoZCoCZp0z/RLLdjTjylBNNt9YOMGPcfiCEwp52lQBoXw4h/xTeL64ha6MNI294KY7KDjPD3N2Xnmxxxs1eGmbjBOc1uxzemhnK4vWB8VfhWlP5OocAxEWKxJlEdjIMA6P5DncClSRW4FY3ZOingre/kU/TeHIHFWPGf1x1EzE61wgQi3p8w+GIVu+L69KB6PnFtKbBVk4w5WdD0qGhj3UujOkDqiE0AEG/GpZ1lrrEYtijuNikwYZNweSFIY/Vx4F5AMuOrG0tu99UT31gJLhHeNnNDOiqa0R77/134aBzHs4dG4mezF7gfjGipi+CWxn8/x0O7rV8jTr4NunodzNzMX0mQyM+eqV6BjMpuPcoSVPH9Lvy/glsa4xYQp3RJT2rxzM/VB+WP87wQ5ozusm3/4m9UGHiM+oyDwkQNj3IgLysPIGihywEp67/4f614RK8S9QojOoGLhcpnO/E61X1ewGFWCX+W9fOSFOS9FDGmwDFWjVxULG31/r2 xVVPyjQL /rB9l1UqpmI20H53AYzi9eOt8KKTR1inq5UdaTtCKAclQoQ7Pz5AqpW+HqmWhSaxiYetPwRnY5mkC6uTJiSWBrDeedPseHPGChJWGcN9gza2u4F6dFEtUD4p0N0wPjpwYfVrwGtkp21hUGeRtqgIXeD4xstHRIxTDGeYttPG6Pq1NEUG6va22mkqLWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 07, 2024 at 02:58:54PM +0000, Pankaj Raghav (Samsung) wrote: > +/** > + * mapping_align_start_index() - Align starting index based on the min > + * folio order of the page cache. _short_ description. "Align index appropriately for this mapping". And maybe that means we should call it "mapping_align_index" instead of mapping_align_start_index? > + * @mapping: The address_space. > + * > + * Ensure the index used is aligned to the minimum folio order when adding > + * new folios to the page cache by rounding down to the nearest minimum > + * folio number of pages. How about: * The index of a folio must be naturally aligned. If you are adding a * new folio to the page cache and need to know what index to give it, * call this function.