From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B9D8C27C53 for ; Wed, 12 Jun 2024 11:27:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DE356B008C; Wed, 12 Jun 2024 07:27:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 883106B0095; Wed, 12 Jun 2024 07:27:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FCB96B0092; Wed, 12 Jun 2024 07:27:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 538DA6B0083 for ; Wed, 12 Jun 2024 07:27:34 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C94E514067D for ; Wed, 12 Jun 2024 11:27:33 +0000 (UTC) X-FDA: 82222011186.28.8623F46 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf16.hostedemail.com (Postfix) with ESMTP id B7656180003 for ; Wed, 12 Jun 2024 11:27:31 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eDxwz643; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718191651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2WXhunE0FX83qRs/SGKpCCNORSUg99lCzf12ZKZzJD0=; b=pRKuPaDm4zA1Fz9IuN6yieZPPvZ0lLbqMjzzcvi8aRCeplOiMmxTr4aqP+QcG08IeLCABa GXwMiLEGYGs3/uDl9YGzaMgWLcsRPNS0kOGMz+gmmR5uPijBOvo4HxBKf61omuf/+nYj75 c++GO0bxNXS0wRrQWwP5wBtJxXkjxpU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eDxwz643; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718191651; a=rsa-sha256; cv=none; b=0pgKgFfn/YBKyi7+o8cZxVfQMCRkKwJgJuKvw1czn+wsm/PderGtNoWV5PZy72g2JiHsYc WO2auN5thOoh82QSdIrhmnWFWRwLkbUPslXtBwvkJcTrHkulpdqAGkCxkB2Ex1OIcNKCr4 RwWwYIXqyhh0CJbhx6cjen33sW+LyHc= Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-52bc1acb9f0so2329835e87.2 for ; Wed, 12 Jun 2024 04:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718191650; x=1718796450; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=2WXhunE0FX83qRs/SGKpCCNORSUg99lCzf12ZKZzJD0=; b=eDxwz6439g4powLy39Onif2rH3piuT/5KmT34c6y261bgbfYyvgvFxJPwLGSFfsf23 LUhgfG3QumwwvCOxWOdduV2dRfZYUzsRErmRJ7/uJS5S/Ks7R0ptI14bJbRx7ybmnZtC KQaqM+LN1Cb4/lvlKdWTyWx9K/E7vUrAfDvfXUkImpdTej+6/t4DZOCBEG8jDChAJmAn 25T/dzMmsdwQiikJF0rEA9mmfXAunDBKywiuR3brht33k8K2Vws8Wg2lWpoFhaKf+rCi dLJQ/1N2sLWltbeZmoML+ZJZ5+V+CUEjy9bpSzHCvIM6aRvsrsdyds+WTrnnFTv958Rd H/Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718191650; x=1718796450; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2WXhunE0FX83qRs/SGKpCCNORSUg99lCzf12ZKZzJD0=; b=SlkcVb1ReHNkgEviOcF8kqo4s4AbahhNdrQQ3mX0eCnO2HPcHI315HwsBVyI1LVa+j ZOWBEB9vmVqRO17NfO0ii9bPQ2vGx/+pl1/5K4QPC/OSl1ZUZPbPxZkfwsjhRqqxvNZh mdb4Kmhz774CssIDzIF3VsheVPbpbd+GBTUkVUUK+HeWDi5pEvpsJeOFgueaIJKV7sCz KHYalNCBcmH6RtR3YOsplqSafX9IHTQu8KWL1rFBNYfnd7IVESbBWrSHY1YDp4XowUyu gZiOrnhUaIDRdMM7PcokFeIauQiMLh04W6DOti4cLor/f11jn3sBAwIKh7rQfzqfIZRG 967Q== X-Forwarded-Encrypted: i=1; AJvYcCXN603E8GbGMPOqaJ1WSKGmigAd4wNhqS3vOi6TijtH0cMXoN2SVVoggoFtvB+lKLLVuvCqJRvoAKI+WstF4v6+4wE= X-Gm-Message-State: AOJu0YwGIucrqej6WOJ2hD56vgdZH1ub95lSV54QIJpHF4S7Op+52EKq fXWgesV6dPwAD7hacU3p1wOGneDQsnposM7VNz7tlUPjNhqA0c8G X-Google-Smtp-Source: AGHT+IFL/+dHqux09NxFiimG8+4GZxdGxQxBDWDe+F9a1kTeGHUaRxVMPVGtrmjMLX8TEzoMX7Y22g== X-Received: by 2002:a05:6512:3e05:b0:52c:836c:9ce8 with SMTP id 2adb3069b0e04-52c9a3b9624mr1506594e87.4.1718191649607; Wed, 12 Jun 2024 04:27:29 -0700 (PDT) Received: from pc636 (host-90-233-193-23.mobileonline.telia.com. [90.233.193.23]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52c879187f0sm1489134e87.272.2024.06.12.04.27.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 04:27:28 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 12 Jun 2024 13:27:26 +0200 To: Zhaoyang Huang , Baoquan He Cc: Uladzislau Rezki , "zhaoyang.huang" , Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Baoquan He , Thomas Gleixner , hailong liu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, steve.kang@unisoc.com Subject: Re: [Resend PATCHv4 1/1] mm: fix incorrect vbq reference in purge_fragmented_block Message-ID: References: <20240607023116.1720640-1-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: B7656180003 X-Stat-Signature: 8jyxqyymn9g5uuiczqtybeuaho1cwwoc X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1718191651-864844 X-HE-Meta: U2FsdGVkX196yBY5LJ7b9WkSubzVBMKlAG3/w0EpiqGw6Mn4W/0cU3yQqRFcHWfjA00eSlwPuk6aH3mx7ZgoaBtKi2Vz/m7jXIfeUoD1W5X1usdpmq4r4CrLaHZ6Z7z/Tyou7H8KFJf3WrpCefWuBUliXXEdn7OW6dDZvgdoBdbLJh5lnK2g7tqHAdaCbxxi+51qTo3VM76n0hAMOSNNHlt70goq25poR4Qx1jKAKzRuYFCHXg9CcG2Dri/DJkxH7lJ9034AV9NuyZMvSVv1yG1WIK/VstLwmavQh31HJ4FZHXr/Hb/75+bbxaSCAyK6mJruw+UQ4YdMUNbbzKi+VvPmp8hqrIyTf2m/1Qoeg+f8JNU/jLiZAOHHKLawYp6hsV8r49mTPeBjIXP/rjeoYabEE/i0hRGfBHV+yGTQBJ4iN2+oQYo6ePnFBvFcSD6K3IjT6xdrpF63EJaUUM8hgTNccBx6pEDdMeNzMuWRUTlWQZCYiKKEi7sgjIJfY55uIXxuJF+QFsDGJ81EwuR82db4sSzGHeGz70DfYCUknhSbdSeBXYN5jXrRoIrNo+rl3fe9dDjfWIFfsvh8uJ3Kil4PwiQpH5pg3i+vEWJPRgJtkGQQA2EGi7+fhOZ8TCftlsn5A2xk+nRIImOY/Nq8tu8DuSydrKfMBEloBV3TMPhLuYKB6bLIcGT1khUqO9UO2a/nu/DliVdbv9PMw31Qh7FJFhF3H19MsZDUdM+RF9zAF3T9CI7Bafa7dD4g/3fPY5dZ03jLjk9lgtiOypk0ZqigXFPpc0+t/mIDFsIfxzTo4t6iWAHbCK0O1wQuTG+vBdLKPWl21zrsTA0d2wiHgzi/YkvmIzcFP2t1yXptgpZM3kuliZ+Ia4cIckvt5w4+GwgXjAHF/Bdd/5vtJmSxag7psjqx7njlYrXerxaFlehh8e5GT6eCK5OfekCAXL1LrFgD31x3WAnpSg0KO+H OPdGQiAM QSgypWNdyIRK4gAJ9alj4VOauc7ODV43k/3GeKDDLL/SDlsiPDRqtz1OiMBEYHR9XeAlGT2H2QoNkbxH84cryNUhF+yV4EhxOb0pV89GEle9DN23lPZmE3YsTzGGoU8qrnaXSFXsU1qiY+hSpIhmBfSzjVyyoA9UDKPKXhL238Y3U2G6Kuqkb79+qlnp/UcHgKjvYJv61jyIgaBa8XPJhgYM+FwdEYGpnU/Lu9h4kDUnH9RR80VlJS+aK4LM6QEF5JWCkMk//DeiGVZYIQvSAPRvCLkBVkBibV4wqWBf3xowwXy3H92JhRlZ9Ea7t4mHs96BLccHuLmk6RsVYs9U3JIgxQA+ZAjGU1LXPWXYqB9u1J9TU3VCt12SKevJQrbwIPYrzJR5m320gIRL9Ef9gLBvZkZ8SOz5WwQCWd7URZauHIT6H4mGVyupmxx0UIBdZf8MjpoxoJTviwBQcP5JZgS29YIQgNFUOiBaISQ/4SZBL6+II3l1Ja5DFFHFyEJQHvKJ8qfrsiB5WbuY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000768, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 12, 2024 at 10:00:14AM +0800, Zhaoyang Huang wrote: > On Wed, Jun 12, 2024 at 2:16 AM Uladzislau Rezki wrote: > > > > > > > > Sorry to bother you again. Are there any other comments or new patch > > > on this which block some test cases of ANDROID that only accept ACKed > > > one on its tree. > > > > > I have just returned from vacation. Give me some time to review your > > patch. Meanwhile, do you have a reproducer? So i would like to see how > > i can trigger an issue that is in question. > This bug arises from an system wide android test which has been > reported by many vendors. Keep mount/unmount an erofs partition is > supposed to be a simple reproducer. IMO, the logic defect is obvious > enough to be found by code review. > Baoquan, any objection about this v4? Your proposal about inserting a new vmap-block based on it belongs to, i.e. not per-this-cpu, should fix an issue. The problem is that such way does __not__ pre-load a current CPU what is not good. -- Uladzislau Rezki