From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E74A6C27C53 for ; Wed, 12 Jun 2024 10:43:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CCBE6B0093; Wed, 12 Jun 2024 06:43:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77BA46B0096; Wed, 12 Jun 2024 06:43:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6446A6B0098; Wed, 12 Jun 2024 06:43:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4619C6B0093 for ; Wed, 12 Jun 2024 06:43:32 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A781B1C0785 for ; Wed, 12 Jun 2024 10:43:31 +0000 (UTC) X-FDA: 82221900222.29.558FEE8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id EB0CC120018 for ; Wed, 12 Jun 2024 10:43:28 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oktXjwWY; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718189009; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H3t+nyOxYgSIQdo0ToFQediow40UdwxovvZbTBwOF+s=; b=mCihayYvNFCbaF0ebpJD2bdhSygr+BG9tnHdmcm0aOq75YKSlNH+1W5dnNfTAOEmT44AVl bbtIpVl7lE3htK4ZmhSelIbX61q3kUu0YksbrTUXgmvtwr6FvhR4KRq/VFQAnu3UOx/3Jg xgUbINTMO6Cf6jfT9+h7v3YQb4Fst/Y= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oktXjwWY; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718189009; a=rsa-sha256; cv=none; b=Ss20AIamSN2uKJ/eD9s8Af3aEGXP47k6i3oFZ5hb80A0FlqrvOIkPG5SxtbSPDaX6FdmCO xgFjYj8tpI0LD6CiIpZxTyysWzphjXG1jk8/bVwmjEZEsQiXm23otYw+oO+aC62lCT5v7Z ene5z9NqVWJV1ZOQMolL6bh6ole7gjM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C3F876134E; Wed, 12 Jun 2024 10:43:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1DE0C3277B; Wed, 12 Jun 2024 10:43:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718189007; bh=i0AkVG96HZP+xZlgakshFx4WYDgJ6NHv2HEdMjfHNzM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oktXjwWY0SjBMdlI1iZB4rWkwiB5T05GruABT09QkcllcPLknmNITngDkJ7UMNaVV 7Fdv2sgReaQFCD3tdrl+PQWXYifjYJ4Dsyu/D0h8ZZtxyCNx8tErP0cfR9Naw+Enng GPYw0bbfHVB0ppCEf09EdsHw84edZ2TvDOlkyLjKvx0P5Ib9CTIJOUHsjyrq1jdnnb YhpATUXX70LETG2uNLsk5gafHeLU1rcxvHvBx0p54u3Dc/gTG82bVYjiOv+5hjpcQL g8YAI2sdNPrGmcGDYJD8lbWIOgr1cRe4XJpdcBR+1HlfgMfZZFdOBxDWsM9gzaV21H Yu/8O4vQJkbDw== Date: Wed, 12 Jun 2024 11:43:24 +0100 From: Mark Brown To: Andrew Morton Cc: Shuah Khan , Muhammad Usama Anjum , Ryan Roberts , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: mm: Make map_fixed_noreplace test names stable Message-ID: References: <20240605-kselftest-mm-fixed-noreplace-v1-1-a235db8b9be9@kernel.org> <20240611152317.8e72edb3a545a685a2a0b395@linux-foundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="taj9yIMJlp9FRGvc" Content-Disposition: inline In-Reply-To: <20240611152317.8e72edb3a545a685a2a0b395@linux-foundation.org> X-Cookie: Your love life will be... interesting. X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EB0CC120018 X-Stat-Signature: ezakber66e5es5brprsgtz4huwbg8hzr X-Rspam-User: X-HE-Tag: 1718189008-378875 X-HE-Meta: U2FsdGVkX19O1NK43XMfqfFiAEVduvDHzk2dPMCgkB/C6U+o4dB9jUYBGoMRGPJcYfISQHbFVB/K2cbVGvDz0MQlm9NekMufJjVXMdRod1GVOju627HaNQE6AfROjOOgTwP6SeHEv40bm5FZHO6yzfxfPIn/BvcmIUrKaoepndkNUZH9v7FexZX492G1yUcmxECXaJ/cC0RJuGTjCLiqrYGGNtvHhAi8LWAcgTi7bXzmg2Zv7C5s0RE8VtAO16qiG2AtjBOCmv+jjD59cCKvIqe+t6YHT9Jb2Fhy4gPaMp6t+X56m9mJSppFNNOWJs/DtKPT4g1Jsu98bzIQ9Cxk1NCq8NpaZ4CzxnLM+LnVA+qsBZtonxf06vjWrU6mvtPUTcBQHnAc3E6nv5wCYutJGplOb+CbXC03oJvM4I2vicQlfjHQ0K0LCwNm+P39z3jrD2WvC/sAqKvribWAqYEpCWZGlKg2bMd6kIHHmyxMpoZeQWKNkaQ7XeX0Q3q7W5NtpwFwlyPBH437QVi5Kep8vSNHJ2kwFh6KMFGmAsjtK5LChGn3jFNQu/AZNySZt3M5OD4rsISowbBnmSCp8SF6bi1OneI/mpZTEVHWSKSWWTRdpv+GB1+btkn9btdRpq0iQnJKC+hfqWeGm/4VSDuzcgo14/KMY6AkCPigrbQw/MRXd8Dra+4JyY2PxJtGu5s5ZGvobd9GZPsTEBIsZgqkby6+Ii5KoiMIlWg0UqB2u13AbNiufvzMkTpEsOVR2v0wyE0R0jyWPXlIe5LpPT6rxuKFZcxT1y5z2QGcBMiY5Moz26B1f5UtHAyVmSNAmEOeNU1L89YtqkA8hlDLg+j74+28ZmSbJCyqUo2X0z1tdlrAOiMDB/2M4piV6qUEk3+f4Btwxu0N9OieFk0FnOXMLtjFgdYRVymd3PabbUpkQ2zum3bs6cFwUooXspaUDgy2Ncxg2F4Z0S6nPzkrrqy zBdlwJpy oY2VBZ6Oon3iX0pHW8jvFpmE+ZTGlodmmTWqScaXbxsFVap9sm9yFH7QXWPoyzuvn/1Zpae0yPs2ftnVKVvYwXugOJ8fa05ETPPni94agVrzS0IBYvSkfG+E179vMRF7MbONefJwjILRiNlZFprBjpk4/LZeJ32eO5El8G/Hc2W7wp23by8XvXKA7NerYR6mmAC5AIT9afaSaMGPYZTIZ2KZbRjhR19Fu6YJgp2Z3P5Mw8ogUXEfwHVjhe7nc13JTwevRIq1OvQtnqUic4WECU5dKJXhIQ9H+R4g4vkgB+vKZLJavUgocl9QX1xa3pkI3UAaXZwWpsRf9NlXBhWSlmbAGsw8Stx1qlM3J X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --taj9yIMJlp9FRGvc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 11, 2024 at 03:23:17PM -0700, Andrew Morton wrote: > On Wed, 05 Jun 2024 23:36:12 +0100 Mark Brown wrote: > > KTAP parsers interpret the output of ksft_test_result_*() as being the > > name of the test. The map_fixed_noreplace test uses a dynamically > > allocated base address for the mmap()s that it tests and currently > > includes this in the test names that it logs so the test names that are > > logged are not stable between runs. It also uses multiples of PAGE_SIZE > > which mean that runs for kernels with different PAGE_SIZE configurations > > can't be directly compared. Both these factors cause issues for CI > > systems when interpreting and displaying results. > > Fix this by replacing the current test names with fixed strings > > describing the intent of the mappings that are logged, the existing > > messages with the actual addresses and sizes are retained as diagnostic > > prints to aid in debugging. > This sounds fairly annoying and I'm inclined to backport the fix into > -stable kernels(?). It's annoying but more of a UI issue than anything too serious - for my setup it just translates into not validating those individual tests and instead only paying attention to the overall result of the program. Personally I'd say that it reaches the severity where it might be worth sending for v6.10 but not to stable. --taj9yIMJlp9FRGvc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZpe8sACgkQJNaLcl1U h9A3rQf/X65fpQaBQdsPSyX4tv50iov2KxXIBmL++mft/PrqcYvGNIQAtxXjeXQZ Q5f7YQ4YcCHlUCjw3ic7zLPox1YNobi7ZBSCU/QvZ9YeWhA3/Ud8Q9CdYPKwx3ZS xhK9NZpQ5WO2QOmtRfSLkdMCTnYV36oM4K4gb9duQOJtEZfh769/AmbVzLLnCoab WIlqmwoMrkfMieNk+H8z/1i2jFWVTxHRiM73dMv6SiWCIjQbMixCXlOMvsf9bCYc 6Eol5gIsfEHmL7qbVi+d+MLC4uypLuA35Mtqvez3EGl1spWKsjV9NsxA2kD7hyVm CE/qEsbVD4KHawxWtsoSbAT4PyHPfw== =/+tZ -----END PGP SIGNATURE----- --taj9yIMJlp9FRGvc--