From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3612CC27C65 for ; Tue, 11 Jun 2024 18:15:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C130D6B00C0; Tue, 11 Jun 2024 14:15:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9B0E6B00C1; Tue, 11 Jun 2024 14:15:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3C396B00C2; Tue, 11 Jun 2024 14:15:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 824726B00C0 for ; Tue, 11 Jun 2024 14:15:57 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 31D6AA24CD for ; Tue, 11 Jun 2024 18:15:57 +0000 (UTC) X-FDA: 82219411554.28.C3D75CF Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id 7D29FC0005 for ; Tue, 11 Jun 2024 18:15:55 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=k86RAQaJ; spf=none (imf28.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718129755; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=we709GSrSi71LXBSzqvO1IMG9MEKMIAa8MQWGK8e8Rg=; b=PcK6nqIB31RmhJElxc7Yb2uq3Rm5fTYeSS/o/G6sTw7jqZopmcH1vHkzWthfIrEoRgQI9t lytcnTOvagczD+n3QmqlBC+9bnYKyjNGsFQiGKcPq88v2ZUPQAmRNHKCrm2bY4iZSY4Rzd rwUS3iH3cIVjqEbZj3titKidLIh+Qd8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718129755; a=rsa-sha256; cv=none; b=DI+mzMAOSMjnBwtIaWR9QaDgACn8spcdqGSSbdF4sd+AA/QC/F8IZfzvtZGN9ffPPjukbN c/7OcCj+FhzqaVfSbQcm/2PU+IcLY1oEWDTdwrQEwKhsCRsvD7fuKMvXqbQpAA3B2x9b2U LkuiARdv92g/YOGZbZekJNvjPA4J0ak= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=k86RAQaJ; spf=none (imf28.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=we709GSrSi71LXBSzqvO1IMG9MEKMIAa8MQWGK8e8Rg=; b=k86RAQaJB2pO/3bH4b5xgLqG3O m9XVNqyJEnWSDrNZxjEkMeafgLdxxuFtWk2l6aRqhG89GNqV9y50TJehG3bSG2REq/s01oLbqT41D emhDRSIQQF7Vqys1AEgOzlWFYUvJQo+wbPVE5A9XGenYTz+fe1j7AweyTnE5x6iBNsQdrdVXEi2dn rE3DEjsuD3/to1vdDILnLurdUn5ljJBUn8L+0KiswP5vNrPYb5ZKxgRYQ/KYYrtxjOKLmDpMUYpXL fWomhalzcwK7yw1Va5svurPLM5IewVNdpx/n00AvCvy3tovDi8atK6smav4j7rCqLI/x10zdIWJ6t PmdZrMUw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sH62C-00000009oHv-2dF3; Tue, 11 Jun 2024 18:15:52 +0000 Date: Tue, 11 Jun 2024 11:15:52 -0700 From: Luis Chamberlain To: "Darrick J. Wong" Cc: patches@lists.linux.dev, fstests@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, ziy@nvidia.com, vbabka@suse.cz, seanjc@google.com, willy@infradead.org, david@redhat.com, hughd@google.com, linmiaohe@huawei.com, muchun.song@linux.dev, osalvador@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, hare@suse.de, john.g.garry@oracle.com Subject: Re: [PATCH 5/5] fstests: add stress truncation + writeback test Message-ID: References: <20240611030203.1719072-1-mcgrof@kernel.org> <20240611030203.1719072-6-mcgrof@kernel.org> <20240611144503.GI52977@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611144503.GI52977@frogsfrogsfrogs> X-Stat-Signature: qebmowgtgmdcezw3y1doxyqqjetdekr1 X-Rspamd-Queue-Id: 7D29FC0005 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1718129755-564014 X-HE-Meta: U2FsdGVkX192AncIBYvQOj0N0jY2ds3AwTWWHHtEcm/KeCrH9EeNcbdyRY7/qV4CoV2c2RwsJTUM15yUV6PAYUgj78vZlzXuU4yQETzw8taRlueVNfrsaqJgc/B5DIF4kTctzExArmsVrxsff8+QxZWT53n2xYz9aONjPQzHb73RK2leghZbAIzlk3BAeRjXg/gMDOB/DV3UjnD12BT05j1IEoRePAgPDXb4XmFu2IDve1XYyiNEzz1FusEwiKx2sAndq16FYJlnEm5JimDA7cM8CjN9PRetGSOu0UtlE4OvxJbVvK+5dKKXn1bpgswBKEwcIcx9vyCSt1g2UVlcpE7JaHP/XEsw8YDw/HJjbKyeFJ/APU1klXVtmbpVxAFIx9yCLaM7Ga7gU6iWDaeLB+vHbkBKAMgHedFxxavxM8+6/0jFAEHlWWpeky+46/AwJ96qzBsHuX3t/GprqetsvgImIaz0BKAwMUg24V0YWmR6ecyqUFZrEjl/AGjylOCKxov7WA1zbuO4+Oz6OY31LkF6090OHC157zgoI0CFu0YaYxuENtOk7hrofZfP5vIj2hspSOzMDJ2+wKkm4wc6Eg3rL1tZDu3krTcfueeb5G3vWv2X+04hW+VVgLijG+pTgHeG8IkB0rhJ6Ptc5wTAvZIrSds6e4s6IYchcE+I2BwKKGyR5Ls10qH0w87c2wvbsWZmWGJ7Y6NrXyGvFsiwG4gVg8K3VqQ9EUG9nQKHuXg6jd0YVGufITfZ9rhbdhY+AY3H9kdW+QdCZaPvvzlMIvLXevjhqIS3a2epdJ9jsQmS+O4h0du08BwOAQaTnsw6ylNzh1pr395W5jJA/eObCHJWnnJnO5plVSzDIF9ZkuxdZAnHotuwMaT5Ne0j7Yb4oMjj/twEgW5XSpqd+kz89ngWygRzhX9oZQEZ4Z7SlWIc/ZABLPNbkJSTdAqKz7qfdmcF89UhwUsk5urJI8l jy9CwbJM eT0hKGcg9+eYG5ZY53HpiHszxCHyJt0SQ+7Lxu355up/97/4Pnq1pw++LdvGO2wUz1f4FZruSZ+e/U7GRmex6vxTLxc2C3Aauad+Udq3cotx1Asx7FXb1ZAAul2B4BakoE2QBZ3F/6E4+BqzkdQTAIvuY6C/F05Uy1QAeCIKRFCyPeOje6dMlyftP9+dQm3aM7aKzjqiE5GqUTBhqn4W9bqPcLm6m3prbx8v3HgXvxinKs7O7QbzMUSVXcOTuctdWrmjCjRZMd3ib8uRj6sP0wPHE5TxmSLEZpoWD0aEo0B4fk12TiTncrXD2JeCQUbcdCn8HFPbea1LKV7M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.024087, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 11, 2024 at 07:45:03AM -0700, Darrick J. Wong wrote: > On Mon, Jun 10, 2024 at 08:02:02PM -0700, Luis Chamberlain wrote: > > +# Requires CONFIG_DEBUGFS and truncation knobs > > +_require_split_debugfs() > > Er... I thought "split" referred to debugfs itself. > > _require_split_huge_pages_knob? Much better, thanks. > > +# This aims at trying to reproduce a difficult to reproduce bug found with > > +# min order. The issue was root caused to an xarray bug when we split folios > > +# to another order other than 0. This functionality is used to support min > > +# order. The crash: > > +# > > +# https://gist.github.com/mcgrof/d12f586ec6ebe32b2472b5d634c397df > > You might want to paste the stacktrace in here directly, in case the > gist ever goes away. Its not a simple crash trace, it is pretty enourmous considering I decoded it, and it has all locking candidates. Even including it after the "---" lines of the patch might make someone go: TLDR. Thoughts? > > +if grep -q thp_split_page /proc/vmstat; then > > + split_count_after=$(grep ^thp_split_page /proc/vmstat | head -1 | awk '{print $2}') > > + split_count_failed_after=$(grep ^thp_split_page_failed /proc/vmstat | head -1 | awk '{print $2}') > > I think this ought to be a separate function for cleanliness? > > _proc_vmstat() > { > awk -v name="$1" '{if ($1 ~ name) {print($2)}}' /proc/vmstat > } > Otherwise this test looks fine to me. Thanks! Luis