From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9D5CC27C65 for ; Tue, 11 Jun 2024 18:05:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C57E6B00B3; Tue, 11 Jun 2024 14:05:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 775906B00B4; Tue, 11 Jun 2024 14:05:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 615C46B00B5; Tue, 11 Jun 2024 14:05:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 425886B00B3 for ; Tue, 11 Jun 2024 14:05:44 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D55F9140697 for ; Tue, 11 Jun 2024 18:05:43 +0000 (UTC) X-FDA: 82219385766.03.016CC63 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf09.hostedemail.com (Postfix) with ESMTP id C625E140015 for ; Tue, 11 Jun 2024 18:05:41 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nMPUrL3A; spf=pass (imf09.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718129141; a=rsa-sha256; cv=none; b=kPTzk+5BLnLM4y19ReXG2a6cQ/bXZ8yCQkBE+OGTkAtR2pzc8IO2Kj+KNbPcsUQowOJmWt U14+Oj7XYn01wQQkMUxAT9rOXiKn/OVcMBYTB9BF8wTTkUJ2EOdxcpBIO0OkeC4a5j3ncP tancUEfnECnr2A100gz8FKSKgVjLcOo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nMPUrL3A; spf=pass (imf09.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718129141; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RUohe5I/U8iYfjovsxU/qvXwQ8UTe5baG/sBR7a+0qU=; b=twqhzN891tyrpPkrQ2/ldnoZUvlCEqD3zJ1GUgsR+GvBbc3Qy0pQhc+IJxqfprAZtTNZbv zkPPmNHqatoTK47rlHN+N0Uhk2XEz3r+GeTSURfXzYGFcv4hizv0BLvIji/tom2Z3WjmMs 25epQTbUsWMLoJY67MsvxqRo4/ArDSg= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-52bbf73f334so4349159e87.2 for ; Tue, 11 Jun 2024 11:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718129140; x=1718733940; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=RUohe5I/U8iYfjovsxU/qvXwQ8UTe5baG/sBR7a+0qU=; b=nMPUrL3ASo4+0+ymb4oz3f6yX6qQYIuTcNeUCcGQlwdR8FiMvCYlwqK/rGE8ki7+bF Ti9J23j192itEyaDZ7Uvy9+hIaNUDB0/HA7HuzEIGNTbmmF8yvD3Hi+jjE+pWoQKfxD0 unzo2W8OoZIoO2NiAKVYUVSNgmmNj1cYx8dRB+esnL07extQFevSusq4Oh5tKHcapClO rCucmGvbNC+NeCRpxth0KSzNWsmSMCi0S/ckiFuBTZqhRE5AY+Z8bSUy++aV9GA2TFB0 DT0hk8c40gIqqKXyVNNmupsIygkiknvGlORdY2erFgK/19cp1ZznSKD4Cdr4JczYQ+HV Nkjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718129140; x=1718733940; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RUohe5I/U8iYfjovsxU/qvXwQ8UTe5baG/sBR7a+0qU=; b=OzjTwkcp5w3swA0Cz4GTnAauCylvUHcN5aSmBwh8i+egEg26R30anONuFUGhtWOVf6 LZC4cZ0TEPyFRmJoLOWOcPrKRxyb6cdyKue83ds52OT2RhByoIlVlMkVjJsP6utQOqVm fzhQBfCK3WX6mJEvyJzBhV0gRAZ7LvTVZew5692Y4nNiwWapA6Wpz6g7LTwUhD4ckpe0 ABZDscCatnQ8g8osiho3GXW0TqucomdMM+DRPxocpAWlRYHjCGZ/gqjk+G0p5logH4oM ZTTGHGOnqOwVN33b7uXlJjBW343IFfvcTGKaelgLroUGCEtTioqFUKXq5Mb9yybl/Lci LXQw== X-Forwarded-Encrypted: i=1; AJvYcCWDqbTiSjs48Ldp/FTPCs5anJ4UIVigb0f76ioUSllhbL9tsxFKUqtudwAu2R5cEn5WvW/M8RmVtgsjEOEr+xDeI34= X-Gm-Message-State: AOJu0YzdKNucAevBU5YjVBfhbePvcbLY2iyMtWN6B6oJGdepdyp11os6 cA6kqOz9tBaLyk4xUDjIc9WqWJgnfhDSMlsUHBurTTremzzgfW3H X-Google-Smtp-Source: AGHT+IE2qPhlRsFkwXDOcSqAcYHE6TUAlN0piNN/sxB8v9XWqfk1bNSlBYNdXHQRf5+2ZR64HQJHIA== X-Received: by 2002:a05:6512:70c:b0:52c:8a4b:f972 with SMTP id 2adb3069b0e04-52c8a4bfb11mr3484974e87.34.1718129140051; Tue, 11 Jun 2024 11:05:40 -0700 (PDT) Received: from pc636 (host-90-233-193-23.mobileonline.telia.com. [90.233.193.23]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52bb433e22bsm2217192e87.287.2024.06.11.11.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 11:05:39 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 11 Jun 2024 20:05:37 +0200 To: Shubhang Kaushik OS Cc: Uladzislau Rezki , "ampere-linux-kernel@lists.amperecomputing.com" , "linux-arm-kernel@lists.infradead.org" , "cl@linux.com" , "corbet@lwn.net" , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "guoren@kernel.org" , "linux-doc@vger.kernel.org" , "xiongwei.song@windriver.com" , "linux-riscv@lists.infradead.org" , "linux-csky@vger.kernel.org" , "willy@infradead.org" Subject: Re: [PATCH v4] vmalloc: Modify the alloc_vmap_area() error message for better diagnostics Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: rse8ysgp16cf3eproytoahw89wzwzj9q X-Rspamd-Queue-Id: C625E140015 X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1718129141-981534 X-HE-Meta: U2FsdGVkX1+lPC6TwwPqLOD6Fn1W+BiEZhMWQ9h6yK5PSF8fTxWntIKdJtf9Ib5UPzemFlRkvVs8w+Axj+aITR8/H2gMuErOa8NSz5LnsjfrIY+xyewNZIqYivsckuDRMuNJHu7SZJoxNO4eMb6M4QXd77j4Kw99UCk98GJz3l11wPDU1ydQ1+G1qQZ9BNpo3T0azHxByTxgOFofEIOHIkVAH0jW5VAuVM2ZNTxWfnIq+FXo2X4tw9mR8BJmQK5aUNqswS4RXuHBcP6fANQvvpSbVvIS/MeKUdr8mTC4SeZQ/7SeJTL3IqCa8rxyxtkAd+lUwaSNZ2PpH7i0kTlRdPzVX6Xm4ne0B3EWvoiIMslXW0gWY4IKee4MybKSaYfiO5t8XfmlbWt6DVNlr8X5Ilu8HhZ4k9zmYjWZsezJsTDdvO4zNvD1DHQzEAzV2duO7AbxS/nd7gM7SCD+xdnUkFJY3DpKkIjpQL0AYGiSf0ypSLG0pXhYTgUy4ghvOTzYm4lqzLkfEw17CiCZy4VmvGbaOa2NDm80YEE2rObYUS7Ythn1ckRMerubjMcTAvY3bCHEk26qJK19U7dKQciJHe78SgtMDrLTtFKceiWv9h+NynBb6uJxMxFzZCuNUn9beFFx9l/vR5JLzAH36gad660TRzCSXrNrKjCon9le90tQd9uN0Q8Qo59I0YQUP3+dvMMFwyPhVKN27Lt/c+dYjgR1omkypb63gqoJm0tPy6N+OoGYhBb7Cs4yqLPwMBolJk2iXPwMYBIopT75E08t8XsEHGMo+7iZDuYvW/oDhXShYOaR48F8wr+dTWOHFCgm5vzAUpDVlnfLpctxryuBTmDFICErG+Pae/qPo4GjyfYdVhu82c7jpR+KiD/iV9DmVeSVh4q8aNkzkUvUWgvTcr0an5jMpprQuALrMgDePH6OdU/eHIvUxD+CooR9us3c53ae/fFPo7bWKhUJbP0 oGe0vn9v D7knE/dhlPxxCRI8m6lrv2FDxxz/BGwrYXg/fIzyJF7Gfpxxluhhu8FdMEhSEMDqUIDxvJlUcaZ5yoH0pAPKyCO+7nhWnwP/gcdKRVA9T8IKvLp4zuU17i/RvhA1LWvEd4eKfLhE+OBs5MGVp3SauA6u6XnWCrdpbcWGE15NS4p/4H/bExiEQeKom3gUv+NWCIb8wp4DsfsDfg+018doRdoWCrqApUTSloob7+iqs40lzwwk79O+OqOKiM5j6Ct6xso+fniX1+519wdfqm1uKALVzgnrQZF0/oBR6F5BiwR7R4dTlSpRaXj0KSg01IJ/RtibrnRkoBGbD/q8stXdLVu43tqr3M1wcAj2Vdv0bK94i6phVbyvv66V8+WFQBpDlZKq+miwQUhCjubuBmKXp+ODCfGwesi+HMez3KtQTZup1sGo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002400, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > This is intentional. When 'addr' equals 'vend' the overflow path is triggered, but then the 'vstart' and 'vend' > values are not carried in the overflow path - making them point to no address. That is the reason 'addr' is used > in the warning message to specify the restrictive range - that gets assigned to 'va_start' and 'va_end' in the ideal case. > What do you mean when you say: "but then the 'vstart' and 'vend' values are not carried in the overflow path - making them point to no address." >From your commit message: "With the update, the output gets modified to include the function parameters along with the start and end of the virtual memory range allowed." i see that you would like to print an allowed range. Thus an allowed range is specified by "vstart" and "vend", i.e.: vstart vend <-------|------|------> vmap spase an allocation must be served between "vstart" and "vend". So, according to your commit message that range should be printed in case of error. Now you print, "vend" address and "vend + size" one. I do not follow why you need it. Could you please explain? -- Uladzislau Rezki