From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93151C27C75 for ; Tue, 11 Jun 2024 17:52:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 350796B0093; Tue, 11 Jun 2024 13:52:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3008D6B00A8; Tue, 11 Jun 2024 13:52:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A13E6B00A9; Tue, 11 Jun 2024 13:52:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EDAD06B0093 for ; Tue, 11 Jun 2024 13:52:13 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 90E431C24E7 for ; Tue, 11 Jun 2024 17:52:13 +0000 (UTC) X-FDA: 82219351746.03.687A578 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 4A16940011 for ; Tue, 11 Jun 2024 17:52:10 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=PmzZEcgP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6YIYDN9U; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=THwRdiYp; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OUu6IJyD; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718128331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VcY9+66PbaVZcQn/3AmGdGmKSjGYDmXRUDA786GKSJA=; b=Z4/c4ZXw3ITUPh3oSvHZ2KOyNwhe4Cit9CYKkRcDV2egilsjYgiYGrBw7s9LBOfgnYdn43 LTbTz4/uo/p+9qp0ksIb1w82k8FGXD+nS9X73HWVE/a4DMppgpcUqGqnJX277JJ2aeDeyD hSUzojvsAYDoj56nLAe8xtOg4fhrBro= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718128331; a=rsa-sha256; cv=none; b=m0iEFo169zDqpdxZf8uZ4HmBIUdHuAkTaMegxuZg4lnX65Q0thFwfUvt+t3gzkA/XFb54r QWXABrrYZ6zBcYAl7QyB7Tkip6+myS1AbEikkuUOcRZYbdbq99LLlmweX+T8k7TxuAvM5N jENzoySYMrvyLqydkKr6PI2ey4zjk4I= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=PmzZEcgP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6YIYDN9U; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=THwRdiYp; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OUu6IJyD; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7400C3393D; Tue, 11 Jun 2024 17:52:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718128329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VcY9+66PbaVZcQn/3AmGdGmKSjGYDmXRUDA786GKSJA=; b=PmzZEcgPXSCu9EiLqUdMROSwdSQrprLqpE5w3EwjVyE/oQVTU+VT0VGyf1faTIZh5aQo/4 fTCPcKJ+whtKSuzgiqY+FuQgUiL6MXvMVuXuQB2F05TEx0uLohMM6tp6qkqHYB9nD3Uiv2 JAD/iXtuaUuwetlSPZouGCPcJl9WtF0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718128329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VcY9+66PbaVZcQn/3AmGdGmKSjGYDmXRUDA786GKSJA=; b=6YIYDN9U6sj2xYIj2zkEv65eskA2NpgIqqkAuT+8OMXnD1tkiRFzMopSZTO6KkmXwyv2Ty XJeNiEJhTqVtDQDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718128328; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VcY9+66PbaVZcQn/3AmGdGmKSjGYDmXRUDA786GKSJA=; b=THwRdiYpiuZzHRI8TN9ZSMeHmE/jY0eyX4ukuCK5Ju20hWl9hW3ErTBeIjImqG7MjnMaFk bjODjn2ucCzL7yZjYOlrjFTc8ik3/f0TtKZ4WDFkBtNwfTXbJ9YqBb1hURD2MotIq5nKU0 CMIw9WyjTJODaAgWZicyvU7WzxZsw6I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718128328; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VcY9+66PbaVZcQn/3AmGdGmKSjGYDmXRUDA786GKSJA=; b=OUu6IJyDb5SwnvhEYtSKAAZTwjyu6JxmkVbJ951IhvN3c9KLYhRrVf0/Mn7vJlKNYNOr1n kNGab4/icNZeK1Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0BEE613A55; Tue, 11 Jun 2024 17:52:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id mACMO8eOaGY3CgAAD6G6ig (envelope-from ); Tue, 11 Jun 2024 17:52:07 +0000 Date: Tue, 11 Jun 2024 19:52:06 +0200 From: Oscar Salvador To: Andrew Morton Cc: syzbot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, muchun.song@linux.dev, syzkaller-bugs@googlegroups.com, Vivek Kasireddy Subject: Re: [syzbot] [mm?] general protection fault in dequeue_hugetlb_folio_nodemask (2) Message-ID: References: <0000000000004f12bb061a9acf07@google.com> <20240611103005.ae4170608bd15d63adee2492@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam03 X-Stat-Signature: op5eaazbrreg3dx1mpqd6hdx4if8fttp X-Rspamd-Queue-Id: 4A16940011 X-Rspam-User: X-HE-Tag: 1718128330-533422 X-HE-Meta: U2FsdGVkX1+fafhMZKxuBdzeyJK1QeXtkf0g36r4vy4luHiAWpE6PuiOAz9ynwjTncOGwmadjSUWAeZteBxjL800y11e4Y0UBZ1X5YQjfzsBdMb6YVbRMpWK7hYnZe6I0XPSl0UiITbNS2c5vc9LBEwUmmVMEQa3M3FnL7yL+znihHFHEVrOPzzme1U2ifIs4+GCVn6d0ty/ZJc+hkxwJrkT1IEETmgFWEECmdJnOLs9p62HK8kZkUKGkbHImkhjQPPhR1pAOlKsVd7/v7cWhOGQ544U/IvTbsFBghjorO7luh0hSZrfo0WCz3SqnKCLJC75bYcApWkjd9jKdbbhFcgrbkdICqsd4pA/TtkCVby+CevTreQVmK8cHxZP3Das5MBGM5ll6bc0nAw3t4Uf79Mw75mvsg8bGqh6/qjIrvh3BnRDfYJ7P8XReSD8c0KpCQlroaFoyD2NQJjj0Urzq2gLs42fu0sSQL6fjCa7ex2ULZQNEoRvlQh5cn7U1IiQOj8A7LGZxkX2vpF3Mfh1A3nHTKjkmn4TseXQQ3aC4ZC7O7WC8+5P9AwXzGyhwiTY6j+aB9dj4+hiBmWg0kn25bYapb1/LJUUxb2x9502VUjWcr6NetnFqYcSl/PQjOB0z6sRgDTjrRTir91S7epfpRGo69rEbRrbgAw6313D6mrf0SS7aqWdNOgMOw+k4L5L0JNcLt/r2XiFR61uhu0Yrr2IIutwlaeOXPamgf4HHNTHnFV7TAjzURoDfw9ByIH1vxc9zJtrNlBDb7go5eC0FoKxLTL0ucj7Oq1WNHzWjPqRmF/zgqjGJCksj2r8Bz6eU8qqBDKDBaq7+bk0DKngKvqbb2PuKqF3kkDu7y2ifqUXgubxl/VVw9k8pEnuaYEVON2FU7E/sfq4Ue4PQnFA1VbGhBY7NXgYH3jUftRgSomxZqiAy7yBWabylhi9dgA3nmObORR/lHA8HBJJ1jD i3Re7Ltd DjKfbuk7QgRDxqopt43qAnqMLAtvf8OiFhR4faOUvVdJcltkLnlnvNw97wEo82MPjeR+W180J3P92SxzP2y6uh5hMf6mGOkd3KJWYIsYDhUv4dMv0q/HnXPWm8gruiYbYJ4qoGG+vdJK9qrb+26CjfSwuj9sNLF4BEvLFaAn61Rcu+c9k829DAJfp68cqj6T0z9v46sqy+e3iujDwPCRY8Km8G4JwFdmRg8xHCDo8w/kXKrbn4IqbihEC7kxKaPYOWLhGqDgMq/5SfcUwTn58r4F2zSo8+UDKwn7sIlgmJgc/D5m8Q0tXWQ+cNi0MfQ6NB3+qTmnN+QC9KY69CjrGlYO+cMk4Rnz5h3LfGhm5pA8H0vRhoTzO8wM9Z2IjuXrwTnpoo3cYxJ0u2GiGzh/U9S6xRCBD/BSksUiNLbKiybgrqUDrq+dcTjQ831FRzeCLSFIa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000564, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 11, 2024 at 07:46:33PM +0200, Oscar Salvador wrote: > On Tue, Jun 11, 2024 at 10:30:05AM -0700, Andrew Morton wrote: > > On Tue, 11 Jun 2024 03:34:25 -0700 syzbot wrote: > > > > > Hello, > > > > > > syzbot found the following issue on: > > > > Thanks. > > > > > Call Trace: > > > > > > alloc_hugetlb_folio_nodemask+0xae/0x3f0 mm/hugetlb.c:2603 > > > memfd_alloc_folio+0x15e/0x390 mm/memfd.c:75 > > > memfd_pin_folios+0x1066/0x1720 mm/gup.c:3864 > > > udmabuf_create+0x658/0x11c0 drivers/dma-buf/udmabuf.c:353 > > > udmabuf_ioctl_create drivers/dma-buf/udmabuf.c:420 [inline] > > > udmabuf_ioctl+0x304/0x4f0 drivers/dma-buf/udmabuf.c:451 > > > vfs_ioctl fs/ioctl.c:51 [inline] > > > __do_sys_ioctl fs/ioctl.c:907 [inline] > > > __se_sys_ioctl+0xfc/0x170 fs/ioctl.c:893 > > > do_syscall_x64 arch/x86/entry/common.c:52 [inline] > > > do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 > > > entry_SYSCALL_64_after_hwframe+0x77/0x7f > > > > I think we can pretty confidently point at the series "mm/gup: > > Introduce memfd_pin_folios() for pinning memfd folios". I'll drop the > > v14 series. > > jfyi: I am trying to reproduce this locally. Actually, should not memfd_alloc_folio() pass htlb_alloc_mask() instead of GFP_USER to alloc_hugetlb_folio_nodemask? Or at least do GFP_HIGHUSER. -- Oscar Salvador SUSE Labs