From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0720CC27C65 for ; Tue, 11 Jun 2024 17:27:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D4786B009F; Tue, 11 Jun 2024 13:27:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 783D96B00A0; Tue, 11 Jun 2024 13:27:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 625756B00A2; Tue, 11 Jun 2024 13:27:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 428826B009F for ; Tue, 11 Jun 2024 13:27:09 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B0810160544 for ; Tue, 11 Jun 2024 17:27:08 +0000 (UTC) X-FDA: 82219288536.07.AFAE0E2 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf17.hostedemail.com (Postfix) with ESMTP id BF68A4000C for ; Tue, 11 Jun 2024 17:27:06 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=e5Id9gXB; spf=pass (imf17.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718126826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZuNAT17Yia2ED/GBtljPyXNC+kaiVErMdlGJkLgW8Pk=; b=v+K1PROY9fmLeUxVdcFmKtg64Bolhr/j5AZUHxOa6wkfusa8rAtrueYyyOfqz4hbce18Te EK0f5BhqcSuhbReBQsZTFILWd4jg1EMR+zw4AZ9+BiDnL62F8EXTugxdKPcMcMocemfZQn pJKU+gebWk3LrqLpZVkP4JDblzjzJzQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=e5Id9gXB; spf=pass (imf17.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718126826; a=rsa-sha256; cv=none; b=wJIi+/7YbXprpRMXULYf05weWfBH6xtGeq9bcMkGik/4gR5WZe8HcIdi9gEfzqG9AmFTGT TLkFOPSCE3hS2/LAJhkBoggMXVQ0upqi4oBI0nQ3okp3B/je0DV49GwUcVm+ujZdBUbqMG C1Q3F/ttIpPy54/pYZTWOqhx27PuFvM= Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-52b7e693b8aso46120e87.1 for ; Tue, 11 Jun 2024 10:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718126825; x=1718731625; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=ZuNAT17Yia2ED/GBtljPyXNC+kaiVErMdlGJkLgW8Pk=; b=e5Id9gXBU6Jw7gWehw6RozpmutsffeycgvWAJaypIRk/UzHmK53eCWrYWGSqjvI9CS txEUl8e+z+FvtRkMVohhr1FU3+5nGvvm75fONdgoUWKKkR6f3IF2UgbyVBP2NJjtj1nQ xfblr820KQZP+y0PUtThSLwPArouHmFtOIXKYmJBXKcm0qvLU+fb9O1Irn7qoy5QeB3o feoyF1WJFg/7SOVEW7OFhan18y8Yk4HFLlp3OiObY8c/Qa5qgkFfRNlmYIoWs03aZK0X IlFB7L3s2O3e1IBBO1/nzgvi3II9J11Qaf9T4bdXRtzXPOuI2Co7xNKw7+5j2dC6qOwM xBNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718126825; x=1718731625; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZuNAT17Yia2ED/GBtljPyXNC+kaiVErMdlGJkLgW8Pk=; b=T524T0U/gNiMgrCwc4FuECFpJg4nwP7jDmXR6MMGtv/yVL+ZCT3k7nHJKaoyiwCnWp P89aXei0Qz827sQhY2epkRj1tpWhpN8SnxbIZdUBXm2J/mrfXX8uGWsNezsAlVXKE+rv 8SCi17dBMHID7YIlftUkXVr7eGtJ5KJo8PknELfyYO14+8KsrsloVrjbi+7plYiadAqX VeRTaG0mRJ2r7yI2Kx9SR9ZUjvZbJB94XeXYwJMbO0Q9a4fylx/3awSPMnGsPexM+JKm 3I27MhPZJRsmC2V/ML94eupz93aZTagFrcGY6oMWX9V253ehcLhIoTRj7wZD+RrizvJX IA4A== X-Forwarded-Encrypted: i=1; AJvYcCVteMtgLIP8TrLXhGIGc2m20uDBb+GArneaAuDbnz/BmLzmLXbqxHnY1EJhuQNXWZQXou2nX0snF0ysTenbIvf7G+Q= X-Gm-Message-State: AOJu0Yy4fWxpOsyvgMzQtpjKw0lJTvtf1CVazkI1IBAvzgZ+8tdI/AEa KB44F//yjWbwCY0fuCtbwQ81cIn/Y1Ya9Juj+MqOhNcOiVeALDcc X-Google-Smtp-Source: AGHT+IGGTOvlVJb8KnHeT+pJ4WbUN0we9oe9aXR38gJXbm4NnMBWL95m6/WpY1sx6qApjEeWgxI6HQ== X-Received: by 2002:ac2:510c:0:b0:52c:884a:96c7 with SMTP id 2adb3069b0e04-52c92437759mr943923e87.17.1718126824740; Tue, 11 Jun 2024 10:27:04 -0700 (PDT) Received: from pc636 (host-90-233-193-23.mobileonline.telia.com. [90.233.193.23]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52c9108266csm503259e87.151.2024.06.11.10.27.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 10:27:04 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 11 Jun 2024 19:27:02 +0200 To: "Paul E. McKenney" Cc: Uladzislau Rezki , Julia Lawall , Vlastimil Babka , "linux-mm@kvack.org" , RCU , cocci@inria.fr Subject: Re: [cocci] patch idea: convert trivial call_rcu users to kfree_rcu Message-ID: References: <2dd5bafb-ceb1-238d-2f51-83ebf135b73@inria.fr> <2ec7eb0f-0950-4d65-b33a-64df7c5f89c9@paulmck-laptop> <77531e55-3418-d4be-f538-7ddc904ed88f@inria.fr> <21a32cbb-d388-4a8c-9298-ef8c82330f9e@paulmck-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: BF68A4000C X-Rspamd-Server: rspam01 X-Stat-Signature: e9kdnkuptj8nznhdy9xw4n5g6yoppfgn X-HE-Tag: 1718126826-952301 X-HE-Meta: U2FsdGVkX1/y/xtnqFrT1ZZESQ6/uh87CAzf6hiZg954MA3v8yvnfmuMfuU8VHTGCuksOGZyWbBzxVOqY8IGOv0Jn+b6yG1uukLp0QFNDl0q/bdBpTSrZNu31c4FFy428cDx8jj5fUh2VOUK+hVlNi+QFjenPhX9ULoisRj30JUIgBkznAAncDg4xm7DhstI+YKYFQz0LQS7fpcJWFkGYMYlC1uD6e4cfI2euQnpbx28mEnJeXv4vuJAeEKmd0Fpov9qgthL7HQhpAOTL4i8yVmQAOo0qx9tC+SnVEnits29nB8EPO6i89rd32No7FcNq4jTlwwRMzzjrk6iIiV5PndQhmV5orAdOGY9yw8Cyo0UO5HCoHNOvop50ztcFWeel7Wt060ThB+gzDMkXBG5h7deLlJ83M8AaWTaR1Ce/YfP5LjqrR3CtaNR4u5ZXznDRX08AM+fl+pPveL0zIS25mvl/BAvu+YJ9SsvYOE6F0AaBHa3SPc9L/Y+lpIjDvsBk0+1ZAwI55vD06nIXE1w/pbTkCkvSSKb9cW5tJebzDPk4kql7eWp/kfBYoerSRScGIT8fDi+WcVZas3heOfeRxXifsFFn6yXhTI5q9QXWqayQC//XCB81C8C6JD7BAEvBeZ1aiJH0JCg6XDdUHlyoD03i+3ugEQJnwbRWNWwx1HpwkiTTGOSFGejgllClFELpGp9HOjiOMgBlryA9CMwog5TgmS5cDGD0tzdl69suGTo8MtnY4qbGylK/N4f5d9C1l91ZCY8PNnCiNt+NF2N1YuthUZVntJgXDQXs23NqWm4A4djQcPY98zt6r5DleMs+cC2XLpGesqg6HLOlqFAaMEn3lz8hZhhchrta+8nNaIb9BYLSqnKzr+EDVtf0gWYKllha6098b35tYN+6CXjrlWNmCHbtJazmxjQBqXWlWm7CjC9+l8RwKmu+z1lSBF+QkHw0aSUbAHdF1kJPmY 3/P+TvS7 OsXq/YT6MEhLhy25Q/tQie5gS2Yb3SYvRc84mdXzF6RGd04rh6bEUhGcFaYYcB1wXvyVDgJP9G9rZVKy9Y8zUzlchPDcfynlAXTCuOh/mHqr2t0xCgWPtQAOL7XdMuM4q6mnMMEC0zQCuHGeNGvYoVpB8pwlDljUqCX0t+yzHk0kURFP6wJBlUAAqeSZBUebn4NiPAzdiHnTqerPC8sMJ7TeMXG0Sxt0M2UvnXnsz//5gwlDgzpRkCtUBUXlgev7r5L0GbioSXBMelDJYFGWONAtCFawSAM5ka5WZVP+jWCxz2X3zHz+2qbDSLmGhadRkwEroZI/V8dZFzq5hsOlwAI7QU+S8q4VqXu8p+zgh78gc2oCoKKpvm0q5AkvggVQLyKMmPQitbdN8gfSkua3cpgk4QhwiRhFJ6KuL1aBhgzK9Yb8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 11, 2024 at 10:25:52AM -0700, Paul E. McKenney wrote: > On Tue, Jun 11, 2024 at 06:40:49PM +0200, Uladzislau Rezki wrote: > > > > > > > > These look ok to me. In the last two cases, the callback function is also > > > > stored in a data structure, eg: > > > > > > > > static struct mfc6_cache *ip6mr_cache_alloc(void) > > > > { > > > > struct mfc6_cache *c = kmem_cache_zalloc(mrt_cachep, GFP_KERNEL); > > > > if (!c) > > > > return NULL; > > > > c->_c.mfc_un.res.last_assert = jiffies - MFC_ASSERT_THRESH - 1; > > > > c->_c.mfc_un.res.minvif = MAXMIFS; > > > > c->_c.free = ip6mr_cache_free_rcu; > > > > refcount_set(&c->_c.mfc_un.res.refcount, 1); > > > > return c; > > > > } > > > > > > > > Should that be left as it is? > > > > > > Given that ->_c.free isn't used in the RCU callback, I am guessing that > > > this is intended for debugging purposes, so that you can see from a crash > > > dump how this will be freed. But I could be completely off-base here. > > > > > > One approach would be to remove the ->_c.free field and call attention > > > to this in the patches' commit logs. > > > > > > Another would be to instead put the address of the allocation function > > > in ->_c.free, and again call attention to this in the commit logs. > > > > > > Is there a better approach than these three? ;-) > > > > > IMO, "_c.free" should be removed: > > Why not send the patch and see what the maintainers say? If they object, > you can always fall back to one of the other two methods, depending on > the nature of their objection. > I can send the patch :) -- Uladzislau Rezki