From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42284C27C65 for ; Tue, 11 Jun 2024 16:33:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BFA16B0092; Tue, 11 Jun 2024 12:33:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66F9D6B0093; Tue, 11 Jun 2024 12:33:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 510286B0095; Tue, 11 Jun 2024 12:33:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 324A36B0092 for ; Tue, 11 Jun 2024 12:33:04 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C884312158D for ; Tue, 11 Jun 2024 16:33:03 +0000 (UTC) X-FDA: 82219152246.06.30F8A65 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 02D194001A for ; Tue, 11 Jun 2024 16:33:00 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=r0SeGOy3; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718123581; a=rsa-sha256; cv=none; b=o35cxM6VDVx58iZFaDE9JHg2g828zeeFojaXXEssD2Nk+CD06JklGgeFCptLsAqdq0WikA 4Dw5q003DqdkCQhV2G0PVmmZPfzW2XwgA9SYsRBwCEXb52ZcQ2evgGIjI7z358Kmcrcznb lB5OEBb8gHFCO02W1kEzHoMWO7kAwQE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=r0SeGOy3; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718123581; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RSRFIPyua+NghJjLjdMIVM7qpgO03eFR28BXwMenbLw=; b=iswIFrK8aOu278+EvhnOXOwYLtWj46T1H5f3ez9AT8PNETRQT9MwpMDkrZD2oDHIHTBdWE VplsOaQy9JFjazF4sj45R1fIC1TrqHBSO7a6Saj+lleRabyJlMNc1yp9GF7aBshQ8Yx0/k GVqifck52COdmntxeAfVpmghYyn+LbU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E4E6D60F1A; Tue, 11 Jun 2024 16:32:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3BE2C2BD10; Tue, 11 Jun 2024 16:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718123579; bh=lMxIU0XrRl1uDi4V9mQvR4uYAOJm3ABeMJ3659SyNfk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r0SeGOy39UxoSlhAVdG/eluwXKp2QUawAC6eypf/lhxLj2IwA1gM1z8lmQek294p+ GLzRrfwOaIjPKGOBjrQyqnAZuX2GsKHDggIVMiZBtedF7VIN+zFpE23EE3qFnZ+m/Y mChR4oemg9D9kd47zNiYzEYJhGlUemQtN6DtWwFZB14M/JHL6FGy+fEptHHt968qTu cb624KQo3PzMm+RZ5w7xryiNG4sCp74j2XCTNoEMvTBWNwrwy8GtHfMIF+RONjOUdn iiII/twh0quHERH/7BmNby08G2J3iqHq5xrIJy9hrrV6fTyEQ8sXh+3DKZXSSiBMzI GJv3BakXu2fZw== Date: Tue, 11 Jun 2024 19:30:47 +0300 From: Mike Rapoport To: Steven Rostedt Cc: Wei Yang , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , linux-hardening@vger.kernel.org, Guenter Roeck , Ross Zwisler , wklin@google.com, Vineeth Remanan Pillai , Joel Fernandes , Suleiman Souhlal , Linus Torvalds , Catalin Marinas , Will Deacon , Ard Biesheuvel Subject: Re: [PATCH v2 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up Message-ID: References: <20240606150143.876469296@goodmis.org> <20240606150316.751642266@goodmis.org> <20240611144029.h7egl4aif5mjlrwf@master> <20240611111218.71e57e0f@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611111218.71e57e0f@gandalf.local.home> X-Stat-Signature: cjigra6ob1zp8ternjn3rysnubqfjohm X-Rspamd-Queue-Id: 02D194001A X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1718123580-969610 X-HE-Meta: U2FsdGVkX1+8v9UQjinyZIjB6H6KTVBlnl3Z5qfW4PWx/ght4FBPT3gkdsAsxpwfCWYUaUDkMDQRMS1Pz+UV9dxlFZNu8iec2sekP5PKsOARupROD8eA31oxKV+5MkGH8exVgsDwTnl+IHD6SsQtv0Fmbvx+HwOW4ZztXUSSq36E5usqUKt9I1RAnKnqQydQIlbySdvmh3y0k0CGkjWrDi+M77GpfHhwuPp13Ryr8EzQiGL4bcjz7uNIbAbOVLA+03+3jbqX5dqhyWAKDxVJ2MlVRk5Nti1ZpBKajCEXdhNn9ljDtsOuH970KsSET4N487sQIlFNrL4Gg0WUgvVGjKwaI5imzLr6O+GCZR2GGMeH4NikKwGY0nVS1NVc0/LEYki/Q/aZaLT5hdn483NOPvgnHPqwxWMwVO18xgPEFH//y0ZH/zyMBYgLjfHnceFpOFdRH/1i3cDeUWBKVX3+7aSch5ClFmH63QzY/HUSzuk27jWlRgb3aSOyN989tfM6+AtlAWac8oTkJrj7t4i8nVe5f+rnpPawPx2LDWmXoebCJF/XnZPqFlpHx1Ce22EUWYbvVdEt+i5tp+r98OQx2wnVNU8m8A62UKG4HJmutRpMdRfEIEL6m0lTPmlgC88oj3Uoy9qf+VbEghSSSYlDClWKZnpPMd9P8SuO7Fy88uLfausM1Fxzc1RHjTLixZyNDdkpyGAfO3+zK6a7Ru/dsA3eT70S7A+qPpZKGApJW+1qGggup/4SQrkSXMlapQUwqd8WKBBMnBYGZYsI7TQs7+kafBycxwLgVUzy++gboN6U1GI1isaSIZJACSO/kACFKASxE9orPzonyo7k1QYtAN4c9az1O7ghvZhX3L50AiPwMbW0PG6mwgbakBHh4D6LEXnWoRNPNVkA5D8JmXqcJcwg1/jxhjizCRMct72Bd3HL975uGpb4RGWuCCsDsYePzMi1s3g53rB5d1i0xmi +ug22JVz +kmH7f1xb+gfTtNar6r/bKcKFCvLqFmP2sFtMDXy4YFxZ6AL0nUTZQJJr5DqCJDu051AP7JgWHYE3Z7Wj9ezmV2+SN3qNFSp0EziI7FtW/0cc7nN/gDHZu8PpIAGfezKlE6vSP3pI4t2oQ/djj4Q+7/hI8OkJ/vhfzIrdKMXmyEyZonDiKshMnDeA9YIqJ2Cti98hIBO9TWt+UqgXdY+EX15S2Iv+LACkSyRABFWT6ixqxnAPDRjVmaifvzyu9nI5UAHbBW4N8DAbzhnWDdacmp58jRImsYAwI2OZT7UNkNDVSpgSaSsOK5BbplSLcPuiFJbDr92fPL33YR4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 11, 2024 at 11:12:18AM -0400, Steven Rostedt wrote: > On Tue, 11 Jun 2024 14:40:29 +0000 > Wei Yang wrote: > > > >+ > > >+ align = memparse(p+1, &p); > > >+ if (*p != ':') > > >+ return -EINVAL; > > >+ > > > > Make sure command line parameters are valid before doing the allocation. > > You mean that size is non zero? > > I don't know if we care what the align is. Zero is valid. memblock won't like zero align, it should be SMP_CACHE_BYTES at least. No point requiring it from user, just update the alignment if the user passed zero. > > >+ start = memblock_phys_alloc(size, align); > > >+ if (!start) > > >+ return -ENOMEM; > > >+ -- Sincerely yours, Mike.