From: Mike Rapoport <rppt@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Wei Yang <richard.weiyang@gmail.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Lorenzo Stoakes <lstoakes@gmail.com>,
linux-mm@kvack.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
linux-hardening@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
Ross Zwisler <zwisler@google.com>,
wklin@google.com,
Vineeth Remanan Pillai <vineeth@bitbyteword.org>,
Joel Fernandes <joel@joelfernandes.org>,
Suleiman Souhlal <suleiman@google.com>,
Linus Torvalds <torvalds@linuxfoundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH v2 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up
Date: Tue, 11 Jun 2024 19:30:47 +0300 [thread overview]
Message-ID: <Zmh7t8kupN2pbCF0@kernel.org> (raw)
In-Reply-To: <20240611111218.71e57e0f@gandalf.local.home>
On Tue, Jun 11, 2024 at 11:12:18AM -0400, Steven Rostedt wrote:
> On Tue, 11 Jun 2024 14:40:29 +0000
> Wei Yang <richard.weiyang@gmail.com> wrote:
>
> > >+
> > >+ align = memparse(p+1, &p);
> > >+ if (*p != ':')
> > >+ return -EINVAL;
> > >+
> >
> > Make sure command line parameters are valid before doing the allocation.
>
> You mean that size is non zero?
>
> I don't know if we care what the align is. Zero is valid.
memblock won't like zero align, it should be SMP_CACHE_BYTES at least.
No point requiring it from user, just update the alignment if the user passed
zero.
> > >+ start = memblock_phys_alloc(size, align);
> > >+ if (!start)
> > >+ return -ENOMEM;
> > >+
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2024-06-11 16:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 15:01 [PATCH v2 0/2] " Steven Rostedt
2024-06-06 15:01 ` [PATCH v2 1/2] " Steven Rostedt
2024-06-07 19:35 ` Guilherme G. Piccoli
2024-06-11 14:40 ` Wei Yang
2024-06-11 14:58 ` Guenter Roeck
2024-06-11 15:12 ` Steven Rostedt
2024-06-11 16:30 ` Mike Rapoport [this message]
2024-06-11 17:34 ` Steven Rostedt
2024-06-11 19:39 ` Steven Rostedt
2024-06-12 7:23 ` Wei Yang
2024-06-12 15:32 ` Steven Rostedt
2024-06-12 7:30 ` Wei Yang
2024-06-12 15:28 ` Steven Rostedt
2024-06-06 15:01 ` [PATCH v2 2/2] pstore/ramoops: Add ramoops.mem_name= command line option Steven Rostedt
2024-06-07 19:38 ` Guilherme G. Piccoli
2024-06-07 19:54 ` [PATCH v2 0/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up Guilherme G. Piccoli
2024-06-10 17:02 ` Kees Cook
2024-06-10 17:08 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zmh7t8kupN2pbCF0@kernel.org \
--to=rppt@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=gpiccoli@igalia.com \
--cc=hpa@zytor.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lstoakes@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=richard.weiyang@gmail.com \
--cc=rostedt@goodmis.org \
--cc=suleiman@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linuxfoundation.org \
--cc=vbabka@suse.cz \
--cc=vineeth@bitbyteword.org \
--cc=will@kernel.org \
--cc=wklin@google.com \
--cc=x86@kernel.org \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox