From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C94C4C25B76 for ; Tue, 11 Jun 2024 07:58:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 567316B0096; Tue, 11 Jun 2024 03:58:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 517556B0098; Tue, 11 Jun 2024 03:58:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DF6B6B0099; Tue, 11 Jun 2024 03:58:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 206346B0096 for ; Tue, 11 Jun 2024 03:58:35 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9CFA5120B4D for ; Tue, 11 Jun 2024 07:58:34 +0000 (UTC) X-FDA: 82217855748.06.6F38730 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id EF235100018 for ; Tue, 11 Jun 2024 07:58:31 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BBxarMO7; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718092712; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6vFCoGU/o48UdvFKW+ItMahY1/uawvkTxxvFoUNx4lM=; b=2VZzeKGYvoRc4yKbB778lbjnk3BrO3XwnthHhrqUrSd4e70texrjvbxKX4UAbU6aJ0Su6C jYUtB3t+5gYMwYGIKL+UroIa1GPWyVWJARELVcye890uqUVsxF6FEIEBZ+ZC3L9PVZKNJK gIyN3IcQe/kTzgnoaVgxZIbfJ54fBHQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BBxarMO7; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718092712; a=rsa-sha256; cv=none; b=n6zeKx+KEMhcBEL1eMH1emX2iTAT5BUwieLIUgMV0xEyvJxnJ5ZnfR0M83VY1NEaaupbFf DaRVFBtEmFeQWPvTybt7mB5+Eh74aMPxbCOrlvz+je1q73nZF+4r+uW3yoFC9A9tR3h3Gd BUqy7URDWzeaUotgJGUqpoTHW38AcOE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 12AD460C47; Tue, 11 Jun 2024 07:58:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB5D0C2BD10; Tue, 11 Jun 2024 07:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718092710; bh=H99vVv9ub0DJP3qHQoowqgVv5mp0f18pTA6aACoo1to=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BBxarMO74u6V3m/bUhzkvkCqjqvOeU19xeLvYt9ai5SYcAaD6Lpe0nm4Gm39WcI8v AinF8TfI1h1ptD9gPu+vBDAh31Wkrb7PZmEPz5HV+bO6zsJ7uaddgoq6Hgm2YHjBJT 01l9hz4WuFEnKSTOii57qgzAGGHBpJ7kUqOfLwJAMN4aFVKLazrXHWWrwlBVHTJfRK 0yuTEi8/tAU8c6bjrL30Mgmug2iXUKS9ohWjdQCOCnP9wRiA3dcJhdqYxQ/PYWmQ2i t2d3PVOC/rBOhQ/NGKsAV2YpBE7WJd8SDs3jHy6ukpYnUhKBWyPuelRKBi8sSfqt5I T+1NtLhjIiRsA== Date: Tue, 11 Jun 2024 10:56:25 +0300 From: Mike Rapoport To: Leesoo Ahn Cc: Leesoo Ahn , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/sparse: use MEMBLOCK_ALLOC_ACCESSIBLE enum instead of 0 Message-ID: References: <20240610151528.943680-1-lsahn@wewakecorp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240610151528.943680-1-lsahn@wewakecorp.com> X-Rspamd-Queue-Id: EF235100018 X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: gwi7yhkpnuxehk6ifgy4jjwf8zswybzs X-HE-Tag: 1718092711-412080 X-HE-Meta: U2FsdGVkX1/VHa9ehhn05eSi+kHCtVi/EfrCJoeEwk2W7ZJ0gxM9q5rlbUWqW1y/B7vAHHjzoMBc50x8qpMDSOMa5VBK3AeF6d2nSfAzXNg7c3sPA+mShzmfUtBAfpeYCmT3O2xW0Rzr+YSDwBhYBqW5g2DMZmRczfHZj6IjyDqtlLJJhmwyy5DDdeze3NeFfbC+lwt+tXGlTyTF76Lwj4lXrHeVczhgTK800c7YTZCbnz4EIi9WAnm/cmgBLW07vuZH1sStRzqpuzzB2VBCDS053ednvrIoRB936QNeRRa13I3TP6t0MbjsjRC8KoH5cTkjV1cCk/hrSvfRMx+t0KVoVtoNu2xWnrcDhc6QnhSGoI3kBB7xAPLze5lbeIvh+57OkzhOgsTzrgZUTtrd6SOKiIyCbIcwzdKlKpMUvTdKqRTBz3rqbL3AMB5wqnP5M5YFyVzVjnDeVJw/c3iB/qeInrpSzTUgjdt4R6StpnmvgMbOQ6HqL5zLUZwGKHB0X0xIASsSYMMnZqueyKNycx5wZmV4J3trgKxbryZFMw8ilfvkSHp9lTi7+S02wcFGmWQsMyavrRKMegT++VJmir+MKaedBvE/5iukpAnvcJVykYO1gOnbfwJljnb34jZ6ErUDVZm9xHKVBon36aFz+Ur4WgcJS5+ii8mKGKhq8h5tSLubjFlMTJ0F0JJ4Pt2KPtdUTLiME4In05Vr0GGkCHs34OevcuXFt0R6OXXrWQLZO+1jJnaOsL7jlaFUl9DW51QR5vF28gylFlmc8eat0tbw9Pqfw4P4O/VhpLKfTNV/rtX7RVAvg+rO0qf2GwVWLIilfRQPha/eRwpPnoxA4Eoekz9cdfk2oV1Zrlt/Kn5SH76YKGAXso7lm90gMPcx89zgwxF8lu9m/KglfIDW0Jp33xv436XTgMiSxzqRkszePALSCb9buU/AjKFZeY9KXG+9CIgiL8a1B8MNOuA +8jQj1Pz QZpJyWTcfHh1bQZh4w7auNboLTEvjTiyCr5Fk0sxNqjykXzwqI6DS2NbP3MTIGjtvAEl6VxYPZKtf7lC1UDAaoRwjLkHvK/LuKdm3S4os8dAOz6nPIncxtNbqUsoU4gmyV3vCiBY8+h9iH4sl8LFBw+c/whdPVC4Dkn/ECzzC8yA/AwGY9KooBUc86x3ANESlCsmoATqEiT94Ez7GGSjCJ2KyeQpa/XKNlzfjD40nFvzXXuS8iDkbKxf6+dB+5PD8Len5vygrqi+O4xUPgLMYDvoezPqkZDhOFlmKTmpCgjSN2DvB0DJ/rm/7un6em1gIn5tOq8eM2TZWTDQ2hgo1GQkokiTDSeE3i+v/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 11, 2024 at 12:15:28AM +0900, Leesoo Ahn wrote: > Setting 'limit' variable to 0 might seem like it means "no limit". But > in the memblock API, 0 actually means the 'MEMBLOCK_ALLOC_ACCESSIBLE' > enum, which limits the physical address range end based on > 'memblock.current_limit'. This could be confusing. > > Use the enum instead of 0 to make it clear. > > Signed-off-by: Leesoo Ahn Acked-by: Mike Rapoport (IBM) > --- > v1 -> v2: do not rename 'limit' to 'limit_or_flag' > --- > mm/sparse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index de40b2c73406..cf93abc542ca 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -351,7 +351,7 @@ sparse_early_usemaps_alloc_pgdat_section(struct pglist_data *pgdat, > again: > usage = memblock_alloc_try_nid(size, SMP_CACHE_BYTES, goal, limit, nid); > if (!usage && limit) { > - limit = 0; > + limit = MEMBLOCK_ALLOC_ACCESSIBLE; > goto again; > } > return usage; > -- > 2.34.1 > -- Sincerely yours, Mike.