From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 644C7C27C55 for ; Mon, 10 Jun 2024 17:00:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 818FF6B0095; Mon, 10 Jun 2024 13:00:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C8816B0096; Mon, 10 Jun 2024 13:00:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 690E96B0098; Mon, 10 Jun 2024 13:00:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4B8936B0095 for ; Mon, 10 Jun 2024 13:00:02 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A86F6141119 for ; Mon, 10 Jun 2024 17:00:01 +0000 (UTC) X-FDA: 82215591402.30.E96A0BB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 618FA100026 for ; Mon, 10 Jun 2024 16:59:58 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T+g9Q+Cn; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718038799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c9KYJn0jhsla+0w2VJDwqP6iO+OOPgYPwwEWm2grdLM=; b=Q2i4w2MsmlFui6AmGU7otILONxxsNVrK8c1jSJ/oIzMn7OW9Q6xzAalILPUPOS7H1Ihvcr 5sxdfj9zhWvHLqmWQbitt/JyDE6HQtRtM3gSbarnQOet6vFTqxHNGQRf80tX/HnqHo8suS SyGfwYs8BFjUmOS0Fuks6dhh63v1wNg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T+g9Q+Cn; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718038799; a=rsa-sha256; cv=none; b=RuxaVuw/s0x6+cYAVODQBf7kadF160XD2rS0tnT6Vjf/afHPABCBI/+Cd9N3xIecdQjE4J xeQHNgROvYbFYHbzh4aOX7k2m+66vvxYmTYkLPyMyWVvqNOwmXbDz3tRHQBWePAvTZTd6C dQZKDN5sGmC1wBnOsNFiJbgzOE+3zLA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=c9KYJn0jhsla+0w2VJDwqP6iO+OOPgYPwwEWm2grdLM=; b=T+g9Q+CnjlZOL26qygCjVfsS3i 0TN7GoOjlQee0qQ5/AxHIanHGBOo4pUpN3oYjMOaGIl3HQGgJlyZX23PlP5Kv1sJiVwuRV+Cx6ZhM hoypDpRGHGMDXXqcS1/ruDm5qEr+rmPVnncwlNH59HzbGbxzMgdDmx6OFpOQDYbWFNsCOcglZTcpi MS6zEGQKBrSYXCz6JbfAgIKKYvgIHbHDlFASq8vKtfrJdNCRqz4OxwWduWC0fSubK5wAl6PbFvVpU O7SCSGADtlhEVQM3Y9PDehpNeUTPaGiQKzCA6Zqnr70DAJT6/CYRRhjwm2axSaNyAteRc8JL56LIl nuJ55v+Q==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGiMr-00000009W06-03DT; Mon, 10 Jun 2024 16:59:37 +0000 Date: Mon, 10 Jun 2024 17:59:36 +0100 From: Matthew Wilcox To: Baolin Wang Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, wangkefeng.wang@huawei.com, chrisl@kernel.org, ying.huang@intel.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, ioworker0@gmail.com, da.gomez@samsung.com, p.raghav@samsung.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] mm: add new 'orders' parameter for find_get_entries() and find_lock_entries() Message-ID: References: <5304c4c54868336985b396d2c46132c2e0cdf803.1717673614.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5304c4c54868336985b396d2c46132c2e0cdf803.1717673614.git.baolin.wang@linux.alibaba.com> X-Rspamd-Queue-Id: 618FA100026 X-Stat-Signature: 9w5ei65qz3dxwntdhrftw1ukhwi1mszx X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1718038798-154834 X-HE-Meta: U2FsdGVkX19qRIifn3t4z3WaMh/Ib6450pfMY1213Mx5+EGADjWaaErvLSXprevxxmfKEUPiq/Uc7XnKZci0tha1R82bIPeroxpfJsxz80rebHQuAkrDSdWw+TDgYiXHWOvWRUBgQiRv5wMEvyNhyJ+AmQdnfbmz+wrJmIkLVROvAn6Q9vficRsq37mY1VzBBAN0uVXU11Ad5VkptdSXnLWkJj5eReGXtixAiGSjJNdwFgyYAZbA5rbC1KMmG0xa7UORmQVF0TXsBkOHnWcky+t6IeYOEVmI0K30GNCGqewyrotvJGoFiPtnzrTppfiUbs3P5xgvFvBUwnOBVdhjf+MOb4S4eGhFUI+YcjVDQ8G9XQ8Lo6+ZgheSAWGjhF42hLXnL+sYGfI6KikJUlHnABMnpz4asIpS4jWGfPE5jTRQZiMpLIN9itolAMzVebIYyuSeUg3ecPpyUiDZPu3r04qA7tUQvuYaKaWzkMDfCWYWk9Tga+TQ4YbCIFRUvmVzfSUndrW84N+s/LfreDnL49B2z02NlGE7+yS1wjbRQtW8nJhNNrbphAq59ZQk9SHTsU0fKOasn12SP9p3zA/cyuNsS/49de0rV+fPQ+4hiThpKTJGUZs0jvc+MVrje5VXU87ijZ9j5kXOBDKD7BKIdKwCIuQkkCTD1ySTR1DSr0/8OfCw2nGdQmTGbjGvECiVij1gx6cRMW9yhKAOpreUaegfk0ZTHZ2EjZ/Q6+sADgFGKXFonzW6FU9262IE6SJUa859Thh9mVT1magfkbWDhJgAZ/s3c32oX18aYPHuFpFgVnKn+s1VWiMigfw68s0gaevOVmFu+evk8KaAZGB+iQWgkh+arXWcqk7CyjE6LCUoU5DwLefVZwfR3MzLX07WK8FYzq+FnyCxVZf9fwM2GKjJpJ03bc2k5iM0fmnEz7mRK/ARiGzfA0L8B05VssoMIyuHHjxnDYcTzOCXWLn s3vBcW4m 62IL9h22luIVqXt8r1B5DPMb8RYFpUd3T/dtdJ7EwNUHKSq73SJSFKfLtmOJ6JdZtsc1JjxRQeojwWRF59sJ1Fnp/6jexNWlLBifWQ15oAN5IBQFf8cV0cIPr97JzpG2KmLSgxABhvm9O8gjRP1x//9qcCqUJ3Ml7+kUU9qnpGfLeO+Z7s47nLKQCO+Sqok+C6f2XeBP14PIXEaYZR/RORxtZ9CPx3Lwmk8QPmdatyG6ULwkz20Lx0d2ALg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 06, 2024 at 07:58:55PM +0800, Baolin Wang wrote: > In the following patches, shmem will support the swap out of large folios, > which means the shmem mappings may contain large order swap entries, so an > 'orders' array is added for find_get_entries() and find_lock_entries() to > obtain the order size of shmem swap entries, which will help in the release > of shmem large folio swap entries. I am not a fan. I was hoping that 'order' would be encoded in the swap entry, not passed as a separate parameter. As I understand it, we currently have a free bit, or swp_to_radix_entry() would not work. We can use that as detailed here to encode the order in a single bit. https://kernelnewbies.org/MatthewWilcox/NaturallyAlignedOrder