From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C4ACC27C55 for ; Mon, 10 Jun 2024 11:47:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37B7A6B0083; Mon, 10 Jun 2024 07:47:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32B3B6B0085; Mon, 10 Jun 2024 07:47:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CC2D6B0088; Mon, 10 Jun 2024 07:47:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ED51B6B0083 for ; Mon, 10 Jun 2024 07:47:33 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A1BFAA272A for ; Mon, 10 Jun 2024 11:47:33 +0000 (UTC) X-FDA: 82214803986.04.8FDA88A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf25.hostedemail.com (Postfix) with ESMTP id 65AD0A0003 for ; Mon, 10 Jun 2024 11:47:31 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="jQO+Qx/4"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pE7TkXSX; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="jQO+Qx/4"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pE7TkXSX; spf=pass (imf25.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718020051; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WJbUj0Me5/uIhq7+KJarpD1i6Sf3idu2woFatetNcL0=; b=bkzd0hpojI9vkY0hVArQjlo4fMBAzP4bttTVS2x/Oc/mKjg8fGQIoH2KZvtZkukYY33v1N c+cv20uJQhUm8QgVAuAxQT9MzkX2TqgNSFrN7a4vqvWkh2rfqDEG/DJ/amm0Yuxhs6grrK FvlHLe/2ilo0vI8tZw8Fdy2DnFAOahM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="jQO+Qx/4"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pE7TkXSX; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="jQO+Qx/4"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pE7TkXSX; spf=pass (imf25.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718020051; a=rsa-sha256; cv=none; b=JEm2YlT4eTLG2jzWmaF9x45ngx+dDSltl37xIyl+A53ZlgHpHXVe0gBAwA05VjVsdy8Gu1 /DEnLJWJDZZHtiaclCDzxezEPtuG2yd4WKtUNOogPLu6lA63Z3e4iclMnilBkV8Fjrz6+z Wa30T5BbICSpM4wsPkkC5fc299/SQrQ= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8172421A5B; Mon, 10 Jun 2024 11:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718020049; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WJbUj0Me5/uIhq7+KJarpD1i6Sf3idu2woFatetNcL0=; b=jQO+Qx/4Mj+vDjMEgjaHWKq33ho5f4Qb6TYgmmU0qZfZs7hYxUfoNdVh0yH7bMllbzqIzj cBgRVPF2mcuk7QqY+/pskie2ykcdmVfJAarIg0QR57zOzx4iU4VSWIXTSa8mKRdzIBa0QD lO9DjXCGRfL9yocXH6oR8JUqcqdOAxc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718020049; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WJbUj0Me5/uIhq7+KJarpD1i6Sf3idu2woFatetNcL0=; b=pE7TkXSXVcV2z59Zw2hFhiW+a9rT+ETwB+nt36sIeCijTXDS4lhfOoWDZeBLz9algnI9z/ eVn0jCO+My8aZ1Ag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718020049; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WJbUj0Me5/uIhq7+KJarpD1i6Sf3idu2woFatetNcL0=; b=jQO+Qx/4Mj+vDjMEgjaHWKq33ho5f4Qb6TYgmmU0qZfZs7hYxUfoNdVh0yH7bMllbzqIzj cBgRVPF2mcuk7QqY+/pskie2ykcdmVfJAarIg0QR57zOzx4iU4VSWIXTSa8mKRdzIBa0QD lO9DjXCGRfL9yocXH6oR8JUqcqdOAxc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718020049; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WJbUj0Me5/uIhq7+KJarpD1i6Sf3idu2woFatetNcL0=; b=pE7TkXSXVcV2z59Zw2hFhiW+a9rT+ETwB+nt36sIeCijTXDS4lhfOoWDZeBLz9algnI9z/ eVn0jCO+My8aZ1Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6843213A7F; Mon, 10 Jun 2024 11:47:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 5brfFtDnZmbLFQAAD6G6ig (envelope-from ); Mon, 10 Jun 2024 11:47:28 +0000 Date: Mon, 10 Jun 2024 13:47:18 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, kasan-dev@googlegroups.com, Andrew Morton , Mike Rapoport , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Alexander Potapenko , Marco Elver , Dmitry Vyukov Subject: Re: [PATCH v1 1/3] mm: pass meminit_context to __free_pages_core() Message-ID: References: <20240607090939.89524-1-david@redhat.com> <20240607090939.89524-2-david@redhat.com> <13070847-4129-490c-b228-2e52bd77566a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13070847-4129-490c-b228-2e52bd77566a@redhat.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 65AD0A0003 X-Stat-Signature: hqwhfyf97dsw9x81o4w8qcira9b6czny X-Rspam-User: X-HE-Tag: 1718020051-670514 X-HE-Meta: U2FsdGVkX18Kno+XoajytN2lZV31pYmshFUMHCBb10uO9uljVYd8iQVV+acdXgTwLcxPKaKH0+Od4SG0nJetstiK+3NdxkXAl929NvjNHL/GLNBmKaBLZDRgZKFazwI+skeMIjWyPqpho6XeIzE+YU639uwZJqkhj3eaHErdXotVRUydWKtyo3fOQbjhlX1HHQiFDMZBvFb24tuCsAx+K4Vamso0QO0+tWZBDsHsQG05BGcPM8rR0eJmPxLafzoFpKL2+64JDQe+rVWRZAi7xFrxt/LNiBdfVH2ZxXVomt8AGciY/VpL2Uqse70IBBDtgk0hvxOVN6Fb1CgVhNKS0CM7APlz8pCoxVKMsvOjCMJkeVgr1PFy2OTQUYIxqQS0vA5dH8zGvxiGVEicCAc/Iq42tRBiEL6UV3hbdCVCY7kgVBH+vKjHG8U/m5sjHl8WFZxpkU3NFMHJtpsEOL0h9CtnZCJ/YQ+5ib2WEdpOsq/v1mfQd3zU/TybBLO96VTfXZZ2CyDs+M5eGay7w6UDL1cVuDVqcObgF9i4k06IZFVBjzQCak9LOV7IcpbJaAx9Mdzwus8ywQvc0oTV/9CeHNskaTqLQTDudMfU47qW/Gx5uK0WeRHOWlqOdQVLurJN7A9H8e0qUa8dTpQqtjPSu8hD4NDMe2aVXF86pr9aCfo+W97IS06yS4RhAspOKx1oO8D6dSmj5OTCkHslyDx8OesEsqxcxuP9FTwVKYLEsPQLlX+mYxRtOmLTsugFMpRsPLD17G9FGJZshWodHnr12qwxTARDB1wq+agbb5n2NoagZtYKhQ6yH5qQAVF0wLvAL1nYAKt+8v4jwOLNZ3iHy9A6AJe8RN00/BnEzWYDSpy/fsep2xnuVcYjtjqlvtPu7Suci2JdgTCSg9zDDFvbZya5/gBIEIM+KREMHDYCACJjNwIx1foqRexjdNkxRTtfyXDA6SygZgt4rfffbDm rWXh6W37 wdPNejVd9FTCGwGbQnpwO8yKcXCezGg9U/O1bw8ZOuDnNLidGNRdb8wCSsxJrMfz+s9gfITjEy09O70O6IbHep/CWLS98T9D960g0E8meN8idjkl7/KQLksuAL+X17//tjvy3HSqXlPuuliW6q6C20AUBJc0vdluvv9WXb1caXKFUTviYv4trzjW84NE+lKWoHUGFYvdH1goZ2lStsEq7oQjO4lyUZU7c4sFO2yaqt6wSTs3dakPNjHoVMyUayPo8cufQag3jzTkP5F3miVeJf7chyw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 10, 2024 at 10:38:05AM +0200, David Hildenbrand wrote: > On 10.06.24 06:03, Oscar Salvador wrote: > > On Fri, Jun 07, 2024 at 11:09:36AM +0200, David Hildenbrand wrote: > > > In preparation for further changes, let's teach __free_pages_core() > > > about the differences of memory hotplug handling. > > > > > > Move the memory hotplug specific handling from generic_online_page() to > > > __free_pages_core(), use adjust_managed_page_count() on the memory > > > hotplug path, and spell out why memory freed via memblock > > > cannot currently use adjust_managed_page_count(). > > > > > > Signed-off-by: David Hildenbrand > > > > All looks good but I am puzzled with something. > > > > > + } else { > > > + /* memblock adjusts totalram_pages() ahead of time. */ > > > + atomic_long_add(nr_pages, &page_zone(page)->managed_pages); > > > + } > > > > You say that memblock adjusts totalram_pages ahead of time, and I guess > > you mean in memblock_free_all() > > And memblock_free_late(), which uses atomic_long_inc(). Ah yes. > Right (it's suboptimal, but not really problematic so far. Hopefully Wei can > clean it up and move it in here as well) That would be great. > For the time being > > "/* memblock adjusts totalram_pages() manually. */" Yes, I think that is better ;-) Thanks! -- Oscar Salvador SUSE Labs