From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99F5CC27C5E for ; Mon, 10 Jun 2024 05:03:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 079C56B009B; Mon, 10 Jun 2024 01:03:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 001E96B00A0; Mon, 10 Jun 2024 01:03:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBD136B00A1; Mon, 10 Jun 2024 01:03:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BCDC16B00A0 for ; Mon, 10 Jun 2024 01:03:56 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4B745A0C97 for ; Mon, 10 Jun 2024 05:03:56 +0000 (UTC) X-FDA: 82213786872.28.FF25831 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf30.hostedemail.com (Postfix) with ESMTP id 065A480003 for ; Mon, 10 Jun 2024 05:03:53 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ow0T3g1s; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=y28M07Ht; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ow0T3g1s; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=y28M07Ht; spf=pass (imf30.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717995834; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e+9/xWudwyvHquTKWWdLAZXx3USzblOimcE1ZFTIXWA=; b=j9Yefihbnq0uoo7M5wo4NK/+ArkcuuNUPMuTk2TSKQt2VsA2CEZDa0znvji3TocktPuw2V WfAzUoDOuNs3bNh9QhS46a4t2Dpi9P5qYZf7d9I5aVoJZ7gkDPZIEoTnTzwMGBvn4SiTnf SEkEuSPB0tLDf3/t/ZGYfEQvcQ9sTBE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ow0T3g1s; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=y28M07Ht; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ow0T3g1s; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=y28M07Ht; spf=pass (imf30.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717995834; a=rsa-sha256; cv=none; b=QJiFv1lFF+s2G0LYSrx1N0p2M5Ya55Opj8bCgZObl1hszgBy8KqaTHxmM4AM208tdjFRiV Sgi9d8ed2bGjEWVh8NyPRcJQBBsvtLG05hl32/ceS/QDiQTCKtJcBfcu4lHY628QQMBeEd fZ27OBl+LVzlzwwXxVp/zlhN83yuIXc= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 642E81F7A6; Mon, 10 Jun 2024 05:03:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1717995832; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e+9/xWudwyvHquTKWWdLAZXx3USzblOimcE1ZFTIXWA=; b=ow0T3g1stzOTkAKxlPb2UciIqA5F6BmoDI6I/MJ7TvOSdK2VYGDsmBCie9OXZDYNEH7vG8 MWlV9jq/bRsjHIbjJ8im38wdywluf6OgRTLEuQclG9HioSd8zFyVswJB5myjxYs0ypEAgb vypF+QPsGn/Loikxs+sqkK3L7SztahA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1717995832; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e+9/xWudwyvHquTKWWdLAZXx3USzblOimcE1ZFTIXWA=; b=y28M07Ht2i1owZwh4enC2uu7PeEGiPkoel040Mzqxo+l+bFu3RtANnbeSJeDxZCkEXO22H VwlRNI9iAjYMl6CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1717995832; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e+9/xWudwyvHquTKWWdLAZXx3USzblOimcE1ZFTIXWA=; b=ow0T3g1stzOTkAKxlPb2UciIqA5F6BmoDI6I/MJ7TvOSdK2VYGDsmBCie9OXZDYNEH7vG8 MWlV9jq/bRsjHIbjJ8im38wdywluf6OgRTLEuQclG9HioSd8zFyVswJB5myjxYs0ypEAgb vypF+QPsGn/Loikxs+sqkK3L7SztahA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1717995832; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e+9/xWudwyvHquTKWWdLAZXx3USzblOimcE1ZFTIXWA=; b=y28M07Ht2i1owZwh4enC2uu7PeEGiPkoel040Mzqxo+l+bFu3RtANnbeSJeDxZCkEXO22H VwlRNI9iAjYMl6CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0F30613A7F; Mon, 10 Jun 2024 05:03:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id nXiOADiJZma2HwAAD6G6ig (envelope-from ); Mon, 10 Jun 2024 05:03:52 +0000 Date: Mon, 10 Jun 2024 07:03:46 +0200 From: Oscar Salvador To: Xiu Jianfeng Cc: akpm@linux-foundation.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 -next 1/3] mm/hugetlb_cgroup: identify the legacy using cgroup_subsys_on_dfl() Message-ID: References: <20240605070133.1941677-1-xiujianfeng@huawei.com> <20240605070133.1941677-2-xiujianfeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240605070133.1941677-2-xiujianfeng@huawei.com> X-Rspamd-Action: no action X-Stat-Signature: qbcirsra34otkf5qjro6w5dduh5b1xnz X-Rspamd-Queue-Id: 065A480003 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717995833-924231 X-HE-Meta: U2FsdGVkX1/OJ0wiXnwzmLXpYDb0WVp0v3WUUtSQx4ujNCJDrOCFD2I081PCKNMCJnOVJRqQAts7xGAtSrdK23a5NJs6uQTadKASZgox8VHYMt6gmpn34S7iSo4MYwMONxNuyFIdsxBiqQwmNlljHGHAy9kZDnKGF9rlAy0t7fevI49OsPpHi3ovyJST8KCZlYocdR8hoGBuntpksPqNG4dxX/XjANvlPhp+lAzqj3PpwdJhr+XbSoeUbikC95y5kH2js+NuvNM1e08GO2BWfCjBX8VZHvNZfuOKt4AMphtaAmghDa7wCgR6B5UiJbRVdS5C1B7RS3qF+A7FYC3obSOtpnXcbvKuELwJrFzfb11LZYaft8alj7kehIJ03W0OrJ+9JbYKivqpcrFTeYoPtKTVvoOfi0p2NFzu3vQ/jkfhnQUlhqRmX7krmHb98b+kq6vvnE5MlO/5oyiJNvgX5z2oib91zhECkhPICVGBnQF1f0S6kfdw+QD8noRlotYdnN4KpM4Z/HCzNTE4n/22/dWQqv1xTunKCN+/rk8A8ykwhmujX97xPgY5wwMiHclHIiDWnkN//iFTdckhDzo+wOyGPprTz7WpgPBKLIzCWo0uW3b1HtX9TA8TluzvT8dsw6sINlrA8n5/TOVuMXU8OzFkSbhWZDwmiFjqfjAvsR06IagGi/zMDmvlU6k+kBb6xDLjXZ+a9+YsynvPcgNhXVk3yl3VRkj4jkoacCjjHNMTkmsEuKEMSAZctyp9ufgRALKjzg+9kzuu/LVQfhGob2u8cOI5qRHs64PNPa/yz1aF44oSB9i3pZahSPi2IfC6keeMgXLLP51lpiy35crq2nz9bG3XHzekgeyA1Q+rGdd37b2CzvwDzBm0kFJccrC0ZY5pfCN7f2a+b81ibErbvGEIg36L27v56dpOv9vwnjkdHqXd7fNLcbW0F/tPtY5zRsZa9NVKwbE0gFqJ88P 0HiAqHVe iBAZsHcoXNRMWuBYDpjVoqGCf65F5o1iapt25QsNFXQ/xZrAtWH5EfhDl+vUMDz3N13LM5kL2fbPSzOyIAW0uFPwJpIvaOYGm79vJcaW2Hb/f3ftQTxuyGQGwXXV77buMdIkRtmuWLk64ijLdiHYqiUI1/jqVJj/oe3vTVA3Z4eY/R1DDmXxNe6rkqn7Qcr0ePqEoqWLVdtt0sON2gPQ3qyqI4Jw02gPy/7cz4J+RHeoZBovMlUIwD7esF8VQrvTZ3HoJuC9F09TXapYz/Y/AChNKHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 05, 2024 at 07:01:31AM +0000, Xiu Jianfeng wrote: > Currently the numa_stat file encodes 1 into private using the micro > MEMFILE_PRIVATE() to identify the legacy. Actually, we can use > cgroup_subsys_on_dfl() instead. This is helpful to handle .private > in the static array of the comming patch. > > Signed-off-by: Xiu Jianfeng Reviewed-by: Oscar Salvador Nit below: > --- > mm/hugetlb_cgroup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c > index e20339a346b9..45f94a869776 100644 > --- a/mm/hugetlb_cgroup.c > +++ b/mm/hugetlb_cgroup.c > @@ -460,7 +460,7 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy) > int nid; > struct cftype *cft = seq_cft(seq); > int idx = MEMFILE_IDX(cft->private); > - bool legacy = MEMFILE_ATTR(cft->private); > + bool legacy = !cgroup_subsys_on_dfl(hugetlb_cgrp_subsys); > struct hugetlb_cgroup *h_cg = hugetlb_cgroup_from_css(seq_css(seq)); > struct cgroup_subsys_state *css; > unsigned long usage; > @@ -839,7 +839,7 @@ static void __init __hugetlb_cgroup_file_legacy_init(int idx) > /* Add the numa stat file */ > cft = &h->cgroup_files_legacy[8]; > snprintf(cft->name, MAX_CFTYPE_NAME, "%s.numa_stat", buf); > - cft->private = MEMFILE_PRIVATE(idx, 1); > + cft->private = MEMFILE_PRIVATE(idx, 0); Do we still have to set it to '0'? Is it not by default? -- Oscar Salvador SUSE Labs