From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0DCFC27C5E for ; Mon, 10 Jun 2024 04:56:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EBDE6B009E; Mon, 10 Jun 2024 00:56:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79B606B009F; Mon, 10 Jun 2024 00:56:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63B616B00A0; Mon, 10 Jun 2024 00:56:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 46A246B009E for ; Mon, 10 Jun 2024 00:56:21 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E9038C0CF6 for ; Mon, 10 Jun 2024 04:56:20 +0000 (UTC) X-FDA: 82213767720.17.FCE8400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf09.hostedemail.com (Postfix) with ESMTP id AE152140008 for ; Mon, 10 Jun 2024 04:56:18 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=C3X+cyDr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ah92qHp1; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=C3X+cyDr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ah92qHp1; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf09.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717995379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=knffddWOyCW0QDl1xKKOijWG3nsccOYGG8rNkmXpwNU=; b=Nvx+lmTMcvmYELGANRssFuXIEWoFEQf0OJBlmqVJf9SNUqBkhdWhb3/MeUTNSXKKWGsyO2 7+L45pWji+KbL5VoBVmsNenYkXN8fK5+jlUuapk+HVpDlJvBLs9/JybAPy6hKq1HsTfN9E zVgW/wWfonKpGXS+mk+BnRyO0dtwOyo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=C3X+cyDr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ah92qHp1; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=C3X+cyDr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ah92qHp1; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf09.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717995379; a=rsa-sha256; cv=none; b=gzBY0cd/Nc05oS5MddT6hcClduVcn1qqFi4tPNA/pAmc2cJAhVufnv95UftgDzCVANALGn n+lN7eyqnmH0e4sDUiEnpoq77toZ1lT7l83J95305eUs450NaYp9Fl/mtv1/TKqJqHSGL4 w+lN0Td+XKb6o1Cg/unM+OIMm46r1EM= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0BAB31F795; Mon, 10 Jun 2024 04:56:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1717995377; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=knffddWOyCW0QDl1xKKOijWG3nsccOYGG8rNkmXpwNU=; b=C3X+cyDriMjyqlC6Xi0lZX+KjFXbOZgNqoCT4d7a6qfRsSrgqAal+S/i51BsWuXyXscvBM Yz395GLQ0YHthjfRlgJqoZbTF0h1sR8Lfj0JZwr31RSJ7rb2wclhPIK80I4xZ+xz9vf61z Ysnom1S/sJuhaLhCuqkxKIhT65rs+jY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1717995377; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=knffddWOyCW0QDl1xKKOijWG3nsccOYGG8rNkmXpwNU=; b=ah92qHp16+13m9WoPghw9Jp/xrp52Qac2Tnk9oeMVbqDrOMRtj6voCjDfzFax2lltlZHxO 7wIP60yurwpqE6CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1717995377; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=knffddWOyCW0QDl1xKKOijWG3nsccOYGG8rNkmXpwNU=; b=C3X+cyDriMjyqlC6Xi0lZX+KjFXbOZgNqoCT4d7a6qfRsSrgqAal+S/i51BsWuXyXscvBM Yz395GLQ0YHthjfRlgJqoZbTF0h1sR8Lfj0JZwr31RSJ7rb2wclhPIK80I4xZ+xz9vf61z Ysnom1S/sJuhaLhCuqkxKIhT65rs+jY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1717995377; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=knffddWOyCW0QDl1xKKOijWG3nsccOYGG8rNkmXpwNU=; b=ah92qHp16+13m9WoPghw9Jp/xrp52Qac2Tnk9oeMVbqDrOMRtj6voCjDfzFax2lltlZHxO 7wIP60yurwpqE6CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9593313A7F; Mon, 10 Jun 2024 04:56:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id pY6aIXCHZmbeHQAAD6G6ig (envelope-from ); Mon, 10 Jun 2024 04:56:16 +0000 Date: Mon, 10 Jun 2024 06:56:15 +0200 From: Oscar Salvador To: Mike Rapoport Cc: linux-mm@kvack.org, Andrew Morton , David Hildenbrand , Jonathan Cameron , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.org Subject: Re: [PATCH] mm/memory_hotplug: Drop memblock_phys_free() call in try_remove_memory() Message-ID: References: <20240605082049.973242-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240605082049.973242-1-rppt@kernel.org> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AE152140008 X-Stat-Signature: 61re194emgozsiiwf1pet93ow4hyb91g X-HE-Tag: 1717995378-967947 X-HE-Meta: U2FsdGVkX1/0iQ3E+0V6LMflVaLhuQvyofumv64U9wGuVA0mRA4MOZ/BT1u6mZhgZmjIHL1fu1kdXIGg2kEnWmca9J4ffWux8wf6Vb854C4iDEQwjkk9A14apjWqKMDgwYxpLLp37HLIAxRkcbl2z3d2dsh3rrPJRgAg0kCThlosDYJIZloZHCijpdfWNqYi1/gxGdmCTSfXMZ3hmJBvHF2/3xzPwHc5ILkLVUtZ9y2N63BahXWiJ3xpx8mIVR0DuNNI51ZE7awcmahAUCirkJAx30l93SXh4sF10Nzne60lDT7ZpMHebfn+P5DML9Cxqw72JUALwyZDXz9xx3l/feW5WdPFo7vW1/xeG1eI2r5HcgUY5x5cgDJ8v9PCwH02uZUbc7G2e5a2BdYbTho+3LbHxhot7rzuUe8FrfufrQQDgSvjrNd9x44cM9jkYbqNf+42PWW/hETPphOQp2LUQhB78oOJU5q/Kl57aT2fKW4MwuLJDVaev2/BxsH1gvQjWxdg8lGd+oHxIYkoKnMY5rH0ltifWXU/l4K8VotCfQcBNWum+Pkc95NrIV5z9XkZDmNkkfENqPRzT7JK3MvNI9Nw/ZAnjVlOCgBddWnT6c2THyG5sEDDUfs7w7UzafY5KYY74zA2mpcrVX/kj8Ua1D8EaLLSoCHkpBRGkG6RftHcokByD+E8iSk9BiC7gLwljAxKNnG0yyew1bH3yKGYZJnAWqGbH/XzPyrpNWJbFQ4JaE2+2Yr8NhWvx/iDJz9gqT3p+bJmMs3AG02LV6zXGj54jdbaxO+j769tICDIwN6rNLQ92mNVl/tuJkyutbOfIbZWKMGThHkE8cbQONJOTsUDWFSte53pwZdm0uJIb51iXMC1IGZhJBB7p25bdwGkHW/bvMtjvsnKFC4oblMjvQAx3EytUTSlH6GbqSx/tGV50S5ivHfARbdUcGhhHx6hERGS7rtPtlAgys+FFso KwEkpN82 cXoVhPOyAZbzp5qeyMrU2aKjOl43uLkgHCWzMdBurbKZp5FDVuszhoXZ/3euhaZQAAGgNp3ozjL3Snb9Wlxw4OzTX5Z6XtmJs9sId0bDuAKKuPv1KwNp2OpxkIfF59bnCTmUo9F711F9E4fErJHN1UpY9y9Fgvw+ecPrCrQPfgd/st5H4NwctIE9sfZ4akiuLjRMvAE8eiHw8LUkX17IOXaqu5O1X8USoNx/W3i+gYMEp0xUK4aGsRo8M48WSxpfpYrWi4HNX82t9JNRPRQWx9EnNCSg3o5D83SPxoAk8YU3+QH6fEk6lXsw5DvT9hruUAwZG1p7JCGSGFJE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 05, 2024 at 11:20:49AM +0300, Mike Rapoport wrote: > From: Jonathan Cameron > > The call for memblock_phys_free() in try_remove_memory() does not balance > any call to memblock_alloc() (or memblock_reserve() for that matter). > > There are no memblock_reserve() calls in mm/memory_hotplug.c, no memblock > allocations possible after mm_core_init(), and even if memblock_add_node() > called from add_memory_resource() would need to allocate memory, that > memory would ba allocated from slab. > > The patch f9126ab9241f ("memory-hotplug: fix wrong edge when hot add a new > node") that introduced that call to memblock_free() does not provide > adequate description why that was required and tinkering with memblock in > the context of memory hotplug on x86 seems bogus because x86 never kept > memblock after boot anyway. > > Drop memblock_phys_free() call in try_remove_memory(). > > Signed-off-by: Jonathan Cameron > [rppt: rewrite the commit message] > Signed-off-by: Mike Rapoport (IBM) Acked-by: Oscar Salvador > --- > mm/memory_hotplug.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 431b1f6753c0..e0d49f128e0d 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -2283,10 +2283,8 @@ static int __ref try_remove_memory(u64 start, u64 size) > remove_memory_blocks_and_altmaps(start, size); > } > > - if (IS_ENABLED(CONFIG_ARCH_KEEP_MEMBLOCK)) { > - memblock_phys_free(start, size); > + if (IS_ENABLED(CONFIG_ARCH_KEEP_MEMBLOCK)) > memblock_remove(start, size); > - } > > release_mem_region_adjustable(start, size); > > -- > 2.43.0 > -- Oscar Salvador SUSE Labs