From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F28B8C27C5E for ; Mon, 10 Jun 2024 04:32:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A4F46B0096; Mon, 10 Jun 2024 00:32:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 653C16B0098; Mon, 10 Jun 2024 00:32:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F34C6B009A; Mon, 10 Jun 2024 00:32:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 323376B0096 for ; Mon, 10 Jun 2024 00:32:19 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D4043C0C87 for ; Mon, 10 Jun 2024 04:32:18 +0000 (UTC) X-FDA: 82213707156.22.7C54397 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf12.hostedemail.com (Postfix) with ESMTP id A398C40011 for ; Mon, 10 Jun 2024 04:32:16 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=z77PfkTK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=h9nOCcky; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=z77PfkTK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=h9nOCcky; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717993936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IND2MoD5+fzd4/enaZpt+uNExFlFrO8ngLetTeSMsF8=; b=KBbkjOnWuqjt7YQrPAPwvO2I+lxu/8IpX0e7nVmo8z6DJLSYEBPs8T9NUhc8KJX4SSlIZp ofVZ8RKmVSBcbLyRgOqZYeRGIcl8dRC67X1hx5x4J8f9tw6NHMhe/sJB0tZRkgvddoCyNr Y+1mjgXcI8DcSME/Qk6WQLcT6rS7X2c= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=z77PfkTK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=h9nOCcky; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=z77PfkTK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=h9nOCcky; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717993936; a=rsa-sha256; cv=none; b=ezMgp7eNNZynRzjrWhAEke4l2xfLUBMbOqaN1ATzb6/BL5VhgLaIRR4bLDLGUnrRvx487f hBjlFCTECbbKMV63JU+mCST9WMOxcbW7KDZTnd9gBEnQgCZiiW5qJHlWHGMQ2LDe6CfuU8 bQKfhyY/5WFNJH+wmK/Tzfx65xqqzE0= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3F89321A28; Mon, 10 Jun 2024 04:32:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1717993935; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IND2MoD5+fzd4/enaZpt+uNExFlFrO8ngLetTeSMsF8=; b=z77PfkTKm4EluD1EW77pRW/2jHupe+DZKwP4g5DBI1lB7Ns2vZ4yZHHlG7dry/MDNboApa pbxd6gUDocDxl2/9vbwgRMcOdkcnGcE3uaC2lS4rN13Prx5i3+6l8J6mKg7rlulexG+fb/ KbTvi/KM7nmIjJbybulnIj3luewEv7I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1717993935; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IND2MoD5+fzd4/enaZpt+uNExFlFrO8ngLetTeSMsF8=; b=h9nOCckyVqEiOGqdbdzc+P0c2skzkfoHu3XOh2WdwQ47UJJekByPQZaQ7W8Yv6T8w33Iju 8OzDSb6XQJA3koDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1717993935; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IND2MoD5+fzd4/enaZpt+uNExFlFrO8ngLetTeSMsF8=; b=z77PfkTKm4EluD1EW77pRW/2jHupe+DZKwP4g5DBI1lB7Ns2vZ4yZHHlG7dry/MDNboApa pbxd6gUDocDxl2/9vbwgRMcOdkcnGcE3uaC2lS4rN13Prx5i3+6l8J6mKg7rlulexG+fb/ KbTvi/KM7nmIjJbybulnIj3luewEv7I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1717993935; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IND2MoD5+fzd4/enaZpt+uNExFlFrO8ngLetTeSMsF8=; b=h9nOCckyVqEiOGqdbdzc+P0c2skzkfoHu3XOh2WdwQ47UJJekByPQZaQ7W8Yv6T8w33Iju 8OzDSb6XQJA3koDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BD19413A7F; Mon, 10 Jun 2024 04:32:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XjxOK86BZmbfGAAAD6G6ig (envelope-from ); Mon, 10 Jun 2024 04:32:14 +0000 Date: Mon, 10 Jun 2024 06:32:09 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , "Kirill A . Shutemov" Subject: Re: [PATCH v1 1/6] fs/proc/task_mmu: indicate PM_FILE for PMD-mapped file THP Message-ID: References: <20240607122357.115423-1-david@redhat.com> <20240607122357.115423-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240607122357.115423-2-david@redhat.com> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A398C40011 X-Stat-Signature: pmdc4ykspqkyhsk7b5ci7wxhwtez4d7r X-HE-Tag: 1717993936-345059 X-HE-Meta: U2FsdGVkX1/omUYVo3IslhvB5oPjrYsBTrrFvo1glikB8+5vIDqmIdpclanBbFesj3pUBI2Pn663WMWAqSZDBADNaQKw+2N/NnYLbYElMNw5W3oy+Qd/bvJP64kMrkXzDKIwwuitms4dAmc1RUvh4lP+PwO7qhTGB0UoCOFnEwNKBugVexxG0sSk4VSpCNFqfiKfMyybmOysAReYwTBf2B4/9UDPx/sHRBIBZKK64h7gDCgmhLUhzVbV1TF7bGwT+NyiA3KSdBH6O2+kaYfrbFzKxcp8h3S8gUDdIcIbWJRHLYYYE1I8TtMau4Ev0BR0Kns90ggED+xgKdBGiXSoZ7d16rb7fBXCO3tqhKWpgWC/rP1ht/KD3ZA9kuToo2wI6mYMkLXmjTvp9Ep7ayzaTZUhc3o4s5llHtB064YlxLE1rG8Sz9+DbEzsH2+WosqCzwppRvt9Glp0AKiHRTyA+VW4ueBCvVZHGGsppujursWRuGWe+TzxQmCXETSrb36/5hekzksNMiors2Iq7Ak4fUJ3bhsYhQpWZT0zpwJ0VLbNCshkUFfh7WwF7GKC/MehZm+878yqfSZU413/BhPoBvNkF7w3qCe4zYzyVn6huApKzdoHshT+2JBBGD21Kgu3Ix5ReQHC3J9RyAHz2O1zN25pdMDckFsak9j41CWHnQ/yecQXDnEDJ9ChjcE1GwOWdUyCFBkuJzNmZnKJQpVAo4zhxWPbo5ZykMK2PvCG5lRZ3M8vmYkBeI7Po/2fKj9DExwPApt8CLRM6NBN4up7e2Zy3P68jvUmc/+eXzC/SaHTogx0aRZAw7W26G5qCfGu0xYmV3pBHkbiXz3jCMbHxAgdxtEHN160oBInlGFGwGOz7hd1gWvJ9HgiWBKrHVpE/iNO8dGvPkMDejZ4gthqSpGg6OkLs3lkbCPepKvsQ2GAKwJsFekjiTxWhpBdEEdkB+OYyseR+/Xf1IlINIF YM98MPbx Zs+B0UG139heKxtNkO2y2yrD5FbRWT2yj6XivTdgW5bDpQsGPOd5kvLoB4EP+/bUyTWynJmPklAqTU7W1fmmogpZyIJuO2ueqKt7Mq+aYKxygiEW3O3p8nEXieYZSsunxv5TVBR8TDAxs65r0NCk5eF1TBPOACjQ4Lrgwgs3NP4Ff6+Tvycjy/E06fHqcDzQdiTU+KmquTJG0T0gtaQhd/sGh5n1OcmZmoiE4MiomJuN8VugCLU8W7894qd/xU9H62JQ/KXh22nYhE5gUjU50Ygl5Z5Eslf6jQ5h9AVFM+/9aNDQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 07, 2024 at 02:23:52PM +0200, David Hildenbrand wrote: > Looks like we never taught pagemap_pmd_range() about the existence of > PMD-mapped file THPs. Seems to date back to the times when we first added > support for non-anon THPs in the form of shmem THP. > > Fixes: 800d8c63b2e9 ("shmem: add huge pages support") > Cc: Kirill A. Shutemov > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador > --- > fs/proc/task_mmu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 5aceb3db7565e..08465b904ced5 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -1522,6 +1522,8 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end, > } > #endif > > + if (page && !PageAnon(page)) > + flags |= PM_FILE; > if (page && !migration && page_mapcount(page) == 1) > flags |= PM_MMAP_EXCLUSIVE; > > -- > 2.45.2 > > -- Oscar Salvador SUSE Labs