From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F07B1C27C5E for ; Mon, 10 Jun 2024 03:23:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C66EE6B0083; Sun, 9 Jun 2024 23:23:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C16B66B0085; Sun, 9 Jun 2024 23:23:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB7266B0088; Sun, 9 Jun 2024 23:23:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8E56A6B0083 for ; Sun, 9 Jun 2024 23:23:37 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0B726140C39 for ; Mon, 10 Jun 2024 03:23:37 +0000 (UTC) X-FDA: 82213534074.01.9CF3DB9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id D4D2540008 for ; Mon, 10 Jun 2024 03:23:34 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=QLkV97PA; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=thvJdHo5; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=apNFq9F9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zHrQdBGC; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717989815; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AqD74k7u9HQG0xtmAgthSPNxIjkcLobv3QHHDm49wY4=; b=f/4RDLXf3TsaQZ72KPdar8SreiNAEVxsNYgR6oZkizkS2GuSeqTIgGuac+MAC8AJc8zHXR GivKzPw4qeHkTSrPXGRPwp9SQClZsRNFfeZt8BpSHK09U2iZMdYDA+QbTwNh8aARhtetKt ARjzlYAhtGy8rKtbgyXCbUnbJ8wcYxo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717989815; a=rsa-sha256; cv=none; b=iFXBp/9CpSPgwQPfo8gMG+ft3Zhl6BbskbZ+cQvMaICc8xY9pt1rV0rdyB1jG/52tghmXi o4O71qvqmTMJ0z2XZ5xRTtFR58+/4mapso0my+gNA5yhgvnxjKpKzJ0DdZPFw0GOljHZFZ P7uHqB/Q2YrB7+4EHQwBUkB30OTsrKs= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=QLkV97PA; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=thvJdHo5; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=apNFq9F9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zHrQdBGC; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D1AA121A2B; Mon, 10 Jun 2024 03:23:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1717989812; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AqD74k7u9HQG0xtmAgthSPNxIjkcLobv3QHHDm49wY4=; b=QLkV97PADal9uWkBMvqGGipEu4TIz5O64viefpW4CMn/J97Wp/DkKizdfYRA6R0aXjTSZe x7Y3084fsj+inw1vM3xKkSX6e1w53+CcURgkbcugIBkPHwtzaknL51bh4xcevmbMlC4IpW iP5DhEvnhyvnGtpqotuBUAUH2hFpoMA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1717989812; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AqD74k7u9HQG0xtmAgthSPNxIjkcLobv3QHHDm49wY4=; b=thvJdHo5bNJp8IfUvfb8tJ5Re8751aTu7AMZU0bl3+i7IEV+FE3t5FxHD0ZsB1aSdZQ8So Gs/lSN0bLCyuhPAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1717989811; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AqD74k7u9HQG0xtmAgthSPNxIjkcLobv3QHHDm49wY4=; b=apNFq9F9XxwjCCiFspfNjiPR5JF1iO1tFQySz985BxE/5r23KRneHFfwtM4HWRhLjq9WHz JeJbAntgAnPXcH5YExLL8fXJqJJv0HZoEF0gxh5HKDoOYtIpW2zeVIl1QZF3p+KJtjkWjm JT7Cpyg+QY/uB9X/oULKJzj+eVjc2Kc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1717989811; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AqD74k7u9HQG0xtmAgthSPNxIjkcLobv3QHHDm49wY4=; b=zHrQdBGCdM0Lxs7xhYGgHlxuL4B33pQK/YSDQbzlxgfkQ6vUYC61NreE/bbXnHe8P4nZ4g eLarRIY7bVL6EpCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8169813A85; Mon, 10 Jun 2024 03:23:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id pCCXHLNxZma/CQAAD6G6ig (envelope-from ); Mon, 10 Jun 2024 03:23:31 +0000 Date: Mon, 10 Jun 2024 05:23:26 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Wei Yang Subject: Re: [PATCH v1 1/2] mm/highmem: reimplement totalhigh_pages() by walking zones Message-ID: References: <20240607083711.62833-1-david@redhat.com> <20240607083711.62833-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240607083711.62833-2-david@redhat.com> X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: 3q6qj76qrwcwnyy4r171hpruusqcdpfy X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D4D2540008 X-HE-Tag: 1717989814-837040 X-HE-Meta: U2FsdGVkX18IPbtmszpskk3RhqmOPIwh+SIi3U4RwXyvuszMLWdfuPAtk3irwhKiUSYMKnRoZdqEOlx732alvpqXYOjJuP75AqA/AEgJi12VGLpFKe8wXbuNZaYqCTXjoo0cOk/kH/DEYRpG01cuv6etwpMb0CH6/GmwRJN4IAT1Zm8DLa1lddLK5dX+gypVHJK9QAKCYxmjpCe8iIe5nbpEHfP/o5EsjlFvZ2FntHk+Lnz8Gkcc5wvufwp1WC/TO6bzOJRJvS0OcPzWShRiJI0Ei5cWBThs2jRIJw6KobWoLGWm2F0wHhoPQqg1LMy27irZZfCO5Dpbsp7oEgNrhgtZ+4tCA6nh04vZ67T0BHdpfnlW48xatJNIrwQ9MgIwvNq9R6QsyVfE1O4cQ+MKuczsU1/ZbQvnWkA8QKdWX37e1Z0rK5pHp9vH2P2tPl79c2JPvDn7iH/uym/5DiXYsqwCy9INiOx8IlTIIMPLyzujMbQ1jC528rUgk1NNEiQQWSLjdSbJrGQGFuNIMCk5IRQ7J4wKT5C3OzZ5z1akf/ROwvDu7aN6hj99Iu/UPIR3UetPZgwOAqYEPtUmoDIeldAmh89CgAqn/b3U2WOPGzbNtLz8Q15DNnwnL6MLa3qBvKI4pKwV62rjDdfjqy/NK1KNgDpMIhzBy1dFfCt+mnU1edpQEdD3fnr+5L031vedZVZH7Hyh2mzXVl9Wp3vyCkM3QxhW5RVrsbhYGY0JNQMjugDwCOa3c/bQhy2K6X0//cAzDzrPu0tFJCVEN6SxF7i8HzHx+QwJK58BiYxS1dtLlelNbXiFSJnQSoTJxqvdF22EtECEITJRywui+6jM1AfTOhhGnKjvMFPH4PUr86m0BHIUeu1C58Ou0RpihC3mBYtgttcP42xr5xkbLRNIX6MzySbKEDnSAL2SnOrJ4aMjRUr5uqmE5LzrZBxRgJ/JC1Rr/34f3IHkpVtDMZI mGB2I0Uo rdTZDR2m9UvSGV5YdhgKK3EjxeRGDHTR7hb85qYT6zglrgQzkkxUodutjCE6PDcR19iBDRsLxo+26tyy7cPITDjYJ+Z9uZG5mhza+GtPmvb+9SLI1HLCwryIChYl+e7ErSiyGiy098FaMXxONBCYCPXSOVIN9ai4vheCGvLLknXT7D4umQSGSw80v0thJOaqOYo1evZ+9KnQmrZxRj2f2xkWBB413RWwS/Aur/Vj+6Vn7Aj6FLn8n/MEOHQwR7JWTYT9IA1G+DRpcslAXewSPWWYsg0IKNvoQvRErWx6ifcSehRTrNIynIiDqkpicDv/mbMQxlcvZyiC2XadertBXDXZ3rg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 07, 2024 at 10:37:10AM +0200, David Hildenbrand wrote: > Can we get rid of the highmem ifdef in adjust_managed_page_count()? > Likely yes: we don't have that many totalhigh_pages() users, and they > all don't seem to be very performance critical. > > So let's implement totalhigh_pages() like nr_free_highpages(), > collecting information from all zones. This is now similar to what we do > in si_meminfo_node() to collect the per-node highmem page count. > > In the common case (single node, 3-4 zones), we really shouldn't care. > We could optimize a bit further (only walk ZONE_HIGHMEM and ZONE_MOVABLE > if required), but there doesn't seem a real need for that. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs