From: Oscar Salvador <osalvador@suse.de>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Wei Yang <richard.weiyang@gmail.com>
Subject: Re: [PATCH v1 1/2] mm/highmem: reimplement totalhigh_pages() by walking zones
Date: Mon, 10 Jun 2024 05:23:26 +0200 [thread overview]
Message-ID: <ZmZxrtGb4rDepBYv@localhost.localdomain> (raw)
In-Reply-To: <20240607083711.62833-2-david@redhat.com>
On Fri, Jun 07, 2024 at 10:37:10AM +0200, David Hildenbrand wrote:
> Can we get rid of the highmem ifdef in adjust_managed_page_count()?
> Likely yes: we don't have that many totalhigh_pages() users, and they
> all don't seem to be very performance critical.
>
> So let's implement totalhigh_pages() like nr_free_highpages(),
> collecting information from all zones. This is now similar to what we do
> in si_meminfo_node() to collect the per-node highmem page count.
>
> In the common case (single node, 3-4 zones), we really shouldn't care.
> We could optimize a bit further (only walk ZONE_HIGHMEM and ZONE_MOVABLE
> if required), but there doesn't seem a real need for that.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2024-06-10 3:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 8:37 [PATCH v1 0/2] mm/highmem: don't track highmem pages manually David Hildenbrand
2024-06-07 8:37 ` [PATCH v1 1/2] mm/highmem: reimplement totalhigh_pages() by walking zones David Hildenbrand
2024-06-08 0:48 ` Wei Yang
2024-06-10 3:23 ` Oscar Salvador [this message]
2024-06-07 8:37 ` [PATCH v1 2/2] mm/highmem: make nr_free_highpages() return "unsigned long" David Hildenbrand
2024-06-08 0:51 ` Wei Yang
2024-06-10 3:40 ` Oscar Salvador
2024-06-10 8:22 ` David Hildenbrand
2024-06-11 0:56 ` Wei Yang
[not found] ` <04b3dda2-c6a8-4f26-90b8-75fe7580d63e@redhat.com>
2024-06-12 7:01 ` Wei Yang
2024-06-12 7:22 ` David Hildenbrand
2024-06-12 7:34 ` Wei Yang
2024-06-08 0:45 ` [PATCH v1 0/2] mm/highmem: don't track highmem pages manually Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmZxrtGb4rDepBYv@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox