From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 567D9C27C5E for ; Mon, 10 Jun 2024 04:03:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A15AC6B0085; Mon, 10 Jun 2024 00:03:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C53C6B0089; Mon, 10 Jun 2024 00:03:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 865C96B008C; Mon, 10 Jun 2024 00:03:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 665246B0085 for ; Mon, 10 Jun 2024 00:03:45 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1AA54140D13 for ; Mon, 10 Jun 2024 04:03:45 +0000 (UTC) X-FDA: 82213635210.23.5B8EAD1 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf17.hostedemail.com (Postfix) with ESMTP id D77DA4000C for ; Mon, 10 Jun 2024 04:03:42 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ydtYYv4z; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2VfRPhmr; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ydtYYv4z; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2VfRPhmr; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717992223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IYHZUWJMx20LtuFCKKBR+s4SdF/zVxwDIU/zuxJyVpA=; b=p4rDUHQDQYvkntTDdMPCfGC3qEjvEmfw74u3DcM5KOhDq2w1WbgU2lHEK+xbMzeMwACVIq /FY4UqX4NdfycwGmLmLKKi3Sfh+n61H5EpirL2U9Gk/utID485BVuEBMmEBT76O1vUKqjl UvCa5lzU6IC8zYPo7Jr497Lr0y+hfxE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ydtYYv4z; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2VfRPhmr; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ydtYYv4z; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2VfRPhmr; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717992223; a=rsa-sha256; cv=none; b=hiJgk6FwoznFOe2Jvr7ANdudf0UUFecplVkP5KpW1n6lwQolSOeAu9EDyhbBjTqI26B3+J PZObkcoHgBgGBt9WwHRMEKlWEQCt8K9wcSylc/ftFhrDIyFjVvd/HK2T0F0CoKi8yNCAVA QKec+7fLEL8bw2xyBhvQd/vjmEm3Ees= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 48E781F74B; Mon, 10 Jun 2024 04:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1717992221; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IYHZUWJMx20LtuFCKKBR+s4SdF/zVxwDIU/zuxJyVpA=; b=ydtYYv4zpnWoA+DOEizDfb0xxwSoFgVJdNwaHwsZ4KNXXr0McZcQoDjm0TnP6modKw7qU/ YU6A1x5Wb6Mc5i5eAKt/8AnZNi+ROMDh3WDQz74dIE+RuF5EAw2jT5VaieXlP6Lpkd0vmq E86gqlWw/GGQiz4G8sn557CdigPAhQM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1717992221; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IYHZUWJMx20LtuFCKKBR+s4SdF/zVxwDIU/zuxJyVpA=; b=2VfRPhmrW05hUtLnVJUcfs9KMJfRv9vz9QyGoBqjvqYUGpchjhJed480Cqm/I/F3MSoXT2 Q9/kUhFsd2NbvbBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1717992221; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IYHZUWJMx20LtuFCKKBR+s4SdF/zVxwDIU/zuxJyVpA=; b=ydtYYv4zpnWoA+DOEizDfb0xxwSoFgVJdNwaHwsZ4KNXXr0McZcQoDjm0TnP6modKw7qU/ YU6A1x5Wb6Mc5i5eAKt/8AnZNi+ROMDh3WDQz74dIE+RuF5EAw2jT5VaieXlP6Lpkd0vmq E86gqlWw/GGQiz4G8sn557CdigPAhQM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1717992221; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IYHZUWJMx20LtuFCKKBR+s4SdF/zVxwDIU/zuxJyVpA=; b=2VfRPhmrW05hUtLnVJUcfs9KMJfRv9vz9QyGoBqjvqYUGpchjhJed480Cqm/I/F3MSoXT2 Q9/kUhFsd2NbvbBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2ECBB13A85; Mon, 10 Jun 2024 04:03:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id K/XmCBx7ZmbzEgAAD6G6ig (envelope-from ); Mon, 10 Jun 2024 04:03:40 +0000 Date: Mon, 10 Jun 2024 06:03:38 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, kasan-dev@googlegroups.com, Andrew Morton , Mike Rapoport , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Alexander Potapenko , Marco Elver , Dmitry Vyukov Subject: Re: [PATCH v1 1/3] mm: pass meminit_context to __free_pages_core() Message-ID: References: <20240607090939.89524-1-david@redhat.com> <20240607090939.89524-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240607090939.89524-2-david@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D77DA4000C X-Stat-Signature: aoeo5sfdu99m5g19itzhkc1ypxswrcw7 X-HE-Tag: 1717992222-275815 X-HE-Meta: U2FsdGVkX19bCV4dWcsaJtte3iPpHtNWySusTrwJe+6yuvnbUboh+8LAc0ynufr6r7xc2w29AnrK6Vn5Ute5dWYNURUJ/BaXJxgYDZeaUOhFPoOIDaOdiXV2qLoe7Guqk6Cb451EQVoYDbKd2s8G8OYnlSFU6BlF1Tq4mkewQDlLWNbzBjEsOjZ8gV9VfIQAGBrGMZbPrCSYY75iiS5vfWcJoMvsS1CR6YHQKIhs2yFsLKcF9guwcLj8TMcCaRTVavFhB+XRhouHnqhCTRVKfKTbppN+xQV6skpyPCRh/hx2R8+HFv0+OjiGaTIWZ3M6sglphwYqGhvs9I8Y+r8R3XVIyNgGryu0/NkbIBnustD5UIZL/5CISlZ4D3enCCTGV3keMIdDqin/sfDoq5l9RQos76drPhGMdRBkf9NsX3+tfeY87BYfN8r3EcbYEg1HFgFtZRm9A4xaAGyNIPxtAgiUEdBb2RhGZms6KVSO2UFVodbhU8gJZLqpi4d0fE/4QzGGkMIIwM7/nnqwW5/GWZv5sG42MlCLydCOIZv+YVwfRDYJRGLgTm//TD8tEsI857NWOa2avSxjPBFe58viH2MS2hu1CAZhAt0ktW1FG84d7iF77+AiLR1fNz9JqvN966ErQTAF6EF4leTaDiV/ll+NyH2vQ6mAwbkRvTl1Wcr4he3UuJAfZyuKXheop2EMamrNhDVA5AirCIVJ8nwwdWbgPs2dkhOoU5C3H5cHZ2EyJxhJ2/rbCQFW0zIIQAgE71knWxD8FXWoHUVE1QNomXAoCqwbDXRpnZ6EHGlNYCICQZOVJVTrVVLnEDqEkOUyEEupnwo0jFYf34NtKrgCPe0kEj1WhYLa2BdG7x0oYq/W3VYHyKxn986ipb925ocppVGCf6qwDxgDpcfAMA73nkkidyxS2n/WSmgcvs7pb6mtPv7P92L9sVq/wVM7UeQGr0l+5yU6NJ1gJz3yRUN Ef3ks8vM nOomVnwxfKpY8VuoT4Jtyw+ct6q7wN4YcXozrtCX7IPu4U65xeqEBBw7UgNXYTJEeFUBEIX2vZa+qOHPUSAJSn75i8cb/OImVaXqB/B7YyAgGx+3hq6h7CvpFa5aOwGvTwnV8xnaNUQ7MQ6TUUJYEMBes9ZTiwkkhQtqh0nAWmWUZt31hgr3fFCcC2LaJVvW22fqukHpz0xtbREnwoHoZd++qxMR34MgNmROFY29/wONYLJ6+lbNAlSU7ekRzAwEKI6Z6CT5dNemqvwaoqhRzthhsQQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 07, 2024 at 11:09:36AM +0200, David Hildenbrand wrote: > In preparation for further changes, let's teach __free_pages_core() > about the differences of memory hotplug handling. > > Move the memory hotplug specific handling from generic_online_page() to > __free_pages_core(), use adjust_managed_page_count() on the memory > hotplug path, and spell out why memory freed via memblock > cannot currently use adjust_managed_page_count(). > > Signed-off-by: David Hildenbrand All looks good but I am puzzled with something. > + } else { > + /* memblock adjusts totalram_pages() ahead of time. */ > + atomic_long_add(nr_pages, &page_zone(page)->managed_pages); > + } You say that memblock adjusts totalram_pages ahead of time, and I guess you mean in memblock_free_all() pages = free_low_memory_core_early() totalram_pages_add(pages); but that is not ahead, it looks like it is upading __after__ sending them to buddy? -- Oscar Salvador SUSE Labs