From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA4EFC27C5E for ; Mon, 10 Jun 2024 03:41:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5997C6B0088; Sun, 9 Jun 2024 23:41:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5496E6B0089; Sun, 9 Jun 2024 23:41:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EA596B008C; Sun, 9 Jun 2024 23:41:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1F2446B0088 for ; Sun, 9 Jun 2024 23:41:01 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9DA46120BEE for ; Mon, 10 Jun 2024 03:41:00 +0000 (UTC) X-FDA: 82213577880.09.7CF8B62 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf15.hostedemail.com (Postfix) with ESMTP id 79C44A0003 for ; Mon, 10 Jun 2024 03:40:58 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XzuVDh8v; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=k7kv4Cr9; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="g80JSXZ/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=xZDiG7fh; spf=pass (imf15.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717990858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XhMeUSPitVOIJg+Ci4UGmlb8AHir6vvuaNsU4B/YN3Y=; b=4N/hhGIJtfcUZI/4E3rvdjjy/wr4+FPnvY5WXqhSEcjyT8wmmFH13syDvuwLIUbFLhi0+L ABm42czevF1Xn5bk6OghyTTDtgOLk7RxKg9o6tqweW4K63CalFvhTru3Msj2KFSljns++B wkGIHQ9ZbomLPBxZhBm0aO/ePSR/U3Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717990858; a=rsa-sha256; cv=none; b=I3+7Hasd6P6Pg0no4aoUOBQPMLuDj0tIcRYCeACI2Ti660FBql40265rfP/ls3NIEbKXmB nR5aFeylt9+9puEw4TePLwKmhGxeH7DqqHdzsXI2U7nAVL+r9NG3Y1XF/DwB9TAI3zJzYA +CsAB0ss6J4aBwFxNAJPqoa/yMg86Bc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XzuVDh8v; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=k7kv4Cr9; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="g80JSXZ/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=xZDiG7fh; spf=pass (imf15.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E23171F74A; Mon, 10 Jun 2024 03:40:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1717990857; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XhMeUSPitVOIJg+Ci4UGmlb8AHir6vvuaNsU4B/YN3Y=; b=XzuVDh8v0pD5ktmxgvQP591nI2YKBJiR2EqqtQR9tDYxJbpghtdjmJHQJiyoJC20iIZy1N WwrtB7C+DhvIZVuDXTo4lpSGQJuMgxMV7B6AUpn1JUuSNklbcUYZOPCPDr8sNhpNcQQHVv TPg75skKUgzfD4TU7yVIvKdm37i1TE0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1717990857; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XhMeUSPitVOIJg+Ci4UGmlb8AHir6vvuaNsU4B/YN3Y=; b=k7kv4Cr9bxZsPs3tbU2SvoKUzp3a7hTtoWVht1nuoBVpZ+dCDIBRBKakoa7mHJHhkAOVAy oa6cp5WniPosyzAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1717990856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XhMeUSPitVOIJg+Ci4UGmlb8AHir6vvuaNsU4B/YN3Y=; b=g80JSXZ/HTmohY5qWwhGy1p5v+b91LdxgDTMLyvg07kkCHB3Dnm10TeqcAaM7MPr/fRk9H FZzfRD9Xab8sghZxlWhEcS7Sr8BKkK45AJdRA9rhCjAyP2YAQ8eR/BlOoC5qmc4rB3CF4a t8Irtea3HRjeOz2nLq5U4UZ3drl/g30= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1717990856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XhMeUSPitVOIJg+Ci4UGmlb8AHir6vvuaNsU4B/YN3Y=; b=xZDiG7fhV7aTRHj5LgUMnmRDeBaCoCL4Hm/Xp7A9JakqDdq5iPvb0mZwEC1xZhNoRM34qq bvXYBL0194icwmBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8E0AF13A85; Mon, 10 Jun 2024 03:40:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XLnLH8h1ZmaeDQAAD6G6ig (envelope-from ); Mon, 10 Jun 2024 03:40:56 +0000 Date: Mon, 10 Jun 2024 05:40:55 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Wei Yang Subject: Re: [PATCH v1 2/2] mm/highmem: make nr_free_highpages() return "unsigned long" Message-ID: References: <20240607083711.62833-1-david@redhat.com> <20240607083711.62833-3-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240607083711.62833-3-david@redhat.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 79C44A0003 X-Rspam-User: X-Stat-Signature: 53hu49re7onmswpppzhkihf94w8ws1ki X-HE-Tag: 1717990858-768349 X-HE-Meta: U2FsdGVkX18dQtafVSDBnmjCxEn96qUevNujgjPLDGnvNEWX24P0Xe2T/wxsEanLc5a79qTqIe6H/QLoxb4mTWmIaxc0ZjZEyCC5dx8ALdL3lTCogTZ5zvpvfQD63QUrPcoZ8ri1ngXa3lidYkQ/e4VDy2PWi7r8MqGWGqMiCD/cRW2E8JdZC0mf/d1HydsOvMdnSMtnfwaFfYYyyUTSynFovGxSdh0Gj9y5PT8QGNtMBLzEoeH4cltwZUCbx84IJs0VMl9mE6LIlh+wtdXrhsX6NRT+oftB7HnSwUdRht+Kw1mC4T2hpgPXYTynV0BJ9LP6/62VlXhPGKTUq6UWoQsxyGk+hptg3M/q7XMIKvevWi4B59Fl/5Zt2lyV4wYpO6jZvq57d4FP9xCAA1RlPuEYQf3tICy+7U6T97wGpva77cKVRU9XuQHx6whrDFC4ABTE1uRKZ4K+RMBkhFp14YfEkguJifANhr1WjDCQVu+TieWnl2viU2eSO/mueKPyWIXVuozXgT296xOIz1uZ98DSssL0uwrfQmkA6z6bmPNd/sQU8/y/WWnF4Pv9y3CKpKEpte2k90Dy36fqa2LmJa8wvN2eThH+zu+7t/G6ih5jiVM1ycPhlWRSl7AufjNT9Gt22+y+6PBKEPTJLvSmD62E3WhQuMlxi9mJ3kBDgdxY02jg3EdZ61q61C7tZps3v8QTIdr1SxZrakT1fIqwqXP3uSjqcm89ripcmjtD/3U+JrAG2pxXB9oeIu98403O13OWB6MpBjya9lA2jE3YFcPj1NldPjEQJzg3LY6Mz5p6rLVg0Fpo7X71X7G0dIKn+uHU+YBFkOGeMWn5V68bWQ76CkhfrQBwGDjm0ly3uO1tjQ41qdbajETnxWD7GJgRTcirMo5DsIRB63p714CbSLyit8kaH2tofO98X6gj0eZeA/lMYRoM6+s6ppVjFPiylu6EHaMzkdhaf1IZ5Sk sj6Dyu2i +3+06W7+l9eHJsfM7+sFmNUJOrHIl0vvB7bJfz8uBrJ6enrmlSlFVuN6nhNyTkddxTxKo/O0zS2OZFD++OuQ8Pig3p2iIbmXL4+Ztacc+NHfGTMGl5AT+Btkzyb+8ZPt9ZEFcim9U6YPiy/cTaM1j0Hj6gB5pqvOpZada3II0zEYHdEbvlNbXnp7qr8VWmJ0h1pInKvgSxdepOYMGSiBcj/ZLLcsPx/Dz326kKz1v29BJ3hicnjg0VU4PRjCRzN2Y890nP6+LoaUkJ8Mn+YKihfQiKjVxnqWaMH34fOG1JrWB78dU3JAWDVgKE/bh/4Y4BAtRLEXjwU+4AEFx4T/8wRnRiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 07, 2024 at 10:37:11AM +0200, David Hildenbrand wrote: > It looks rather weird that totalhigh_pages() returns an > "unsigned long" but nr_free_highpages() returns an "unsigned int". > > Let's return an "unsigned long" from nr_free_highpages() to be > consistent. > > While at it, use a plain "0" instead of a "0UL" in the !CONFIG_HIGHMEM > totalhigh_pages() implementation, to make these look alike as well. > > Signed-off-by: David Hildenbrand ... > -static inline unsigned int nr_free_highpages(void) { return 0; } > -static inline unsigned long totalhigh_pages(void) { return 0UL; } > +static inline unsigned long nr_free_highpages(void) { return 0; } > +static inline unsigned long totalhigh_pages(void) { return 0; } Although I doubt it has any consequences, I would just leave them both with UL, so the return type is consistent with what we are returning. Other than that Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs