From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E50FC25B76 for ; Sat, 8 Jun 2024 15:15:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FE0C6B0088; Sat, 8 Jun 2024 11:15:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AD5F6B0089; Sat, 8 Jun 2024 11:15:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49D616B008C; Sat, 8 Jun 2024 11:15:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2CC2A6B0088 for ; Sat, 8 Jun 2024 11:15:18 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 54098A1A90 for ; Sat, 8 Jun 2024 15:15:17 +0000 (UTC) X-FDA: 82208069874.06.AB64306 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 803D6120017 for ; Sat, 8 Jun 2024 15:15:11 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=b0bvSqHd; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717859713; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7Zz8vX4pW1P6Jn3NTMHPQV3Gj3dsMMb4vvh1Nd2Xc7E=; b=MqnFHjJnBr05qJboS6jxiROlYNmjKdOTEgkwtWjZNsWq1gTBaoCkfxesg+6sFiZ1orCgya GfDqO/3MmPBIYLj593tCSoZW95FhOm3V6+HQAywoWSV0j5tOuT6rlFo770RFGaFZ8sDJbJ uNFaZ0+snhGoUjLQr/LLQuvGFeDZ/h4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=b0bvSqHd; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717859713; a=rsa-sha256; cv=none; b=XXg60oV4z8FxuYmPOiYqcyZcMG0UaZl5zWRo86LmIhzOm3TsgJGAKvFB4PQAVK45zqdkmn lsSG9eAzKwIiZKIArezq5PJo8S3pIX+9qevWBP58m/lDr/OoRh19cTvGAKG0Z4Wm23pK9A Nc5DPRFmq+7Djvi2dBlgbfiiPmkbqQQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7Zz8vX4pW1P6Jn3NTMHPQV3Gj3dsMMb4vvh1Nd2Xc7E=; b=b0bvSqHdRMz1oEeNGRnZrDQoBK hjCWqa6AlwEP585nHcNFAIFikKHVuefZ7Vgg3NBG5I9gCl60yhzi2FqJFHwFtRQMZ+G28Vi7SMS6W phn2zcGNc1zAYjQRvlSMdDcPXTHi4nndLDOYYPWwNUQf6WWkZq6VMQexw7w0y1gBucNI1+P68nsI9 7SsNyvRWje7RUW8MhIBtNX5Ey94ABLGLrb5FM5sII1ePqzEwmVlFu22ydgUwlndWEZ9Xcv51Wb96+ o+T89bkVbcnED+Lb4koSWExW7MuoIfFYupXm6BDS/jMu7a2bEe9XiDkR8oFSFOHKDufkrWKNgKsTn vCHW+dTQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFxmX-00000007MZs-2oWV; Sat, 08 Jun 2024 15:15:01 +0000 Date: Sat, 8 Jun 2024 16:15:01 +0100 From: Matthew Wilcox To: yangge1116 Cc: David Hildenbrand , Baolin Wang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, liuzixing@hygon.cn Subject: Re: [PATCH] mm/gup: don't check page lru flag before draining it Message-ID: References: <0d7a4405-9a2e-4bd1-ba89-a31486155233@redhat.com> <776de760-e817-43b2-bd00-8ce96f4e37a8@redhat.com> <7063920f-963a-4b3e-a3f3-c5cc227bc877@redhat.com> <48150a28-ed48-49ff-9432-9cd30cda4da4@linux.alibaba.com> <11ef3deb-d1e3-46d5-97ed-9ba3c1fbbba9@redhat.com> <697a9bc2-a655-4035-aa5e-7d3acb23e79d@redhat.com> <3a368e38-a4cb-413e-a6d9-41c6b3dbd5ae@redhat.com> <48fb0e58-16d1-7956-cf35-74741826617a@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48fb0e58-16d1-7956-cf35-74741826617a@126.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 803D6120017 X-Stat-Signature: jj7eji4py989b1mnbrcnxzqxx4ydcqsh X-HE-Tag: 1717859711-20740 X-HE-Meta: U2FsdGVkX1/05T66EAs3W2M1APCJVTeZOFaPpwKqfGf7wO07NhH58eso4vfHo62dPs96m3+AyRCmv+8ZsM64VxDD3TQkBFqr75Xj43UbQhqLPyGN8zEDGlpAnfpgXUDKrj6EivGSjSlfPcgHRKO1ZGAny616leNYuh+fcEEER9i5kwOxfriTKtfaKk9eWh1IDBhKixMGi+ntfJ5Re1aV3hgrpzz8cKZEWpHrVbtJ7twHkCXhM++jPiEBtAMnlsGW5rX/pAHz9w0aA6FZNHjyhy9gt7vu8auzt5FqgOS5GhULDLB8wZPh09Y7X1Jkx4wkub9jBDZWQfQ/aVOgW++Mi3dJTPg54L8Sr7OfoFq2pKP2KgC8X3Qm2khb7GY+66Fnw5QrdtfNsmK1R0aRVURwPCPQyPazd/oJLCzwOB1Nu4DcrRYTDjef4ElWo3aImPVHWYgNWW+lULbb9UR623BUH58hzdRcyMvTLxim/XiVG7TbGvdB2BG4prmINbqqB6MvpawH21b1vvfYojnyKbZEfVABdhcQapHfvlA5J38Arp2D6zK0vT2YVBLwftfv+OPIpJBSBM4Wmvpeeg7RxPwKWt2dgD9VgsWO2vZaYICiFbVaQRH4NSlT5/vPgHd7XrYR94k0vI5HwyqJk24GNfkrT7JPxHiMDjAEFCWn/lO1H+ClNgdvJEVNYM/dc5D+WelGDlOXUsHF7X3cwBf7edoe8OYir1VgxihjjN1Td0eGc4zv85wUGNkDs1phPtl+i7x0e2loOPg+gkUAovNhG2dTSjqzTKzZL1ERMbPYNFnjWty8ZmkYZmT6a/NBQIX8fGakudZdaOu6rysiHS821RAMk+X49aEjoL3NKBkqDvdSAuSGmhfEB7BWZ8WTTptT+oXgJnhAixEzJUqZyQsKEj2kvD270hUWTm6Cu514N3RjEh3N+X7xC2x/y8ck/TXfTQfxubhNvgVSPeuw88MUN8v +r2hPyhv m++N6RQGXfYNAyPLWLfGcopd/QxEIcRdtaBTQgjmhkAKMkRaCaJFHCRpfTYuBYtRymlfDR8S6yRvU4QBKTIhwhYu3VjZXkpZChXuYRjABBvAu0r+KIfzpX0HU+qEHVsC7lEc2u8KquGLXgCU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 08, 2024 at 12:38:49PM +0800, yangge1116 wrote: > Can we add a PG_lru_batch flag to determine whether a page is in lru batch? > If we can, seems this problem will be easier. Page flags are in short supply. You'd need a really good justification.