From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40052C25B76 for ; Sat, 8 Jun 2024 07:58:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65F2A6B0088; Sat, 8 Jun 2024 03:58:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60EAF6B0089; Sat, 8 Jun 2024 03:58:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FC3F6B008C; Sat, 8 Jun 2024 03:58:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 376916B0088 for ; Sat, 8 Jun 2024 03:58:21 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 85CFD40677 for ; Sat, 8 Jun 2024 07:58:20 +0000 (UTC) X-FDA: 82206968760.12.79B782A Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf25.hostedemail.com (Postfix) with ESMTP id 729D4A0008 for ; Sat, 8 Jun 2024 07:58:18 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dwlUkFXk; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717833499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g546z6DxKa0qkAl37I63uBx3R4d53pcUFpdUJsTh0Dk=; b=PzNgoWNrmXWqzHwtF9gjnrqa+XYYYaUpwdhid45gaorl0epKbgOZBwBjs5ETV6fUoeVU5h 9XyxdhF/ciEdlEAiAJ3B8uYIOleOGneXhs4XB450LoYXrGs6r7pG1PTP68dRyF/NLq17mW UW01wBt765AFcSffDccyKdNN5r6o+lo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717833499; a=rsa-sha256; cv=none; b=Wt/HSIm9LtUugqqNFOcVGgovWkPw5UWQ/BMejZcKQ+xSpcvkDRQfoln24buDpJmHCRLT8/ P6vI004K4vzfltShs66F14kn0+rRQjJ0BN/fKQOBk8patq0g2G4tGeV1JPFW9jZeusrKIg Iqnlakl38V7Skq2zjF9N3wOzJOeODAQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dwlUkFXk; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7D70CCE1EA8; Sat, 8 Jun 2024 07:58:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61EF5C2BD11; Sat, 8 Jun 2024 07:58:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717833492; bh=sJcQLRlT/DHc9JsZ1DXr6ErFx3JmHWcHRmfXt2bnKLQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dwlUkFXkDHJ+xpJ5arTICvLSNvlAEYuGmnFM9hCtHB5sEDXA3BbcNKAnli1pgZBjv I8hhMAFBP0ffq0iQ0lbHde/JUrHM96m5AMvEXp4VzgndSZO/E2DZNU1aR6C/pVTzjJ hFwNreKEJb2Ls77HaGNl1PwMj9peipvwAMpIwg5vN+M11y0JNSRcumBn7HI/O+rNPF SkB8295INAb4tIgNkvGXb/25TxUDR6dzlGeqcTDO9qX7mrc9tVEz0CPc7vRGkTjF1/ VDsLp/YFH4KyNkBKw1ShNMNfLI3ioxpPNT3TBVb+IgdQ7ZdHgI93vfnbHcbmcGaL3B YfxpdAZQNZlYA== Date: Sat, 8 Jun 2024 10:56:11 +0300 From: Mike Rapoport To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/mm_init.c: don't initialize page->lru again Message-ID: References: <20240605221436.24627-1-richard.weiyang@gmail.com> <20240608003535.cxrupjomwaxh7zpi@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240608003535.cxrupjomwaxh7zpi@master> X-Rspam-User: X-Stat-Signature: 7s51idekkj7yfg59oo8955qu4gprrcsj X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 729D4A0008 X-HE-Tag: 1717833498-194680 X-HE-Meta: U2FsdGVkX19WpfYUGHwi7q3UJk8B4q8Y5FUDpr8NKjeeVXrCKohaVH1gWffTdVzjJWqjZz5g6fnuN2q4UBmAoBQvnO0N0c/1xoMk0cjO5id5r1Z/R5CUf91YKYwm7RlkiztEx0QMUCFFlbNnKa8OCJtj0snZDY2wH3s3t9Bm8QTtXCLvSXIKm3OlXHFrL3x++B1lDMHuU30oqfjtObdepESc1werXi0ltTmzjSXtunhxubwgG8zP33ohHtDBjzJdzSa8/DLmWa1JSPqPPBMXoOXunCve4aYFp1dnEnsvKBChA0Z9iS8hhnVRT/JCk6f8AwGJi7symNAhN9RztOmpbGxAAOOK72i39iRZyZ8OI3STOVtchRL9P20EqzU0nnCacVsRsiYAKpQISJxTZxhYmFX7av/xzI7kkblRT6q8DMa1DMcvRw2d3PW+DoNtytUdz1cfQj2SG85pK3tRb8BLkmas0m2DYd/1h7zCdoORvi0ylyQtss1DLTfiWr7w/JmDJiZx7d70BK0HE0ujJB1cK7QUtdnLyqZz4WdKy4hyGNxAGzWejIpi5XHALU4y7/9JRYzDMXfZhvleXhzPFscqwxYH7esMcBTP+uGo8QGMbyDgHIBEGYVrV43mYWlsl0UUY8cszFvq4mDMuYvyfbL2v99mYWr0sKIsqESodrtoqR413JOQvcsKdO0Hi871zCj1wWh+upNMe6jum5uxpTzfeQq3AHBpNnLAM7ijLc8Y0fcHiopmT6x3OQLhqJXmLlyCP9YWVZyoGpky1uzunYFNh9zFw1FbU/Y5BMgq1BZn+KoTKRoL29H9hSqYYIApZB7L6LiJzvZZvv71jyXnOzsOABigCMxrznhFTWf83X+/UIj2LSE1S2yWnx42P1V6cxud9c+ZBgDbiR6gIO0HrctabdNf3JIw1EcDIL5s+0fLx9g+43uXYzJBsopti43Z5KQm2yNdcH0pRGAXDN1l7uh aT3URtFt YzDCqQ7oYcXFPBL4mqf7cr1olcmRYzA+837mh/98NT1HA4SJvGZfCIy/4VDADHy4Gmzdz2s4O8vFxsxhaE4zI6ezkxT3cSmtvtJMMjRpp5bGJvD/m81U5+7qIeLERnN6nV676DXiWdtHnsE8/87PXOyhJpKNnZQzjscNT+9GOCdnfHG9cecQZITFHzEo0ZhuiBwSPHnG2jfyxVHbc0KKa8bwm9y6uZrnGssQlBa4Tx3BM5d/cJ10HkH+oX5oMGYfZZOgwk1G6obu5BzQDafX5LSrNfuLKAB5n9oO+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 08, 2024 at 12:35:35AM +0000, Wei Yang wrote: > On Fri, Jun 07, 2024 at 10:33:41AM +0300, Mike Rapoport wrote: > >On Wed, Jun 05, 2024 at 10:14:36PM +0000, Wei Yang wrote: > >> After init_reserved_page(), we expect __init_single_page() has done its > >> work to the page, which already initialize page->lru properly. > > > >init_reserved_page only available with CONFIG_DEFERRED_STRUCT_PAGE_INIT > > The common page initialize path is : > > memmap_init > memmap_init_zone_range > memmap_init_range > defer_init > __init_single_page > > If CONFIG_DEFERRED_STRUCT_PAGE_INIT set, we would skip initialization for pages > after first_init_pfn. So init_reserved_page would initialize page struct > before __SetPageReserved(). > > If CONFIG_DEFERRED_STRUCT_PAGE_INIT not set, page struct is already initialized. > > Is my understanding correct? Yes, and it should be a part of the changelog :) > >> We don't need to do it again. > >> > >> Signed-off-by: Wei Yang > >> --- > >> mm/mm_init.c | 3 --- > >> 1 file changed, 3 deletions(-) > >> > >> diff --git a/mm/mm_init.c b/mm/mm_init.c > >> index 14133a1cfc7b..30379b0e7729 100644 > >> --- a/mm/mm_init.c > >> +++ b/mm/mm_init.c > >> @@ -759,9 +759,6 @@ void __meminit reserve_bootmem_region(phys_addr_t start, > >> > >> init_reserved_page(start_pfn, nid); > >> > >> - /* Avoid false-positive PageTail() */ > >> - INIT_LIST_HEAD(&page->lru); > >> - > >> /* > >> * no need for atomic set_bit because the struct > >> * page is not visible yet so nobody should > >> -- > >> 2.34.1 > >> > >> > > > >-- > >Sincerely yours, > >Mike. > > -- > Wei Yang > Help you, Help me -- Sincerely yours, Mike.