From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80EA6C27C53 for ; Fri, 7 Jun 2024 13:18:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB5586B009C; Fri, 7 Jun 2024 09:18:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E63FB6B009E; Fri, 7 Jun 2024 09:18:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2BFE6B009F; Fri, 7 Jun 2024 09:18:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B240F6B009C for ; Fri, 7 Jun 2024 09:18:48 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4ED8E4191D for ; Fri, 7 Jun 2024 13:18:48 +0000 (UTC) X-FDA: 82204147536.19.8405409 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf18.hostedemail.com (Postfix) with ESMTP id 28DFC1C002B for ; Fri, 7 Jun 2024 13:18:45 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=RQr4rMlf; spf=pass (imf18.hostedemail.com: domain of osalvador@suse.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=osalvador@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717766326; a=rsa-sha256; cv=none; b=HlDT8DxVK4KklnbJ8YeYqtnQ0Qz2/9Ksbs7ZfqW1KFFwWRq1hicMJ1lk+NRCSYfVjJguOl hbZtDmNJVbV1NI4jbxpYXdP4wCsKn+gZzzyn+NOpNHm3/lLHVI+bFkW7wBfi9ekxMAW5pb fUBZ/kRhqGkpmZyqa/+8y0u1BOpxAvA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=RQr4rMlf; spf=pass (imf18.hostedemail.com: domain of osalvador@suse.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=osalvador@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717766326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UNOtY9kbCwarj0NKj0Q/xsdwvI1gsG+x4nJEIzhwFBs=; b=DxiEPhrc7cXY7byyAFE9uUpuXRxXIDu/p3TyPKEN+9/b4MPzZbSqK63CIOw/3toFICO/AK aB7N5+wT7sGNF8supvxgOfi9WsHkexSFOrKllMqMaIFOlD/ZKWEsDAp8hJbXbuKd9VTWib Y2QrxC/jNMy3Q1/uFk0BmoRf20QPBgw= Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2eabd22d3f4so24552671fa.1 for ; Fri, 07 Jun 2024 06:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1717766324; x=1718371124; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=UNOtY9kbCwarj0NKj0Q/xsdwvI1gsG+x4nJEIzhwFBs=; b=RQr4rMlf/7695ETx+eJ7F7nuv8DRSsEbbJdwkEZZdApB+ZL8H9GsgrIxBVO6XwiGIB auq4r458SGpSIBlxxbxxXui4yyf5gtlFTvGKSosx5vKDqqjhOczxif5YkoUUHiTL4mHw JHHZRU21SBt9ITaguH9r9BHGw0VPxttlhHcDE1vLUQmFvmmUbx++2wARvOWUrihcrRtj iZzrNYOPmfSv34/S2hLPwvWUBN0AJK64KTkmodOc3Y2asIKNO+97BtYViXXM5jw751mU 1Jv+MjIcNZu+48AZWHMpt0ksf6R6zSpBY5w9V92+GDVdVI9JeI8FkWXx2ta5ur0rZr2w bhVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717766324; x=1718371124; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UNOtY9kbCwarj0NKj0Q/xsdwvI1gsG+x4nJEIzhwFBs=; b=s34U2VmoJdlGR2SZPhfBQQ+hisYvmXSA6SiULOUS54DU2tFtOsjJ1bTrYwkb3SdQZZ RQ+GuUq/5l0bkyL0+rAqLL9LTdK5eP9iUrTV10KAi42cQsgioUv3Mdq9G/o4DoOJip6s c9DvrLTD9xbvFfSp6hC00P23O/E7Rkmqbs0JYIWH4/87pamRdfoo+RL7VY6kQgYUtcko J5u+m812gCU02r/pVkkbBFUHeAMddpNVMMCxGh6iu32EzApFkRdyqJWxZ0Ql1TkoCgVI Xk0/sB/w4bCHQbevw1LFH0tTWkDUxAK+/cl8Irs4fF4JbCH45q20kp2nUbncHg01y+MB L5HQ== X-Forwarded-Encrypted: i=1; AJvYcCVEL/KrFgha/Tayum12/gDzSGdLgzLEuszHDG+nxJuFKQp0jgn3ngTPzgGw1zbMz5nke45Blz8bQcF4G6PDDiP2pNo= X-Gm-Message-State: AOJu0YzD1fw2/LlKxUw6qjVezHwoAYGq9eT9lp/IgrczHPET7XyqAhkx 1Ahb5YHbrQKlnXBOGQL+T95GX1+t4C03tSh/Z9eGsC1J21umdMvccqPmRV8xfso= X-Google-Smtp-Source: AGHT+IEBxyjXDl9VEt7rh7TeIxG6bOvGA4j17IdvLoM+xGRwnhFMyvO9AhcxnCYNWTyb7vuvBSDlAQ== X-Received: by 2002:a05:651c:550:b0:2ea:e12e:bee5 with SMTP id 38308e7fff4ca-2eae12ec074mr11738031fa.4.1717766324270; Fri, 07 Jun 2024 06:18:44 -0700 (PDT) Received: from localhost.localdomain (62.83.84.125.dyn.user.ono.com. [62.83.84.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42158111143sm87617865e9.20.2024.06.07.06.18.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 06:18:44 -0700 (PDT) From: Oscar Salvador X-Google-Original-From: Oscar Salvador Date: Fri, 7 Jun 2024 15:18:40 +0200 To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet Subject: Re: [PATCH v1 0/6] fs/proc: move page_mapcount() to fs/proc/internal.h Message-ID: References: <20240607122357.115423-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240607122357.115423-1-david@redhat.com> X-Rspamd-Queue-Id: 28DFC1C002B X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: 3x3baq984by6tjebmmtfoy1s1k1756uc X-HE-Tag: 1717766325-712980 X-HE-Meta: U2FsdGVkX1/CEtWsuDcj/OJFNFF6WswsRcyOzZj1vF2x3B5/BMS64fa/XFYTIcXirgdE2g/ErYDIjdvI98jKckGmbTlhT0jF+zTQkyB3Q9S7e2c4nqfvWoq/NYjRkPiAGjIphh6XXjfctaHnT75BLKM++/g+7UqT2gQy0VSG+GWbcaNf14y6dqlV8kqO9TGdX+B8UJ81xL6VGDjSO5su+GKOQuw1zcg7Cxmi8vul53whE9OKTctIzF0/N7+NveBRutHMWa2huYfyLtqRIC9R+y8rb8pfeIfvw8Ve3RpfsDkuGPt3Rsvy+ju6yD+PRk4Yyi24YJFNOjvM8wOcNH5b6kK5EvUQZH3s6aHJ8AAoIr/qJ4MDgL/v05tK9FbafCtzLfvvonklKoGqu8lRYAwj+RwUmx+5yQKqrbNqRw6/So5dgDG/Pmh6eUMgxkRCzA6FT3KoW9Y3IasIYfvRu1Oin5l/bUWBe/nweoIlsxMMQ2Xt6YAIJnDr0csZ4k7wr79xxOw5rWR46xKoRpxjPyVfSiUVtTozTIhQ+WuG7fii8suuaYu7Fe2s1kcOQTXfYC1+JPsEzbb99bdw91FVSR7Fj7342lDZvdSSzTGL6TnyuabjI3CU+mPfSJ6FuPoFJinjEkQQLJqMVyTwSUF9Z2H8GKOh+/cmL+8ZhxSRSikgelB8GczXPYjgGOjSdexn+1lcf2OtW1Gpw4cNnERFji4yWyzWMdm/R0rXEiU5gItqadHNwpW7aMcdTyptjhbKZrcJX7d0UbAlbV0pMOTPGHLuQVbwFmfxxy1A6t5kzsxcBJfwVmOGmQU99xf1f6FGXPt6DlAghzOqa0e6BCuNPoy36kS3YXNeqcuaI5D1W3poKpFfJCNwErdwn9YUo9/Xvnuy1P0E7JrXbEF8OQBnmSbvptlbvsCq9bTe6qvOE6AkXDdg69Om0czdLN0bAQqKY7CcAN6iYaM/uyEUcagibiz HY3PyrG6 mUsXZ1/ak7b9AkLzWV1cbaEQwJLAnKqaPnIAG2rnGS4A/BxGnsytSMwQfKOIkAjLTjOtliIc8HKxjTZRp756V8fsze3/F9M4zcP1ZHGHbg5RYTYb3aR3tAMAJNUOOtjKP3VY3HyTNIFmL2MSe0nsQT91UGqcFRWn4AO/NR2n4yUEtxORWOGvK2AF0fspGoy5ijW4jYmSvODKgqPxa88VrsMRb5SL/l9zzqWGbXzZE4KLx7/blrDEqSkR9jJHTmWOnwKLNmUGSnYrU3uNLaeKmbJfaWPEnm0KvvJOevPoN9vsc/JgTOwvD6FkMkiqYAV6KgTVtZXWs/3rBaJfDkmzJzGt1ujAWl7IrzO1H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 07, 2024 at 02:23:51PM +0200, David Hildenbrand wrote: > With all other page_mapcount() users in the tree gone, move > page_mapcount() to fs/proc/internal.h, rename it and extend the > documentation to prevent future (ab)use. > > ... of course, I find some issues while working on that code that I sort > first ;) > > We'll now only end up calling page_mapcount() > [now folio_precise_page_mapcount()] on pages mapped via present page table > entries. Except for /proc/kpagecount, that still does questionable things, > but we'll leave that legacy interface as is for now. > > Did a quick sanity check. Likely we would want some better selfestest > for /proc/$/pagemap + smaps. I'll see if I can find some time to write > some more. I stumbled upon some of these issues while unifying .{pud/pmd}_entry and .hugetlb_entry. I am not sure what is the current state of pagemap/smaps selftest, but since I am going to need them anyway to keep me in check and making sure I do not break anything hugetlb-related, I might as well write some of them. -- Oscar Salvador SUSE Labs