From: Christoph Hellwig <hch@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Martin Oliveira <martin.oliveira@eideticom.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-mm@kvack.org,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Logan Gunthorpe <logang@deltatee.com>, Tejun Heo <tj@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Michael Guralnik <michaelgur@nvidia.com>,
Dan Williams <dan.j.williams@intel.com>,
Ard Biesheuvel <ardb@kernel.org>,
Valentine Sinitsyn <valesini@yandex-team.ru>,
Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH 1/6] kernfs: create vm_operations_struct without page_mkwrite()
Date: Thu, 6 Jun 2024 22:03:33 -0700 [thread overview]
Message-ID: <ZmKUpXQmMLpH8vf5@infradead.org> (raw)
In-Reply-To: <2024060658-ember-unblessed-4c74@gregkh>
On Thu, Jun 06, 2024 at 10:54:06PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 05, 2024 at 01:29:29PM -0600, Martin Oliveira wrote:
> > The standard kernfs vm_ops installs a page_mkwrite() operator which
> > modifies the file update time on write.
> >
> > This not always required (or makes sense), such as in the P2PDMA, which
> > uses the sysfs file as an allocator from userspace.
>
> That's not a good idea, please don't do that. sysfs binary files are
> "pass through", why would you want to use this as an allocator?
I think the real question is why sysfs binary files implement
page_mkwrite by default. page_mkwrite is needed for file systems that
need to allocate space from a free space pool, which seems odd for
sysfs.
next prev parent reply other threads:[~2024-06-07 5:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 19:29 [PATCH 0/6] Enable P2PDMA in Userspace RDMA Martin Oliveira
2024-06-05 19:29 ` [PATCH 1/6] kernfs: create vm_operations_struct without page_mkwrite() Martin Oliveira
2024-06-05 21:43 ` Bjorn Helgaas
2024-06-06 20:54 ` Greg Kroah-Hartman
2024-06-06 21:32 ` Logan Gunthorpe
2024-06-07 5:03 ` Christoph Hellwig [this message]
2024-06-07 16:16 ` Logan Gunthorpe
2024-06-07 19:18 ` Greg Kroah-Hartman
2024-06-05 19:29 ` [PATCH 2/6] sysfs: add mmap_allocates parameter to struct bin_attribute Martin Oliveira
2024-06-05 19:29 ` [PATCH 3/6] PCI/P2PDMA: create VMA without page_mkwrite() operator Martin Oliveira
2024-06-05 21:45 ` Bjorn Helgaas
2024-06-05 19:29 ` [PATCH 4/6] mm/gup: handle ZONE_DEVICE pages in folio_fast_pin_allowed() Martin Oliveira
2024-06-05 19:29 ` [PATCH 5/6] mm/gup: allow FOLL_LONGTERM & FOLL_PCI_P2PDMA Martin Oliveira
2024-06-05 19:29 ` [PATCH 6/6] RDMA/umem: add support for P2P RDMA Martin Oliveira
2024-06-10 12:11 ` Jason Gunthorpe
2024-06-06 8:53 ` [PATCH 0/6] Enable P2PDMA in Userspace RDMA Zhu Yanjun
2024-06-06 21:32 ` Martin Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmKUpXQmMLpH8vf5@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=lukas@wunner.de \
--cc=martin.oliveira@eideticom.com \
--cc=michaelgur@nvidia.com \
--cc=mike.marciniszyn@intel.com \
--cc=rafael@kernel.org \
--cc=tj@kernel.org \
--cc=valesini@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox