From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7469C27C53 for ; Fri, 7 Jun 2024 07:37:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 500996B00A4; Fri, 7 Jun 2024 03:37:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AEFA6B00A5; Fri, 7 Jun 2024 03:37:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 376286B00A6; Fri, 7 Jun 2024 03:37:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 19E366B00A4 for ; Fri, 7 Jun 2024 03:37:32 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BE5671C29D6 for ; Fri, 7 Jun 2024 07:37:31 +0000 (UTC) X-FDA: 82203287502.27.083A986 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by imf27.hostedemail.com (Postfix) with ESMTP id DB5D440003 for ; Fri, 7 Jun 2024 07:37:29 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=GmkJaRd4; spf=pass (imf27.hostedemail.com: domain of osalvador@suse.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=osalvador@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717745850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s7f9odkH4nqlNDkoBdG1RGbEfYe2W4UxGmJOppHwoQw=; b=Rrnxvtec3h5At4MrxpQ+0n6qYD2bQWc6oJ65weD9mzl2N9jzIkczfkBOtMqvfQa+w6yWsa sCsDc2Ak/A1ZYEuwlOeLDaNYrlVKVqhUt1LpewbL6k326nOu0HNI9jaXEl7JrB7mYEbvJY YC5HZAQqsAT30xGX369RTfwEld/zqWo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=GmkJaRd4; spf=pass (imf27.hostedemail.com: domain of osalvador@suse.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=osalvador@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717745850; a=rsa-sha256; cv=none; b=2g5ReYSS4s6DY3xKVDUum/o+/nydcwaRCLq52tUm4xSi048sV+zlllrxZihe+p1ViPskrv DDJYCGeLTSMAkFwLDUKGVt0TmpP5ASW6nGTs7ehPTHCaz7CslVOIYFStyPcnmlBeyHvoOC awWT8S9yCNm4JrOqDl9tfzLYrk80No8= Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-35e5c6600f0so1457723f8f.3 for ; Fri, 07 Jun 2024 00:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1717745848; x=1718350648; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=s7f9odkH4nqlNDkoBdG1RGbEfYe2W4UxGmJOppHwoQw=; b=GmkJaRd4EOZQv/x/8O5EEXHTezBFYXvavFtDn+CQt9a/Y9rYJOH+nC0odBMw2ZatdZ fx4U21DmGgEa2mawsSThKr6/0NncEPiMnx+3HMLCQPv0kSQbEx+cgSc+OjEaeN0qdmRg sFt8kySMAI7j1cypEn7oPpv85Gzo4HHlJLVAylg/dISoDKE5CoVhsdX1gYylDEAhFNrS KeF2yaxn9GSIhdny06ijz2CFzHLU4Iac+kSGJ8OsWLO25KI6WyCwihB6RH0DYH4gPSfr M+oMId6WBsP7KzOt1XkPA+BCAhvCoPYNx0+4I8n1duHkG9QGhBhXEBgAq1+EWBjYB5kP naRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717745848; x=1718350648; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s7f9odkH4nqlNDkoBdG1RGbEfYe2W4UxGmJOppHwoQw=; b=NTkFvlaRJBx7P5XuJBtZ57hktiq31wnAUAXNWtZqD83dWlsn+avkd1s9jbdCmzOvs4 QKz3nJszS3PSzMOPI3M8NPXzSp7JciKXMz0unrkseqvtMWZxHjt13/ZhoBHfVcZ6THIc rQaTg5GT7z4lQf8FSXs2S/Ae6mfPsl3laQLEs3Hyz9atas4hItdti6B/FY84BbtP3exX D5ueS4pJ3SOOapzYbpXN1dKgCubMUlyq0/TCUuVzLOE83DuCt9eO+Z3bF6MZGZADZgsf VoZ7bpGImK38wxD570NRtyT3qeDmFdepMF1h79EMGAnsJr1NlDoxtEsBGM8OcOQiHHHb tYgQ== X-Gm-Message-State: AOJu0YyWXkvDchnPSkzjDA92UCXgLJRcIhaeaKhdGPidwq8k+m5sll+C Azp44VvPc5D0o141TTF5z6U69zKIqHExGTCOtw4Lw3+WA/VxXSZNghP5SZO5abg= X-Google-Smtp-Source: AGHT+IE/YF8k48fFIRZefOBJiz3W4OR8sqVrlZY1CGl7xAyeQ466Z8xIR8jJKkF83TAF/kYrZbzKQQ== X-Received: by 2002:adf:f607:0:b0:352:f27d:525e with SMTP id ffacd0b85a97d-35efee0affcmr1108043f8f.47.1717745848349; Fri, 07 Jun 2024 00:37:28 -0700 (PDT) Received: from localhost.localdomain (62.83.84.125.dyn.user.ono.com. [62.83.84.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35ef5fc1c77sm3346521f8f.95.2024.06.07.00.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 00:37:28 -0700 (PDT) From: Oscar Salvador X-Google-Original-From: Oscar Salvador Date: Fri, 7 Jun 2024 09:37:26 +0200 To: Mike Rapoport Cc: linux-mm@kvack.org, Andrew Morton , David Hildenbrand , Jonathan Cameron , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.org Subject: Re: [PATCH] mm/memory_hotplug: Drop memblock_phys_free() call in try_remove_memory() Message-ID: References: <20240605082049.973242-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240605082049.973242-1-rppt@kernel.org> X-Stat-Signature: 4ayqxis899c7c49y1b4666cas4pmd7e6 X-Rspamd-Queue-Id: DB5D440003 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717745849-214917 X-HE-Meta: U2FsdGVkX1/r5pBu23Lqq0h9pQ5eceJlI5S4FWfPpxLP23WlW9u2/rXefGqGqQIZIM4HhXBnzSIpfRr1Bz5RlyZ0D71qyKz0XkVjgUci+5smsK4IgfManeZbPR3QvYLDLg4rqZlcp+2M99XVQ1qUj4Tde2gQW8Nr93esGCfRpLMgrxGa+4zYlOwpGc3mVpJwl1E0sGHo/QnBt4I4L2yUet4M8KXAn0JH3ssBkiWFsehEuAogocrRn/nQMzDrGmoxLjjrJi4XqxYr2b905xyrhtKoWgiQd3JP6QVMjPHcXy0zDCi0Yhf0Pe9TgIqq5uyG92RHmSSDQgrRS11NlVeJ9My/WEd4+Xh/iIw08OpoQ+YqkhxQ2C2lEGDuR3gSuC/k+ER5urNFQwV3Vi7cOucWBWFHR2cA3YfHcRymdE+d6trnFaQNIEr7/zND/WBL7QLmJ6YaBZSwmlYiJ2OmzSo1NL3g8Gv0pEamndu7XRcdvGIq0ktn8OTP54+2giDeRcYT5FeK6ZBrSOMhbzXI6JGkbKqG6SnyUeHhY+OnAIa/WpnbYm2kxXhUnUULp9BOaETCQkP3eV8R0npGeoCvvef8Yaj7jXihzrYNjfqNgG85EYL5+5tcET4z8XHsEcPWganR23lucQIOo3UXqbOp/8STtoJFaFRMgozfJw62Ok5qDwV4MzhniduWdV+P6V4rd5u9EOHS+sIy7ekryviGAwwdHgjleS8K3OXzyrzuGnQH/q4KF1VDnsQk+bbDU00/6Et79YUzpDNqW8e4cdBQZdRBK8zaRuMQq5QgTd+OX3ECPUFPEe1C+KyNXW4BubE9GEC5c1IfwQ4zIjuDgh/tgHN8scX0/ZKTJlveyxaxZLU6PREHHu5B9oyETWezkd9XHD6kv+9jGCklmGx1ztQ6cvXdg1GnhzoPYEjm6ZG+3Ro+w0002uu9B2c9wcjp/brWDM3G368Wux6Y72AdYMtXa4O s2M5UE3V FNXX8NqqtpCQH1fDS/EJQHX7AV5e3Xe7vEfRoRJSfPrCfu8KK4hvYPqNS1pZZP7VHkjC42ZdJXDJdc9g5PQYgxMio3cV1+zOnBNKwpxyOfWcOccrL+TOiibu2TK8wyPPtyNHkwfTZ1K0SGRMoetr8DDOFB/ST1tZALuscaJxl6tAzV9lHpGjvVhcdmUtEfw+g5esvP9GWfL09t3OJA1ojiltrNoWgS63ZmnWiwcbaEIdBok68AMpi1fZAKD2+zr1G2mnMAwQ0jsywgn+sqyYuRwgMQHgLDPNGT2p7RmIVkvsQBO73tOF/83oZlwbllkuVKzXPR+3C261u/Br0a7VcwMXUA6pV7KgSwEKqqfeT2YPfcfKIouk6wQPufjRJ3lBeSmUJ6yOClh5sc8RBv7vvdFww7s+x7gaIvAOhr3vxozEoJx/vw8LGm0/y5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 05, 2024 at 11:20:49AM +0300, Mike Rapoport wrote: > From: Jonathan Cameron > > The call for memblock_phys_free() in try_remove_memory() does not balance > any call to memblock_alloc() (or memblock_reserve() for that matter). > > There are no memblock_reserve() calls in mm/memory_hotplug.c, no memblock > allocations possible after mm_core_init(), and even if memblock_add_node() > called from add_memory_resource() would need to allocate memory, that > memory would ba allocated from slab. > > The patch f9126ab9241f ("memory-hotplug: fix wrong edge when hot add a new > node") that introduced that call to memblock_free() does not provide > adequate description why that was required and tinkering with memblock in > the context of memory hotplug on x86 seems bogus because x86 never kept > memblock after boot anyway. > > Drop memblock_phys_free() call in try_remove_memory(). > > Signed-off-by: Jonathan Cameron > [rppt: rewrite the commit message] > Signed-off-by: Mike Rapoport (IBM) Acked-by: Oscar Salvador -- Oscar Salvador SUSE Labs