From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D383BC27C53 for ; Fri, 7 Jun 2024 07:35:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 439DE6B00A0; Fri, 7 Jun 2024 03:35:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E8DA6B00A1; Fri, 7 Jun 2024 03:35:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B0AA6B00A2; Fri, 7 Jun 2024 03:35:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0C3066B00A0 for ; Fri, 7 Jun 2024 03:35:01 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9B815C1537 for ; Fri, 7 Jun 2024 07:35:00 +0000 (UTC) X-FDA: 82203281160.01.D91C9F1 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf21.hostedemail.com (Postfix) with ESMTP id A797C1C0008 for ; Fri, 7 Jun 2024 07:34:57 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Mw6c1sgM; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=osalvador@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717745697; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a0hiqs37/YYfDkPbEWIHD+E1YcNVxWsv4TZUXhjiyX8=; b=7/c5J/WHN8DoSDXcMp/ZrwuWuJVO1PLiTUQwjQ1nL1jAULeqzYZ3V/Rsmtfwsrsqnhxk5D IBpEanoboXfB6K6ONt2vKnjyByYDPGB+arPO9ETQ2i5aj5NvFfY9KCgjtMwRyp0s0N2dLB c+U0NUg2ynGnqgWCgAGERHn4PpSvJyk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Mw6c1sgM; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=osalvador@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717745697; a=rsa-sha256; cv=none; b=XdVH4/FrxWcKwVb2pA6p0EeSLKDKjrM2zkUoy6EZbsIv9+QtSywMOOuRiiYqoBzglPhhza +LvRN7UOR4lh8HrfXFJ2Nv6wdypoB2LeP96YrA3zpMG8TjJTZY0+3jcYz1BmK38FpwLAts USKHu1PXbIrNfI9EZqZUbW5Qn9mtzvQ= Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-52961b77655so2088836e87.2 for ; Fri, 07 Jun 2024 00:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1717745696; x=1718350496; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=a0hiqs37/YYfDkPbEWIHD+E1YcNVxWsv4TZUXhjiyX8=; b=Mw6c1sgM8I+lgdOt8ZMNskarQh6tFb6mTk57UdrVj1w/Wz2KO1tlO7x4D1/zI+FBqY D8r7Bl6IpRDAmXp20dTxN6yG6wFxUaE0vjovEEoDhjgSl56IWD/RuZtQzr0gFFnOspO3 oBrFC6ZBImh9UeOu8GxBnpsrG9HIrbW/5Zu7cPNYmY969lcRqmzRFQ8gdyRmVDl1ub8R sB6J415F1BNZhMyLEoSGGfnaYLmZFVLztyx7niHJEi+ENkzDy5dEDM+CnxokDl46fVMn EoSo5CWv5ZfuMUlQoLdmPvRtoTCqQ77SUxcKMlRQ4328M+FuDtgsjhimLo0JRWkmpedB KieQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717745696; x=1718350496; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a0hiqs37/YYfDkPbEWIHD+E1YcNVxWsv4TZUXhjiyX8=; b=i6QeSS1vyR2ogCuKES6edZ4tWGU+An7wYNgFBb/Wb9JWO1U2vdMNbnGSu0w3OSwVO2 oDfdwgveJ8fOxbVkeMOh5miDBs2w3A2JN8oIGujyN7MNW1rWgU+G0NFjgQbTsamK2qpm UxcUH2dVRyudBrobvepLQbLx1I3fhv3P38PvuAONnbCFNfk+rGdsoPQrMAqt5GcJVPM2 GiJ7BmLESrraIhS01v6WjdstwuBVSG3u6TU4pCWxNoZ4ueUPGOPH/PLhm9SHlkc0L89W TuN4htZ1Rxb9R8EI/k426TiaGx7rmaA6mPpCC+FvkMk9Gc1AXtEcsEX5GejIqC3uPK67 DI4A== X-Forwarded-Encrypted: i=1; AJvYcCU+pZ72u2sOfiAX5hIYkiHb1Tys1cGkfyt442TN1c7H/B4LxSpeLPlb6cPGn6sG2r9BSAXx3gB63TiErQHhOpcERkE= X-Gm-Message-State: AOJu0YwBziU/Gpjm5UHI3gljyuD1VVTWTT9X700zLkvJPJvHqt2ywvBy f8gYRd0d/LiH0XoI91vnoW6YfQWXLmeQfi9kufuVxnbsS3c0VPgno/7VkO28xfA= X-Google-Smtp-Source: AGHT+IETPBZvvper/s0wnn4VSTIAEUU1vgglXMpyNGhfA/TTDOotwLa9A093Rv3iH6oKFyhOBGAS1w== X-Received: by 2002:a05:6512:690:b0:52a:f859:fe4 with SMTP id 2adb3069b0e04-52bb9f5d0d5mr1357170e87.7.1717745695875; Fri, 07 Jun 2024 00:34:55 -0700 (PDT) Received: from localhost.localdomain (62.83.84.125.dyn.user.ono.com. [62.83.84.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4215c364bcdsm43774355e9.19.2024.06.07.00.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 00:34:55 -0700 (PDT) From: Oscar Salvador X-Google-Original-From: Oscar Salvador Date: Fri, 7 Jun 2024 09:34:53 +0200 To: Anastasia Belova Cc: David Hildenbrand , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH v2] mm/memory_hotplug: prevent accessing by index=-1 Message-ID: References: <01d90f6c-64a1-4d25-a760-0d8865f6de95@redhat.com> <20240606080659.18525-1-abelova@astralinux.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240606080659.18525-1-abelova@astralinux.ru> X-Rspamd-Queue-Id: A797C1C0008 X-Stat-Signature: 7pprhapdyfmusxz6o8rrqyc3ugcu5wsa X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717745697-419101 X-HE-Meta: U2FsdGVkX1+zn70faRRr4LT6PxrGH2OnOZfDI0wY9s/Su5lEM+yqClAjymiECPRXpk3X5KKNDUSesWLYlbPD3Iun/fmBQNN/+6PuI9/xwKJvGKI1ZzXYyOIedv1kcojV3tF/MHW9KJhGXdc7wUeVtUDN1NRtSLf4MVXEYXzrwaijYyDXqRNJnlfoBsF5ZugGnsDwn+ECs1HQ8Jwc3Da3yHdP48E/ucXnHJphwhvacJtMDl59rUfP3Eu80JFLapcYe4ewNi44ch3Afh1MkXsJhnpEau38eGuPRNL2RqISk9CLKMzdK5MIeG99IijS7rTPbbf0PUp3nwKibSyJnN7KMvXE4Hn2wrjhrSdt48mmV4BTVmcaxYh+SYZfC7v3vDSEnJCYw5qDQXRufJx86NJIBwyL/KgZt2Wr21X+2T7FZmfOpqONgHkrfVLmiFnlECh4i8TOgjJBeKTQBQXFleIMgkQ+1eCMUinJVhbyE/PAnxt1NRj0+OflBSoq6fM59Un/r+7QsCp5l4qzxaUj6EFumD+3QG85mtzsWz26JYaqAOP0FN0qfhZFyJ/H79Pekqbl9RR0oCtvOQj5GG9GLqCwAb43FoodOKThRENsB1dwfKhJuWn93hIl5mvVGrXlRENEMWEF/sF65+OE9PiA7GlMWfsj9DEO5BR9PpjRbzZWNStv3p6EI5rFqgKm5jo1gwdhyhMUb24vUWwDD7O/bTytpfBJD+Po92uXTgMPTI76e/XYz7O2sHCLEJkEDCFUsUo8aBNuwLhi+yvRdqXCGWP8UBjcT8akpkPuk1PaRRu1GCTy3qjr6+re07aTWSUhxkOQhRGh0fo5C9RlcM+PDRnrDlPm8z/X6e7xUKbGlfYIRJyerRJbym8LdHgptvXHaV4ATZXbilSRtEdkvHATib4qv8vyaoBiQ56XesW8U23gCl+rd+GRmCQtJneJD+XKil3WTaR1uMQrtXtW87HRd0M /CnDc3H4 r3x02jEX53YgMqj7INM9dW5F8ht6AMsjFPJE4XKADkiPZ8u9bHjutHdEkDY82eTKgupwgg8s7omOhfPVbXT4yph+rw40UMGqmNgWio3mt/jxp7tX0NIFMeYQDLxASmmi5Y7e56i2nCN50FLyXPO/nuFqR0P/VsjGwTp+4VI+io2w/PLluqzWob04SIUj+5juGGf6DKiNrCfNYdrI6pIhdT0fxmQODiAsJ2pf/sVt9DZsyMFUzH6kqqD75Tqu3K+OsfIkko+TrIxFH44PsYeF+DEVGr+WH0G8mPFDYL2BOMl8sADSRA/DPdlNityUYzz63QZ0JHTuLftYtqtKVNr7I3xJV7XSXcUn3iQOw54lk1/3MTRedgxzExh8c3c69vu/zbCe8h8ieoYEdGMZkxYzi+X7UfGODK3S3rXoSbpPoIhCwT3rQLr8gI+bFyqjROrHkUszK13XEXMGDG9i+sxyXe0EXzlJpR/eq39QHJXUVKGNUn/s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.004189, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 06, 2024 at 11:06:59AM +0300, Anastasia Belova wrote: > nid may be equal to NUMA_NO_NODE=-1. Prevent accessing node_data > array by invalid index with check for nid. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: e83a437faa62 ("mm/memory_hotplug: introduce "auto-movable" online policy") > Signed-off-by: Anastasia Belova Acked-by: Oscar Salvador Thanks! -- Oscar Salvador SUSE Labs