From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A2CAC27C53 for ; Fri, 7 Jun 2024 07:35:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2DFF6B00A2; Fri, 7 Jun 2024 03:35:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DD826B00A3; Fri, 7 Jun 2024 03:35:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A6176B00A4; Fri, 7 Jun 2024 03:35:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6934B6B00A2 for ; Fri, 7 Jun 2024 03:35:47 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EEEBFC02FB for ; Fri, 7 Jun 2024 07:35:46 +0000 (UTC) X-FDA: 82203283092.20.7271DFA Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf19.hostedemail.com (Postfix) with ESMTP id E1D391A000E for ; Fri, 7 Jun 2024 07:35:44 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kKfXDrAB; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717745745; a=rsa-sha256; cv=none; b=zZOH5eqbYJdPoteqKPo6tND8TP9tCkvrUYPwBtuYUry4tb5I5yEc8ULsBfh19yHEGk2H0y JKremhe+2/AgmHt7bDC6treUY3+YhSaOA6r91kXDAbfybg2rs/GBZHDoaXhhJuEsJ2z4Tz H3nNw+JglehTG0KzWvC74xJloqW0nWE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kKfXDrAB; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717745745; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UB0G+yTK11cXtchE3HFvV6R7iV9GcuEe4F0yviLfHJ0=; b=0xZJve9psEf+ZrOiw1pHtiDHDR09eys7wtTLdwVEUYKzOO5heeaDC6NUx4q9/BLspKOCp+ 92/8fW8SVdnmGRx3q7CinTpnPzZY9pVAzZ6iUz4g9N3doXGPpfgsKM65hF7cnrY9tgFDez H6l2/Suxrigh20B8CJqC6lNdquAfoRA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id EFEE5CE1C8E; Fri, 7 Jun 2024 07:35:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDF0CC2BBFC; Fri, 7 Jun 2024 07:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717745740; bh=Vgz7wuUL+DghEUWcRu+7+7usAd0lv5Kje4fr7ZkUPGE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kKfXDrABEkDwHfu+cwp4UmA0tpvRL7CdW4zj5NN8M+AI0w1gN4EHTD590LJKAbiTl OYQSKJVCcRhmDBJtb9J1Jg3dUXy1w4rf8HJKO/fbC623XGo0l7Ulbl6vd/qLzbyvjR gRhJiLQooI1LAAazLtbEBgiAojcMIsSiX+tkLByo2suXxaAxIgmqlYYrQGXZmcqBQj iQREFbCpT7ezH0g4imxpZY5eEL/pOsklZSm1+gmjDlRYXLxvFboAttXJNewTOOpXyb iLOSi1BAI8lplvPBqCDpy1qrA/I7IE8t2cqCsDfbYtwQWlzme3b+Rfi1Rg19chgrEL h81Sa7M5H9tBw== Date: Fri, 7 Jun 2024 10:33:41 +0300 From: Mike Rapoport To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/mm_init.c: don't initialize page->lru again Message-ID: References: <20240605221436.24627-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240605221436.24627-1-richard.weiyang@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E1D391A000E X-Stat-Signature: uj7b8and7your7idmben6dmmrkebyaq1 X-HE-Tag: 1717745744-836717 X-HE-Meta: U2FsdGVkX19AQ/TyAIem0hUAVVn+QS8IxwyIGffNK5IFaLAHAAUUzBc9lq6Gi4vx3XcexeEZ6npEGb9pDHXSzWBd9y+lxDwckwE30OjgxOfoSS3qJZIJo/rl/2CzO6SpGcmdNn7KdpEIfWM2iBbwiskdx+1dHsryINJ3D/E9A7h9facM7TYok4TfWuyD0lfhNBINTRa0LKwhSZR5brhyz2LUwNeqzzCsuP+8XaZc9GfNLX931OpDLFHdJpq//ZQ6Se/B3adAosgCnJE2fUJLHQT8FxjUZlIh9u6eRKZKFpVV7XW0qp2xlU2VSpo5mK9v/nWct5Ow+08jxT2m+HvEplUb0aY8v1lSo8zwZcUU/9GFdsV9I29MCSSSf7FKvf0LDyzhFUNkZVoEEST13lYYgPmmqVd5g/fzGh0hZ5Gnz2tTVs6VDQBl/hEYwtGcYbi4htfZGqkzwttvhBhQlIQVLs5JeeH0KRZkAoMeIF0W6FHf90n5PEmS7IxvFSqjcCYVjIPIv9vaiGhRhzmlnY0vHt4im+O4MOPCabOuH+DktdO2PAr6fxYoLJ7vkdrDN1L+r8BPRCg46XYaJG9SBJdNdEzOcswOw0gD2n5eDzJxsDkvLpiWA3bCqZ85dA4XDg7q/2mgUh8ZPXqFy3/HfW3QWwMhg2ZMDZNJSo9ljRPzQgGOTfg1b0IMlmJisZpakEIF9kkJxDTZK0pClp1W37X5gOfHK43t40iPIcd8iidPcegBECFpWWKKe9MBqEK9nWzDSz9Hq8qmlsdWNAeE+k6TLIhZa4vOVkv7xBA80XoF8jjw9b4ggn0fiq/ersfwFBkmCfqWpg25c3+8dFtm96ZLVOLnyp5Hg2rx0GGIkkCsucS7crDha5zlL8XmtoPjGqtuYjtHfGryZ7R67RPv+F4nwDZYdKOsnQY+zS7f84mrKuEb05MXHcepHqn5FpQfdEAzzhg7qx/D8vLkBJp1Dyz lv+QTQ57 9tQnI1yetU1Z9uc+G0x8gQcwR5jAexBZ/9HCP4giefxrrl9Apus2W/RKxx1hxhuGeL/jqmXthNaUK6PA/19t1OpF/sJkbr/DJ6AhgtwhjhamxwOyi/DoN5oYq2t0BWs+PHvZvSzAmFokFtPfoiK/ILT1sZMwxfe3jKTukntGhce5g8s75stmErnrbIeM+vDnJ02uurOXLOLK4kooDKHIiNSdd3UAxsCLtRJhR8pUBJQCfy5ReggQSbulNLLUbVZ+ubRAsAIzO62/Uat+/2ege9IWsElhlJJnKHH54uSh4JRb5JW65UHwQOy9h5Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 05, 2024 at 10:14:36PM +0000, Wei Yang wrote: > After init_reserved_page(), we expect __init_single_page() has done its > work to the page, which already initialize page->lru properly. init_reserved_page only available with CONFIG_DEFERRED_STRUCT_PAGE_INIT > We don't need to do it again. > > Signed-off-by: Wei Yang > --- > mm/mm_init.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 14133a1cfc7b..30379b0e7729 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -759,9 +759,6 @@ void __meminit reserve_bootmem_region(phys_addr_t start, > > init_reserved_page(start_pfn, nid); > > - /* Avoid false-positive PageTail() */ > - INIT_LIST_HEAD(&page->lru); > - > /* > * no need for atomic set_bit because the struct > * page is not visible yet so nobody should > -- > 2.34.1 > > -- Sincerely yours, Mike.