From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E762EC27C52 for ; Thu, 6 Jun 2024 19:50:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CAE36B009D; Thu, 6 Jun 2024 15:50:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 473356B009E; Thu, 6 Jun 2024 15:50:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33B226B00A0; Thu, 6 Jun 2024 15:50:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 166056B009D for ; Thu, 6 Jun 2024 15:50:11 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 99D27417E9 for ; Thu, 6 Jun 2024 19:50:10 +0000 (UTC) X-FDA: 82201504980.06.8F350C6 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf16.hostedemail.com (Postfix) with ESMTP id 516D1180023 for ; Thu, 6 Jun 2024 19:50:06 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="YEPP/M/w"; spf=pass (imf16.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717703408; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=55VwDxRaQwcY2yjaV+J1oo7tgR49/bcejsNj/4930JI=; b=RsfVLft83w+xZwvN7iEc65d1Vk2MYdbUtL3sJQb9zZ/fKJTsbo9yZpbS8OyqirxQih2UxF NDv4sEBJMvNJi36yd9041D4tVVZMRorygxAdUz5ZlA6rm0AZeWjHhmeKF/1mfBdS+BTU2i d7YP7H1e6tcbeKSJ+OOLJskjCnTw1/8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="YEPP/M/w"; spf=pass (imf16.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717703408; a=rsa-sha256; cv=none; b=Obw7UuoCFrq7XP4rCF9Fw0i/ybsybyOj8fUznckQnd8w6u7gbzvfOneOzrmsJe/pbKacl3 Uwe/uxQsnej/nAY07aNAVFkmJPmLPOIjHLe1B+8I7+guUBE07PNbtTTdUV3g5w0GjpuN6k ZjicXyGr5kU/Q9jJ02BtpEiieBDv8LI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5F2E9CE1C5E; Thu, 6 Jun 2024 19:50:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA801C2BD10; Thu, 6 Jun 2024 19:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717703400; bh=sKOr9mRXx0a4WKiNAnV+HI3LIk3H9FP9Tw9NowZ77cg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YEPP/M/wak7joAX9X9Mq0XbdUTtgJEbhY2reGlqG5wnJGohVLLTCvQjzvEePy2JSf jPBYbYQvj+y5iwCA3Wwm01rKtv0+SupwHeFtfkWMY3GFaFzuPn2aHfIslfJ6WhF/RW zQwFhzKpXyEO6bok/JMT4j9VrVAxZtE/H6o54KI6grhmvWwOwVBWYRzZiWMX/HFrvE qBY67sr8B6U+O925KEfopMpFjT6MALM/aJ1OM6fYe5CQ7f4Xs7tJUcMLnDBVBU+2Ol 0+CN1XC1WiDb79TzZ8hQVGkDSR1lHQqWvI+lCBtBp7LwMk8PIlblF0fZxcywSAOs26 j0Z3YNG9oo+ew== Date: Thu, 6 Jun 2024 22:48:01 +0300 From: Mike Rapoport To: "Paul E. McKenney" Cc: Jan Beulich , Naresh Kamboju , open list , linux-mm , lkft-triage@lists.linaro.org, Andrew Morton , Dan Carpenter , Arnd Bergmann Subject: Re: x86: WARNING: at mm/memblock.c:1339 memblock_set_node - Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead Message-ID: References: <315d6873-d618-4126-b67a-de62502d7ee2@paulmck-laptop> <7d55b65e-331a-4ce2-8f72-d3c5c9e6eae0@suse.com> <20c484a5-d797-4782-b5b5-bea5fcae9284@paulmck-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: dbjtnr7g9xfgazsssfphbteunpgrh7qk X-Rspamd-Queue-Id: 516D1180023 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717703406-736871 X-HE-Meta: U2FsdGVkX18Fxh6hjmNJ8a/2NvDvrWqDm5hPuGBKUbnHk4PI/EUkzIjDFuB+w9miPhAiZm7b6Lvd85pUcjgZw/pZFOfzZExSRh+lHfLSEvEB1Usg8V6/FgiAqFmGKYC/tZPb0+nMlZWqJ5MnK60wktSSIgR7t/E7Z2RvHgfcNN4GiK4w4a/3GlU4YjAMqT20iS77uzsz5pl5A2hT6GB3Yt1Dc2agZ38rp8rFdYmyuim9xkH4fLPMiEsOf6ahdW+ZNYluR+EFzDxN+b54b4+e9Tq0h2f+ttXBodkDykjFOkyGtIxO5CJLo7TJkfEzmxHSM3bz6viERgdbQxLR3w5cpkWvAQBhSQ4f+/DyTPH2Iu8HoXkK2vlcPnQn/7xLLsgF8LvEhEyEKxHbyZhvVInNSe3oRUiqLTaD1WDH1Sso+prEObbss9boLQ4mIolJnSTRFNsUIXcxRHzxxAm1OYluH7O3dvBuSdwYZ+3k7YmR0VR1RBefBjFu2/RWQskWZ6cc1JuuP0SmlmDNomH3cKzRLPxvX+rguBNbsqP3K8P4URf1AdWL0atc+zc8ISfKKeF6wIgPpP0gyqFxmByk3qqePIYlby8LQSeSNyRDBbW8DfHcsYHHdsDQmzu4LFDHjdSxGjeXS6uiUPG5+QMn12459RUn3cZgPX2ozn0pUQyqB1fykeW8/ACtxglYngfstd6AMXsYaU5x0WJSbX86lqDkvZ/zx9wU1k2PN6+YJba6GndP0Su7l5Ue7utxqErgkT13/it94QXiYyn9bufw10o1nzzJBjNm9YbfxXXoqdO43lEtP7PUkhhf9WdMFNHUrO340swD9KOpPZpWHizViFjbQeRTEP6YbNM8WFN1l9x5I6gp8PqOh/QgD+MV+liKQKk8fGyq2yJ9k4uYAt536KACjnxjmZ6bvES7qrLA7G3MzAMbYq7T47IWwojZELTF9oH9fhNUi/wet4jFX08VryC IY40nlDY 2sGK9E8nolXQJ7z8/Cb317PcCyPq8AgViY70iGiYEzQ6oFMxbAuee6WnWZvnZpY2f7kVPZLvW2dcK1nDikDGfyIXa963avV3L2nRlg0Ey7/HTd+erm1+ECRFZEO49OS1qVUSnlrsBMjnYPjGMD/eqPndfVJFaPw3hRiwWYh9bOpIJvSoC3AcjLgn3PzStJuWGbMUQeDYZ2ONkTyp47OuCjz3YeE3BVZSv3L2SY6ZXW64xCfUWvV9JMRMSB2QyBlnkkm+xZSL4Y/HPcHTgtFqqaKQMt1gPCeN1RWMJyn3uVLZt4IfwQgahAlMaCxK2GsKYcCif9e5LeF2l6b/PcvOwZcaU2jDtFhoWrpVN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 06, 2024 at 11:04:30AM -0700, Paul E. McKenney wrote: > On Thu, Jun 06, 2024 at 07:19:40AM -0700, Paul E. McKenney wrote: > > On Thu, Jun 06, 2024 at 08:13:17AM +0200, Jan Beulich wrote: > > > On 05.06.2024 22:48, Paul E. McKenney wrote: > > > > On Wed, Jun 05, 2024 at 09:46:37PM +0200, Jan Beulich wrote: > > > >> On 05.06.2024 21:07, Paul E. McKenney wrote: > > > >>> On Mon, Jun 03, 2024 at 07:19:21PM +0530, Naresh Kamboju wrote: > > > >>>> The following kernel warnings are noticed on x86 devices while booting > > > >>>> the Linux next-20240603 tag and looks like it is expected to warn users to > > > >>>> use NUMA_NO_NODE instead. > > > >>>> > > > >>>> Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead > > > >>>> > > > >>>> The following config is enabled > > > >>>> CONFIG_NUMA=y > > > >>> > > > >>> I am seeing this as well. Is the following commit premature? > > > >>> > > > >>> e0eec24e2e19 ("memblock: make memblock_set_node() also warn about use of MAX_NUMNODES") > > > >>> > > > >>> Maybe old ACPI tables and device trees need to catch up? > > > >>> > > > >>> Left to myself, I would simply remove the WARN_ON_ONCE() from the above > > > >>> commit, but I would guess that there is a better way. > > > >> > > > >> Well, the warning is issued precisely to make clear that call > > > >> sites need to change. A patch to do so for the two instances > > > >> on x86 that I'm aware of is already pending maintainer approval. > > > > > > > > Could you please point me at that patch so that I can stop repeatedly > > > > reproducing those two particular issues? > > > > > > https://lore.kernel.org/lkml/abadb736-a239-49e4-ab42-ace7acdd4278@suse.com/ > > > > Thank you, Jan! > > > > A quick initial test shows that this clears things up. I have started > > a longer test to check for additional issues. But in the meantime > > for the issues I was already seeing in the initial test: > > > > Tested-by: Paul E. McKenney > > And the longer test ran without errors as well, so again, thank you! > > Any chance of getting this into -next sooner rather than later? Should be there tomorrow. > Thanx, Paul -- Sincerely yours, Mike.