From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F12C1C27C52 for ; Thu, 6 Jun 2024 18:45:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 297196B00B3; Thu, 6 Jun 2024 14:45:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2476B6B00B5; Thu, 6 Jun 2024 14:45:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10EE36B00B7; Thu, 6 Jun 2024 14:45:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DEDAD6B00B3 for ; Thu, 6 Jun 2024 14:45:10 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 95C871A0DF9 for ; Thu, 6 Jun 2024 18:45:10 +0000 (UTC) X-FDA: 82201341180.04.35A1902 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf17.hostedemail.com (Postfix) with ESMTP id 5C39840016 for ; Thu, 6 Jun 2024 18:45:08 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (imf17.hostedemail.com: 192.198.163.11 is neither permitted nor denied by domain of andy.shevchenko@gmail.com) smtp.mailfrom=andy.shevchenko@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717699508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cFD6QTrtu528ZaZy0WO+j3403QPbiz0/KCEAxXHgrDc=; b=aN8WdLCwtoQY/Hx8cfCVPIpTeKlzv4GJfMnEgQioKE/BcDVUchpkemsk30kllXurBOt8qb e+o8nHuruOBFPLAX0U9Fyo6yMUQRwiSwMPPAYRTwndG2B1QqzKoi2uPQp2PpIIS+pqEQrC xzee16jD4T3Jk//dgDIPIxw45h2YTmQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (imf17.hostedemail.com: 192.198.163.11 is neither permitted nor denied by domain of andy.shevchenko@gmail.com) smtp.mailfrom=andy.shevchenko@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717699508; a=rsa-sha256; cv=none; b=68z4H9qq4mp9yUGTb6Ey8tqmfKaHAeCRpik9fJvJINq7+SiuhmSacmSV6opfW76kq4el3O wamF/QMIRutB1cB6rPw8FUbIKPk7sYEFn9dJP+bjgDQ7tE5b1TZF9RrsqCb+3Bs4Dmrg+M EWfRjAewCECom4zryUVltr1vUjfbhfU= X-CSE-ConnectionGUID: 4/fVTYdNRtS7ZVrMuF1Puw== X-CSE-MsgGUID: NDrNVvWyRaWzkwaIgR1eBw== X-IronPort-AV: E=McAfee;i="6600,9927,11095"; a="25023460" X-IronPort-AV: E=Sophos;i="6.08,219,1712646000"; d="scan'208";a="25023460" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2024 11:45:07 -0700 X-CSE-ConnectionGUID: 0wYlbXFhQG2/L17ed08ZhQ== X-CSE-MsgGUID: 4O166ereS/KuAx73cRovBg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,219,1712646000"; d="scan'208";a="61271546" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2024 11:45:05 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1sFI6g-0000000EHbk-0qde; Thu, 06 Jun 2024 21:45:02 +0300 Date: Thu, 6 Jun 2024 21:45:01 +0300 From: Andy Shevchenko To: Kees Cook Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, akpm@linux-foundation.org, Jean-Philippe Brucker , linux-tegra@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/util: Swap kmemdup_array() arguments Message-ID: References: <20240606144608.97817-2-jean-philippe@linaro.org> <171768935175.54606.14878127902164737048.b4-ty@kernel.org> <202406061046.A2137C9@keescook> <202406061108.1D3E64882@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <202406061108.1D3E64882@keescook> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Queue-Id: 5C39840016 X-Stat-Signature: mrt6emq38eme7p7ww16dbzwr5i5cdczx X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717699508-86269 X-HE-Meta: U2FsdGVkX19UOFyu4UtoZDzSjpyxptWa+wuVU594urr3XBpI4yKGAnjDwuhY6wa4ZjhbWjPA7WJX9rS/VmO9QT6kmTe3LFYjTEYWNn3T7lNYiKixBVrkZ3p58T+5vPfzX/5L0cNnSTFKeOgSRIua2i8aB255fBGEPHH5u53cZk2Jf2rLNGuC1nAf8PXBqL8RA6n0AVHm2eSF/ntThqbeoBHwHicP/H1jOx7jmFLxHV9Tthns1V2T7FCmMMSvnX5/awGrOh0FToZ1ES9iMTmaN76o0T3W/ygLXX2zlybWz7eJS+UsWT8ppDorFYf5TjZrE83E1xyCE5BEYsbsZzxAxzOwth9NWq0QR7mWHX3ZmU97BLh8jGE+45gsJVwn+iRaatdAqMTth6zO5tSXzYvMq4aUdSNkmSMTCtYiPBVhR9FLP5sCEj0Ouaov4MI3/o0P8MjeGa41JFwHiMfOSkVUrDiMMTqv5osszxsx6DhLdQhA6AlDhH6a898pmKMo9RrNjNBiQQbz3Irb2y54sH5he6tnFIRDmXL1OCKbQNUYnEKSM8Mgh6JH4GrCYDotDEIrHk3kS73pLFHdwH5hACa6HAuDgTXLwJ3Cuu3FoiAFnw8S0DFJM/ppV+VBJM4qbq9tqipNRQMsTHjnQHeWpBdgsaXi1s6YmlazAgy++hRqB+4jO902GJ8BKFTQtUev/oL8oWh4nXNnENfQE1Nd3dJX1NEHiGUaCUWmqHl1qUiQD6hq5lt6ZQjPbVkc0IkLr5bnSQNYG7nkK5ekxb2aHO+nvjiYSSjwg7JJPO2wsCPJhuPCtevc9yUJsLrTOLdzuFUvl8anMmaysQMQK0SMJhJ3mIMRvMQuN4e0NEmlDhehOqW8z0CyjZ920oLsXLWyk7n36yJjgbCIBT6ddtFSi6I6YU50zgAnu5eSva0hv+AKml2JA+XfXxv22QaSo4y76EyYUziDZE4m62UyWZP0E1h 1vtOK+sD gyV47uJg6MCFLhJ9GAfLZVOZ3FJLFwcsTnTWoUWEet+Vt8Xog7jAcyiqOsMWI6ghOO6RKfcP4tx+ofEJ5Yaz08efyD0XJ6n0QTieE7DbpOyN+q4tFyKAPhVA0rdxtq/MVk2vsaSv1UHrJfO6/X3/XQNJvjYmorBJrN/K0OzDZXVvdyZs5NZD/oL4XEB3RAEVWh3rgYHiMaK0C9NCis2CNIvjBHLu7z3TV/KGycTkg8MAHQmkOgK0FH2JWIYFTmU0nl/IxJJGRi5xOkyj7YYMqbvFnROq9FWuWmSGDGYvWuSyBG5fnY0pKqCZm0wM2de4ldC7jZNFt6RuvjEks4Qi/Hh6YuRpaxX+hA8VwRWRHaxqSfAMphFOt5IcjDjhZxWFsdXmknPo72vYpmBR7ijc7ae1rvYlw2MUGQfCHeTJb6R0rUDzItYI0yIKd5UvMl62A8Tyv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 06, 2024 at 11:10:43AM -0700, Kees Cook wrote: > On Thu, Jun 06, 2024 at 08:48:37PM +0300, Andy Shevchenko wrote: > > On Thu, Jun 6, 2024 at 8:46 PM Kees Cook wrote: > > > > > > On Thu, Jun 06, 2024 at 08:35:13PM +0300, Andy Shevchenko wrote: > > > > On Thu, Jun 6, 2024 at 6:56 PM Kees Cook wrote: > > > > > On Thu, 06 Jun 2024 15:46:09 +0100, Jean-Philippe Brucker wrote: > > > > > > > > [...] > > > > > > > > > Applied to for-next/hardening, thanks! > > > > > > > > Btw, is it possible to get this for v6.10, so we may start enabling it > > > > for others? > > > > > > Which others do you mean? > > > > There are a lot of users of kmemdup(x*y) which I want to convert > > sooner than later to kmemdup_array(x,y). > > Ah-ha, I see what you mean. Well, I'm not sure we can do v6.10 for this > because rc2 is behind us, and that's what most subsystems merge to. I > can land the patch for rc3 so there will be no warnings in Linus's > tree/-next, but conversions in subsystem trees will gain warnings, I > think... I see, but v6.10-rc3 is still better than v6.11-rc1. Some of the subsystems are okay to merge rcX to their for-next if needed. -- With Best Regards, Andy Shevchenko