From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3160AC27C53 for ; Wed, 5 Jun 2024 22:45:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD55D6B00A4; Wed, 5 Jun 2024 18:45:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A85566B00AB; Wed, 5 Jun 2024 18:45:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 926546B00AC; Wed, 5 Jun 2024 18:45:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 721AB6B00A4 for ; Wed, 5 Jun 2024 18:45:21 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1A53A160BC8 for ; Wed, 5 Jun 2024 22:45:21 +0000 (UTC) X-FDA: 82198317642.16.4E1E5FD Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 42CF8C001E for ; Wed, 5 Jun 2024 22:45:19 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Yykds7zA; spf=pass (imf22.hostedemail.com: domain of cmllamas@google.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=cmllamas@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717627519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WFSJCEy6u4uqWSm/uIbCw8MODebn4cqaARhTPhnxhUo=; b=2VhJefnwmrjoaX/iMA3qyrZL+sEew4EEmEfUROBF8aeC5N1C+G1BarlpLqGKFcRBTcSbJ0 7l8acMDY+jawy7S3Q2RWbNA6cC0nvxBbwxHIyPqYzudLZQm2oddAURvPb7t2eiq252iX/4 2FO0WsVM50W2A15pMKh/tLnvWxHtRRA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Yykds7zA; spf=pass (imf22.hostedemail.com: domain of cmllamas@google.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=cmllamas@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717627519; a=rsa-sha256; cv=none; b=2kJ+I5rLneshyoKiBoYmwaOyLu0rQIhqP/wFyiZi/MQpDNtfz+Re6zTVhGk1McFNxZpSYD pHEoz3wBLY7GxZoChRlQut07skri23sGFYlhEYSdLFuq52SHeVTlNKvEywttrti2ZVEzEh 6NmstLBiW6ILYVI6StA0SbGtRvuJSbA= Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-70255d5ddc7so275118b3a.3 for ; Wed, 05 Jun 2024 15:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1717627518; x=1718232318; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WFSJCEy6u4uqWSm/uIbCw8MODebn4cqaARhTPhnxhUo=; b=Yykds7zAc2dXF2Nmgr7F0FuGXV6Kb/wF2R+GXUdYa0K4zTrYevpvXyzsa/ai6nC1U0 4wmKBU04ce5jj2RbdxS3+LXrIaVZUQVi4TY7TxTU9ACeM+AVEmRx9L18xei6gIEe1zwv fsTqlDJiSWug6Z8ssej/NtXrjDSx8pwCJSDqhXs+LpRnfJHedDuCnp1KmIcO3ejRVNmE RoXh6/rJRbGx5XLjFbqnSfKm8sukr/sRu9rj/SkSGv5ZLOWnn92vhX+lRNmGPDG7U/FL fCUiizIB5DEumfut1qpuiepY82y6E+dgfhaMMeC+9LvoHfPZ+T2d1h3j1Uf+WhEp4UPE se2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717627518; x=1718232318; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WFSJCEy6u4uqWSm/uIbCw8MODebn4cqaARhTPhnxhUo=; b=h5Kisc6wcoMOT+MVPO0tvUKb5rVH+aHR8FhZNI5suwZXxI8VS1NO4vxHAkB4Ka6nLB Ayx5oqtKuaV/n5VmFUDUYw+Y+kpGeoJwA+ealJcBNvTmloAmrMQT+PWby4kHvuYjBJQ4 zT5ZTFb0tDphgGWlVSENCRakc8qTlW5lr5X5ljYhTnJl5w0M4M0C+7LI6/82zvXpuq9d 6FptjkCPdkjeR62VOwSVwJct99ZSNIjFQeH5vRV5cK8Eg+KyuGNUcIbdHoBBx9XZuQPq b/IWJCrxrwQbL75e6f7P8e99WOfjjgzvVd+SsMvCzGSvVLQTQMH7vnFC5U1e9LbbrMPv zAtA== X-Forwarded-Encrypted: i=1; AJvYcCXQa5Ok8iz5a3dG74eI8Pwk8XNbdIB3dnUS3xM9BdiaEOqmgxkRurCag51kK+tlps2DT9ru4uMxZikmrFHyS0mHxrU= X-Gm-Message-State: AOJu0YxrA9Q6boBeJwQX3Ku87Th2ZVL7S0qhgYe4y69HFcO8JXaep3C0 WCLF+HEW2VelNfrh3CoW0ibPSlmFvoRRRusNWYMn1hTGivU55GlHR4KlIdD8kg== X-Google-Smtp-Source: AGHT+IFjCDvYFFF2wgJdE13PmmXi1cL2xUEC6TiDuuPu1y0FqnGaQUW2DXAfSAA3tRUDfbCP/YT6+g== X-Received: by 2002:a05:6a20:2590:b0:1af:d4dd:65e5 with SMTP id adf61e73a8af0-1b2b6f94b13mr4916867637.21.1717627517578; Wed, 05 Jun 2024 15:45:17 -0700 (PDT) Received: from google.com (226.75.127.34.bc.googleusercontent.com. [34.127.75.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-703fd4f8847sm16039b3a.171.2024.06.05.15.45.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 15:45:17 -0700 (PDT) Date: Wed, 5 Jun 2024 22:45:13 +0000 From: Carlos Llamas To: Edward Liaw Cc: shuah@kernel.org, Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Andrew Morton , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, llvm@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH v1 1/2] selftests/mm: Include linux/mman.h Message-ID: References: <20240605223637.1374969-1-edliaw@google.com> <20240605223637.1374969-2-edliaw@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240605223637.1374969-2-edliaw@google.com> X-Stat-Signature: ogtcps41saoia69a17caefyd89qymme5 X-Rspamd-Queue-Id: 42CF8C001E X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717627519-697432 X-HE-Meta: U2FsdGVkX19ks8FDwhofnIBNp4bHrR2hgWtcpQyQTHPKu343rj+Gq97IqYjaEhqc5afFIoRVm03bwns+k7YImD6LXVeCIc8uSwHl3cVk9s8x2dwZP9meYHKB7N8McT3TT31M9RIZwt1wN5YLIG8o2HM5Jf2t/79s6OQnSAU9jEyY5S8iGO7Aw7+Z2YHq4iCGxI7ICpnUnCoQMedjBJ7V7JH1E62Pv5FZINNDjIoiPMjzigp/3P7cp2A1/4GTcywitEdY1zuMw1MhfzuNLFKsoSxxSC0fLlnwUzh2SFfi+YSQxJ5dofwX32WjAYTKuXSF+yrg1v4qr47oIKIUFyRdIOqZmhKuImFdMEhoneKnpjA4V4Z8uQENBJPfMDk8hBuwBrYP1rlzgtd8LLPBQn4id0wbicmvY85cCCO+w+7IKtuH7U1gh7uMkfi+1aWMAFJqu7KKJc3+abfqNR3u06nuLWzmzHFjmD/BTUv1Bqsn01I+QnmINDsIgc8atTVJ9Wk1j3XZyphg6Tg1IsuYNMOAaYWKadc73FedaMjEQNY83JUw2Jy2VAvoRAwGq4kpPr3LqonnrdpXK0RKxjm2IrcgWHuFUgH0D9Hv+mNcrPUgzbhIx5yA0iH3evLLnBWSbbds+hVJCCm82ucSRbLMp1bjzpjKnHBQELMfH9p1AvcioEtm98iwhoOG9kKloGlFEfjI6YTuBVrhBML/4HddfY9owBLcKr6klV4H3X2pQ2qJM+/JQPvk1kJmNksP1icu56G3Tx5m8OSqlAY0XfKYM6u45olQOqD0ILqcRHAQCLC08Q0IHXRQJixJYB3XkBXPt8wvzkfiFGC38ofs3j2Dw4wrsK+nRZe9H6LWGZeKRTnoDkvREGi6ydWmtnrR9hK5vP8i3EFMedUKDkyGkTWCS7eOenaltRSUrCVZOxLfijsGJw6ChDQOQwVHiFqhRx0Pq6rtH7Euc7pa6HY3lAWAiQj tG+j97KP ZM1vuGp0fpsvJNIVJwlUOMOY4IA9vWu68eE2wvpJL37OInhCLMVqixXG2lOCrGE4CUB/OBjvNCL7qknEpAGmXp8LsbYQ7jny1kchlYvHNKGbgZAWYoX1ejl9ykTvGCJI8dEOYK00UAft7ZNqOTu7T1twNdWGwYajLhbcdQvOyS8kBD45Hbh2ioqT/+248772wVNRzct9oCBnU66gN54LtsdrYXnHhz7eV8hjFOF1hXkFuwlDsvKKwvMWSHt/61X8nC+hark4j9HXStqHGQGXTEjatjnp59ssQD/oYIWoTqo3or2P42gM1qd1xKvegCovBKoNex+eCeSQ9SfoIU0DOT/eXBMr9pxEF0GOjlgrNZm3ROIOIN0+zCtTlsXw8Z5Q3JnrN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000037, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 05, 2024 at 10:36:34PM +0000, Edward Liaw wrote: > thuge-gen defines MAP_HUGE_* macros that are provided by linux/mman.h > since 4.15. Removes the macros and includes linux/mman.h instead. > > Signed-off-by: Edward Liaw > --- > tools/testing/selftests/mm/thuge-gen.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/mm/thuge-gen.c b/tools/testing/selftests/mm/thuge-gen.c > index ea7fd8fe2876..034635317935 100644 > --- a/tools/testing/selftests/mm/thuge-gen.c > +++ b/tools/testing/selftests/mm/thuge-gen.c > @@ -15,6 +15,7 @@ > > #define _GNU_SOURCE 1 > #include > +#include > #include > #include > #include > @@ -28,10 +29,6 @@ > #include "vm_util.h" > #include "../kselftest.h" > > -#define MAP_HUGE_2MB (21 << MAP_HUGE_SHIFT) > -#define MAP_HUGE_1GB (30 << MAP_HUGE_SHIFT) > -#define MAP_HUGE_SHIFT 26 > -#define MAP_HUGE_MASK 0x3f > #if !defined(MAP_HUGETLB) > #define MAP_HUGETLB 0x40000 > #endif > -- > 2.45.1.467.gbab1589fc0-goog > This makes sense to me, particularly when other mm selftests are using the same include pattern. Reviewed-by: Carlos Llamas