From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F295CC27C4F for ; Sat, 15 Jun 2024 08:26:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EBC16B0130; Sat, 15 Jun 2024 04:20:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89B1D6B0143; Sat, 15 Jun 2024 04:20:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 763106B0147; Sat, 15 Jun 2024 04:20:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 587D56B0130 for ; Sat, 15 Jun 2024 04:20:01 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 02EDF1A0B41 for ; Sat, 15 Jun 2024 08:20:00 +0000 (UTC) X-FDA: 82232425002.30.348F6CF Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf05.hostedemail.com (Postfix) with ESMTP id E73A910001A for ; Sat, 15 Jun 2024 08:19:57 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sXYRtG1F; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718439597; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/C1OaMkMUNqGrbXHszRG2oF48V9vjQjXgd5y9/cMqtE=; b=Yq+/AuXlff7WpdytXjS9uYK+evNWKL6+0BaLJCPEWVBtQsZ1cX/CJqdlA4QMtwDgQZJt5k /qdVGYPwnYOxsW6MQkdJ2gol2oEDtZUoaa84zvRrb30gUzNyLsrE2Tzdrjf7L2OIIzm/A0 aXFKdrYJ+GpBhcC45TiFZFz3qKxvLVI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sXYRtG1F; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718439597; a=rsa-sha256; cv=none; b=2kNv/wOCPuYHH34+HpeG/hf04vrZ4p6oIHO6LeNgmBh8NpwQOg3ateKDOuVS29/6C2oIcx OG6fsHsR3iRiU+40CIPnD1Uglp8Ovnndc+YqBG18NFJpb8XrK0jelYeunjWt9bl5ODA8gf VN7AAU3cHigq3riOOF1dbMQk3KaXxwk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 07104CE059D; Sat, 15 Jun 2024 08:19:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92EDEC116B1; Sat, 15 Jun 2024 08:19:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718439593; bh=kP5jMFr8uFhLgCSpDSobxyBlrDXjZxRM7l38OANEgkc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sXYRtG1F6xZqXEPtpeDfbfD6HMH55I9azpupHA0S82GojDFHKy3nMxRT3jRZ9uM/A Ay//zAO5Z4D2FO4fhvz7G4nCMRWLTd4InV/qmLPhYxjDd3tiBSYbIT7bxxU+N/wfxA rY2uuf8ox4oXYeYkcaeDBy5//PkQvAVcUd3koJan6k0ESm3IaOUU9+S2M01t4kO8W6 6KRSc8fOSHBDn1KBuRwY+tf8i4xCtn3KnWqK56oR+U7CzXNKeSpAKU5Z16lyoJ9cyF I/l1lJ52hTtechVDegX0bffTpj2B9SXzjFJmfcAfZptFy6ttxftnj478ed2HDIkom4 HQc9R2Kn9nzmw== Date: Sat, 15 Jun 2024 11:17:39 +0300 From: Mike Rapoport To: Wei Yang Cc: richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, linux-um@lists.infradead.org, linux-mm@kvack.org, Jeff Dike , Paolo 'Blaisorblade' Giarrusso , Alasdair G Kergon , Andrew Morton , David Hildenbrand Subject: Re: [PATCH v2] um/mm: remove redundant assignment of max_low_pfn Message-ID: References: <20240615034150.2958-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240615034150.2958-1-richard.weiyang@gmail.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: E73A910001A X-Stat-Signature: ftym93e89spuozrh9x7s8wdktjn134ik X-HE-Tag: 1718439597-799942 X-HE-Meta: U2FsdGVkX1/PdcdgFO23CN+LTaU2K3SyqIZYmIO8qu8UMzcMSghQ503yb0pA3lG4hdIfRCzTEidzaJjQo4UKVh7b3AegNgfxufw78ZBdan6f+UMWI7ygQey6Hhvxt6CZbB/EORLeNb5sW4WRPFfcsU3QGSn2KFrJvNLi+N+0yDwJWDzBEZmoDBFnCRa51ylYYO6ESHcZrzk45Y8XhHyBWzN30pl12HVhi1ddq5+pavmHWBqYBKcs2/XPjMQyd3vwOWVkRKz76G3hmXZ14vw9PoNG5mZ9WTzNrPxz2JJ1s/SjDfjjzWTItkeGSYAivjhSbZ7OfwxfQpItOsJeKchF0w0JI+qokI8Fl1o8LoNfEoxj6RRJMATw+4A6b8yVhn5T0P7wgfqR0BUWkL8XhzEGDDLE78eVbbrMQ7VHxdXmQ/jU8AAUfIvPTXvgDSx+ZxZowBf2V0rks+IpBms+lUCZCrVCmkR+9T/TuSk+yDKx9p6ap7tROYfUORzx/gTzRLxO4uD/ncLbhgIIG+R3saY11f4oMj+CkoW4Y65BTqLfncCXtmI+7skdkyqj0xx03kjCgRtMm2fRpu9sqGsV+3nx4Se7giAJuqd2hgVlsJYNqYFIyBRgoKksIPfsDj99hb7tCnrY9TaAG+cpx01394+7VAH0oljE3YPAaT5estwtE3fzKubfbeoZBsAvzPYdKVcBNvZZhXmjd21pGwF8uw8OZmmmgQgp0jh5y5yPfjTolt8+gBuHrHWVPykxbsdxNQW4oKr+xUEmvuiePJlYofBFxUmXlzzAvxhtM/EI3bE2deSkZ30n+gJdg+ItOJDHRHV7N38KRW82HBibTyMfFnpCdP8JG97uv7gpe/WZFjETlofMOXkEsvhUPlHDXJ6k6GfF+dfynNuiH+EhjHjL0ZV4o7+/mLaH6V+8iCW9mp4TFbW0tg8vaI8UKiQhIlaoaxFEtLMQnVln3i+NMi3NBDq EhDt2/Iz pL2u/Ho3pPABYucqNccW2sfmhNJ3WkBJ50rfTPpTt2JStSvJjiLFmIct/4Ijwq162CtTw4kQ2Sf3uIze1vcknLew2y2kAnR+IedLTxAdHJO+xvJjyLpB91sBJi2kmhYGckSKxmgRRifq41lNqmKiN+yrApyIhHL26UL3/r5ZPzL6qgTwSkj0Vt3GJuEAbPeKWGOqnDjoAjI1Z3B6gztDZnyX2qHaEwa1yz7c4yxp8TiGG9ZXrj0BQX2PJh+GFWpaJCPl5h87l6p3DeUKxdbVa4HuB6termbSUx9XviOfkN1di/eYZYy0rekXl2N8sye5I6f/4kxJYLdzYpkj+7WLEpXIbDIrt6SS1ftwg1RsQcL69N+av9kfwGXMHdheu7Jj8386LW9jnhjJrvO8p7MkbYkk9qO3lwv13+Z7tB+mYGMsEyQpsNZtF9Yb4/G1he7MymL5NqKIw+9T+S4yXCCoqdnGXx7anq/hK0lxo4SRSP+0ZlwMTy9dZkoUHS5Yy4bHNbka9VUxttvLELpc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 15, 2024 at 03:41:50AM +0000, Wei Yang wrote: > Current calculation of max_low_pfn is introduced in commit af84eab20891 > ("[PATCH] uml: fix LVM crash"). It is intended to set max_low_pfn to the > same value as max_pfn. > > But I am not sure why the max_pfn is set to totalram_pages, which > represents the number of usable pages in system instead of an absolute > page frame number. (The change history stops there.) > > While we have already calculate it in setup_physmem(), so not necessary > to do it again. > > Also this would help changing totalram_pages accounting, since we plan > to move the accounting into __free_pages_core(). With this change, > totalram_pages may not represent the total usable pages at this point, > since some pages would be deferred initialized. > > Signed-off-by: Wei Yang > CC: Jeff Dike > Cc: Paolo 'Blaisorblade' Giarrusso > Cc: Alasdair G Kergon > CC: Andrew Morton > CC: Mike Rapoport (IBM) > CC: David Hildenbrand Acked-by: Mike Rapoport (IBM) > --- > v2: remove redundant assignment of max_low_pfn > --- > arch/um/kernel/mem.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/um/kernel/mem.c b/arch/um/kernel/mem.c > index ca91accd64fc..a5b4fe2ad931 100644 > --- a/arch/um/kernel/mem.c > +++ b/arch/um/kernel/mem.c > @@ -73,7 +73,6 @@ void __init mem_init(void) > > /* this will put all low memory onto the freelists */ > memblock_free_all(); > - max_low_pfn = totalram_pages(); > max_pfn = max_low_pfn; > kmalloc_ok = 1; > } > -- > 2.34.1 > -- Sincerely yours, Mike.