From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC85C27C53 for ; Mon, 17 Jun 2024 01:29:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCDD06B0123; Sun, 16 Jun 2024 21:29:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7CD56B0125; Sun, 16 Jun 2024 21:29:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A44776B0126; Sun, 16 Jun 2024 21:29:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 871476B0123 for ; Sun, 16 Jun 2024 21:29:49 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EA86EA1304 for ; Mon, 17 Jun 2024 01:29:48 +0000 (UTC) X-FDA: 82238648856.11.1EB6636 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf22.hostedemail.com (Postfix) with ESMTP id EC0AEC0008 for ; Mon, 17 Jun 2024 01:29:46 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=AjtKuRES; spf=pass (imf22.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718587781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bqgWAO4mCWwupa+lR9NOrzfPSBggKHunYbwtSEV5JoQ=; b=N+RignW0zwj+NTpO07Whfj2Z9ZMzEYPhqETT0AEdeTJ7Mes5/7CAU4HIfcfyxJVTuAG5uX hubMr6+VpW8LA/OPdP73lMJabByJm7M6wy478rRTG/97IG2Hpiaaah3oUhZiL1v83borlx V1Mj3uLZfIytj/kJtEhGRoX4tDvAcJU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718587781; a=rsa-sha256; cv=none; b=ArOBpXPJ/0tJahZ4qvdXgNWsyATuq32ciIEqOFWhllRF6Aoyt8EYytZ5kPxiqzzRd5f/Dy poJih1gvcptMMYtJQMoPElrsp+fu0goAyVOolLj5/4lY//2PKJQACsjA/jXgHbpSl2bgl5 2WTzcYEUFDvcW2gnrY90+9Q998CWhsE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=AjtKuRES; spf=pass (imf22.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1f6c7cdec83so34199815ad.0 for ; Sun, 16 Jun 2024 18:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1718587786; x=1719192586; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bqgWAO4mCWwupa+lR9NOrzfPSBggKHunYbwtSEV5JoQ=; b=AjtKuRESYMVBuF6U5Bgp/4JGWOCOPKEy8S9mJJf3ooEgEp3Mig9NwU+vFywEm1XVjn 352+noiNmSPNLzuuR4eXL2D1M4wwjUDDN1kaA7p8AYMght9lbie5aD/amKQVfQ7INymH e3WEQQ+AI2vbsLRkh+ZV1/Vx2/5RbNWSPKP+iOr8wuWeOnnJAZhMRCAWQq6DSsmwr0/v sW8HjA1BuzKGESEwiYmVJ5nlvSUiJBtkJMERDnx5COXZvKT6Ht/CI9Fu4PiQZLmb3ZkC ttBWyUXCdeVNylH2IKHefWsibO17+mL+LVHGRk4tvIORE08o/4amAA2GG04wtnVmTWSe Yeag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718587786; x=1719192586; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bqgWAO4mCWwupa+lR9NOrzfPSBggKHunYbwtSEV5JoQ=; b=Be80umsZagSv7TrbS/UukvcJl6BKnSUA5JpZgSuPKViSDsVnhNxUp82VAmfgvOQswM BOY6J9NU7pts3J3hRtKOS97dYGS9DKsyxoT4gq3GuIiVn8RvlUgwZNcqWJ/tS7ZnvBtH kwvQpIZkFtIQ3h9ZrsZbSBHtWI7YulY9n/MGeS67554ZKyEgpFYO9Jsy+u1KPp/AO7RX 4rwjTPhx2ygMYu3O5Mr1sSoJs3Fxjo/SBooyXFonGEFm4fv5FlZJzSysZIeE9ykWaZ8w HxRlimwqjNK73FjZMG73zIqVeCifY9oyWEFzcmfYJo25FCC+OU6TGAtiRdYA+79Jlug5 j73g== X-Forwarded-Encrypted: i=1; AJvYcCWhJ0hnmU8TnEr2et48NbnUnksHVPtQ4jtw0BfxG/4t2OqMdI55vZGGLHQc3vf4Ob/UdJPk0n94W3y0W21GY74b6Ms= X-Gm-Message-State: AOJu0YxbO4PPWvOK9JDBuZGae9rdG4dII/+21tMKVWaGS5W0APATbodN a9To+Mftv6e7PE3xVpbMu/vgImhiTZANHpl+XqJBwrGA7Bek7s+K/wBHXILlIdU= X-Google-Smtp-Source: AGHT+IH2yamUY2L+mg2sDf6W0MYe+fr1/6bICbKfZYn/cmrt+tr3TvVUeXggb8kPWxWwSK9lWhE1Zw== X-Received: by 2002:a17:902:e88a:b0:1f6:d368:7dd7 with SMTP id d9443c01a7336-1f862b155e2mr101843335ad.45.1718587785415; Sun, 16 Jun 2024 18:29:45 -0700 (PDT) Received: from dread.disaster.area (pa49-179-32-121.pa.nsw.optusnet.com.au. [49.179.32.121]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855ee80fesm69659525ad.124.2024.06.16.18.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jun 2024 18:29:44 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1sJ1Bm-00124e-1P; Mon, 17 Jun 2024 11:29:42 +1000 Date: Mon, 17 Jun 2024 11:29:42 +1000 From: Dave Chinner To: Christoph Hellwig Cc: "Pankaj Raghav (Samsung)" , djwong@kernel.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, willy@infradead.org, mcgrof@kernel.org, linux-mm@kvack.org, hare@suse.de, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, Zi Yan , linux-xfs@vger.kernel.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, john.g.garry@oracle.com Subject: Re: [PATCH v7 11/11] xfs: enable block size larger than page size support Message-ID: References: <20240607145902.1137853-1-kernel@pankajraghav.com> <20240607145902.1137853-12-kernel@pankajraghav.com> <20240613084725.GC23371@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240613084725.GC23371@lst.de> X-Stat-Signature: ybczs3dnwpu4d534mw6wmban65cbh9bm X-Rspamd-Queue-Id: EC0AEC0008 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1718587786-634044 X-HE-Meta: U2FsdGVkX19pPE6oe/7Y6cx81UotBkQJu+ToTGetGwx5eYvfhl8DLchdlWSK0G9vET+063JdBtNs+pJ3kli2zJlDbjCSE5gFXeRLcQQh7i5e278BpCoryoihSVuVWj26xTZBUFxZwCcPRivtHL9OF06A7PEcC2aQc14/hnIPKXMR15scM4+goLP59KCp4SysLz53bkTl4qqfq2lyJ6hDZJeijSBcdeIbf6HWvQwM+VAcIjTthzNIS6knE3PerqYNRGQVe8nrxXKRC6caqDV83KpIWkcxlLGICGbp3eOWFNszTrA5pFLoexS9sHs+uQ/quq+2KYlwAz4gbw/06wqCZwz8+UaC1xl/ZX03SVter0XPXIx0Y9c6HPJWSx3sQloCgfBErLHFmYBLz5x0sPWwVSAXr93W5Vx97kBwrDGk78YU5flyOWsmeraS0qF4LPq8gruGobrOnaQiyZVjl0OJLmwycv0A3wZ1NFogiuMYXj9SHOT/u6vLHAnzJqbzlY08V8UObFcQrFNjZOtKjYipDHd68SyvzJaz8miYuZY8Tv50yxK5P5DKA7c9THMdoPWnG6ytDyd9hJggcL+SuOb1vBAC4D6pf8ps+Ey4vP9D19k9V0IgQLF6R09nlrslg63JIkbSqaEWSw/r+QEZyqusnBMA4IdzwgbzycsKm/+H2ggcJiG7WMvUH1Ul8Jg7Whjmm1d0K+USdyi6JWUltP0Att8MRdVXhZH2zi+PJiHNtB+m/jqDylFOOCUNyLl5nMa04gytI5k3G932O2fM2Tnaz8NbGF7U2hrREe9+o7Qo0dfI9PxKuF2WvgPhle0fqZyD58zghlXLWo6s0sBbo8cwVyt6PckuxC/01NsS1OVh5WDhEbSMWqd0shJe3TXay3twPhMH5cWuw4DTVDXVTiUCoBDvO3mXWGMZHJdq8xOgFXXupVbF0jeRn97G8iMumSXCIWEnTyLc1jgdAMFhjzQ E5M+tnTn b8qecLCV9VuCZ7GoTaYgYp+pF00FaiSSLOynDtYiq0ohM/PCEpINFd0ccOHW/NF/nl9ivgBpAyxUIe8DYnqkvntS/Os8dxSitPGQV7Kr2Z52T8HrikMgUW4t7THOloVUNeQaCwhwQwrmscU5aEMb6x/wcMDidQS9zCa5ZUPyeIxWxwIHje/Ijlw/Wso8lIg1BmEXwfYXkgfSgJjl+Sj6/CdfKdz2fnuyoTmUfKPe28cqhX4+Hvt0KXCng369SJaE56qMKt5kzLoJPSE3SZJ5+ylyXwQgVllWZqxrdM9+A7tVGjacTblShW7fzr2NsvBq6LSyeTDHWshImyf7xTox+eA8ewGY/ZD3gIM05138PVmPdboTDMbXIm2riV3kztZtsG2Huhzpw0oDTq2I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 13, 2024 at 10:47:25AM +0200, Christoph Hellwig wrote: > On Fri, Jun 07, 2024 at 02:59:02PM +0000, Pankaj Raghav (Samsung) wrote: > > --- a/fs/xfs/libxfs/xfs_ialloc.c > > +++ b/fs/xfs/libxfs/xfs_ialloc.c > > @@ -3019,6 +3019,11 @@ xfs_ialloc_setup_geometry( > > igeo->ialloc_align = mp->m_dalign; > > else > > igeo->ialloc_align = 0; > > + > > + if (mp->m_sb.sb_blocksize > PAGE_SIZE) > > + igeo->min_folio_order = mp->m_sb.sb_blocklog - PAGE_SHIFT; > > + else > > + igeo->min_folio_order = 0; > > } > > The minimum folio order isn't really part of the inode (allocation) > geometry, is it? I suggested it last time around instead of calculating the same constant on every inode allocation. We're already storing in-memory strunct xfs_inode allocation init values in this structure. e.g. in xfs_inode_alloc() we see things like this: ip->i_diflags2 = mp->m_ino_geo.new_diflags2; So that we only calculate the default values for the filesystem once instead of on every inode allocation. This isn't unreasonable because xfs_inode_alloc() is a fairly hot path. The only other place we might store it is the struct xfs_mount, but given all the inode allocation constants are already in the embedded mp->m_ino_geo structure, it just seems like a much better idea to put it will all the other inode allocation constants than dump it randomly into the struct xfs_mount.... -Dave. -- Dave Chinner david@fromorbit.com