From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE719C25B74 for ; Sun, 2 Jun 2024 17:43:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3215E6B00B1; Sun, 2 Jun 2024 13:43:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D0AF6B00B2; Sun, 2 Jun 2024 13:43:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 198996B00B3; Sun, 2 Jun 2024 13:43:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EF68F6B00B1 for ; Sun, 2 Jun 2024 13:43:47 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8ED1DA18E7 for ; Sun, 2 Jun 2024 17:43:47 +0000 (UTC) X-FDA: 82186671294.26.4BAF7E2 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf13.hostedemail.com (Postfix) with ESMTP id C47E32000C for ; Sun, 2 Jun 2024 17:43:45 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QXephPkx; spf=pass (imf13.hostedemail.com: domain of visitorckw@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=visitorckw@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717350225; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QVYvn45xuKCqAmfsQN9o8nWTGJ8RKVT6+1YtcfyGBkw=; b=5q9QGJM4bfVe9rCJ84PYPNHFGku0dCeh3TIb6lCcYfPWvSenTVUVnI3zMv001YPWRg8ZCe Ggq6dYhLQcgcCWaXF4iu/n3gCixK6lpFWB1i6SrsTiI7bPXwDwt1oiZJqzkCPv1dzY8Sj5 OjpFchCrsFv4F3gA4YXLt5PXUauYjcc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QXephPkx; spf=pass (imf13.hostedemail.com: domain of visitorckw@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=visitorckw@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717350225; a=rsa-sha256; cv=none; b=3azz0nzJHJud+fLXrdeOPkWd7JvLrjQg1SpfIgc07T3WxZClQE/xzdnrcW4N/qBhMbKamF j4Ud7kYg8+S9X5vmN2FRIvQcdU9P8vTPnmstbTArxbTUxmxjS+uuLvrVi3I6amn2UJSEbs FryRjrmtjpXpC9ZcAJrkxHVWNm8ucEc= Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2c21571e99bso90024a91.2 for ; Sun, 02 Jun 2024 10:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717350224; x=1717955024; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QVYvn45xuKCqAmfsQN9o8nWTGJ8RKVT6+1YtcfyGBkw=; b=QXephPkxJSkbuKQatXxE2/PBrY39vsQ5gLSZ6I/ZJSzNWpE7G9YaNzqxSrANCZQYoU 5H6RzmUO/yOVE/LfWbHLiyI2J6UgbLfkyjchq0W2vwqSd0WGjtlWi/i1hB4r2D5sAHlg FBn9LgNOv/1jkXSkxS16DOFIqajgNiz4CfP5pm2OnnP6HUfL1QFgsqQQr2+xJlVsHov4 51bsDAmdFs1XZkJz2toWOr0LPV08L8+Wb7LYJMeYyL+ci+3rclZAsyEYzGs+yRLXOt+g A2qcP+q30N2ZUDYoLJTKBF0SH0HnMAad9IGQ0wsi6wqUgk6ceR64P28NXxq2BT38shXb iORw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717350224; x=1717955024; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QVYvn45xuKCqAmfsQN9o8nWTGJ8RKVT6+1YtcfyGBkw=; b=HWaOVTRXJP8RUxtto4LgfkrsqbM8NP1djYA/nlccFcnEMu8s9yP9qqrOOvLQ3M6EaZ VlIB/ctOSDuUZlfgL+lvBhJIn0ZMuHm56ggkMsWijLaX+ridA5tJlSHI50Eyv7CHpOsE oV1DkUEhOqeGgnmNa6SwwXnzICffFQpps24Mgg3u2bjwvI4sEtd1MDNe/8vZttCVjYtR axCL9ieS81oBlSOK7F4e1R4UNA0Ga1EDqTX5pJC+OrtY1XczAIJ4V8PSxJnkVxPTA4X5 +wAsgJadl3TCPYghv9kEsQevIwPrFXzDiEp2CfImyRn2X7T8p5EjI0mJZxge8uGu16Mo lZGQ== X-Forwarded-Encrypted: i=1; AJvYcCUVP3VGtwB6sG+lAgCi70CkQaCxuXYlZZlQuAbviZhooMZ8O16KrOJV+yL/CHDFEfK/gfwALVgdJy8ZT4PdzFVaOF4= X-Gm-Message-State: AOJu0YyCMuA/ybiMs0FwKypbmHdZ/xqMKakk0DZ67qRw1Im7posTtKi+ Svm2oz0O2J8id4hEs8vHulcoLaG4vPptsfYGvuYoClRMxdyIvF1w X-Google-Smtp-Source: AGHT+IEA/orTGFjeW7gsNTSl5epQsQ3MkyyvV4S9DpL38mexliTyPs4rfRg2cLoDMIIuPJjEfC3bwQ== X-Received: by 2002:a17:903:22c3:b0:1eb:50eb:c07d with SMTP id d9443c01a7336-1f6370c34c3mr80842555ad.4.1717350224447; Sun, 02 Jun 2024 10:43:44 -0700 (PDT) Received: from visitorckw-System-Product-Name ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f632355498sm50159925ad.66.2024.06.02.10.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 10:43:43 -0700 (PDT) Date: Mon, 3 Jun 2024 01:43:40 +0800 From: Kuan-Wei Chiu To: kernel test robot Cc: oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List , Ian Rogers Subject: Re: [akpm-mm:mm-nonmm-unstable 38/65] fs/bcachefs/clock.c:150:18-21: Unneeded variable: "ret". Return "NULL" on line 164 Message-ID: References: <202406030001.jwsq6DZp-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202406030001.jwsq6DZp-lkp@intel.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C47E32000C X-Stat-Signature: fuwsnumwt31i4u8fznjs6n4zf5drzys5 X-Rspam-User: X-HE-Tag: 1717350225-990390 X-HE-Meta: U2FsdGVkX1+tyVU9eFhULXv5ep8f0/gAnGbYGLilA4HxWIH5gWKF6fSzPoR5PozXZchlteLqhG8QhubzwrFfKAOf7XJVmVecnRTkB4DTiloKzB6XaJzO5phHUwvGcXG5Bp8SN/d+ncarrnCoyNJbQQZF/qpJ/sNCZtVPYxwFzQOUlSUJ7Jl4J0vSh4+OGW9n+BYPq3HRj76004k5pEPgLrwyXC0Gr/dljUkqsQ4Is3PXp05H4050hOS8DLLYI8J2pL6t2r0iuNvBKWzDi3JHaTaO2XzvfnAJeCjd8vssdX/2hiOjp7YJb2PobyHh4gIFJxjiL6julL/PYV15dOOjv1SGba5cnPd54qlFF07NVGWQqNSVfMXKl6YcYUnIumHsNSCJ2F1O+R2zd4fpQvn1eFa9Qdarq5kRhh/Emy4d4lNHBhE6CMnD3+pngSf3cjY359bKCxML6Xl7MEX6QRG3RnDFnfSHgAJyDsN8FIfEkEwJ+qgyak/7eGwiAAsGmfdO9W73s86rqht9238quVLajgd/i6rtNfAWsx2bwgoCDmBmqsaFEfHnsLWFaAocsZzmh8LIdfEwz75DvxLKUWEW2WW5piSDUcGS7LxN9YxHih+jkDzZDtxJP1ViNwRmpHVBVLPBYdmQPPp93p0T1TKPFOym+YDPNhzWlkU4SEKGkCXuRZJS5zXZ07fl60LvvzVvDuFBg8XKJcgXNUVWXhMXieHB0aW0ZV7IQ6qf9H14j7YdvMRXc5OzE2atn50CWCaH1wGOjsCMfbuP0YiC1viAofjtBJhZE3teY0fzcINeFoM8qbmZ10kwIbZMzCkwHP7qI1xmjviOYpaSvDCfCMBZGJrVUEfQLl1av9o0ZLHOiTOtZokTDyd6rfiHdTKqYCkmsJHNzZmG/u3xIj2juS77QqHnFNZL6FsZiT3XrpFzS/MiyeUWhOzOBA/6YitzwG/OdAB3SkyLDIYBho8TyrR s6RxjqX4 bJHGoRVaXMsHxYQQKSXGVffBTUS8ZGv6nazAyK4cpdzU2U+DcMcCEdJIiWWnCczlU8g05iO13RsK6R+gvQQXq/OZSjzR+ywUFVWTAYB+aSCp1TIWGFFisSIo9qSXoSI/PLqlQsiYzP6WrI2Sk3PHGx8yS78hE47GrmkRl56jrXjooLweNMOhWjGNneB+z2dTjpv/NwJf4jztA5yHNkkp2NIDS9rE4OpyAUemzkGguG42pu9F0UbKg11pWr5s14wskH/ZXWG0vhenI8VSKjASgp4G03wxcLkPGoiu4EvD0B5E0xN+v2WNi2N4Bn4XOBNUz8jDwpdy0j2jxEDqMp9kx8kEE3oDZ4ksJ7+SKkynSTIg3JWiNVRP41j+ivsoQou8FSqESJUjIX3VnFqRZy+dYH4rrSA9I47wx+YcsMJb8RdleokMe1mIshGnQQdNR5Jc3i5sE+8O/2p9s5XprXsOwRwNScPa23H63+9O2ukisyLdbJAJxh+qMCbg/J327blqQPW+5nwiOEnDXwPLIkcXdmo/J0WfGBx940+scBEHyUyTXbGvDQSqD8YMjMLaWNeTj+2WqUexonxsmMPzNFm2XvJLTIT8wWurMSUJIHG1+EYYSv2nYhmEMW/McJVMpslclgP/ZGghMcHiSqgGpF6W70ZGM7g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 03, 2024 at 12:46:08AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable > head: 54524b845fbe070c5401141bc4ff2ec3f01f1e72 > commit: cf66e6c3b24c5aaf365c54bb7dc8b9cb01f47f4d [38/65] bcachefs: remove heap-related macros and switch to generic min_heap > config: x86_64-randconfig-102-20240602 (https://download.01.org/0day-ci/archive/20240603/202406030001.jwsq6DZp-lkp@intel.com/config) > compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202406030001.jwsq6DZp-lkp@intel.com/ > > cocci warnings: (new ones prefixed by >>) > >> fs/bcachefs/clock.c:150:18-21: Unneeded variable: "ret". Return "NULL" on line 164 > Hi Andrew, This error occurred because I forgot to store the minimum value into 'ret' before calling min_heap_pop(). Should I submit a new version of the patch series or send a separate patch to fix this error? Regards, Kuan-Wei > vim +150 fs/bcachefs/clock.c > > 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 146 > 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 147 static struct io_timer *get_expired_timer(struct io_clock *clock, > 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 148 unsigned long now) > 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 149 { > 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 @150 struct io_timer *ret = NULL; > cf66e6c3b24c5aa Kuan-Wei Chiu 2024-05-24 151 const struct min_heap_callbacks callbacks = { > cf66e6c3b24c5aa Kuan-Wei Chiu 2024-05-24 152 .less = io_timer_cmp, > cf66e6c3b24c5aa Kuan-Wei Chiu 2024-05-24 153 .swp = io_timer_swp, > cf66e6c3b24c5aa Kuan-Wei Chiu 2024-05-24 154 }; > 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 155 > 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 156 spin_lock(&clock->timer_lock); > 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 157 > cf66e6c3b24c5aa Kuan-Wei Chiu 2024-05-24 158 if (clock->timers.nr && > 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 159 time_after_eq(now, clock->timers.data[0]->expire)) > cf66e6c3b24c5aa Kuan-Wei Chiu 2024-05-24 160 min_heap_pop(&clock->timers, &callbacks, NULL); > 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 161 > 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 162 spin_unlock(&clock->timer_lock); > 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 163 > 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 @164 return ret; > 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 165 } > 1c6fdbd8f2465dd Kent Overstreet 2017-03-16 166 > > :::::: The code at line 150 was first introduced by commit > :::::: 1c6fdbd8f2465ddfb73a01ec620cbf3d14044e1a bcachefs: Initial commit > > :::::: TO: Kent Overstreet > :::::: CC: Kent Overstreet > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki