From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C4F0C25B75 for ; Fri, 31 May 2024 23:44:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 902E66B009E; Fri, 31 May 2024 19:44:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88A2E6B00A3; Fri, 31 May 2024 19:44:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72B346B00A4; Fri, 31 May 2024 19:44:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 552DB6B009E for ; Fri, 31 May 2024 19:44:29 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B78D91A0283 for ; Fri, 31 May 2024 23:44:28 +0000 (UTC) X-FDA: 82180322616.09.DC2694B Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) by imf28.hostedemail.com (Postfix) with ESMTP id 1982AC0008 for ; Fri, 31 May 2024 23:44:25 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=JM4VUaWy; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf28.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717199066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QQSw4uPQgRlAk3kSFCT2kJLdIQ/8AieJ62AywbPlN10=; b=Nz6Ug6mfxM6RXQXflX67Vo4I8F1mq8DWQChG4MMCHdqlLdS1x5xbSb7lR15jDz+i6IUuhB NsMJq660CUJAdjV+RxxdEymp3z1/Tws0TAW0F0BjAXJgqkDFo3aHvyXWYRbMwP+1gXLj5w wMRVybuE3DcbuOjvKj892HCaxWfjSmo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=JM4VUaWy; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf28.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717199066; a=rsa-sha256; cv=none; b=ZrxJGPmbfCs9ahcFQPHS+utbp+Rbh2Y9+MUD08cew6QYY10q/Y16SA16EN8IhyfwGgzc3x VpKt8L/cCLmdiUXrABCglIlJ7LbxloyuIDwjhIOMeklzfEow+Jk6GCPwgFiL5VfkdO5l8H ocprGoeFZu+TnGH2Me2ChuagLQ3ST14= X-Envelope-To: vbabka@suse.cz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717199064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QQSw4uPQgRlAk3kSFCT2kJLdIQ/8AieJ62AywbPlN10=; b=JM4VUaWyXQA4oPsqLQCYJRQ+U5ltEWNYbqydiC0118Lvw8ARSRQKxDtoz/LXNP3l36eZfL /0+mD9xqfT1uKyARczwtW716OzeJDqc/dzWzcB7fmug0ExijVA7JmuW/f4IgXve4nDh6uQ An09w1e8j9woSKGsMHLCxhQsgpbmDFs= X-Envelope-To: akinobu.mita@gmail.com X-Envelope-To: cl@linux.com X-Envelope-To: rientjes@google.com X-Envelope-To: ast@kernel.org X-Envelope-To: daniel@iogearbox.net X-Envelope-To: andrii@kernel.org X-Envelope-To: naveen.n.rao@linux.ibm.com X-Envelope-To: anil.s.keshavamurthy@intel.com X-Envelope-To: davem@davemloft.net X-Envelope-To: mhiramat@kernel.org X-Envelope-To: rostedt@goodmis.org X-Envelope-To: mark.rutland@arm.com X-Envelope-To: jolsa@kernel.org X-Envelope-To: 42.hyeyoo@gmail.com X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: bpf@vger.kernel.org X-Envelope-To: linux-trace-kernel@vger.kernel.org Date: Fri, 31 May 2024 16:44:16 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Vlastimil Babka Cc: Akinobu Mita , Christoph Lameter , David Rientjes , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , Steven Rostedt , Mark Rutland , Jiri Olsa , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC 3/4] mm, slab: add static key for should_failslab() Message-ID: References: <20240531-fault-injection-statickeys-v1-0-a513fd0a9614@suse.cz> <20240531-fault-injection-statickeys-v1-3-a513fd0a9614@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240531-fault-injection-statickeys-v1-3-a513fd0a9614@suse.cz> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 1982AC0008 X-Stat-Signature: 4bygixoyie7ta6hdrhy3ns4hu7hdeiz3 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717199065-684511 X-HE-Meta: U2FsdGVkX19BRJPA0H6Rm1U7oHJHa67F658jLvS8UMArcmzt2ke9+CQOeqvWy3Jg/Tx1FvIyX/R2Z6tqC1qidTBDTsQNrPyn3rw4+WgQPEQ9tm0JIkZyee/bIEjevKdOWNYuDHHiflkTC6tplHlkoXqblo3VPl22jVgvpiLcWbOnPFySalJNL5UWuLagNtT/d36XgKqwT3ymcWdMbQr8I53preK1h0iEfsiVgitG3bpXnXn/w521AUGOowDZ+C0FNIXyRA88fmkJgPQX8YW68souOeMtDF46phUeHsnrvbMKqes8l8D3mB0ytBY3lgokUvV692o82yOpXW9FtT5FPaCtYYayr4JbtV/yyo1Qm2GbqFYQQgUgbXmnuPUkm0r3mp+oySuH+KfVI2VgVn3ogCaE2m9KudW/VxwQi/XCV/kJY67DgDI0zWf7PgZMG7Jv9ZJWyDBmVptFM1XeUfBxvnAK6WGTYZ53zP9f4y9k86Bbawaqq5UbpeUVGd9j4QujIYC1pBk/xyxM8vnusV5XtJaZZR+sMrWEOgraQZeDqb1F0g6gN5qLRM1MfeyR+q7DNx1VOAFtVdzFrkDHKUPr3NlHZ12XBNwONFFAkWF1o7PuRNPPWI1isVrA50PcFvXRte0f9VTcHC9nPQQ1WxSGxZrvbaLmHs+7CmGiBdBlGSImjjLw9CAsF7OoJZeSeGiTC00hPn8PdWMY5iFu9MecnrtVU1PlgpU2jr8rkwBtNK24TkDdWm8/+k4L1kOGsZ5K5WVGbTx8RIxDK92kZiBVisOgdx8ARh0YmbUg0uFQj+abD87Cejq6MtmRWT7/4ZFvz5YRsXsISHVrRkho2HcRET6FEiFtxoblBBOxcV57EZjuk0PApEeB5KCEHRoa2wa/cBPgciRWZE7pmnC8qM//AuZxymORRcrPs5voVYKoHG9JWBIACRFGMuzZHyas2Joj/fP6UanfHhk17TEZqrJ l0BE4s0e uQF52SktMOKy7QmFUv6xYqp+cVATOj+iL54zWWiMiuwJ6tW7oR1hH7WQEC6CiJpGcJXVjcFauoXVDwMydWlnUUIg4TBALWZi9TkkJkJERvPXR1/jgPBY1fgVBqeJVjOAEPzXWkatsfBoRFR4b1gQaz867B+1Bm+9UU9Qn/e86/5xfcKNidfJk7YP4/aHgIZiN5hxA+EyXnh2azAxRddeVEclzb6dx8Tam0gNoUtrL2nQfTtpFhsb/5bZ8TfMg+ybXSWbj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 31, 2024 at 11:33:34AM +0200, Vlastimil Babka wrote: > Since commit 4f6923fbb352 ("mm: make should_failslab always available for > fault injection") should_failslab() is unconditionally a noinline > function. This adds visible overhead to the slab allocation hotpath, > even if the function is empty. With CONFIG_FAILSLAB=y there's additional > overhead when the functionality is not enabled by a boot parameter or > debugfs. > > The overhead can be eliminated with a static key around the callsite. > Fault injection and error injection frameworks can now be told that the > this function has a static key associated, and are able to enable and > disable it accordingly. > > Signed-off-by: Vlastimil Babka Reviewed-by: Roman Gushchin