From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E43FCC25B75 for ; Fri, 31 May 2024 23:25:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AE776B009E; Fri, 31 May 2024 19:25:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45D286B00A1; Fri, 31 May 2024 19:25:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3250B6B00A2; Fri, 31 May 2024 19:25:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0FD276B009E for ; Fri, 31 May 2024 19:25:05 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A3E7A1C27D0 for ; Fri, 31 May 2024 23:25:04 +0000 (UTC) X-FDA: 82180273728.23.610CB67 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 94F9B140013 for ; Fri, 31 May 2024 23:25:02 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MvkLwDMq; spf=pass (imf23.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717197902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9OswPDDFUjIMOdynPoqOpjOBcZ9Oh6NGxWSjBgab9jQ=; b=JXpL1XG8iLLh2ced+e2gm43fg6TawbWM0Eojj+WOSJm0/39T7BDECB4cVM7WMpBbBuEFgm rauLDivi3Xq1XHh6y5BPLBUvCZ8lH2WKEeRDKXjPGH6HByeWo+D73doC81aDxmyzWb0tJK VRTJjG9BDdtlR/JxmJzcu2ZR51elPec= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MvkLwDMq; spf=pass (imf23.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717197902; a=rsa-sha256; cv=none; b=6yMqs5vZ3ANESmxlHCK+USF9RGtHi3BygN/oQoyFML7vx6CGsbFJnHjMIXQMPQg6oaUaME xyJfpw1avwmo8xCRKVb2wML/QrImu82dqmvnzG8/BpUPxqcgO7rVnLUelJuQU1r2bMgxCY atxHNUT8sKwN5v2S497zSdzPVUG8e2w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717197901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9OswPDDFUjIMOdynPoqOpjOBcZ9Oh6NGxWSjBgab9jQ=; b=MvkLwDMqppXlajW1t3JluZynl/j+v5lptd/gmvzj3WWYq845galTTIGWgTYk2SIBoyfpun ntoEexLFAOEcKSqNJJdAXyn7QQG2PVBAD3JOo79SbWHgVtGoGiJ2xu2AWpbiu8Kg/7o4A2 RiwLrHz5RZZnbdncvvAZ2ZecMnvAm78= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-183-F3bi8sLDPb6cQvLtOxJffw-1; Fri, 31 May 2024 19:25:00 -0400 X-MC-Unique: F3bi8sLDPb6cQvLtOxJffw-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6ad803bc570so7261356d6.1 for ; Fri, 31 May 2024 16:24:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717197899; x=1717802699; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9OswPDDFUjIMOdynPoqOpjOBcZ9Oh6NGxWSjBgab9jQ=; b=CCKLN27xiCkc4rO1Xsa1rnVUZ2guwJBXP/xsSd23NgUXPJoHjyHcFkhadj0fRpv3eJ ECJD3RC0p0uogv9F1E9MLKHrH+BEf+Ob444fx7HBffmQHAYgrDWeAvnpcnjh7gIgBKUL W70+bORKeRGgnjSR7Mez2+qV+YAgc/MmWBhsQ0lFaURC72/DSehGJKiinnFWBBjehKw3 egngb6lygQmhfoxGQwkAjwvNS/KxF/zEvoUVZr9tFRGh0A7RDOPpdRa9y0DAFoiW8AbX ozqeb7zXKjNvd2iR8iD3d7T/fsRnV0SSRx4S2GRKibgaJeENpjQ88v82L8bW5mU2/4Yk tlhA== X-Forwarded-Encrypted: i=1; AJvYcCUiG49D6C6/AYKYTE5iPu7+GECS5PeWXjCyHfNZXng73R5prTeuiyB9ZRzyqcCTyewK0QlmVCs/2LSuUuWIVsLiA7g= X-Gm-Message-State: AOJu0YxmyMITTEHX6ptt5OqvUPCgO4vadVFSrWSXRBY22iUSPGnqpoeT dV4r4uR4kWSyyDWUQAdfi1x4QI/jPTvIZgHhFoxL1fNK1T0B1prwsPNhFOmz1b4gz6g6+sMjKJV pMgFG5GArCFCyH3iCQNGRc+FoDP/YpemaMrLFvQFUFuHzNVj/ X-Received: by 2002:a05:6214:f6e:b0:6ad:8c3b:6aed with SMTP id 6a1803df08f44-6aecd599f82mr36367376d6.2.1717197898250; Fri, 31 May 2024 16:24:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFz+7XbQjDZ9os1V3c/5X75LCTcRQverrG6zGj/NwlvNEnqx93sPhKf/BgLleDFbNQtcwzDPg== X-Received: by 2002:a05:6214:f6e:b0:6ad:8c3b:6aed with SMTP id 6a1803df08f44-6aecd599f82mr36367206d6.2.1717197897510; Fri, 31 May 2024 16:24:57 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6ae4b4065a1sm10327056d6.94.2024.05.31.16.24.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 May 2024 16:24:57 -0700 (PDT) Date: Fri, 31 May 2024 19:24:54 -0400 From: Peter Xu To: David Hildenbrand Cc: Yang Shi , kernel test robot , Jason Gunthorpe , Vivek Kasireddy , Rik van Riel , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Matthew Wilcox , Christopher Lameter , linux-mm@kvack.org Subject: Re: [linus:master] [mm] efa7df3e3b: kernel_BUG_at_include/linux/page_ref.h Message-ID: References: <202405311534.86cd4043-lkp@intel.com> <890e5a79-8574-4a24-90ab-b9888968d5e5@redhat.com> MIME-Version: 1.0 In-Reply-To: <890e5a79-8574-4a24-90ab-b9888968d5e5@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 94F9B140013 X-Stat-Signature: 9mjh1qabio7e4pw16p56kck5mngd3yqp X-Rspam-User: X-HE-Tag: 1717197902-333349 X-HE-Meta: U2FsdGVkX1+YoM5VJSDuVFVM7zcmHxJMRRW8u1SSlrEBmBqRGrKtLlPIZ7iV/yuoRVYLPlD7DblU04GAW24A6JI9wJKCmFET9I5Kztrdd0oGsuLxrVrKYWhC3JHWPhqyHb/voJDDj0DZo84p+JsQipWqw1TxS8gxcg59X9/K+xbXlq9SJmXc3XN6Bw8m9KRgXHHOgkjQrwq+8N6+LLpedxgVUTmTuv3idoecz0FA8nVfSf/mObUVwdAfhM9O9NbyFJwi4TNUgUXd84jq4smpzstuXpuyddNgko+Y3fEAbrsCHNzjalMzIogsMwHoedfN17W1nwYquYa33oXi8bSdwnl+qe5EpzyLMMJokUs6LWiShcx81sTNLYUnixaalOz/ES3OKmIWX7qQf1RiSxj3eDF8T1cE/M89/aGJvXsUwWQvapG4MREH+krp6LgH+wAczWB91eaep7ylPSaTWI5U0pw7N0ZQKL86lAf91WiPwfHdXfljnFeMfmNOph64RM+81XmvSf1N4wRHrLPxwhOuUPaSu8YNDw1JGpaSFy/wIzC6EIoHNeVq0Acox2YdXlMRuaUk+lMgllFFxn1X3506eXe9StyLkTuWWeZwQkD5Tj/EQlVX4pPk5J9UC+zMdGJMVqT3EVRaE2KjAfdF6/65I1EhPEKYv2FWSmKYEQYsuPATwEtaGVm39Kkd9EvyI06CZ0s/mCFz+2sQd6WnDTQDuBDSiChPAGgZtqy/anZnWj5G4Jd/D0vIqLu2PXC2VAP54Hn1iezh+4YgrkkR5nXE5tkQ2iLOjRNFngEEn+y0M9X9lpPKAXuQ4GyUvkDtdzH3uEAVqbbNLCxjylESyvO683ge6vOE+yRdmgFOf/69K3C32uoPrGDDdUyJJOh3EA/R5To/XBDiLpsmkhgexMKe8yS1h0TrIzeul15uqMuBpGrjU1XnLoeGXtdClYw6dBSGAzBWd+r2Xo/5esTXRCq Q/X/FkgO ghd96B36NwwbhsvfLaJctzFyFz0cZUm5qe1oaBNNNIZ/r14cqVVv1gnLjPQBFZtbamttUF4KavDS30M6Ahsri1Fu47kvekGO2K8fXbdlzRE0G+w94LnMFGbaGQ+P37gNIDPU4tTPY5XcbmiarkeVhKIiffUrgHPxXHCmKH0HLRT+NdelmdKp59Z2eYnAv5QbZmbJoRI51xXvvB2mH8cu1zWlnhY9i6AD9S/h9PjMRZygR9idS2QttqFRlgBgScULtlzbjj1OqQ2blVsoA1j2iG0aVIz86q9Rcy61zNv/TVUOPG4JljIHVi9mFcE+7WPzUc0pnCy8tMMqWcM8f/6uy986kNArKWU0cvxMAMkmAwrd7vno+EDS4yNE1sduXIctMtB/f9NwxqjijWHUWgMNxWmPrvF/zLlXeCIYK3z8gRdrFtuKeK27I55rj5FSIiy9SdIP4/UVnkNRKPMc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 31, 2024 at 07:46:41PM +0200, David Hildenbrand wrote: > try_grab_folio()->try_get_folio()->folio_ref_try_add_rcu() > > Is called (mm-unstable) from: > > (1) gup_fast function, here IRQs are disable > (2) gup_hugepte(), possibly problematic > (3) memfd_pin_folios(), possibly problematic > (4) __get_user_pages(), likely problematic > > (1) should be fine. > > (2) is possibly problematic on the !fast path. If so, due to commit > a12083d721d7 ("mm/gup: handle hugepd for follow_page()") ? CCing Peter. > > (3) is possibly wrong. CCing Vivek. > > (4) is what we hit here I guess it was overlooked because try_grab_folio() didn't have any comment or implication on RCU or IRQ internal helpers being used, hence a bit confusing. E.g. it has different context requirement on try_grab_page(), even though they look like sister functions. It might be helpful to have a better name, something like try_grab_folio_rcu() in this case. Btw, none of above cases (2-4) have real bug, but we're looking at some way to avoid triggering the sanity check, am I right? I hope besides the host splash I didn't overlook any other side effect this issue would cause, and the splash IIUC should so far be benign, as either gup slow (2,4) or the newly added memfd_pin_folios() (3) look like to have the refcount stablized anyway. Yang's patch in the other email looks sane to me, just that then we'll add quite some code just to avoid this sanity check in paths 2-4 which seems like an slight overkill. One thing I'm thinking is whether folio_ref_try_add_rcu() can get rid of its RCU limitation. It boils down to whether we can use atomic_add_unless() on TINY_RCU / UP setup too? I mean, we do plenty of similar things (get_page_unless_zero, etc.) in generic code and I don't understand why here we need to treat folio_ref_try_add_rcu() specially. IOW, the assertions here we added: VM_BUG_ON(!in_atomic() && !irqs_disabled()); Is because we need atomicity of below sequences: VM_BUG_ON_FOLIO(folio_ref_count(folio) == 0, folio); folio_ref_add(folio, count); But atomic ops avoids it. This chunk of code was (mostly) originally added in 2008 in commit e286781d5f2e ("mm: speculative page references"). In short, I'm wondering whether something like below would make sense and easier: ===8<=== diff --git a/include/linux/page_ref.h b/include/linux/page_ref.h index 1acf5bac7f50..c89a67d239d1 100644 --- a/include/linux/page_ref.h +++ b/include/linux/page_ref.h @@ -258,26 +258,9 @@ static inline bool folio_try_get(struct folio *folio) return folio_ref_add_unless(folio, 1, 0); } -static inline bool folio_ref_try_add_rcu(struct folio *folio, int count) -{ -#ifdef CONFIG_TINY_RCU - /* - * The caller guarantees the folio will not be freed from interrupt - * context, so (on !SMP) we only need preemption to be disabled - * and TINY_RCU does that for us. - */ -# ifdef CONFIG_PREEMPT_COUNT - VM_BUG_ON(!in_atomic() && !irqs_disabled()); -# endif - VM_BUG_ON_FOLIO(folio_ref_count(folio) == 0, folio); - folio_ref_add(folio, count); -#else - if (unlikely(!folio_ref_add_unless(folio, count, 0))) { - /* Either the folio has been freed, or will be freed. */ - return false; - } -#endif - return true; +static inline bool folio_ref_try_add(struct folio *folio, int count) +{ + return folio_ref_add_unless(folio, count, 0); } /** @@ -305,7 +288,7 @@ static inline bool folio_ref_try_add_rcu(struct folio *folio, int count) */ static inline bool folio_try_get_rcu(struct folio *folio) { - return folio_ref_try_add_rcu(folio, 1); + return folio_ref_try_add(folio, 1); } static inline int page_ref_freeze(struct page *page, int count) diff --git a/mm/gup.c b/mm/gup.c index e17466fd62bb..17f89e8d31f1 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -78,7 +78,7 @@ static inline struct folio *try_get_folio(struct page *page, int refs) folio = page_folio(page); if (WARN_ON_ONCE(folio_ref_count(folio) < 0)) return NULL; - if (unlikely(!folio_ref_try_add_rcu(folio, refs))) + if (unlikely(!folio_ref_try_add(folio, refs))) return NULL; /* ===8<=== So instead of adding new code, we fix it by removing some. There might be some implication on TINY_RCU / UP config on using the atomic_add_unless() to replace one atomic_add(), but I'm not sure whether that's a major issue. The benefit is try_get_folio() then don't need a renaming then, because the rcu implication just went away. Thanks, -- Peter Xu