From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EC60C25B75 for ; Fri, 31 May 2024 13:56:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D65E6B0088; Fri, 31 May 2024 09:56:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 986266B008A; Fri, 31 May 2024 09:56:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 876B96B008C; Fri, 31 May 2024 09:56:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 685946B0088 for ; Fri, 31 May 2024 09:56:11 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 128DE141796 for ; Fri, 31 May 2024 13:56:11 +0000 (UTC) X-FDA: 82178840142.17.9CD6E4D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf07.hostedemail.com (Postfix) with ESMTP id E3AA640015 for ; Fri, 31 May 2024 13:56:07 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=dyo4c21p; spf=none (imf07.hostedemail.com: domain of BATV+4872a67a45e6d46d0c49+7586+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4872a67a45e6d46d0c49+7586+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717163768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hOUDzBNArOYepgPXo1iBbPP69U/83MRMAzI9ClltqG8=; b=aebemCOEAFhRd1eWuLgIN6UdTBhWXIP/1WoIj31hr0hsSn5go0oQFixuWLLGHIEAPLy30e +qUgLn7xO0Yc6PTQxhuh5j2DuA27SMZ38d3Fd9Izv0scCCqkrnDSX0Du7HaNF+RRzRf9UG wOWlOTIVa6Wlr1ikMzFseXw/vjCPD28= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=dyo4c21p; spf=none (imf07.hostedemail.com: domain of BATV+4872a67a45e6d46d0c49+7586+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4872a67a45e6d46d0c49+7586+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717163768; a=rsa-sha256; cv=none; b=obSMxsmWkfiX1lfvuZP0ea5m1Z6DliEQ3o+S8WuKDhdZo/km73iLPIPnTosE6GnKTaPEXB 221v8UJoJdZE6zVBszef/s8IUt+s6PVCVavcv15F22s4/Mq5bo1KI6ERw62EPu+B02JKPU SlKaeUBzCmmD5kLX9nDVw7Pq2S7r6N4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hOUDzBNArOYepgPXo1iBbPP69U/83MRMAzI9ClltqG8=; b=dyo4c21paVDca+eFQBC4DuhOYJ LTeU21aATKcrl3hz/Eg8cFbI2gUdm+HhwSEzjTDcL5v6TtrfdusHofTY7e2B2WbMv2+vp1DcBk5io dpNZm/JIKpcohiX5AQfvkzXlEYy2W8Brtj6XTbPkZWNoMDzyYGjKk5URQWxTISnLOQRYH9E01pwEn 01WAfbf9VOG+qsETi3vINJ19k8tRXl2RzrxxrHpDxp7+h6cya5JuvXyD9fGS7veahJtNpNtMNpjKR 8yKpAbbMLJfeE+h0sod77aWaNnEmphVLf8zLwIjjzSvZ51esr0Ea5704S0jqpESMutLWONUCvRZrF hZXuCyxw==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sD2jh-0000000AQEH-1vt9; Fri, 31 May 2024 13:56:01 +0000 Date: Fri, 31 May 2024 06:56:01 -0700 From: Christoph Hellwig To: Bernd Schubert Cc: Miklos Szeredi , Amir Goldstein , linux-fsdevel@vger.kernel.org, bernd.schubert@fastmail.fm, Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH RFC v2 06/19] Add a vmalloc_node_user function Message-ID: References: <20240529-fuse-uring-for-6-9-rfc2-out-v1-0-d149476b1d65@ddn.com> <20240529-fuse-uring-for-6-9-rfc2-out-v1-6-d149476b1d65@ddn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240529-fuse-uring-for-6-9-rfc2-out-v1-6-d149476b1d65@ddn.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E3AA640015 X-Stat-Signature: 43rb66crdbyg7qoan7uus8717t1xywq6 X-Rspam-User: X-HE-Tag: 1717163767-776337 X-HE-Meta: U2FsdGVkX196fwqlpZ9hEbYgWtPoZgG3UynRUY8EC7ECP9vkN4YVHn0cDw9kg+9ki/XrlL6xdmfZ5yQBtZOCXaA8IDY8vUjktgUAa38SbELYWbMtDyCrrZ1kZjQfM4USk8R9ZzGzKDuMifTeRCJ+MXjhin7ywm85dHjJH59uuHggoK2/UAiqkZEVyBT6LudtcCImJW1vN1NJRNXS7kLli0+IME/5DQkXQxufSgaUDhRkXAm20vy0Ag+0jt4bUAU0KiY5BzbChp+2YHLS+IePjYV2Rx/6NcN9VFaJ3JotuC6JN8gzUVWY0+6ujWBF5QKqTkBrA9wCWe11AHFYgMNL6iMkUk5tT0H5j7TTRxIgj1wylUvFDcEZi9QKDxmJfmEfe2FwxnjUipKyCIBy//UNw2InDLn8yEriEx2Ik+htLacP6ZgeC/08cQsZrsoI9DnZBfG1JrZQcwDQQTiE0n142BYj+r9AfjBkXmx0uYEHJ2S1tenuSaPBjJqBsqqVqvq4AQZUk5XJHRdY2rzvNgBrB3VpUwPsWxIqkqvyD9C5Ha5vy37F2xIhESFzDYjB/AaK2lKZcgtV/woN8ZeLJBU7t10px/p3BnKXTwC7VrCoyvyY9Tr588ZE9OO71QJGUVppNTgd2xC8229ruAOfM19x0ZFrJACj92MLVdU+R0L/y+MPhUaSJsLIRkS6IrS+z3xaydGpR620m/kRcJ2LRFu48b7VvwX44pZmSzDKvubuKyXLiHo5ri/YpvFoTAyKFMn7WTshhIblNcK0QaheSzb2Ep/DgbY1D6v3E+synuufxt15zCsQn21Cwx6z6YkojI1WWrDiLfagQN0G5dVIB94ypew125trJ9vSxmcQoqCwCDhxeJHD49gf4BKHVHrpYcROjU+ViDjgWH7oR1C6/dOLU9R8sAcxqAC8Q1Ddy+57R+j53+hkVi2qgnuDedq2yJkmttZV1k480ZpeBrZERXv +GxBmQRA Tkp4Vf4WG/P6IiOURSNmauLWHgyNO884qRjKAS2V95dJHV3CtfeoNlm3bC4YgBWJdW2uWkqboP8vEF/lSTp7kV53ZQmhSpw+3oVrAhzf1EWriNHZGTAweTUNkQCCYNnT1+apqdWfpcY4/CC+OWOOVaV1REs/jrW8bOX08xDzwqPDVxrvFD3JXJdFlRsvRsJ2ZjnztNIGtk48Gu69qRUU5EAYgC0JP2nVyZuOIGztxscl1d++8t6QSJE4b/GMnrSvMbX3aBaldphk68RVx0I9xz7PGLGBhBTUdyZq1fpJXLQ+AzpPxc7EiT93ZW0yDZeabV3DJqHA3CUSqL64aU/T80DMZj1Ds3Q7wUATuPO2D7r3vMk5nV2gtajlz1iUc6h6y/4VGIcYIF9PKt3zMVImCKJ94zGqUvRKsGxlOL5VZz2AZJTXpSHkpCtkv/y+YuwVU1fKWTAgm2deejqsG2PF0gQQRKWnd+lOe51qzmhRs1bNUhEkHAHNdjiqwDUsY11h6D18myUTG+Sg8tZEV8+l+Haoa3KRMaevsTfqy2hHtS9qWg+D2tpVBiisDweazYoYIiQjnuyZg9nMBLUKZga7P37cNIkf2NDE5uvqgEiMcqe7ze1M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 29, 2024 at 08:00:41PM +0200, Bernd Schubert wrote: > This is to have a numa aware vmalloc function for memory exposed to > userspace. Fuse uring will allocate queue memory using this > new function. > > Signed-off-by: Bernd Schubert > cc: Andrew Morton > cc: linux-mm@kvack.org > Acked-by: Andrew Morton > --- > include/linux/vmalloc.h | 1 + > mm/nommu.c | 6 ++++++ > mm/vmalloc.c | 41 +++++++++++++++++++++++++++++++++++++---- > 3 files changed, 44 insertions(+), 4 deletions(-) > > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index 98ea90e90439..e7645702074e 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -141,6 +141,7 @@ static inline unsigned long vmalloc_nr_pages(void) { return 0; } > extern void *vmalloc(unsigned long size) __alloc_size(1); > extern void *vzalloc(unsigned long size) __alloc_size(1); > extern void *vmalloc_user(unsigned long size) __alloc_size(1); > +extern void *vmalloc_node_user(unsigned long size, int node) __alloc_size(1); > extern void *vmalloc_node(unsigned long size, int node) __alloc_size(1); > extern void *vzalloc_node(unsigned long size, int node) __alloc_size(1); > extern void *vmalloc_32(unsigned long size) __alloc_size(1); > diff --git a/mm/nommu.c b/mm/nommu.c > index 5ec8f44e7ce9..207ddf639aa9 100644 > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -185,6 +185,12 @@ void *vmalloc_user(unsigned long size) > } > EXPORT_SYMBOL(vmalloc_user); > > +void *vmalloc_node_user(unsigned long size, int node) > +{ > + return __vmalloc_user_flags(size, GFP_KERNEL | __GFP_ZERO); > +} > +EXPORT_SYMBOL(vmalloc_node_user); > + > struct page *vmalloc_to_page(const void *addr) > { > return virt_to_page(addr); > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 68fa001648cc..0ac2f44b2b1f 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3958,6 +3958,25 @@ void *vzalloc(unsigned long size) > } > EXPORT_SYMBOL(vzalloc); > > +/** > + * _vmalloc_node_user - allocate zeroed virtually contiguous memory for userspace Please avoid the overly long line. > + * on the given numa node > + * @size: allocation size > + * @node: numa node > + * > + * The resulting memory area is zeroed so it can be mapped to userspace > + * without leaking data. > + * > + * Return: pointer to the allocated memory or %NULL on error > + */ > +static void *_vmalloc_node_user(unsigned long size, int node) Although for static functions kerneldoc comments are pretty silly to start with. > void *vmalloc_user(unsigned long size) > { > - return __vmalloc_node_range(size, SHMLBA, VMALLOC_START, VMALLOC_END, > - GFP_KERNEL | __GFP_ZERO, PAGE_KERNEL, > - VM_USERMAP, NUMA_NO_NODE, > - __builtin_return_address(0)); > + return _vmalloc_node_user(size, NUMA_NO_NODE); But I suspect simply adding a gfp_t argument to vmalloc_node might be a much easier to use interface here, even if it would need a sanity check to only allow for actually useful to vmalloc flags.