From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34A98C25B75 for ; Fri, 31 May 2024 13:21:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B405B6B0099; Fri, 31 May 2024 09:21:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF0196B00A1; Fri, 31 May 2024 09:21:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B81F6B00A2; Fri, 31 May 2024 09:21:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7CCBD6B0099 for ; Fri, 31 May 2024 09:21:01 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 31BEBA2A62 for ; Fri, 31 May 2024 13:21:01 +0000 (UTC) X-FDA: 82178751522.05.2396013 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 11A2F180006 for ; Fri, 31 May 2024 13:20:56 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bWKdxHhm; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717161658; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yYmj5HbRFBhg7n9dSx3Ho7FPIQnwrH0bnrFIQlD3oxE=; b=bkHd3Axjtr5mmNK3ohFECDYcxy9/oGlKc0euBnAEyRlax0UNsxyNZ76j++9zT0Ehgj/s08 OOQoCAEghHsiCD/ZcLb5MBzk17UOX6QjbZ2N8IvpFL9Gq2Vaw/fZ1iJbxbSPct8SBjq3WF mvdUTOSLMiW5ocYje6z8cpWugdvRHek= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bWKdxHhm; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717161658; a=rsa-sha256; cv=none; b=N++7aNF7AOdLZGMVdk8+pMeDG7ataRte8efgH/QqrV++jjyFgYryOum5D6YNTw8u1XH2u+ 8izSeMFURctoeoX6Iu4ibGyOlDp31BdV2fNhpbf1ItJgaHINNDRQQfWFsIvio/Kaqbugh6 ZyciJDXqrTEzaY5+PJJAf1un68vz2Zk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yYmj5HbRFBhg7n9dSx3Ho7FPIQnwrH0bnrFIQlD3oxE=; b=bWKdxHhm+/Mf+8Jyp1+myRGOMf ZgcrTjv3f1p6zIdY1kk1cDvEeMbeaau9x4OY10j02wbQeZkFZZuzQv27WYkdnZdKzTuPnWIfT8Syt NfRxEIetC/mMFPm/gtKve1taQwz/5ySaFHTFHzoJdme7Ua4BHISz0qbozWNv6EjEiluA89EqeKS+2 iPYdM3pyYqPb+Ebg5lX6hDM7WRKeczBTUtKcJmvkO7Rj49RRpjTqaItSmENP8fHKp+rODiiz4h75J 525vJxK3NNMsmkK7tbM3r4brIanOgos15J24GMUC8WpNakH8p4dz5WjFRtwpIDMFoGCK7NBqHIApc w4CI/V2w==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sD2Bh-0000000Bjg8-1Vi7; Fri, 31 May 2024 13:20:53 +0000 Date: Fri, 31 May 2024 14:20:53 +0100 From: Matthew Wilcox To: Chengming Zhou Cc: Dev Jain , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com Subject: Re: [External] Re: [QUESTION] mm: Redundant const parameter? Message-ID: References: <7f7c3bbe-e250-420d-a7d5-89508d881f0b@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f7c3bbe-e250-420d-a7d5-89508d881f0b@bytedance.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 11A2F180006 X-Stat-Signature: i11pc4ardxpdxcfkbu5f89jfdydxockx X-HE-Tag: 1717161656-675380 X-HE-Meta: U2FsdGVkX1+TWv8K+DwYVT9WCZn8Qso3Y2Iwbcbd89zdj8cHh0zrfLxifPptZkkTUaWJka6N378WvYtPKPP0aSUjo3P39KkIolwH0dwTa+JNfn8okFSWEm+DkCFzAYLWmKcNefsF3gaK4JK5F99Ee2dCZHlcgsfCgedlNfZ2Tx9Vo1zodp8FN9h2MLduGM11vVJ90e6AhlrF6OOppkrVbSO7JA/Q0VcP4zK+jzj+L/IWsYYmKy+SzUCrg40V6hUYiUHLQjRAlDKp1bdBcTCnZBn+f8U2Y2xe9OaFEq9uuQEmo8T1Kgv9j90PDjsgHOQA2AWEf5T66S9a5OGAYaE11PW+YgFqgo9DYiDuRArnmMNSfpaK6Ze86qcHP/22raYGvtrv4dDunAsGX2xjmlrvnYAlq7csK9k+qRBdW/2rsUb/DQ7/E2VvRsiGELSnUh2ymYN+GD1BX2Ix+Du5EtbTE6X3YHXX755dGBa9G14ceBnhLAj5q0kv3RTJh1lhsSadJOn1wFFkL8KrrQ5fPALDR9JGrLCeZ2hADgta6iL06MkWHAq+97Jo99lLqljbZjI65NEjOZFomDqfrji3OrMYepEw9cbotF6PPcwkwfSyHm2ReSAWHjrB7HTrQhF7iqgTPoWDp1xEC4GHe1AMWQ9VpTlEbew1OBUvFkH3ZgEYT6CGJa7pCcSrbHr8+yCtq7ohBpZK3f+ongDhUDmMGNKgaP7kQv92wNekCbTXUdDNRG+FN+z2N6f9TTxZ3EF4SRD2gqleS+JgiUnjllsr8x9LvreSgsOORW2hpLYB41+EtrP8JUe94hati3oeEduaogqmEaJGi/YkJzwHLmqcU2/Uy+A6UbHHCbVtm1SinCQSFLUZSq+JQRJNOOFBE044wI0vOMSWLC7h4JLXnufkPQCTPGrlVg9wRAgYdzOBtFpfpPmCOh6mHrhUPF2GoFdkOtfd4boAfWoLd8gAAlr58jW aRBhBEXI fRpuJp4M5YOSbcqczEJfhvbuh9j//wS82m3xcgFy+UjCeh4HDLVeU+nqmACB07nV2zTL2hqL5wfLwocDi1QcYmyQkQiShmu0qW2ad4fS+E4JSsv6ZJH23CXStlX2XUun4pCI3Epz/elClrTDScyapWKwFkkqldSifXS1hPO2Qhlu6cvgEGJTkjcnmCA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000190, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 31, 2024 at 08:30:08PM +0800, Chengming Zhou wrote: > On 2024/5/31 19:31, Dev Jain wrote: > > I guess it would be better if I send this as a patch and wait for comments. > > Ah, you're right. I think it should be: > > return folio_test_workingset(slab_folio(slab)); > > Right? Don't notice there isn't any build warning about this "const" discard. But there used to be! I fixed that in ce3467af6bde dated Feb 27 2024, which took a fair amount of prep work to make happen.