From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A52E3C25B75 for ; Fri, 31 May 2024 12:17:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A7636B0083; Fri, 31 May 2024 08:17:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 158066B008C; Fri, 31 May 2024 08:17:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 045C36B0099; Fri, 31 May 2024 08:17:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DC9676B0083 for ; Fri, 31 May 2024 08:17:11 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2403A161745 for ; Fri, 31 May 2024 12:17:11 +0000 (UTC) X-FDA: 82178590662.19.E1F785F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 7B38F40022 for ; Fri, 31 May 2024 12:17:07 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HDY9ElEZ; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717157829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jyAihqKd6Hda45CnlrSOdjqk2oTnBzNCXKHWOSSfS08=; b=pvtKc5vVjRKYaoR+X1NXkIbfYBXU5/BoLzcVHDNI5Qu5WZhhTiU9rpXzRgThtOWqolgjFN ydifhw2I2rx+qVLkNCKpCNfICu4OoI2y6RVAdVzMxyxwND0kS2oHRR0ohqfIHOrTHCNCoJ gV9uaCSgDcwFM/9A7ZjeiKT+/9dsDHA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HDY9ElEZ; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717157829; a=rsa-sha256; cv=none; b=eRMbO96YqPpWIRrnDxQSPD5PJMZ4XxHa16i9oleJeYHw2l5v5fuqlhIyKoV8x6cvNGLY75 CULFGveRgEWZSa9+Un4DzuLhuJtM+fPmQLfRfpSE8cP17g4KP3m3wOkeO9m72r8Re/Nh+X Ao+xlw1oOvv7Eyl/JPBVcejLw4WLffA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jyAihqKd6Hda45CnlrSOdjqk2oTnBzNCXKHWOSSfS08=; b=HDY9ElEZC9QCWO1z7fesMTuep6 qymvqqVoiC7kRrNdDlxkZWmkqgX+HmhEo4cqg8q0iosnF0EphRjsAhCWCKIMr6UhVjZ55ZRb0oH2L 6vYfFqpxLPaIjAvh4O2DJTXN2M3VTOL15AU0pmMdLJ8s/MDVTN5vppX0fCKSqHvtFHaKJpsP1NAls 71oIl2eab6ruBXI2bZK0Mtx1xHl0tinVPzn7gaH2Zg/p03dVaWsPmlvFSunecZathoOldAcdGVfIg U0YU6d8J8KTEDQ/TCLqAlss2q7SRCsV/MISxgaCH96Znf0VN/1K7/3i5/zoWnzxqOWEg8CzVmb3s8 pi/U+okg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sD1Bv-0000000BhRZ-0Vr8; Fri, 31 May 2024 12:17:03 +0000 Date: Fri, 31 May 2024 13:17:03 +0100 From: Matthew Wilcox To: Dev Jain Cc: zhouchengming@bytedance.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com Subject: Re: [QUESTION] mm: Redundant const parameter? Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 7B38F40022 X-Stat-Signature: 3318x7osq3ct9y1jgmbm9ygrb4wq5ceb X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717157827-643974 X-HE-Meta: U2FsdGVkX1/RE/l0DYAyjl1tVXigWwNv1qykulkVD7M2l1hgi4pTgPOX5+8D69QLuOFIsbpXzJxxB0rh7QJbtVlCped1DNLGUIrjiMKBsOGG8zhaB51MctzSA8jGpRvLzpnhbNawshVlwXgO5dXLl0dwwKBoa9W7k/P23jqOUspoYKAD7HVSVkW0/EBto1saKzTsILutbsHY+Yj37Z9DrX4FQrHsuNjqG3XsqxekdYNcBuY2iRtCkhgWGsQYcYxX8GYL1URnoQtihxZfIO8wdXIT3A1o5Hw67iQE0S7x1ibhN69AW9lUHemrifOgPoT3Zl0nDaEWtTUQxHgIYqLVCbR3KgkyAzPViPOr2S0DN2JRfQZpqfNBZPOCTauEJ4MN+nBQ6r5O0DITepzTpfy2fm8iB5O4uyk5cL2kSRnbV+OzbCxbME7rRLTfQ8d+zOHzoJQwgIHb36dV98IOcx+NYZmkSTHem0Wrbvl/z7BVrjbc456hKeLEy/zy3wVBMq5jYhdHwTBTdSw7HFqlguj1l8zRM5Y7rRrn3btUg+RYwsQ7vaeU/PXj0fyHNp8yqYj/VhQitUCTP3xHx7hbWy7q0bFezYgbRAcc52TqHbmJCa7NWq+qqljJ8OALqJEh34qx59ztFEyrvIxfwmefdJsEa2AOPsHeygGUGQljHWIUI0243Qdw907ns2ftv0Nb+cCn7fAcG8BHIOPE5fVAcsX31q77hXWBeS31/78Mx8UPQ0nHRq+mekHw6ni2KGrV8OGFB65Ty7UFl75o50qIIHUjOyGYrM5rYZLzkSwioZCr04v7zoFCFtwYIK7XcqBy3w2HOwF+JsaBZjpVdY6MUU7XRbWirLrmir8Y/zrR4pYJaDEVXvZI9Lyg8bN6RZwMt24lJWbZbrrlwgbuShLwcOzya3a3uQvPXe5kTREyvOqT7rIG6mmlcBifZS46xzrlZxBCzthEyrCMGV+kEeX4yOP vuMRwnHR oGB12aIeO7MYFZ9tml+ExrXSYr0yG6XwDboDF9Hz7ZJxVyklS66jy8LzXuv4v4WDVGz/zA0s+tJRoqmbUhzh3iLT/B0KOzb9ZKMOEzWvQqvu6/0zLkRT/0xbkAn1bf2812GEBOE9tuOdniZlz4WKe0DmgspPYIN7MfEJC9Hg40sALAPfBcHvRZJ+QQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000046, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 31, 2024 at 04:42:59PM +0530, Dev Jain wrote: > Hi Chengming, > > In mm/slub.c, you had defined slab_test_node_partial() to take a const > parameter. > > Is there any point of taking in a const, when you are anyways typecasting it > to > > a (struct folio *) from (const struct folio *) ? In fact, at the place where > you call > > slab_test_node_partial(), the struct slab *slab is not const. I have a patch to fix this; hang on a second ...