From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00432C25B74 for ; Thu, 30 May 2024 18:33:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89E1C6B0099; Thu, 30 May 2024 14:33:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84DD66B009A; Thu, 30 May 2024 14:33:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73BE26B009B; Thu, 30 May 2024 14:33:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 566CD6B0099 for ; Thu, 30 May 2024 14:33:51 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DBCE9120EF1 for ; Thu, 30 May 2024 18:33:50 +0000 (UTC) X-FDA: 82175911020.27.44396D4 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf13.hostedemail.com (Postfix) with ESMTP id 02C9D20017 for ; Thu, 30 May 2024 18:33:48 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CNDwEmAP; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf13.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717094029; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eghPQlXH5B6siCX7AO+/cKxSt9mXEKhBpwWSkvOB0HE=; b=iR9XQJutqG21TEb6eTC03lZeDyuXaqMy5GUdDI+qXx+LvtZBl7MzyV00h9Rbqo/BadNNRQ BnfiRutiby1X3gaNgqqWz4nTBvWvSHCMr+cDwTtRMdJ/COxAYwef673YwedOVJwZ1w8vMY fMhEGkpHyWrcYzCvgeb70AErMQ6WVQ8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717094029; a=rsa-sha256; cv=none; b=OfVq96OxYVLx+VRWQkbEJieUmVK2532B5lQUBpZRnHwJGdX/PtDgL+G3UlcSBaxP5RWDAf zUs5i1reV6QJHTdJLNB+MHgAt7pNTlskweQh2BlmkIPhWhmfaRdxab4rEsEmKmIp34L3Wk L1lhhz2XeWQpiOiWTIMA72KDbrUPF40= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CNDwEmAP; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf13.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=htejun@gmail.com Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1f47728fa4cso8257655ad.3 for ; Thu, 30 May 2024 11:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717094028; x=1717698828; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=eghPQlXH5B6siCX7AO+/cKxSt9mXEKhBpwWSkvOB0HE=; b=CNDwEmAPdWWd6LodT8k1KAGX04B8ockg7EbAGiXcmORK2znkrI5bT9n64FYRIRslcj XlbEndCaDKPzM0SMgiYpFp84yFaG00VLoh2iBxVBbCJCaznfwWpCQSgQCBfBYvFyRh13 qitj7rgh0//47BnmMNpMehF0o/T78ttFRwc/mGDTJFOkx0YhADkbf9f2x2bWBEoRgAd2 mPagMVrQXsw8IyB1YcE4JCMhl94kJMDzXaSzlF47s0d5rWJSD+LBlStd0MCrAZzctfyU EcuaR5cafI8rpaRzTx8p3ih648qHvUpmfs2O/7+PckSTj94ipVc8l4bi7HvOnkXE8Y1w GQxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717094028; x=1717698828; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eghPQlXH5B6siCX7AO+/cKxSt9mXEKhBpwWSkvOB0HE=; b=wBW4PYApKx2e0ouGg/dGTF+rqdoZJfdgTQeZ/K7LANex2mICfMJp5cw2AUCUTL8JpX PC/OurztfiguyeHaDlJnALvttcL/DcIq8QgAzkrVa+RDlDyCjGxjWtCEzaCOrHo7AOgZ bBjB+lVZ42srq7aClfU8RRSOBo9xBlwJRpmGVYwvH5L48KoUkrYTltIhWC1UC3UuCIql IlZmnH1cLERu0WeQTzAtxYXpjHytKPr11dAgzkBj07viPGf8mPKddKvy1RPrD6+kmahZ BHRtd/RNPoGRNhZKOyi+nRu7CKjllVifUKzu29WxRsIeIrOFA/SfhDZN6TWmaCi+0huk 3Akw== X-Forwarded-Encrypted: i=1; AJvYcCXUCWYY31JhBcgZe3c5jNlqIZjxGJmYliCqvhip0ZReQBecixXCQ+f8EYd1XtKYJb6oKaXJyriLm0+IWJQLfq7VNvw= X-Gm-Message-State: AOJu0YwMtCL/WiNZQ+Lc64ULKSodXFTk9Vp3eZMXg9TJH9Eki39ljKNR ffUvSCtLKS4HnBsUZigCvpq8FJ+eLT2uNCrb0EWyyJtzA00GScHsS9SnHQ== X-Google-Smtp-Source: AGHT+IE9ZQCkNGKYoWv5GgCRExwHq9C646wxcmNRYsjqkc2Vq4/IkiHFHMxwWsIC0vxVYrQuCdkbug== X-Received: by 2002:a17:902:f687:b0:1f6:1c72:955f with SMTP id d9443c01a7336-1f61c7295bbmr30209895ad.43.1717094027851; Thu, 30 May 2024 11:33:47 -0700 (PDT) Received: from localhost (dhcp-141-239-159-203.hawaiiantel.net. [141.239.159.203]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f63237d065sm1000155ad.111.2024.05.30.11.33.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 11:33:47 -0700 (PDT) Date: Thu, 30 May 2024 08:33:46 -1000 From: Tejun Heo To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 8/8] writeback: factor out balance_wb_limits to remove repeated code Message-ID: References: <20240514125254.142203-1-shikemeng@huaweicloud.com> <20240514125254.142203-9-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240514125254.142203-9-shikemeng@huaweicloud.com> X-Stat-Signature: 18xf64m1q3brsbpqo6kop7tpwof61ofz X-Rspamd-Queue-Id: 02C9D20017 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1717094028-775100 X-HE-Meta: U2FsdGVkX181K3UzNnyKd//cRt+gFZ6MRDIyya/BE47BSk2I4vzoLPRUd8+rFn0ouxqF+xG9xNef4KTDyYzmwb0pQBmXh19pBuuNT8Iw+Y2uoiHlkEWqfqrG4Dqmzzh3Z417d1/r3AfS6UfDlou5vJrjJcqA6wBh05B5fG7N7aImAbk7HGJB+8t21JxAdTUBNlXoNswSFIwpkPV6hvxlFZVAKYtiYMINA/fR4Tqg2qA9xMPVPMLerAK1CsOadNsfXILQRBhFwEG4rYDjbsDE9MXthf4uv02KuE4wwKnB2lSd9uduqXvsPPt81+VR/HNAlfkc5ddekyV/8eLCDkgt7S2qGKt/pq1Zjcyom99fg2jZnJtDCwobkwNkjl3nGm7Ib9wT8SQbGa9kaTNy1NhCRqwTgKbjwYMGlX5bXHngBDOXHjmfufqJr/rWOOIZNnwEFP9RxuQcLWdkUt+ly+k1UrLV5vNP+J1YUBEnYPCQNpOmC6LMLfUE1bcY1XHViWWGletrWfKYe/E3EwjunQUG2Fq4ZFTsM0R51VkBUftNNj/w6RoZQJPhH1V7k0eKvT6gkfP0tWpk75kfqJ5bNhnw8+sAilgsodlSCiQIE9DVWa/1p6ZjShZG2oLLhxDajyVa6oCGmLTDj0QuhOPlFE8nMsc8sOBPk0QH39CWjXFr8h6aU+y6TjDqY2xFfXszJapwHKPI3CkElb9RYkZ1F31l5d0Y9zxzVzK30WKin6JVqOa8BVbkofbpL4IHldSI2rlFu7Mv1WkZ50fEtHs7H+pp2IA1POv5gnMeLSGhvME+hu91KNXhuqGxGrA8OCEIBFkYkSYrFOsVxfdbFFjylT9PDynM4T/ht0Jzg6dtYCz6dKmPNfwiKJa6w55I/9x6Y7QOREf2hiNk5afqDfYkfkz43ebiQV6ILL/93hAFHKC7ySkFilL5TzrfunjV6MTsAwJTtViiJejCuJCZphtYphm WvIdaFQL KxuUgAStu0Tulhq/fzavp0JpFjc8hcuCx1SAU4Y75h5BX7WTlob+1zZY/7MF4WzSeYTC4uFjlcgzEWLlV0Sxg+jpcJFqU82w+hXqGRJ0soaRBIs8NJzM4MClSO68dvpQ9cRwwxiWWwe4dwtgiusyC09Nkrrf02iBVzd0uucTy8GkejVCZ5S9sf/x5ekHLqUnWOY8ZeR/beNddaX3Ra6R0axn7WHuhTaEP6RDZ1dH8iH9bStGdvyDjNdZneeZHgm9NdG3LD2sgr3yTMWixkGLfZ4q8+TKmUlTzEIBMjPAKh6KpNgRdOuWlmg5K6NCuBCyFoJPRRn91u0e8PU9BKHRlKx93CYSg+EMMT+J2fWQDCA0ntN46WCaNSsKlyzstdu3sGNWbi2gaB1u3hNwHpFnYytutmlmkA1BXydsPb4Vlraad+U3+yGpDeg0/N9O8hNQVY+kQLEGIk6Rxg5xqW/ieO8NsyQMwCVpWp0ACoGGYEdzg+HBnCtUzGqZ6ZWmJrrpZOvfhhSbIwBSZpqyd5RiwJ0FviOC/KXvWYUKy18LcbBoIGpU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.006851, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Tue, May 14, 2024 at 08:52:54PM +0800, Kemeng Shi wrote: > +static void balance_wb_limits(struct dirty_throttle_control *dtc, > + bool strictlimit) > +{ > + wb_dirty_freerun(dtc, strictlimit); > + if (dtc->freerun) > + return; > + > + wb_dirty_exceeded(dtc, strictlimit); > + wb_position_ratio(dtc); > +} ... > @@ -1869,12 +1880,9 @@ static int balance_dirty_pages(struct bdi_writeback *wb, > * Calculate global domain's pos_ratio and select the > * global dtc by default. > */ > - wb_dirty_freerun(gdtc, strictlimit); > + balance_wb_limits(gdtc, strictlimit); > if (gdtc->freerun) > goto free_running; > - > - wb_dirty_exceeded(gdtc, strictlimit); > - wb_position_ratio(gdtc); > sdtc = gdtc; Isn't this a bit nasty? The helper skips updating states because it knows the caller is not going to use them? I'm not sure the slight code reduction justifies the added subtlety. Thanks. -- tejun