From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B35C0C25B74 for ; Thu, 30 May 2024 18:35:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CDF06B0098; Thu, 30 May 2024 14:35:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47DEC6B0099; Thu, 30 May 2024 14:35:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36D5A6B009A; Thu, 30 May 2024 14:35:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 17C8D6B0098 for ; Thu, 30 May 2024 14:35:11 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 96D9EA041C for ; Thu, 30 May 2024 18:35:10 +0000 (UTC) X-FDA: 82175914380.19.F7F03E0 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf04.hostedemail.com (Postfix) with ESMTP id A0A8D4000F for ; Thu, 30 May 2024 18:35:08 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=akuh1AEY; spf=pass (imf04.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717094108; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UQyclnjydiTSU7cNN94QLETZqPnCeDkTako/wYgboZc=; b=rhn1LtWVouaczZ6LiqT5yteLkB++pb2iJOjl1TApJpR6IHFMHXM/2yCQ6Dh3+78NJk7mTx uuG28UztBNYkx/aRsB0yHxAyHvtBRajPxF8djZzmLC04L0eBVC4kstjr2UlYeXzmvuMyF7 0EdhXqQYEAv9b2uXXiO5f81RZaj/eAI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=akuh1AEY; spf=pass (imf04.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717094108; a=rsa-sha256; cv=none; b=H30AB1fex2lga4nvvfrUvdNP2PzAmaC9qOpOfaH5ptgluegvh9LuKn/5triaEp6UKSgA2c xiLIUSUZS+C50Xnsr+iSLoyXb9ZftGevoMr0Ul4dlYHAMqmRMY4QxRCExudUtwecsjjJFV Csesu8+/XTmqqrxorTVVFs4mfC0USPU= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1f62fae8c1aso2559415ad.3 for ; Thu, 30 May 2024 11:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717094107; x=1717698907; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=UQyclnjydiTSU7cNN94QLETZqPnCeDkTako/wYgboZc=; b=akuh1AEY89AYmeOdRwk3xgMmeTlF7qyCgY0/rRzEiNwSMZzxTYStAtpZUoD3S43tVD S4D/ksFWMgmDKixNKjrbKxP4AQ34Psrg9bkOL554x7gkbWz3EwdQ7I5F9UydRfvtJY/Z pjqmncGnI+9tQqdMssypL/glXOkPldCd+0bnRQ1a0ZbeOmCW1Gxdjo8leGegCEtgPGfK rHYoleqO2SanBKUuagmUdE6Z/CuaIm7lUq8eWrCS9CkI9Mx1jNwErL6FmN9pmpptT83T ot6qhN6I3FQzwhIG2DhfMUlYAkj3l424rbLF6ayIAk5p53jAYTjc8tr7UhQnXvupegjy OJ1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717094107; x=1717698907; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UQyclnjydiTSU7cNN94QLETZqPnCeDkTako/wYgboZc=; b=RB9tbRDDg1qQv2AJ00yGGpuECiobmVRge+1jt1M1mPVug1F/K8YWXa9Bj1djUn4itc YVKhEuYms5Dgy3Nus++DxSHeL+iM7pNQl7VDl71Yhyg/7//r8twG+fn7Nj/eVYht+X1T IsMB2ZClEsMMK+h5XAe7MTfUC4zTvcVLdTCjtzLtmF/oJJzw0G4zlw6v7uuoMdO+uy4u dK16kTVrgQYNZAXHLkX/Fu6Z20OMzjGyd/a/GAktwcsDWGHSzMqkRWV9rpvwr4vhs2pO 8GvLDy1SRSSmNXU9aZ4QjZuSmHrDSLt4D9unW04DCgW9xLpwqxdFKZ8YHWwLkmCUkJGZ 8EZg== X-Forwarded-Encrypted: i=1; AJvYcCVTYzJV6BbvuQ/U1GMiRSQpYjowYwAkz+IwfppL1jnWFb+bQyiIRH5ANsXKtN918GZxHmC5gnAEY0Yqus4T4PNhJKo= X-Gm-Message-State: AOJu0Yz92S6qUoiD5KrPaBQ70kG2ei8tQfKYFsmYoxY4GFUQeNnzpH4H blc/tFOuf70JhF2NoZjfpBIs4/zVwDhj//O21EipoZWE3WPU0FoD X-Google-Smtp-Source: AGHT+IHDEfOGq7HNxJoku45iJzrQaZAIUNA329dViSCdnrDOwypFw2GaCt1T0+oOV3lhFHrRqTg2Mg== X-Received: by 2002:a17:902:d4c2:b0:1f4:bcef:e940 with SMTP id d9443c01a7336-1f619b2cae4mr35438925ad.45.1717094107448; Thu, 30 May 2024 11:35:07 -0700 (PDT) Received: from localhost (dhcp-141-239-159-203.hawaiiantel.net. [141.239.159.203]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f632338afbsm1052635ad.47.2024.05.30.11.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 11:35:07 -0700 (PDT) Date: Thu, 30 May 2024 08:35:05 -1000 From: Tejun Heo To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/8] Add helper functions to remove repeated code and improve readability of cgroup writeback Message-ID: References: <20240514125254.142203-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240514125254.142203-1-shikemeng@huaweicloud.com> X-Stat-Signature: pg8eipty5s7rgi1dinrbixpciftdcand X-Rspamd-Queue-Id: A0A8D4000F X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717094108-317108 X-HE-Meta: U2FsdGVkX18YXg421rMSe7pV/I+YCXDUW/sc4oq+QZ4pIXuTT+cVI+KG6D/yz7mTGLxGeCywXc08zLPzAPbp6KVTzrUyNXiL3kop4+dYTanOntECOAC6p2fvNPH/uvtRnKTvWb9ryjIZlmXADulxzufjTjJ3LJ7Ctme7erBKRv5aj1gPpi2fSmQrtfkzsW0FFzQI9roo+/sfaHuznDOSWlco46575GWSNth9lxiG3hKx5L/gRW+I7vBcK5Pi3NvbP28fOT/s6hHcZ5oXP6uaXyNrLE7YzOOY+ePGhMyKF5bRLXLwf4wrESwYM87iOQfFJtMb8o+KAYlYvSnv+NwgodV16msFyttgqE058wk3hOA8+G94Oy+QS/Yl1L7ZPDaIvOewf59mRwUvw3b5u83ccpK30uJcr5eK8/25gA4TR1pO1+vQc4gRulUH2Z1fZc4mXgW0MCxyy3PUiE5TCfgEwvRQyEBunNsSWMB/4bwi6boZrpCISunOd/XwKCLRnM3rK0rQ21+BUtvLyrVgdqlJenCEwaE64rhncBz5S6KUhG59RuKhf1Q8mBvwB6URMrFMx7S1CJL05F124DFCrGEsUWOgCo3jzv40kkKbOKPx7v9xwFOyRKlWt3AwqduXpp4vgky30Xg0qKDpa2UeEELM0cv9mVzSj1LxNMzMdNIpFAGJS5Cs/eEp4Q7iK5qSu+oowr4dgMt7HzIOI07r3wP5CKGsEYCykzEAgHu5rdM7bSPFPvQIxBTpi4jmhxRe+9eagnD1Qy+fRlFkKad5nlgam8yivozWtD75BqZy7sKIKdBiRFeNNLH+YkD0Mlx6R8eMVH2qjAQQ8FOyXh4dzWuMBPkaqmsyxSqlwFxY4xbExmC6oR+8+/yMJUX8c18HXypDJI/sdRIRH28J3jPMvjIy0ZYOXUXw+p0H9JtAFDzSACDQGCrat/wFA6vu/h1H8naT95k6XHnERAwQtqQqd4f 7k742uUQ xrUjiEARmIUtSLWu7dN7yaSCGv1pph4lLH3de60evwsUOx1Jr0qFVvz6bZHCX/MXfjAG4vQXQqnovqmvddkwRtdTeh8ckXL4inpEmMocDPuaIftp6jM90r0D9Fke0LOiCcf2L6pG6HuciPIQuCEm4A0j4jUEV6z4tN+5A+XWSrMw5Scm9wRTx7nHZM13aVUfL/OJCyBVk8phNDGREUWxpEvm7Oa0hc1T3mp1h6SNcJn2NmXntqdclFA7bTWHbJv4YQOlPFSob5vVYEAi8S71VjgV/u5zaNZ+88b4xmytmrIXRDNlg5e74SDl/XxtlMxjYhavHXOkXe3o/D3jSy1XVsPzrNZ5yzJzzqkqwfZUXNSaoSryC/NKaD+Xv9DB9zEcmoFQ+HVGbJwmfztCQpBVYiCacW7FPwPE0A5fbOrT4gxOg9/+NphNLuwMgGibunhQtNQacEhn5gdrbfBelnFJaWKHP244mNPOK6qnrVpIAj/Rpx02rtI+r+glb0v84rRVh1yadDSvpD2N/SGA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000207, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, Sorry about the long delay. The first seven patches look fine to me and improve code readability quite a bit. Andrew, would you mind applying the first seven? Thanks. -- tejun