From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DC8EC25B78 for ; Thu, 30 May 2024 07:19:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD3056B009B; Thu, 30 May 2024 03:19:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA6696B009C; Thu, 30 May 2024 03:19:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A479E6B009D; Thu, 30 May 2024 03:19:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 832F96B009B for ; Thu, 30 May 2024 03:19:10 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 32B7D140EA8 for ; Thu, 30 May 2024 07:19:10 +0000 (UTC) X-FDA: 82174210860.15.A2A57FA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 4BD8340023 for ; Thu, 30 May 2024 07:19:08 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a2cN77M8; spf=pass (imf27.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717053548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iZGq8sKKqv0GQPGpX0nqEsoomt5Fgw2t8XRl12KY1wg=; b=JdGoOuHxKxfaxTTuv02YuXisRb9zhc4dN5fd6Oy8nB0rkz93s+nQ1XvNqCYesvBsNF7Dtz iVaL3LlIgTkBA4X79pEiec8bvenKRV4LrLdIhpl9BJztpSH6I6fDCF+HhH2pJ5tFnLYn+g uOKCdzNWLTmNEpWhux5EWmSVwOcoQ7k= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a2cN77M8; spf=pass (imf27.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717053548; a=rsa-sha256; cv=none; b=LmETNxPLQPdZqWKpK1WZ1FoAWHQme7aUj5Z0QPnsDZGgVMPx6bbKp6wKAYxFL6jEFdf+2V qYep0jZfUwqZJ2wd+vHNBxiFuSYvAW0guW4AdvyRDijzUHk1WDRwl++IEsr/OLNKzVaVCm 0KvmRm3dRmjh2ALCHqEvsfk3h96OdSY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717053547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iZGq8sKKqv0GQPGpX0nqEsoomt5Fgw2t8XRl12KY1wg=; b=a2cN77M8pyvc5vBOTMN205YBshYZMfFgUqqtmfxPqYKshzN6ktRLxYZ3iRxU0xWb94st9G 8XbSXm0QujqMrvqAlEGR/ZZ53X9s36zMF6HZn1PSURanZ99IolROqBQaXORmJ2FfBuSmSQ gt0FcCcdY9SsJbhmSZ1FFCDF8atUyC0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-u-EL3OrGOryN3zr2_1fd2w-1; Thu, 30 May 2024 03:19:00 -0400 X-MC-Unique: u-EL3OrGOryN3zr2_1fd2w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B28E4101A52C; Thu, 30 May 2024 07:18:59 +0000 (UTC) Received: from localhost (unknown [10.72.116.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D138D3C27; Thu, 30 May 2024 07:18:58 +0000 (UTC) Date: Thu, 30 May 2024 15:18:55 +0800 From: Baoquan He To: "zhaoyang.huang" Cc: Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com Subject: Re: [PATCH] mm: fix incorrect vbq reference in purge_fragmented_block Message-ID: References: <20240530025144.1570865-1-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240530025144.1570865-1-zhaoyang.huang@unisoc.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4BD8340023 X-Stat-Signature: 5rwoowak4bsaprgpybojbfinwnuzj6ye X-HE-Tag: 1717053548-347680 X-HE-Meta: U2FsdGVkX18YnZCZtkP25HRcNG40IUYSy196LY3Ff9oShx+fYXDU46y+kfMs8OjWqqyUtEZdAnji/XmAcl83LnkMWjBmqTxJNtP53fKeUn1NHyzP2Y9GMLV+7UIWDBZS0GGgqn8nouCRxZLXyGGuUHpuoOqHgDVWemdgEptn5kKLllbuHE2Bi2VNdxiJL2+n2UGECTryLi2NMec6J93JR0gI8fNoBdP3E0mZlzmbAMZt2opOkCAU5edGFkBslodcL5vk+Yk0mj80EsOz5PKLE9eWKyCzDm/iv9aaaB2YCWZoZ2Oz8T2242g1jJM17Idbh1/xayjHYF/tGJBrR9D3m0P9Dkzq5JRxpj/RKj47OWnp/5jpOCiUwPygcLdRoldIb/VCgl9AUTae5OFtN/P53CkzkKev8rlxKH1cQVBYpDe2JuuFNOtC0NYbqhWkT2is5eLWB9GcuInBEV1BNx8i+tm9HR/GhRIIdYcnl9iKJ5h07B4z0Bsi+YZY2Jjbs7vjSiZEGr2nPNlY8BeTnGWcgebvcldvnDHo7TDDmdb+Q1+craE89BqkIglLFGRPSkz6MYL1Jl1Px+MmAGVi825W12UNTPtFhEjNBhz6f5Acfs1xj5HP9nQ8WG4tEDoL5n0fe5otZ1VTC5kiZLBZRbHMGg/K9dgygGrzNDMRS05K+sDCb4gAB1QZxfBZwYQJijKCwrXlWc714X4eju/v+WktOnfBycvcaESYa388y95Us6kgzqD4hfW4shQABP7u1iE6lIrxt0b5XoKQRCd7qjRFxImQUrCpet/foa4cA77SIKUqOCgNyfpRjmxeDcoxuKK4TlbVOJSmcl8qiYH/yCz4/hZ2lzFn+jlB6ltlJukAI8pQzHzuzfU26TY/mIAicwnz1/p+ChxQHeXRXY7N+LxkG82w3jG/khXuRYW0PzmWPNBliaYo+wBhklpsBusx5kSkzUXk7Z8+TPqDQ2mkXla /mXo0SSg kENeZ6+6zv5Dl/16TkSZa2W3JqdlHq3BGWgGLJqP7HChrLfa5RD90M6i/VdYZaQ56ej34AV0+Wcj+31cneB29WLyjSXMDSN//ncZ3UVVYZ8cMi+7X9tNEG3/0me4teBK61gbnXeK92PkqoSk2+LxUcwk9idceu27rv4vtTbz9NOZSEmTtxXVei/+4NTSQjZ/1znDEm25vhHL9LC5+9AM3O1ku5z7+TH1+mF5Qb6MsqtL96NoxFAbwQrCYnwzh1ji+vCpawwhXoqk5PZ/o8Nsl5wBnhoFgLDaUqflIMhHSJ+RZBuPna3UIi3LtQO+A1fCj1fnNSK9fdearLoz3AgmYypP9gw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05/30/24 at 10:51am, zhaoyang.huang wrote: > From: Zhaoyang Huang > > Broken vbq->free reported on a v6.6 based system which is caused > by invalid vbq->lock protect over vbq->free in purge_fragmented_block. > This should be introduced by the Fixes below which ignored vbq->lock > matter. It will be helpful to provide more details, what's the symptom of the brekage, and in which case vbq->free is broken. > > Fixes: fc1e0d980037 ("mm/vmalloc: prevent stale TLBs in fully utilized blocks") > > Signed-off-by: Zhaoyang Huang > --- > mm/vmalloc.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 22aa63f4ef63..112b50431725 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2614,9 +2614,10 @@ static void free_vmap_block(struct vmap_block *vb) > } > > static bool purge_fragmented_block(struct vmap_block *vb, > - struct vmap_block_queue *vbq, struct list_head *purge_list, > - bool force_purge) > + struct list_head *purge_list, bool force_purge) > { > + struct vmap_block_queue *vbq; > + > if (vb->free + vb->dirty != VMAP_BBMAP_BITS || > vb->dirty == VMAP_BBMAP_BITS) > return false; > @@ -2625,6 +2626,8 @@ static bool purge_fragmented_block(struct vmap_block *vb, > if (!(force_purge || vb->free < VMAP_PURGE_THRESHOLD)) > return false; > > + vbq = container_of(addr_to_vb_xa(vb->va->va_start), > + struct vmap_block_queue, vmap_blocks); > /* prevent further allocs after releasing lock */ > WRITE_ONCE(vb->free, 0); > /* prevent purging it again */ > @@ -2664,7 +2667,7 @@ static void purge_fragmented_blocks(int cpu) > continue; > > spin_lock(&vb->lock); > - purge_fragmented_block(vb, vbq, &purge, true); > + purge_fragmented_block(vb, &purge, true); > spin_unlock(&vb->lock); > } > rcu_read_unlock(); > @@ -2801,7 +2804,7 @@ static void _vm_unmap_aliases(unsigned long start, unsigned long end, int flush) > * not purgeable, check whether there is dirty > * space to be flushed. > */ > - if (!purge_fragmented_block(vb, vbq, &purge_list, false) && > + if (!purge_fragmented_block(vb, &purge_list, false) && > vb->dirty_max && vb->dirty != VMAP_BBMAP_BITS) { > unsigned long va_start = vb->va->va_start; > unsigned long s, e; > -- > 2.25.1 > >