From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70379C25B75 for ; Wed, 29 May 2024 21:51:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAB506B009D; Wed, 29 May 2024 17:51:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D334D6B009E; Wed, 29 May 2024 17:51:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BACD36B009F; Wed, 29 May 2024 17:51:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9AF346B009D for ; Wed, 29 May 2024 17:51:29 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1BB0F1C150F for ; Wed, 29 May 2024 21:51:29 +0000 (UTC) X-FDA: 82172780298.24.314DA49 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf21.hostedemail.com (Postfix) with ESMTP id 64A211C0002 for ; Wed, 29 May 2024 21:51:27 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Z6Ai0f0a; spf=pass (imf21.hostedemail.com: domain of 3XqNXZgYKCD0rdZmibfnnfkd.bnlkhmtw-lljuZbj.nqf@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3XqNXZgYKCD0rdZmibfnnfkd.bnlkhmtw-lljuZbj.nqf@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717019487; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HZEwQSuDxXsJBbCguZar5+VKzM/izfp4n/7bUq7QabM=; b=nNreOcEIgPvH5FpnLAvpprYyEkNi8WFw+J6XMefiZwV/wdgOW+442hCyh9Cre9cnW3bw7Q EIq1I+AIf7orvnAOQ9V2gRcSBmE82rH1EU0D6HiG04Y9TQAyloktu3+wqwY7/ThtIqQTkt GXYtqzGiPcFrS5saYVKqzjbN+S/ygLE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Z6Ai0f0a; spf=pass (imf21.hostedemail.com: domain of 3XqNXZgYKCD0rdZmibfnnfkd.bnlkhmtw-lljuZbj.nqf@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3XqNXZgYKCD0rdZmibfnnfkd.bnlkhmtw-lljuZbj.nqf@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717019487; a=rsa-sha256; cv=none; b=jHpu9kQ8H7C3iiLAsYSxZa7wIgcti7ba+31DMtH1Z7m0zuIRNwrli5bwUflT5dwWgr/K6o ewJYYEM3X/cGrM/mNjcMJ9V6Zz6Y7FHkb+M6Za4Sc8mhU1BVBsRhwoKqgm/WeDYN8ojdpZ lifposm9SbHRa0GO7u/itgcW/abYrdc= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-df771bdee6bso294909276.3 for ; Wed, 29 May 2024 14:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1717019486; x=1717624286; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=HZEwQSuDxXsJBbCguZar5+VKzM/izfp4n/7bUq7QabM=; b=Z6Ai0f0aru4kr9Aet1CtBM4Ped9PUJmrIV9Zl8q54mZntysW7T6HKoo1wfXNzm+I4x DUnzmWoSNaWBufQ5OW1i+MyF7bbdAVvzylkVpiri3ry+yLwQgfHNEiaB7qJ6HY8k7krf /6Dg5uNIlfygY4oFo+Ge4rUUft1KmDh3QPHiHWU3N1/z/AEUFbnhzgNvcKZ2z2HDd9cr tof4WlkrE4//uL/+PP/uuSfqATY/1CNQ1NSCgpnT0JZgfrldrK3+ySvH+q23/OVNytu4 BbG/l7l5HI+sMd9OK5/E+QZwtS7A4oT0e5CJAwSPUH/AtxXMo7vdaElxpWHW1L2UPSdb 3eUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717019486; x=1717624286; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HZEwQSuDxXsJBbCguZar5+VKzM/izfp4n/7bUq7QabM=; b=biHN4ubeG0QoKd0cq2sOG5fHCq9TA48wTG1uyk5IzuMkwiD9Xp32ycIn5B/Ued5AGm CaCKSyWUmpBgseHEYH3dAOqioBGgKwlF9WxhzqbPAIC1mohbbXqjgRxgiY27ziYlvuDd IS9Ajui5qlx66xYmiBQ36tpbknihCxkuFUB144VmwA9vECW8JRF6HEHOQKT2fAVdjtmD ydB2odh2x7aunpY1APUrfKgrvOZKKIbxEnGd/oqcGCDfQo19OjJdnwCwewf3m6JFeNAr D49vT5Rc+I6rPoaIinpyEfYmruI0klGqIT0u0F3uZodu9p/Z1wZF2NOfxX9PhlvSbfxe pcjg== X-Forwarded-Encrypted: i=1; AJvYcCXWR8CUJyNJXfoggAh1ilVoHE/SWdW9/HdVZ8m95kZQpMGc46O5pGIRnQ5JlbIJZCBFXE2pC2yO2GKwhYExt3ICpOQ= X-Gm-Message-State: AOJu0Yyd1k84iRPUwA9WsSVBbZCL7sqEnVBWN+YnuPWxqq+eKFRLN8ik 8OdKSYJW8TAkhrrpr/fX4j9w3PEE8ncYIBIrlkeAaIsj0H+KVuXsQpTQj2yjYBPipNZLmUA2Qd/ weg== X-Google-Smtp-Source: AGHT+IGqNZ2BbD8cAo2AnWXa3Pi0tfvxVmoPgtWnywK5+NXQgcmpZ6RBn86fT+8nIYtd+ZPLip7+OZUjHdQ= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:188e:b0:df7:8889:4795 with SMTP id 3f1490d57ef6-dfa5a407dc6mr54800276.0.1717019486318; Wed, 29 May 2024 14:51:26 -0700 (PDT) Date: Wed, 29 May 2024 14:51:24 -0700 In-Reply-To: <20240529180510.2295118-4-jthoughton@google.com> Mime-Version: 1.0 References: <20240529180510.2295118-1-jthoughton@google.com> <20240529180510.2295118-4-jthoughton@google.com> Message-ID: Subject: Re: [PATCH v4 3/7] KVM: Add lockless memslot walk to KVM From: Sean Christopherson To: James Houghton Cc: Andrew Morton , Paolo Bonzini , Albert Ou , Ankit Agrawal , Anup Patel , Atish Patra , Axel Rasmussen , Bibo Mao , Catalin Marinas , David Matlack , David Rientjes , Huacai Chen , James Morse , Jonathan Corbet , Marc Zyngier , Michael Ellerman , Nicholas Piggin , Oliver Upton , Palmer Dabbelt , Paul Walmsley , Raghavendra Rao Ananta , Ryan Roberts , Shaoqin Huang , Shuah Khan , Suzuki K Poulose , Tianrui Zhao , Will Deacon , Yu Zhao , Zenghui Yu , kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev Content-Type: text/plain; charset="us-ascii" X-Stat-Signature: mp4z4w6oydtkdawpynh4rmgmqy85ck6h X-Rspamd-Queue-Id: 64A211C0002 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717019487-702185 X-HE-Meta: U2FsdGVkX19BsaShQnNOl/N572LmH7ED56GkfOyp2waByrmL9JgacAC0TJmOFUyp8/TA2qbsKPuC1Vs1uwvQc4Jvg9GKHHLDRgUIZbcHMn9n9qhEUlrdeVg+4pd4PMOI0NKYN/s7TBn+xpGIoI/BkMuhaT4ld2sfmQEh/CbYe2X4Ew9IO6fRaDEqk51yEgdiIkQigKmDDW1J+wt3MQ1QFSpQ6m02sZN+DZ6MZzNRFQ0qFSJrVUM1QQRo+xuhhOFhRqUcXfpXMb9U02MCiFh9MgEenq+hSLsNRb4lxhb6IVdXnbeUTBTFiztC7fESEFEGPgsSIN56GfAB9rmepGZ2y+nlBl4D5vbytFc2fPcwWpzuksGFH0mDz8vNpwjEiXOdFqM9y/WEtKIiZvwI60hBQkYoL8IDkPrs5L++Qat6X/Nca08NVGAZrk3xpjwULV7+ZI/E5wYlRGsCUQ1/w4uOeotp7dAIfKTCM0/o4c40cfmvZbQnu+5Jbk+r1CveKYZgUnSN5tQTuOjNrLxaeVUCftAgB946riUAcVOU2F1GyXbrMkVmAdYqzdLIa05KAG1Xke0UX2Bopyy3MVI/LS/iAGRCcU7QvwTkWM185F7eWA3fP0bNYTgGFIj44sDqIL5+ce4UbyNoUkQZqTCWuC634Pj8d9qP8LxoEX4IW7Ngssoqgm2fNU1EV9q843/uSm6rTHGgkCye70B0cU9xzAcBcdmavt/hQWDbtIY+R8CHm1WNCx3KxFwoap5j6nL7XDIJvT6NKNkTcM/kkZ4nxOCpFezgTOAE8Q8/BjZWoYsd6QjkaedMxLizDCvQAaJXW0pYMMRX9NCp6jklsexlT65TsKIC4874UycdasAotuj6UjHS6mtpY1yga4XLhdEkyMLjvhh0zom5S7nY13PY7ynqViZyJ2w2sXT3vIZqafblv7aiqrXiQ4fWJaU6LrZPklSeIgoeT3ixbI+B4W1PPbD u3LIrLZu ibI3nAo+PLot5lywl+Ldrlcu2ZJQG0xuxdfpl0t39i+vI/7rHgcogYc8CWzeNWb2VWm0YC90zRS+4LorRdOk5hNnroSDm/faBr/Efskra42gpNRpU4eQAyvuHVSSoDYGiuzUoi+kBNuzSmWkpeCJxkCc4xzF4B9ta4bA67g+g6+84duWyr955osbYW2tenXCFicHSIqqLiP9bAEsJFG3EhkT3BTsHmiwpHybIMNkZc2HKAiX6vZ7lqQLKBh/nl+27eR1zs6W671zugnHy7US4G4Ki1sZ6WJNwFoaVGLuxJKFpOvJZvUByym3Wn0ujwvhPnuZk1iSpc8s49GFbh+o9Sy+BrC5xVyt9k1PXJCSnjX4+X67q3Rfc1pzNYlI75E9jeSav50T/WY5LIUme4h3413Q99BvIzaWbAhHwo/LRMQiS+MuQBJ3yc8ak3DhDGTpJI0ZQ8U/mL7tSI5QezS95siyVLprirnRlR290t4XRvHc9CezZaDhU9swqLBBGN5uYQqfrdUqQ0Lg6WVHv1G6UPpmopdq2XvsytXXLI/GBSM7xOOxOyDA2y1CDboDzIk316D5K5ww2hSJztHOBcyL379TrlQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 29, 2024, James Houghton wrote: > @@ -686,10 +694,12 @@ static __always_inline int kvm_handle_hva_range(struct mmu_notifier *mn, > return __kvm_handle_hva_range(kvm, &range).ret; > } > > -static __always_inline int kvm_handle_hva_range_no_flush(struct mmu_notifier *mn, > - unsigned long start, > - unsigned long end, > - gfn_handler_t handler) > +static __always_inline int kvm_handle_hva_range_no_flush( > + struct mmu_notifier *mn, > + unsigned long start, > + unsigned long end, > + gfn_handler_t handler, > + bool lockless) Unnecessary and unwanted style change. > { > struct kvm *kvm = mmu_notifier_to_kvm(mn); > const struct kvm_mmu_notifier_range range = { > @@ -699,6 +709,7 @@ static __always_inline int kvm_handle_hva_range_no_flush(struct mmu_notifier *mn > .on_lock = (void *)kvm_null_fn, > .flush_on_ret = false, > .may_block = false, > + .lockless = lockless, Why add @lockess to kvm_handle_hva_range_no_flush()? Both callers immediately pass %false, and conceptually, locking is always optional for a "no flush" variant. > }; > > return __kvm_handle_hva_range(kvm, &range).ret; > @@ -889,7 +900,8 @@ static int kvm_mmu_notifier_clear_young(struct mmu_notifier *mn, > * cadence. If we find this inaccurate, we might come up with a > * more sophisticated heuristic later. > */ > - return kvm_handle_hva_range_no_flush(mn, start, end, kvm_age_gfn); > + return kvm_handle_hva_range_no_flush(mn, start, end, > + kvm_age_gfn, false); > } > > static int kvm_mmu_notifier_test_young(struct mmu_notifier *mn, > @@ -899,7 +911,7 @@ static int kvm_mmu_notifier_test_young(struct mmu_notifier *mn, > trace_kvm_test_age_hva(address); > > return kvm_handle_hva_range_no_flush(mn, address, address + 1, > - kvm_test_age_gfn); > + kvm_test_age_gfn, false); > } > > static void kvm_mmu_notifier_release(struct mmu_notifier *mn, > -- > 2.45.1.288.g0e0cd299f1-goog >