From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1822C25B75 for ; Wed, 29 May 2024 20:35:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35FD26B0096; Wed, 29 May 2024 16:35:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 30FE56B0098; Wed, 29 May 2024 16:35:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D8786B0099; Wed, 29 May 2024 16:35:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F2F0D6B0096 for ; Wed, 29 May 2024 16:35:54 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 975E280503 for ; Wed, 29 May 2024 20:35:54 +0000 (UTC) X-FDA: 82172589828.11.3B61256 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf30.hostedemail.com (Postfix) with ESMTP id 7F15F80012 for ; Wed, 29 May 2024 20:35:52 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=L5Hxr83p; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf30.hostedemail.com: domain of osalvador@suse.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=osalvador@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717014952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JC3x5apHXdzmR/YV5C0DYO7+NyF+i3CFIw4rUzWOank=; b=FkyxHk22Cz17PkhdYrwV3i6d1mNxzwgclfnb8VHX8bNZjIRXGGEc3wsPijDm6WIiBb+zzS 6TaFiSbf5XwSlQtIhtQ8GO3PNtXIdlBxp9XEWK5iyeaxTd5EwV0TalQkdfWEGeApllpxyf gEyF4h5ZCIAerkmcWJlHXmAeNHfCSnc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=L5Hxr83p; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf30.hostedemail.com: domain of osalvador@suse.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=osalvador@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717014952; a=rsa-sha256; cv=none; b=k0KilI9xXHWvF6xiR2qIgAG3jaD90IbVJsjQTLA7cvJOvwKZMSofLm/6ql42Qw5XgZNd5I GvNwL4PvOiDJPUGLkBWsAImOb1FaEVl5n4osET8DNjZmWIzmI7V3POmyG3FcYKKoKtRA7g ZsMxU2vOzzSH8BB2jzHPHLNnTzFZIlg= Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4202cea9a2fso1597385e9.3 for ; Wed, 29 May 2024 13:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1717014951; x=1717619751; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=JC3x5apHXdzmR/YV5C0DYO7+NyF+i3CFIw4rUzWOank=; b=L5Hxr83p+I46pQs5y0wzjWrBQ5hz4KFHQGVAUzHfgy9WT9aS5c6Pck+6P9SaPGsTGO O33CmSSu/daaggtC3BU9kmLa+Kp++oFZvlrtu38c3i94H0z4ClhQqupVXaxQaPjlzfuF 0RYePmNYEM9vNUPWdQZ2NFZhgjZaNx+1a5RpE/S86gD7mhgVzImPKk4/3yBdNxA+qKPv hsuuzxLNZAfW+i1+ucegJtRq2jV9jisciGv4M6uhl9h8T5gxV5e6QoBxk6MfVYfiHuDR lXMxK2dm0IKnMgt1hXfwbE3CAjaaSyBuqJSrj7UOAI1m8qrhQlg4hgIchtDFD1pOLhvZ X2HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717014951; x=1717619751; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JC3x5apHXdzmR/YV5C0DYO7+NyF+i3CFIw4rUzWOank=; b=JntGIc2jit5t7fIg2dt2SCEmm74dn3W/l1tAbqqdQ8zfaWAZg2T2Kufuje/H3B/bui IECtH3FrpuJLwtMzYow5CbwuOm2pnJXxczf3TpUgVV5m40801dhTHcR1ii7JkRlYzyf8 /S03uZwDh2bguqdHUDfYWSFLsDT2kOSYI4iuA/S68tVrGbFf13U+kO+pgG5Ank+JuDU9 4o/yVtztk8ym8bLHBMYC3Bm9+zJN8JQKbCFJ70DUK7qgGJKIU1vTfRbOP0qamSkkjRWg RNhPJM+b5Ri/JgilRhVE69Ign6I4EprBuGaXDLFqXzsoWGmVdRlccSdca7WGHCsVDOBa C5EQ== X-Forwarded-Encrypted: i=1; AJvYcCU/x3wfbG3UIdVpLJTkgVVMbakuDj1TT951XCy18EJfg12k7BfGurnzNYuNXr4CFOHrFrl1xw9+iHb+MhRLgtEaz1E= X-Gm-Message-State: AOJu0Yyp6S2zzqpao3whA6Vo1h5LMTaolXNXfHk5SmNY27yfCI5u3tfU j7Yb6qNBjIXw11Vib3L62hb5xPJIbaOYqa3Q953TevuIQauwAytbXIT7PUVvIfA= X-Google-Smtp-Source: AGHT+IG3AG7XvBjUxEuIqDkIem5kESHSEggsK3zdIN5ufHeWfrSxUAX8R3RPXwQOqZVR99lIOuJZ2g== X-Received: by 2002:a05:600c:4ecb:b0:420:29a8:ff5e with SMTP id 5b1f17b1804b1-4212781b3f3mr2973705e9.19.1717014950770; Wed, 29 May 2024 13:35:50 -0700 (PDT) Received: from localhost.localdomain (62.83.84.125.dyn.user.ono.com. [62.83.84.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42127059a50sm4743805e9.1.2024.05.29.13.35.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 13:35:50 -0700 (PDT) From: Oscar Salvador X-Google-Original-From: Oscar Salvador Date: Wed, 29 May 2024 22:35:48 +0200 To: Breno Leitao Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Muchun Song , syzbot+d3fe2dc5ffe9380b714b@syzkaller.appspotmail.com Subject: Re: [PATCH] mm/hugetlb: Do not call vma_add_reservation upon ENOMEM Message-ID: References: <20240528205323.20439-1-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 7F15F80012 X-Stat-Signature: 6g3nymiff5wggjrue94yxkgwwrw9mzs6 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717014952-85312 X-HE-Meta: U2FsdGVkX19Rcp6RKosIATfiUgZKmlS9lYBJFeMk42UFppvrU2jBEOcIAtrMLWgl8aRSYVrCDeG8AT5ygaxFu5VKQJt2Q8mRC8bjr37YrtmGbZl/PvV0WfJEjYeZNauIuGhMIn2MI43ibOGt09XJUVlgMy2ahGrfRxunUsnnUxVykd/NQCvnQ4s7pji2ZcG5V54C7h4NW4QMi3rkDr3uVVypvI86dL2EvPSSycu2JWilWPG+Itvraw815d4PATVuS2tzP/kQg6zvbAiklY/iBDfrQACCNh/QW07KMjx9LOv41KGYNntLqTQBCVlcScg20G2Cn8rcqZ1fxu6U7tLkX9/gpgS1gQc+h3As7dl0nWU4WrYhWjIlKhmmW63lID/FIc654aisjHMVG43Q4zPQ66Idyebb5QIdwhDPI1EW0nWyrfx47nMX/QRQK7CCBGjFxZsfUMzV4FEf9S9LxF0LhEoBJNzh+2Eubj7SxxMXaZ43b42ac17ab+LBE1OjhOSgDLS6m/p50HVqeCTN0saEp4msb8CF2mjVQhn2zJbrNyF44Hd0n4qGLTrKI8cZw3T73kCT+Hy8/B78P2yzeFVC/HRKX9S9x8sWAw7B+uufVzF95/ETQMxHnyaUZl0VYXQ+2BUHlrJomlVfYANRaofB49pFg7n25dxQWlIkeK6N2HqOv25jBwIkJyKpipOc+JjSUc9+gtn4fsX5O5GwWMC5cJqqcIIVTvr715nw1aHwwNyeLeanvlecihtdIBUhpcxgElWQ7kyxSnZKeMy183ZXppQE0VhJlJuHmcVZ6dcrS70/flxKST/asYtUYEUKUTKXd/8ROWnwWLdcTwfwGz07ogcDM4hoLuXuntYXm1ep9p3DIGAn4dnecHIRPVm8JvHaWpzF9DLCZXQ7IjQFtDpyDw4VCLBAVtvAb8K3c0M8AN2OJy/px4IqUlwhwGvvxX+cbrANTU36ARF4TUO3ExB eRsbmX7h +fPYRE7sJhBH1ji8tXoz3vSsrZxmwyUIlvWDQM5Vsxylo+suDQ/i4Q4L4hv2HXCdNKtUIGCcRKPQzvz2fb5mxuPZWJWSjeAPZe+b3tCi9hDtQ4CFm/nIBKYYDr9m6r5t6mOEA+M9RKusgGXK3ouE5Z0RgXVInavoOWebxuhPWN22tw12N4Hm8gM/Q12q61ZqVtakkyaIBeC1DvnoOh/wxU++jsegYCJHGcFKR3Zhq04EOivPxSzxuyPpHC6N5dflr5e1ozwlUM5SyPz2qcy1ICC3cf71t/pPD6feG4CSm7HfHK+9HOrqsK0g5iEv3QJwTnkbd/ayJKv2CjdLJ0/+sEuQCyXYmFSCrARLRv3CXOp5yhAtKuJvp9Y+PlRUHUe6ToCh2FlHna2o5cw0HQCjm9AlCqOEOp21f7PXi72zicEzfII05McTWe8rq0KN8IHiZ5LaFUD5DjWilVtW37yN7nZ/SMaVtntzSccRBuyqcQNwkS75WWK0VJUPsdwvUCHyDuE4k X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 29, 2024 at 08:43:06AM -0700, Breno Leitao wrote: > vma_needs_reservation returns a long. > > static long vma_needs_reservation(struct hstate *h, > struct vm_area_struct *vma, unsigned long addr) Yeah, I missed that, thanks. @Andrew: Can you fold the following in? Thanks diff --git a/mm/hugetlb.c b/mm/hugetlb.c index f35abff8be60..0b9e64aa279b 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -5769,7 +5769,7 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, * forever. */ if (adjust_reservation) { - int rc = vma_needs_reservation(h, vma, address); + long rc = vma_needs_reservation(h, vma, address); if (rc < 0) /* Pressumably allocate_file_region_entries failed > Reviewed-by: Breno Leitao Thanks -- Oscar Salvador SUSE Labs