From: Oscar Salvador <osalvador@suse.com>
To: Breno Leitao <leitao@debian.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Muchun Song <muchun.song@linux.dev>,
syzbot+d3fe2dc5ffe9380b714b@syzkaller.appspotmail.com
Subject: Re: [PATCH] mm/hugetlb: Do not call vma_add_reservation upon ENOMEM
Date: Wed, 29 May 2024 22:35:48 +0200 [thread overview]
Message-ID: <ZleQrVXDPiF_U7Hn@localhost.localdomain> (raw)
In-Reply-To: <ZldNCutdbyroqoNv@gmail.com>
On Wed, May 29, 2024 at 08:43:06AM -0700, Breno Leitao wrote:
> vma_needs_reservation returns a long.
>
> static long vma_needs_reservation(struct hstate *h,
> struct vm_area_struct *vma, unsigned long addr)
Yeah, I missed that, thanks.
@Andrew: Can you fold the following in? Thanks
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index f35abff8be60..0b9e64aa279b 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -5769,7 +5769,7 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma,
* forever.
*/
if (adjust_reservation) {
- int rc = vma_needs_reservation(h, vma, address);
+ long rc = vma_needs_reservation(h, vma, address);
if (rc < 0)
/* Pressumably allocate_file_region_entries failed
> Reviewed-by: Breno Leitao <leitao@debian.org>
Thanks
--
Oscar Salvador
SUSE Labs
prev parent reply other threads:[~2024-05-29 20:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 20:53 Oscar Salvador
2024-05-29 15:43 ` Breno Leitao
2024-05-29 20:35 ` Oscar Salvador [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZleQrVXDPiF_U7Hn@localhost.localdomain \
--to=osalvador@suse.com \
--cc=akpm@linux-foundation.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=syzbot+d3fe2dc5ffe9380b714b@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox